fog 1.0.0 → 1.5.0

data/lib/fog/vcloud/models/compute/server.rb

@@ -1,58 +1,57 @@
+require 'fog/vcloud/models/compute/helpers/status'
 module Fog
   module Vcloud
     class Compute
       class Server < Fog::Vcloud::Model
 
-        identity :href, :aliases => :Href
+        include Fog::Vcloud::Compute::Helpers::Status
 
+        identity :href, :aliases => :Href
+        attribute :links, :aliases => :Link, :type => :array
         ignore_attributes :xmlns, :xmlns_i, :xmlns_xsi, :xmlns_xsd
 
         attribute :type
         attribute :name
         attribute :status
-        attribute :network_connections, :aliases => :NetworkConnectionSection, :squash => :NetworkConnection
-        attribute :os, :aliases => :OperatingSystemSection
-        attribute :virtual_hardware, :aliases => :VirtualHardwareSection
+        attribute :deployed, :type => :boolean
         attribute :description, :aliases => :Description
-        attribute :storage_size, :aliases => :size
-        attribute :links, :aliases => :Link, :type => :array
+
+        attribute :vapp_scoped_local_id, :aliases => :VAppScopedLocalId
+
+        attribute :network_connections, :aliases => :NetworkConnectionSection, :squash => :NetworkConnection
+        attribute :virtual_hardware, :aliases => :'ovf:VirtualHardwareSection', :squash => :'ovf:Item'
+
+        attribute :guest_customization, :aliases => :GuestCustomizationSection
+        attribute :operating_system, :aliases => :'ovf:OperatingSystemSection'
+
         attribute :tasks, :aliases => :Tasks, :type => :array
 
-        attribute :vm_data, :aliases => :Children, :squash => :Vm
+        has_up :vapp
 
-        def ip_address
+        def computer_name
           load_unless_loaded!
-          vm[0][:NetworkConnectionSection][:NetworkConnection][:IpAddress]
+          self.guest_customization[:ComputerName]
         end
 
-        def friendly_status
+        def os_desc
           load_unless_loaded!
-          case status
-          when '0'
-            'creating'
-          when '8'
-            'off'
-          when '4'
-            'on'
-          else
-            'unkown'
-          end
+          self.operating_system[:'ovf:Description']
         end
 
-        def ready?
-          reload_status # always ensure we have the correct status
-          running_tasks = tasks && tasks.flatten.any? {|ti| ti.kind_of?(Hash) && ti[:status] == 'running' }
-          status != '0' && !running_tasks # 0 is provisioning, and no running tasks
+        def os_type
+          load_unless_loaded!
+          self.operating_system[:vmw_osType]
         end
 
-        def on?
-          reload_status # always ensure we have the correct status
-          status == '4'
+        def ip_addresses
+          load_unless_loaded!
+          [self.network_connections].flatten.collect{|n| n[:IpAddress] }
         end
 
-        def off?
+        def ready?
           reload_status # always ensure we have the correct status
-          status == '8'
+          running_tasks = tasks && tasks.flatten.any? {|ti| ti.kind_of?(Hash) && ti[:status] == 'running' }
+          status != '0' && !running_tasks # 0 is provisioning, and no running tasks
         end
 
         def power_on
@@ -83,11 +82,6 @@ module Fog
           power_on
         end
 
-        def vm
-          load_unless_loaded!
-          self.vm_data
-        end
-
         def name=(new_name)
           attributes[:name] = new_name
           @changed = true
@@ -120,7 +114,7 @@ module Fog
 
         def disks
           disk_mess.map do |dm|
-            { :number => dm[:"rasd:AddressOnParent"], :size => dm[:"rasd:VirtualQuantity"].to_i, :resource => dm[:"rasd:HostResource"] }
+            { :number => dm[:"rasd:AddressOnParent"].to_i, :size => dm[:"rasd:HostResource"][:vcloud_capacity].to_i, :resource => dm[:"rasd:HostResource"], :disk_data => dm }
           end
         end
 
@@ -187,12 +181,12 @@ module Fog
                 vh[:'rasd:ResourceType'] == '17' &&
                   vh[:'rasd:AddressOnParent'].to_s == @remove_disk.to_s
               end
-              connection.configure_vm_disks(vm_href, data)
+              connection.configure_vm_disks(self.href, data)
             end
             if @disk_change == :added
               data = disk_mess
               data << @add_disk
-              connection.configure_vm_disks(vm_href, data)
+              connection.configure_vm_disks(self.href, data)
             end
             if @name_changed || @description_changed
               edit_uri = links.select {|i| i[:rel] == 'edit'}
@@ -216,14 +210,6 @@ module Fog
         end
         alias :delete :destroy
 
-        def vm_href
-          load_unless_loaded!
-          #require 'pp'
-          #pp vm_data
-          #vm_data[0][:Link].select {|v| v[:rel] == 'edit'}[0][:href]
-          vm_data.kind_of?(Array)? vm_data[0][:href] : vm_data[:href]
-        end
-
         private
 
         def reset_tracking
@@ -242,29 +228,24 @@ module Fog
           }
         end
 
-        def virtual_hardware_section
-          load_unless_loaded!
-          vm[0][:"ovf:VirtualHardwareSection"][:"ovf:Item"]
-        end
-
         def memory_mess
           load_unless_loaded!
-          if virtual_hardware_section
-            virtual_hardware_section.detect { |item| item[:"rasd:ResourceType"] == "4" }
+          if virtual_hardware
+            virtual_hardware.detect { |item| item[:"rasd:ResourceType"] == "4" }
           end
         end
 
         def cpu_mess
           load_unless_loaded!
-          if virtual_hardware_section
-            virtual_hardware_section.detect { |item| item[:"rasd:ResourceType"] == "3" }
+          if virtual_hardware
+            virtual_hardware.detect { |item| item[:"rasd:ResourceType"] == "3" }
           end
         end
 
         def disk_mess
           load_unless_loaded!
-          if virtual_hardware_section
-            virtual_hardware_section.select { |item| item[:"rasd:ResourceType"] == "17" }
+          if virtual_hardware
+            virtual_hardware.select { |item| item[:"rasd:ResourceType"] == "17" }
           else
             []
           end
@@ -282,9 +263,8 @@ module Fog
         end
 
         def reload_status
-          self.status = connection.get_vapp(href).body[:status]
+          self.status = connection.get_vapp(href).status
         end
-
       end
     end
   end

data/lib/fog/vcloud/models/compute/servers.rb

@@ -13,16 +13,13 @@ module Fog
         attribute :href, :aliases => :Href
 
         def all
-          check_href!(:parent => "Vdc")
-          load(_vapps)
+          check_href!("Vapp")
+          vapp.load_unless_loaded!
+          load(vapp.children||[])
         end
 
         def get(uri)
-          if data = connection.get_vapp(uri)
-            # If no tasks returned, set a mock entry to flush on reload
-            data.body[:Tasks] = {} unless data.body[:Tasks]
-            new(data.body)
-          end
+          connection.get_vapp(uri)
         rescue Fog::Errors::NotFound
           nil
         end
@@ -37,19 +34,16 @@ module Fog
 
         private
 
-        def _resource_entities
-          if Hash === resource_entities = connection.get_vdc(href).body[:ResourceEntities]
-            resource_entities[:ResourceEntity]
-          end
+        def vapp
+          @vapp ||= (attributes[:vapp] || init_vapp)
         end
 
-        def _vapps
-          resource_entities = _resource_entities
-          if resource_entities.nil?
-            []
-          else
-            resource_entities.select {|re| re[:type] == 'application/vnd.vmware.vcloud.vApp+xml' }
-          end
+        def init_vapp
+          Fog::Vcloud::Compute::Vapp.new(
+            :connection => connection,
+            :href => self.href,
+            :collection => Fog::Vcloud::Compute::Vapps.new(:connection => connection)
+          )
         end
 
       end

data/lib/fog/vcloud/models/compute/task.rb

@@ -4,7 +4,7 @@ module Fog
       class Task < Fog::Vcloud::Model
 
         identity :href, :aliases => :Href
-
+        attribute :links, :aliases => :Link, :type => :array
         ignore_attributes :xmlns, :xmlns_i, :xmlns_xsi, :xmlns_xsd
 
         attribute :status

data/lib/fog/vcloud/models/compute/tasks.rb

@@ -19,9 +19,7 @@ module Fog
         end
 
         def get(uri)
-          if data = connection.get_task(uri)
-            new(data.body)
-          end
+          connection.get_task(uri)
         rescue Fog::Errors::NotFound
           nil
         end

data/lib/fog/vcloud/models/compute/vapp.rb

@@ -0,0 +1,43 @@
+require 'fog/vcloud/models/compute/helpers/status'
+module Fog
+  module Vcloud
+    class Compute
+      class Vapp < Fog::Vcloud::Model
+
+        include Fog::Vcloud::Compute::Helpers::Status
+
+        identity :href, :aliases => :Href
+        attribute :links, :aliases => :Link, :type => :array
+        ignore_attributes :xmlns, :xmlns_i, :xmlns_xsi, :xmlns_xsd
+
+        attribute :name
+        attribute :type
+        attribute :status
+        attribute :description, :aliases => :Description
+        attribute :deployed, :type => :boolean
+
+        attribute :children, :aliases => :Children, :squash => :Vm
+        attribute :lease_settings, :aliases => :LeaseSettingsSection
+
+        attribute :network_configs, :aliases => :NetworkConfigSection
+
+        has_up :vdc
+
+        def servers
+          @servers ||= Fog::Vcloud::Compute::Servers.
+            new( :connection => connection,
+                 :href => href,
+                 :vapp => self
+            )
+        end
+
+        def networks
+          @networks ||= Fog::Vcloud::Compute::Networks.
+            new( :connection => connection,
+                 :href => href
+            )
+        end
+      end
+    end
+  end
+end

data/lib/fog/vcloud/models/compute/vapps.rb

@@ -0,0 +1,28 @@
+require 'fog/vcloud/models/compute/vapp'
+
+module Fog
+  module Vcloud
+    class Compute
+
+      class Vapps < Collection
+
+        model Fog::Vcloud::Compute::Vapp
+
+        undef_method :create
+
+        attribute :href
+
+        def all
+          load([connection.get_vdc(self.href).resource_entities].flatten.select { |re| re[:type] == "application/vnd.vmware.vcloud.vApp+xml" })
+        end
+
+        def get(uri)
+          connection.get_vapp(uri)
+        rescue Fog::Errors::NotFound
+          nil
+        end
+
+      end
+    end
+  end
+end

data/lib/fog/vcloud/models/compute/vdc.rb

@@ -3,20 +3,24 @@ module Fog
     class Compute
       class Vdc < Fog::Vcloud::Model
 
-        identity :href
-
-        ignore_attributes :xmlns, :xmlns_xsi, :xmlns_xsd
+        identity :href, :aliases => :Href
+        attribute :links, :aliases => :Link, :type => :array
+        ignore_attributes :xmlns, :xmlns_i, :xmlns_xsi, :xmlns_xsd
 
         attribute :name
         attribute :type
         attribute :description, :aliases => :Description
-        attribute :other_links, :aliases => :Link
+        attribute :network_quota, :aliases => :NetworkQuota, :type => :integer
+        attribute :nic_quota, :aliases => :NicQuota, :type => :integer
+        attribute :vm_quota, :aliases => :VmQuota, :type => :integer
+        attribute :is_enabled, :aliases => :IsEnabled, :type => :boolean
         attribute :compute_capacity, :aliases => :ComputeCapacity
         attribute :storage_capacity, :aliases => :StorageCapacity
         attribute :available_networks, :aliases => :AvailableNetworks, :squash => :Network
+
         attribute :resource_entities, :aliases => :ResourceEntities, :squash => :ResourceEntity
-        attribute :deployed_vm_quota
-        attribute :instantiated_vm_quota
+
+        has_up :organization
 
         def networks
           @networks ||= Fog::Vcloud::Compute::Networks.
@@ -24,32 +28,13 @@ module Fog
                  :href => href )
         end
 
-        def servers
-          @servers ||= Fog::Vcloud::Compute::Servers.
+        def vapps
+          @vapps ||= Fog::Vcloud::Compute::Vapps.
             new( :connection => connection,
-                 :href => href )
+                 :href => href
+            )
         end
 
-        def tasks
-          @tasks ||= Fog::Vcloud::Compute::Tasks.
-            new( :connection => connection,
-                 :href => href + "/tasksList" )
-        end
-
-        private
-
-        def collection_based_on_type(type, klass = nil)
-          load_unless_loaded!
-          test_links = other_links.kind_of?(Array) ? other_links : [other_links]
-          if link = test_links.detect { |link| link[:type] == type }
-            case type
-            when "application/vnd.vmware.vcloud.catalog+xml"
-              Fog::Vcloud::Compute::Catalog
-            end.new( :connection => connection, :href => link[:href] )
-          else
-            [ ]
-          end
-        end
       end
     end
   end

data/lib/fog/vcloud/models/compute/vdcs.rb

@@ -10,30 +10,25 @@ module Fog
 
         undef_method :create
 
+        attribute :href
+
         def all
-          data = connection.get_organization(organization_uri).body[:Link].select { |link| link[:type] == "application/vnd.vmware.vcloud.vdc+xml" }
+          data = connection.get_organization(org_uri).links.select { |link| link[:type] == "application/vnd.vmware.vcloud.vdc+xml" }
           data.each { |link| link.delete_if { |key, value| [:rel].include?(key) } }
           load(data)
         end
 
         def get(uri)
-          if data = connection.get_vdc(uri)
-            new(data.body)
-          end
+          connection.get_vdc(uri)
         rescue Fog::Errors::NotFound
           nil
         end
 
-        def organization_uri
-          @organization_uri ||= connection.default_organization_uri
-        end
-
         private
 
-        def organization_uri=(new_organization_uri)
-          @organization_uri = new_organization_uri
+        def org_uri
+          self.href ||= connection.default_organization_uri
         end
-
       end
     end
   end

data/lib/fog/vcloud/requests/compute/clone_vapp.rb

@@ -5,7 +5,7 @@ module Fog
 
         def validate_clone_vapp_options(options)
           valid_opts = [:name, :poweron]
-          unless valid_opts.all? { |opt| options.keys.include?(opt) }
+          unless valid_opts.all? { |opt| options.has_key?(opt) }
             raise ArgumentError.new("Required data missing: #{(valid_opts - options.keys).map(&:inspect).join(", ")}")
           end
         end

data/lib/fog/vcloud/requests/compute/configure_network.rb

@@ -5,7 +5,7 @@ module Fog
 
         def validate_network_data(network_data, configure=false)
           valid_opts = [:id, :href, :name, :address, :broadcast, :gateway]
-          unless valid_opts.all? { |opt| network_data.keys.include?(opt) }
+          unless valid_opts.all? { |opt| network_data.has_key?(opt) }
             raise ArgumentError.new("Required data missing: #{(valid_opts - network_data.keys).map(&:inspect).join(", ")}")
           end
         end

data/lib/fog/vcloud/requests/compute/configure_network_ip.rb

@@ -6,7 +6,7 @@ module Fog
 
         def validate_network_ip_data(network_ip_data)
           valid_opts = [:id, :href, :name, :status, :server]
-          unless valid_opts.all? { |opt| network_ip_data.keys.include?(opt) }
+          unless valid_opts.all? { |opt| network_ip_data.has_key?(opt) }
             raise ArgumentError.new("Required data missing: #{(valid_opts - network_ip_data.keys).map(&:inspect).join(", ")}")
           end
         end

data/lib/fog/vcloud/requests/compute/configure_vapp.rb

@@ -6,7 +6,7 @@ module Fog
 
         def validate_vapp_data(vapp_data)
           valid_opts = [:name, :cpus, :memory, :disks]
-          unless valid_opts.all? { |opt| vapp_data.keys.include?(opt) }
+          unless valid_opts.all? { |opt| vapp_data.has_key?(opt) }
             raise ArgumentError.new("Required Vapp data missing: #{(valid_opts - vapp_data.keys).map(&:inspect).join(", ")}")
           end
         end

data/lib/fog/vcloud/requests/compute/configure_vm.rb

@@ -1,135 +1,3 @@
-# -*- coding: utf-8 -*-
-hardware_hash = {:xmlns_vcloud=>"http://www.vmware.com/vcloud/v1",
- :vcloud_href=>
-  "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/",
- :vcloud_type=>"application/vnd.vmware.vcloud.virtualHardwareSection+xml",
- :"ovf:Info"=>"Virtual hardware requirements",
- :"ovf:System"=>
-  {:"vssd:ElementName"=>"Virtual Hardware Family",
-   :"vssd:InstanceID"=>"0",
-   :"vssd:VirtualSystemIdentifier"=>"centos",
-   :"vssd:VirtualSystemType"=>"vmx-07"},
- :"ovf:Item"=>
-  [{:"rasd:Address"=>"00:50:56:01:00:db",
-    :"rasd:AddressOnParent"=>"0",
-    :"rasd:AutomaticAllocation"=>"true",
-    :"rasd:Connection"=>"Gandalf_Dev_OrgNW_to_ExtNW_DirectConnect",
-    :"rasd:Description"=>"PCNet32 ethernet adapter",
-    :"rasd:ElementName"=>"Network adapter 0",
-    :"rasd:InstanceID"=>"1",
-    :"rasd:ResourceSubType"=>"PCNet32",
-    :"rasd:ResourceType"=>"10"},
-   {:"rasd:Address"=>"0",
-    :"rasd:Description"=>"SCSI Controller",
-    :"rasd:ElementName"=>"SCSI Controller 0",
-    :"rasd:InstanceID"=>"2",
-    :"rasd:ResourceSubType"=>"lsilogic",
-    :"rasd:ResourceType"=>"6"},
-   {:"rasd:AddressOnParent"=>"0",
-    :"rasd:Description"=>"Hard disk",
-    :"rasd:ElementName"=>"Hard disk 1",
-    :"rasd:HostResource"=>
-     {:vcloud_capacity=>"8192",
-      :vcloud_busType=>"6",
-      :vcloud_busSubType=>"lsilogic"},
-    :"rasd:InstanceID"=>"2000",
-    :"rasd:Parent"=>"2",
-    :"rasd:ResourceType"=>"17"},
-   {:"rasd:Address"=>"0",
-    :"rasd:Description"=>"IDE Controller",
-    :"rasd:ElementName"=>"IDE Controller 0",
-    :"rasd:InstanceID"=>"3",
-    :"rasd:ResourceType"=>"5"},
-   {:"rasd:AddressOnParent"=>"0",
-    :"rasd:AutomaticAllocation"=>"false",
-    :"rasd:Description"=>"CD/DVD Drive",
-    :"rasd:ElementName"=>"CD/DVD Drive 1",
-    :"rasd:HostResource"=>"",
-    :"rasd:InstanceID"=>"3000",
-    :"rasd:Parent"=>"3",
-    :"rasd:ResourceType"=>"15"},
-   {:"rasd:AddressOnParent"=>"0",
-    :"rasd:AutomaticAllocation"=>"false",
-    :"rasd:Description"=>"Floppy Drive",
-    :"rasd:ElementName"=>"Floppy Drive 1",
-    :"rasd:HostResource"=>"",
-    :"rasd:InstanceID"=>"8000",
-    :"rasd:ResourceType"=>"14"},
-   {:vcloud_href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/cpu",
-    :vcloud_type=>"application/vnd.vmware.vcloud.rasdItem+xml",
-    :"rasd:AllocationUnits"=>"hertz * 10^6",
-    :"rasd:Description"=>"Number of Virtual CPUs",
-    :"rasd:ElementName"=>"1 virtual CPU(s)",
-    :"rasd:InstanceID"=>"4",
-    :"rasd:Reservation"=>"0",
-    :"rasd:ResourceType"=>"3",
-    :"rasd:VirtualQuantity"=>"1",
-    :"rasd:Weight"=>"0",
-    :Link=>
-     {:rel=>"edit",
-      :type=>"application/vnd.vmware.vcloud.rasdItem+xml",
-      :href=>
-       "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/cpu"}},
-   {:vcloud_href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/memory",
-    :vcloud_type=>"application/vnd.vmware.vcloud.rasdItem+xml",
-    :"rasd:AllocationUnits"=>"byte * 2^20",
-    :"rasd:Description"=>"Memory Size",
-    :"rasd:ElementName"=>"512 MB of memory",
-    :"rasd:InstanceID"=>"5",
-    :"rasd:Reservation"=>"0",
-    :"rasd:ResourceType"=>"4",
-    :"rasd:VirtualQuantity"=>"768",
-    :"rasd:Weight"=>"0",
-    :Link=>
-     {:rel=>"edit",
-      :type=>"application/vnd.vmware.vcloud.rasdItem+xml",
-      :href=>
-       "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/memory"}}],
- :Link=>
-  [{:rel=>"edit",
-    :type=>"application/vnd.vmware.vcloud.virtualHardwareSection+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/"},
-   {:rel=>"down",
-    :type=>"application/vnd.vmware.vcloud.rasdItem+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/cpu"},
-   {:rel=>"edit",
-    :type=>"application/vnd.vmware.vcloud.rasdItem+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/cpu"},
-   {:rel=>"down",
-    :type=>"application/vnd.vmware.vcloud.rasdItem+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/memory"},
-   {:rel=>"edit",
-    :type=>"application/vnd.vmware.vcloud.rasdItem+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/memory"},
-   {:rel=>"down",
-    :type=>"application/vnd.vmware.vcloud.rasdItemsList+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/disks"},
-   {:rel=>"edit",
-    :type=>"application/vnd.vmware.vcloud.rasdItemsList+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/disks"},
-   {:rel=>"down",
-    :type=>"application/vnd.vmware.vcloud.rasdItemsList+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/media"},
-   {:rel=>"down",
-    :type=>"application/vnd.vmware.vcloud.rasdItemsList+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/networkCards"},
-   {:rel=>"edit",
-    :type=>"application/vnd.vmware.vcloud.rasdItemsList+xml",
-    :href=>
-     "https://vcd01.esx.dev.int.realestate.com.au/api/v1.0/vApp/vm-624535987/virtualHardwareSection/networkCards"}]}
-
-
 module Fog
   module Vcloud
     class Compute
@@ -138,7 +6,7 @@ module Fog
 
         def validate_vm_data(vm_data)
           valid_opts = [:name, :cpus, :memory, :disks]
-          unless valid_opts.all? { |opt| vm_data.keys.include?(opt) }
+          unless valid_opts.all? { |opt| vm_data.has_key?(opt) }
             raise ArgumentError.new("Required vm data missing: #{(valid_opts - vm_data.keys).map(&:inspect).join(", ")}")
           end
         end
@@ -238,10 +106,4 @@ module Fog
       end
     end
   end
-end
-
-if $0 == __FILE__
-  require 'builder'
-  i = Fog::Vcloud::Compute::Real.new
-  puts i.generate_configure_vm_request(hardware_hash)
-end
+end

data/lib/fog/vcloud/requests/compute/get_server.rb

@@ -0,0 +1,10 @@
+module Fog
+  module Vcloud
+    class Compute
+
+      class Real
+        basic_request :get_server
+      end
+    end
+  end
+end

data/lib/fog/vcloud/requests/compute/instantiate_vapp_template.rb

@@ -7,7 +7,7 @@ module Fog
         def validate_instantiate_vapp_template_options options
           # :network_uri removed, if not specified will use template network config.
           valid_opts = [:catalog_item_uri, :name, :vdc_uri]
-          unless valid_opts.all? { |opt| options.keys.include?(opt) }
+          unless valid_opts.all? { |opt| options.has_key?(opt) }
             raise ArgumentError.new("Required data missing: #{(valid_opts - options.keys).map(&:inspect).join(", ")}")
           end