fog-proxmox 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a248dd1c4522b48cddfef2eccd5d07ee1c888fd72460ec333390e71b81803b5
-  data.tar.gz: 3ba917b2e4ae32138edabc4abc8cd65d5248eb6404f367bb11cd61a4c7395180
+  metadata.gz: d571150b56652b8f22fc3172ac26caf7918bdc167c5202b9f0809f138693da0f
+  data.tar.gz: f26c7b0f98d625306b573bdc2c848974438b03260ac7814b796d055e9967c88a
 SHA512:
-  metadata.gz: 962ebb8637afce2db9c75156efcaf0d296c41b9027f881824bc096046016077126c2efd498caa346fa3837310d42a67ae0dfba7854124b9664c36b520f073044
-  data.tar.gz: a13abbba5806fd3414a52cfac3fb684c596eb7cd9edec744813274d41ca1afdf4d0e69e8d136ba9407691e60d24de4f2991f93aa2687186dadabdb4b13c6f726
+  metadata.gz: df89614d08202bce01cc9f9be6d0fe3bd03a763672016ef363a0666a70e08625c6babed6d5969344496334d1aa5f59ef9584bf4e10b1b8f1b39a60d648d8b3b0
+  data.tar.gz: 4fea613dea946a99e5376f6b691eaf6112c1f21d8116497a44e0cc67aba0ddb081a766941b9a1fb8922e40160e451791984a2c06176670fce9f979556fc730bd

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [1.1.0](https://github.com/fog/fog-proxmox/compare/v1.0.0...v1.1.0) (2026-10-21)
+
+
+### Features
+
+* Add hotplug support ([#158](https://github.com/fog/fog-proxmox/issues/158)) ([0745f60](https://github.com/fog/fog-proxmox/commit/0745f6013003af9d0b1ec7304749a5c52038fa62))
+* Add VirtIO RNG device support ([#160](https://github.com/fog/fog-proxmox/issues/160)) ([a31b9d3](https://github.com/fog/fog-proxmox/commit/a31b9d39927d82b2db9da6c1889b9fd556905b5c))
+
+
+### Bug Fixes
+
+* ISO upload task polling ([3dc3c31](https://github.com/fog/fog-proxmox/commit/3dc3c31fe8cd72fc719954917dad39afa6b08ebd))
+
 ## [1.0.0](https://github.com/fog/fog-proxmox/compare/v0.16.2...v1.0.0) (2026-09-14)
 
 

data/README.md

@@ -2,14 +2,14 @@
 
 # Fog::Proxmox
 
-![CI](https://github.com/fog/fog-proxmox/workflows/CI/badge.svg)
+[![CI](https://github.com/fog/fog-proxmox/actions/workflows/ci.yml/badge.svg)](https://github.com/fog/fog-proxmox/actions/workflows/ci.yml)
 [![Maintainability](https://api.codeclimate.com/v1/badges/dfcdcc32f096abf1b2b4/maintainability)](https://codeclimate.com/github/fog/fog-proxmox/maintainability)
 [![Test Coverage](https://api.codeclimate.com/v1/badges/dfcdcc32f096abf1b2b4/test_coverage)](https://codeclimate.com/github/fog/fog-proxmox/test_coverage)
 [![Gem Version](https://badge.fury.io/rb/fog-proxmox.svg)](https://badge.fury.io/rb/fog-proxmox)
 
-This is a [FOG](http://fog.io/) (>= 2.1) module gem to support [Proxmox VE](https://www.proxmox.com/en/proxmox-ve)
+This is a [FOG](https://fog.github.io/) (>= 2.1) module gem to support [Proxmox VE](https://www.proxmox.com/en/proxmox-ve)
 
-It is intended to satisfy this [feature](https://github.com/fog/fog/issues/3644), but Proxmox provider only, and above all this [Foreman](http://www.theforeman.org) [feature](https://projects.theforeman.org/issues/2186).
+It is intended to satisfy this [feature](https://github.com/fog/fog/issues/3644), but Proxmox provider only, and above all this [Foreman](https://www.theforeman.org) [feature](https://projects.theforeman.org/issues/2186).
 
 It is inspired by the great [fog-openstack](https://github.com/fog/fog-openstack) module.
 
@@ -102,7 +102,7 @@ bundle exec rake --tasks
 ## Contributing
 
 You can reach the [contributors](.github/CONTRIBUTORS.md).
-Bug reports and pull requests are welcome on GitHub at [Fog-Proxmox](https://github.com/fog/fog-proxmox/issues). This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at [Fog-Proxmox](https://github.com/fog/fog-proxmox/issues). This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](https://www.contributor-covenant.org) code of conduct.
 
 Please read [how to contribute](.github/CONTRIBUTING.md).
 

data/lib/fog/proxmox/compute/models/rng.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+# This file is part of Fog::Proxmox.
+
+# Fog::Proxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# Fog::Proxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with Fog::Proxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'fog/proxmox/helpers/rng_helper'
+
+module Fog
+  module Proxmox
+    class Compute
+      # VirtIO RNG device; period is in milliseconds and max_bytes is in bytes.
+      class Rng < Fog::Model
+        attribute :max_bytes
+        attribute :period
+        attribute :source
+
+        def flatten
+          Fog::Proxmox::RngHelper.flatten(attributes)
+        end
+      end
+    end
+  end
+end

data/lib/fog/proxmox/compute/models/server_config.rb

@@ -21,6 +21,7 @@ require 'fog/proxmox/attributes'
 require 'fog/proxmox/helpers/nic_helper'
 require 'fog/proxmox/helpers/controller_helper'
 require 'fog/proxmox/helpers/efidisk_helper'
+require 'fog/proxmox/helpers/rng_helper'
 
 module Fog
   module Proxmox
@@ -41,6 +42,7 @@ module Fog
         attribute :onboot
         attribute :boot
         attribute :agent
+        attribute :hotplug
         attribute :scsihw
         attribute :sockets
         attribute :memory
@@ -80,6 +82,7 @@ module Fog
         attribute :searchdomain
         attribute :nameserver
         attribute :efidisk
+        attribute :rng
 
         def initialize(new_attributes = {})
           prepare_service_value(new_attributes)
@@ -88,6 +91,7 @@ module Fog
           initialize_interfaces(new_attributes)
           initialize_disks(new_attributes)
           initialize_efidisk(new_attributes)
+          initialize_rng(new_attributes)
           super(new_attributes)
         end
 
@@ -103,9 +107,10 @@ module Fog
         end
 
         def flatten
-          flat_hash = attributes.reject { |attribute| %i[node_id type vmid disks interfaces].include? attribute }
+          flat_hash = attributes.reject { |attribute| %i[node_id type vmid disks interfaces rng].include? attribute }
           flat_hash.merge(interfaces_flatten)
           flat_hash.merge(disks_flatten)
+          flat_hash.merge!(rng.flatten) unless rng.nil?
           flat_hash
         end
 
@@ -166,6 +171,14 @@ module Fog
           efidisk_hash = Fog::Proxmox::EfidiskHelper.extract(efidisk)
           attributes[:efidisk] = Fog::Proxmox::Compute::Efidisk.new(efidisk_hash)
         end
+
+        def initialize_rng(new_attributes)
+          rng = new_attributes[:rng0] || new_attributes['rng0']
+          return if rng.nil?
+
+          rng_hash = Fog::Proxmox::RngHelper.extract(rng)
+          attributes[:rng] = Fog::Proxmox::Compute::Rng.new(rng_hash)
+        end
       end
     end
   end

data/lib/fog/proxmox/compute.rb

@@ -37,6 +37,7 @@ module Fog
       model :disk
       collection :disks
       model :efidisk
+      model :rng
       model :server_config
       model :volume
       collection :volumes

data/lib/fog/proxmox/helpers/agent_helper.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+# This file is part of Fog::Proxmox.
+
+# Fog::Proxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# Fog::Proxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with Fog::Proxmox. If not, see <http://www.gnu.org/licenses/>.
+
+module Fog
+  module Proxmox
+    # Convert guest agent settings to and from Proxmox configuration strings.
+    module AgentHelper
+      DEFAULTS = {
+        'enabled' => '0',
+        'freeze-fs-on-backup' => '1',
+        'fstrim_cloned_disks' => '0',
+        'type' => 'virtio'
+      }.freeze
+
+      def self.extract(agent)
+        settings = DEFAULTS.dup
+        agent.to_s.split(',').each do |option|
+          key, value = option.split('=', 2)
+          if value.nil?
+            settings['enabled'] = key
+          else
+            settings[key] = value
+          end
+        end
+
+        settings['freeze-fs-on-backup'] = settings.fetch('freeze-fs', settings['freeze-fs-on-backup'])
+        settings
+      end
+
+      def self.flatten(settings)
+        "enabled=#{settings['enabled']},freeze-fs-on-backup=#{settings['freeze-fs-on-backup']}," \
+          "fstrim_cloned_disks=#{settings['fstrim_cloned_disks']},type=#{settings['type']}"
+      end
+    end
+  end
+end

data/lib/fog/proxmox/helpers/hotplug_helper.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+# This file is part of Fog::Proxmox.
+
+# Fog::Proxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# Fog::Proxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with Fog::Proxmox. If not, see <http://www.gnu.org/licenses/>.
+
+module Fog
+  module Proxmox
+    # Convert hotplug settings to and from Proxmox configuration strings.
+    module HotplugHelper
+      DEVICES = %w[disk network usb cpu memory].freeze
+      DEFAULTS = %w[disk network usb].freeze
+
+      def self.extract(hotplug)
+        hotplug = hotplug.to_s
+        {
+          enabled: hotplug != '0',
+          devices: hotplug.empty? || hotplug == '1' ? DEFAULTS.dup : hotplug.split(',')
+        }
+      end
+
+      def self.flatten(settings)
+        return '0' unless settings[:enabled]
+
+        devices = DEVICES.select { |device| settings[:devices].include?(device) }
+        devices.empty? ? '0' : devices.join(',')
+      end
+    end
+  end
+end

data/lib/fog/proxmox/helpers/rng_helper.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+# This file is part of Fog::Proxmox.
+
+# Fog::Proxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# Fog::Proxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with Fog::Proxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'fog/proxmox/hash'
+
+module Fog
+  module Proxmox
+    # Convert RNG devices to and from Proxmox configuration strings
+    module RngHelper
+      RNG_SOURCES = %w[/dev/urandom /dev/random /dev/hwrng].freeze
+
+      def self.flatten(rng)
+        return {} if rng.nil?
+
+        options = rng.select do |key, value|
+          %i[max_bytes period source].include?(key) && !value.nil? && value != ''
+        end
+
+        validate(options)
+
+        { rng0: Fog::Proxmox::Hash.stringify(options) }
+      end
+
+      def self.validate(rng)
+        raise ArgumentError, 'RNG source is required and must be /dev/urandom, /dev/random, or /dev/hwrng' unless RNG_SOURCES.include?(rng[:source].to_s)
+
+        %i[max_bytes period].each do |key|
+          next if rng[key].nil? || rng[key] == ''
+          next if rng[key].to_s.match?(/\A[0-9]+\z/)
+
+          raise ArgumentError, "RNG #{key} must be a non-negative integer"
+        end
+
+        true
+      end
+
+      def self.extract(rng)
+        options = rng.split(',').each_with_object({}) do |option, values|
+          key, value = option.split('=', 2)
+          values[key.to_sym] = value&.sub(/\A"(.*)"\z/, '\1')
+        end
+
+        options.slice(:max_bytes, :period, :source)
+      end
+    end
+  end
+end

data/lib/fog/proxmox/storage/models/iso_upload.rb

@@ -22,9 +22,10 @@ module Fog
             )
           end
           Fog::Logger.debug("Upload response: #{response.inspect}")
-          raise Fog::Errors::Error, "Unexpected upload response: #{response.inspect}" unless response.to_s.start_with?('UPID:')
+          task_node = response.to_s[/\AUPID:([^:]+):/, 1]
+          raise Fog::Errors::Error, "Unexpected upload response: #{response.inspect}" unless task_node
 
-          service.nodes.get(node_id).tasks.wait_for(response)
+          service.nodes.get(task_node).tasks.wait_for(response)
           response
         end
       end

data/lib/fog/proxmox/version.rb

@@ -19,6 +19,6 @@
 
 module Fog
   module Proxmox
-    VERSION = '1.0.0'
+    VERSION = '1.1.0'
   end
 end

data/spec/fog/proxmox/storage/storage_upload_iso_spec.rb

@@ -13,6 +13,7 @@ describe Fog::Proxmox::Compute::Storage do # rubocop:disable RSpec/SpecFilePathF
   let(:upload_service) { Minitest::Mock.new }
   let(:storage) { storage_class.new(service: service, node_id: 'pve', storage: 'local') }
   let(:iso) { Tempfile.new(['cloudinit', '.iso']) }
+  let(:upload_upid) { 'UPID:pve:000008D8:00009E0D:5FBE5DEC:imgcopy::root@pam:' }
 
   attr_accessor :uploaded_file
 
@@ -28,11 +29,11 @@ describe Fog::Proxmox::Compute::Storage do # rubocop:disable RSpec/SpecFilePathF
     iso.close!
   end
 
-  def expect_upload(response, error: nil)
+  def expect_upload(response, error: nil, node: 'pve')
     service.expect(:nil?, false)
     service.expect(:config, :compute_config)
     upload_service.expect(:upload_iso, response) do |path, body|
-      _(path).must_equal(node: 'pve', storage: 'local')
+      _(path).must_equal(node: node, storage: 'local')
       _(body[:filename]).must_equal File.basename(iso.path)
       self.uploaded_file = body[:file]
       _(uploaded_file.read).must_equal "cloud-init\x00\xFF".b
@@ -54,27 +55,38 @@ describe Fog::Proxmox::Compute::Storage do # rubocop:disable RSpec/SpecFilePathF
     upload_service.verify
   end
 
-  def expect_wait(error: nil)
+  def expect_wait(error: nil, node: 'pve', expected_upid: upload_upid)
     tasks = Object.new
     test = self
     tasks.define_singleton_method(:wait_for) do |upid|
-      test.assert_equal 'UPID:upload', upid
+      test.assert_equal expected_upid, upid
       test.assert_predicate test.uploaded_file, :closed?
       raise error if error
 
       true
     end
     nodes = Minitest::Mock.new
-    nodes.expect(:get, Struct.new(:tasks).new(tasks), ['pve'])
+    nodes.expect(:get, Struct.new(:tasks).new(tasks), [node])
     service.expect(:nodes, nodes)
     nodes
   end
 
   it 'uploads to its node and storage, closes the file, and waits before returning the UPID' do
-    expect_upload('UPID:upload')
+    expect_upload(upload_upid)
     nodes = expect_wait
 
-    _(upload_iso).must_equal 'UPID:upload'
+    _(upload_iso).must_equal upload_upid
+    service.verify
+    nodes.verify
+  end
+
+  it 'polls the node in the returned UPID when it differs from the upload node' do
+    storage.node_id = 'test-2'
+    upid = 'UPID:test-1:000008D8:00009E0D:5FBE5DEC:upload::root@pam:'
+    expect_upload(upid, node: 'test-2')
+    nodes = expect_wait(node: 'test-1', expected_upid: upid)
+
+    _(upload_iso).must_equal upid
     service.verify
     nodes.verify
   end
@@ -88,6 +100,15 @@ describe Fog::Proxmox::Compute::Storage do # rubocop:disable RSpec/SpecFilePathF
     service.verify
   end
 
+  it 'rejects a UPID with no task owner without polling tasks' do
+    expect_upload('UPID::000008D8:00009E0D:5FBE5DEC:imgcopy::root@pam:')
+
+    error = _(proc { upload_iso }).must_raise Fog::Errors::Error
+    _(error.message).must_match(/Unexpected upload response/)
+    _(uploaded_file.closed?).must_equal true
+    service.verify
+  end
+
   it 'closes the file when the upload request fails' do
     expect_upload(nil, error: Fog::Errors::Error.new('Upload failed'))
 
@@ -97,7 +118,7 @@ describe Fog::Proxmox::Compute::Storage do # rubocop:disable RSpec/SpecFilePathF
   end
 
   it 'propagates task failures' do
-    expect_upload('UPID:upload')
+    expect_upload(upload_upid)
     nodes = expect_wait(error: Fog::Errors::Error.new('Task failed'))
 
     error = _(proc { upload_iso }).must_raise Fog::Errors::Error

data/spec/helpers/agent_helper_spec.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+# This file is part of Fog::Proxmox.
+
+# Fog::Proxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# Fog::Proxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with Fog::Proxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'spec_helper'
+require 'fog/proxmox/helpers/agent_helper'
+
+describe 'AgentHelper' do
+  describe '.extract' do
+    [nil, '', '0', 0].each do |agent|
+      it "uses disabled defaults for #{agent.inspect}" do
+        assert_equal Fog::Proxmox::AgentHelper::DEFAULTS, Fog::Proxmox::AgentHelper.extract(agent)
+      end
+    end
+
+    ['1', 1, 'enabled=1'].each do |agent|
+      it "reads enabled shorthand #{agent.inspect}" do
+        expected = Fog::Proxmox::AgentHelper::DEFAULTS.merge('enabled' => '1')
+        assert_equal expected, Fog::Proxmox::AgentHelper.extract(agent)
+      end
+    end
+
+    it 'reads explicit options even when disabled' do
+      settings = Fog::Proxmox::AgentHelper.extract('enabled=0,freeze-fs-on-backup=0,fstrim_cloned_disks=1,type=isa')
+      assert_equal({ 'enabled' => '0', 'freeze-fs-on-backup' => '0', 'fstrim_cloned_disks' => '1', 'type' => 'isa' }, settings)
+    end
+
+    it 'prefers freeze-fs regardless of option order' do
+      ['freeze-fs=0,freeze-fs-on-backup=1', 'freeze-fs-on-backup=1,freeze-fs=0'].each do |options|
+        assert_equal '0', Fog::Proxmox::AgentHelper.extract("1,#{options}")['freeze-fs-on-backup']
+      end
+    end
+
+    it 'splits option values at only the first equals sign' do
+      assert_equal 'a=b', Fog::Proxmox::AgentHelper.extract('type=a=b')['type']
+    end
+
+    it 'returns independent settings without changing defaults' do
+      Fog::Proxmox::AgentHelper.extract(nil)['enabled'] = '1'
+      assert_equal '0', Fog::Proxmox::AgentHelper.extract(nil)['enabled']
+    end
+  end
+
+  describe '.flatten' do
+    %w[0 1].each do |enabled|
+      it "serializes all options with enabled=#{enabled}" do
+        settings = { 'enabled' => enabled, 'freeze-fs-on-backup' => '0', 'fstrim_cloned_disks' => '1', 'type' => 'isa' }
+        assert_equal "enabled=#{enabled},freeze-fs-on-backup=0,fstrim_cloned_disks=1,type=isa", Fog::Proxmox::AgentHelper.flatten(settings)
+        assert_equal settings, Fog::Proxmox::AgentHelper.extract(Fog::Proxmox::AgentHelper.flatten(settings))
+      end
+    end
+  end
+end

data/spec/helpers/hotplug_helper_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+# This file is part of Fog::Proxmox.
+
+# Fog::Proxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# Fog::Proxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with Fog::Proxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'spec_helper'
+require 'fog/proxmox/helpers/hotplug_helper'
+
+describe 'HotplugHelper' do
+  describe '.extract' do
+    [nil, '', '1', 1].each do |hotplug|
+      it "uses enabled default devices for #{hotplug.inspect}" do
+        assert_equal({ enabled: true, devices: %w[disk network usb] }, Fog::Proxmox::HotplugHelper.extract(hotplug))
+      end
+    end
+
+    ['0', 0].each do |hotplug|
+      it "disables hotplug for #{hotplug.inspect}" do
+        settings = Fog::Proxmox::HotplugHelper.extract(hotplug)
+        assert_equal false, settings[:enabled]
+        assert_empty Fog::Proxmox::HotplugHelper::DEVICES & settings[:devices]
+      end
+    end
+
+    it 'reads an explicit device list' do
+      assert_equal({ enabled: true, devices: %w[disk cpu memory] }, Fog::Proxmox::HotplugHelper.extract('disk,cpu,memory'))
+    end
+
+    it 'returns an independent default device list' do
+      Fog::Proxmox::HotplugHelper.extract(nil)[:devices].clear
+      assert_equal %w[disk network usb], Fog::Proxmox::HotplugHelper.extract(nil)[:devices]
+    end
+  end
+
+  describe '.flatten' do
+    it 'serializes selected devices in the existing device order' do
+      assert_equal 'disk,network,cpu', Fog::Proxmox::HotplugHelper.flatten(enabled: true, devices: %w[cpu network disk])
+    end
+
+    it 'disables hotplug even when devices are selected' do
+      assert_equal '0', Fog::Proxmox::HotplugHelper.flatten(enabled: false, devices: %w[disk network])
+    end
+
+    it 'disables hotplug when no supported devices are selected' do
+      [[], ['unknown']].each do |devices|
+        assert_equal '0', Fog::Proxmox::HotplugHelper.flatten(enabled: true, devices: devices)
+      end
+    end
+
+    it 'round trips explicit supported devices' do
+      raw = 'disk,cpu,memory'
+      assert_equal raw, Fog::Proxmox::HotplugHelper.flatten(Fog::Proxmox::HotplugHelper.extract(raw))
+    end
+  end
+end

data/spec/helpers/rng_helper_spec.rb

@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+# This file is part of Fog::Proxmox.
+
+# Fog::Proxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# Fog::Proxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with Fog::Proxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'spec_helper'
+require 'fog/proxmox/helpers/rng_helper'
+
+rng_helper_class = Fog::Proxmox::RngHelper
+
+describe Fog::Proxmox::RngHelper do
+  let(:rng_value) { 'max_bytes=1024,period=2000,source=/dev/urandom' }
+  let(:rng_attributes) { { max_bytes: '1024', period: '2000', source: '/dev/urandom' } }
+
+  it 'extracts all RNG options' do
+    assert_equal rng_attributes, rng_helper_class.extract(rng_value)
+  end
+
+  it 'extracts options regardless of their order' do
+    assert_equal rng_attributes,
+                 rng_helper_class.extract('source=/dev/urandom,period=2000,max_bytes=1024')
+  end
+
+  it 'extracts a quoted period without the surrounding quotes' do
+    assert_equal rng_attributes,
+                 rng_helper_class.extract('source=/dev/urandom,max_bytes=1024,period="2000"')
+  end
+
+  it 'extracts quoted values for all RNG options' do
+    assert_equal rng_attributes,
+                 rng_helper_class.extract('max_bytes="1024",period="2000",source="/dev/urandom"')
+  end
+
+  it 'extracts a source without optional rate limits' do
+    assert_equal({ source: '/dev/hwrng' },
+                 rng_helper_class.extract('source=/dev/hwrng'))
+  end
+
+  it 'ignores unsupported options when extracting' do
+    assert_equal({ source: '/dev/urandom' },
+                 rng_helper_class.extract('source=/dev/urandom,unknown=value'))
+  end
+
+  it 'flattens all RNG options' do
+    assert_equal({ rng0: rng_value }, rng_helper_class.flatten(rng_attributes))
+  end
+
+  it 'accepts each supported RNG source' do
+    %w[/dev/urandom /dev/random /dev/hwrng].each do |source|
+      assert_equal({ rng0: "source=#{source}" }, rng_helper_class.flatten(source: source))
+    end
+  end
+
+  it 'requires a source when configuring an RNG device' do
+    [{}, { max_bytes: 1024 }, { source: nil }, { source: '' }].each do |attributes|
+      error = assert_raises(ArgumentError) { rng_helper_class.flatten(attributes) }
+      assert_match(/RNG source is required/, error.message)
+    end
+  end
+
+  it 'rejects unsupported or partially matching source paths' do
+    ['/dev/null', '/dev/random/extra', 'prefix/dev/urandom', "/dev/hwrng\n", ' '].each do |source|
+      assert_raises(ArgumentError) { rng_helper_class.flatten(source: source) }
+    end
+  end
+
+  it 'accepts integer rate limits' do
+    assert_equal({ rng0: rng_value },
+                 rng_helper_class.flatten(max_bytes: 1024, period: 2000, source: '/dev/urandom'))
+  end
+
+  %i[max_bytes period].each do |key|
+    it "rejects invalid #{key} values" do
+      ['abc', '1024bytes', '1.5', 1.5, -1, '-1', true, ' ', "1024\n"].each do |value|
+        error = assert_raises(ArgumentError) do
+          rng_helper_class.flatten(source: '/dev/urandom', key => value)
+        end
+        assert_equal "RNG #{key} must be a non-negative integer", error.message
+      end
+    end
+  end
+
+  it 'omits unset options and retains zero values' do
+    assert_equal({ rng0: 'max_bytes=0,source=/dev/random' },
+                 rng_helper_class.flatten(max_bytes: 0, period: nil, source: '/dev/random'))
+  end
+
+  it 'omits blank limits and unsupported options' do
+    assert_equal({ rng0: 'source=/dev/urandom' },
+                 rng_helper_class.flatten(max_bytes: '', period: '', source: '/dev/urandom', unknown: 'value'))
+  end
+
+  it 'returns an empty hash for a missing device' do
+    assert_empty rng_helper_class.flatten(nil)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fog-proxmox
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Tristan Robert
@@ -9,20 +9,6 @@ bindir: bin
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: bundler-audit
   requirement: !ruby/object:Gem::Requirement
@@ -264,6 +250,7 @@ files:
 - lib/fog/proxmox/compute/models/multipart_iso_upload.rb
 - lib/fog/proxmox/compute/models/node.rb
 - lib/fog/proxmox/compute/models/nodes.rb
+- lib/fog/proxmox/compute/models/rng.rb
 - lib/fog/proxmox/compute/models/server.rb
 - lib/fog/proxmox/compute/models/server_config.rb
 - lib/fog/proxmox/compute/models/servers.rb
@@ -315,12 +302,15 @@ files:
 - lib/fog/proxmox/core.rb
 - lib/fog/proxmox/errors.rb
 - lib/fog/proxmox/hash.rb
+- lib/fog/proxmox/helpers/agent_helper.rb
 - lib/fog/proxmox/helpers/controller_helper.rb
 - lib/fog/proxmox/helpers/cpu_helper.rb
 - lib/fog/proxmox/helpers/disk_helper.rb
 - lib/fog/proxmox/helpers/efidisk_helper.rb
+- lib/fog/proxmox/helpers/hotplug_helper.rb
 - lib/fog/proxmox/helpers/ip_helper.rb
 - lib/fog/proxmox/helpers/nic_helper.rb
+- lib/fog/proxmox/helpers/rng_helper.rb
 - lib/fog/proxmox/identity.rb
 - lib/fog/proxmox/identity/models/domain.rb
 - lib/fog/proxmox/identity/models/domain_type.rb
@@ -422,12 +412,15 @@ files:
 - spec/fog/proxmox/storage/real_upload_iso_spec.rb
 - spec/fog/proxmox/storage/storage_upload_iso_spec.rb
 - spec/hash_spec.rb
+- spec/helpers/agent_helper_spec.rb
 - spec/helpers/controller_helper_spec.rb
 - spec/helpers/cpu_helper_spec.rb
 - spec/helpers/disk_helper_spec.rb
 - spec/helpers/efidisk_helper_spec.rb
+- spec/helpers/hotplug_helper_spec.rb
 - spec/helpers/ip_helper_spec.rb
 - spec/helpers/nic_helper_spec.rb
+- spec/helpers/rng_helper_spec.rb
 - spec/identity_spec.rb
 - spec/network_spec.rb
 - spec/proxmox_vcr.rb