fog-proxmox 0.10.0 → 0.14.0

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/list_snapshots.rb

@@ -36,7 +36,30 @@ module Fog
 
       # class Mock list_snapshots request
       class Mock
-        def list_snapshots; end
+        def list_snapshots(_path_params)
+          [
+            {
+              'name' => 'snapshot1',
+              'description' => 'latest snapshot',
+              'snaptime' => 1_578_057_452,
+              'vmstate' => 0,
+              'node_id' => 'proxmox',
+              'server_id' => '100',
+              'server_type' => 'qemu',
+              'vmgenid' => nil
+            },
+            {
+              'name' => 'snapshot2',
+              'description' => 'latest snapshot2',
+              'snaptime' => 1_578_058_452,
+              'vmstate' => 0,
+              'node_id' => 'proxmox',
+              'server_id' => '100',
+              'server_type' => 'qemu',
+              'vmgenid' => nil
+            }
+          ]
+        end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/list_storages.rb

@@ -37,7 +37,9 @@ module Fog
 
       # class Mock list_storages request
       class Mock
-        def list_storages; end
+        def list_storages(_node, _options = {})
+          []
+        end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/list_tasks.rb

@@ -35,7 +35,9 @@ module Fog
 
       # class Mock list_tasks request
       class Mock
-        def list_tasks; end
+        def list_tasks(_node, _options = {})
+          []
+        end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/list_volumes.rb

@@ -35,7 +35,9 @@ module Fog
 
       # class Mock list_volumes request
       class Mock
-        def list_volumes; end
+        def list_volumes(_node, _storage, _options = {})
+          []
+        end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/log_task.rb

@@ -35,7 +35,9 @@ module Fog
 
       # class Mock status_task
       class Mock
-        def log_task(node, upid); end
+        def log_task(_node, _upid, options = {})
+          [{ 't' => 'TASK OK', 'n' => 1 }]
+        end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/migrate_server.rb

@@ -37,7 +37,7 @@ module Fog
 
       # class Mock migrate_server request
       class Mock
-        def migrate_server; end
+        def migrate_server(_path_params, _body_params); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/move_disk.rb

@@ -36,7 +36,7 @@ module Fog
 
       # class Mock move_disk request
       class Mock
-        def move_disk; end
+        def move_disk(_path_params, _body_params); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/move_volume.rb

@@ -36,7 +36,7 @@ module Fog
 
       # class Mock move_volume request
       class Mock
-        def move_volume; end
+        def move_volume(_path_params, _body_params); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/next_vmid.rb

@@ -35,6 +35,7 @@ module Fog
 
       # class Mock next_vmid collection
       class Mock
+        def next_vmid; end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/resize_container.rb

@@ -36,7 +36,7 @@ module Fog
 
       # class Mock resize_container request
       class Mock
-        def resize_container; end
+        def resize_container(_path_params, _body_params); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/resize_server.rb

@@ -36,7 +36,7 @@ module Fog
 
       # class Mock resize_server request
       class Mock
-        def resize_server; end
+        def resize_server(_path_params, _body_params); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/rollback_snapshot.rb

@@ -39,7 +39,9 @@ module Fog
 
       # class Mock rollback_snapshot request
       class Mock
-        def rollback_snapshot; end
+        def rollback_snapshot(_path_params)
+          'UPID:proxmox:00002EBF:646E2BF3:5E1C7E39:qmrollback:100:root@pam:'
+        end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/status_task.rb

@@ -34,7 +34,7 @@ module Fog
 
       # class Mock status_task
       class Mock
-        def status_task(node, upid); end
+        def status_task(_node, _upid); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/stop_task.rb

@@ -34,7 +34,7 @@ module Fog
 
       # class Mock get_task collection
       class Mock
-        def stop_task(taskid); end
+        def stop_task(_node, _taskid); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/template_server.rb

@@ -37,6 +37,7 @@ module Fog
 
       # class Mock template_server request
       class Mock
+        def template_server(_path_params, _body_params); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/update_server.rb

@@ -37,6 +37,7 @@ module Fog
 
       # class Mock update_server request
       class Mock
+        def update_server(_path_params, _body_params); end
       end
     end
   end

data/lib/fog/{compute/proxmox → proxmox/compute}/requests/update_snapshot.rb

@@ -38,7 +38,7 @@ module Fog
 
       # class Mock update_snapshot request
       class Mock
-        def update_snapshot; end
+        def update_snapshot(_path_params, _body_params); end
       end
     end
   end

data/lib/fog/proxmox/core.rb

@@ -25,41 +25,55 @@ module Fog
   module Proxmox
     # Core module
     module Core
-      attr_accessor :pve_ticket
-      attr_reader :pve_csrftoken
-      attr_reader :pve_username
-      attr_reader :deadline
-      attr_reader :principal
+      attr_accessor :token
+      attr_reader :auth_method
+      attr_reader :expires
+      attr_reader :current_user
+
+      def user_token?
+        @auth_token == 'user_token'
+      end
 
       # fallback
       def self.not_found_class
-        Fog::Proxmox::Compute::NotFound
+        Fog::Proxmox::Core::NotFound
       end
 
-      def initialize_identity(options)
-        @principal = nil
-        @pve_ticket = nil
-        Fog::Proxmox::Variables.to_variables(self, options, 'pve')
-        @pve_uri = URI.parse(@pve_url)
-        missing_credentials = []
-        missing_credentials << :pve_username unless @pve_username
+      def initialize(options = {})
+        setup(options)
+        authenticate
+        @auth_token.missing_credentials(options)
+        @connection = Fog::Core::Connection.new(@proxmox_url, @persistent, @connection_options)
+      end
 
-        unless @pve_ticket
-          missing_credentials << :pve_password unless @pve_password
+      def setup(options)        
+        if options.respond_to?(:config_service?) && options.config_service?
+          configure(options)
+          return
         end
-
-        raise ArgumentError, "Missing required arguments: #{missing_credentials.join(', ')}" unless missing_credentials.empty?
+        Fog::Proxmox::Variables.to_variables(self, options, 'proxmox')
+        @connection_options = options[:connection_options] || {}
+        @connection_options[:disable_proxy] = true if ENV['DISABLE_PROXY'] == 'true'    
+        @connection_options[:ssl_verify_peer] = false if ENV['SSL_VERIFY_PEER'] == 'false'
+        @proxmox_must_reauthenticate = true
+        @persistent = options[:persistent] || false  
+        @token ||= options[:proxmox_token]   
+        @auth_method ||= options[:proxmox_auth_method]   
+        if @token
+          @proxmox_can_reauthenticate = false
+        else
+          @proxmox_can_reauthenticate = true
+        end   
       end
 
       def credentials
         options = {
           provider: 'proxmox',
-          pve_url: @pve_uri.to_s,
-          pve_ticket: @pve_ticket,
-          pve_csrftoken: @pve_csrftoken,
-          pve_username: @pve_username
+          proxmox_auth_method: @auth_method,
+          proxmox_url: @proxmox_uri.to_s,
+          current_user: @current_user
         }
-        pve_options.merge options
+        proxmox_options.merge options
       end
 
       def reload
@@ -68,16 +82,22 @@ module Fog
 
       private
 
+      def expired?
+        return false if @expires.nil?
+        return false if @expires == 0
+        return @expires - Time.now.utc.to_i < 60
+      end
+
       def request(params)
-        retried = false
+        retried = false     
         begin
-          response = @connection.request(params.merge(
-                                           headers: headers(params[:method], params[:headers])
-          ))
+          authenticate! if expired?
+          request_options = params.merge(path: "#{@path}/#{params[:path]}", headers: @auth_token.headers(params[:method], params.respond_to?(:headers) ? params[:headers] : {}, {}))
+          response = @connection.request(request_options)
         rescue Excon::Errors::Unauthorized => error
           # token expiration and token renewal possible
-          if error.response.body != 'Bad username or password' && !retried
-            authenticate
+          if !%w[Bad username or password, invalid token value!].include?(error.response.body) && @proxmox_can_reauthenticate && !retried
+            authenticate!
             retried = true
             retry
           # bad credentials or token renewal not possible
@@ -95,41 +115,30 @@ module Fog
         Fog::Proxmox::Json.get_data(response)
       end
 
-      def headers(method, additional_headers)
-        additional_headers ||= {}
-        headers_hash = { 'Accept' => 'application/json' }
-        # CSRF token is required to PUT, POST and DELETE http requests
-        if %w[PUT POST DELETE].include? method
-          headers_hash.store('CSRFPreventionToken', @pve_csrftoken)
-        end
-        # ticket must be present in cookie
-        headers_hash.store('Cookie', "PVEAuthCookie=#{@pve_ticket}") if @pve_ticket
-        headers_hash.merge additional_headers
-        headers_hash
-      end
-
-      def pve_options
-        Fog::Proxmox::Variables.to_hash(self, 'pve')
+      def proxmox_options
+        Fog::Proxmox::Variables.to_hash(self, 'proxmox')
       end
 
       def authenticate
-        options = pve_options
-        @pve_ticket = options[:pve_ticket]
-        Fog::Proxmox.authenticate(options, @connection_options)
-        @principal = Fog::Proxmox.credentials
-        @pve_username = Fog::Proxmox.credentials[:username]
-        @pve_ticket = Fog::Proxmox.credentials[:ticket]
-        @pve_deadline = Fog::Proxmox.credentials[:deadline]
-        @pve_csrftoken = Fog::Proxmox.credentials[:csrftoken]
-
-        @host       = @pve_uri.host
-        @api_path   = @pve_uri.path
-        @api_path.sub!(%r{/$}, '')
-        @port       = @pve_uri.port
-        @scheme     = @pve_uri.scheme
-
+        if @proxmox_must_reauthenticate
+          @token = nil if @proxmox_must_reauthenticate
+          @auth_token = Fog::Proxmox::Auth::Token.build(proxmox_options, @connection_options)
+          @current_user = proxmox_options[:proxmox_userid] ? proxmox_options[:proxmox_userid] : proxmox_options[:proxmox_username]
+          @token = @auth_token.token
+          @expires = @auth_token.expires
+          @proxmox_must_reauthenticate = false
+        else
+          @token = @proxmox_token
+        end
+        uri = URI.parse(@proxmox_url)
+        @path = uri.path
         true
       end
+
+      def authenticate!
+        @proxmox_must_reauthenticate = true
+        authenticate
+      end
     end
   end
 end

data/lib/fog/proxmox/hash.rb

@@ -23,13 +23,13 @@ module Fog
     module Hash
 
       def self.stringify(hash)
-        filtered = hash.reject { |_key,value| value.to_s.empty? }
+        filtered = hash.reject { |_key, value| value.nil? }
         a = filtered.to_a.collect { |item| item.join('=') }
         a.join(',')
       end
 
       def self.flatten(hash)
-        filtered = hash.reject { |_key,value| value.to_s.empty? }
+        filtered = hash.reject { |_key, value| value.nil? }
         a = filtered.to_a.collect { |item| item.join(': ') }
         a.join(',')
       end

data/lib/fog/proxmox/helpers/cpu_helper.rb

@@ -21,21 +21,60 @@ module Fog
   module Proxmox
     # module Cpu mixins
     module CpuHelper
-      CPU_REGEXP = /(\bcputype=)?(\w+)[,]?(\bflags=)?(\+[\w-]+)?[;]?(\+[\w-]+)?/
-      def self.extract(cpu,i)
-        cpu ? CPU_REGEXP.match(cpu.to_s)[i] : ''
+      CPU_REGEXP = /(\bcputype=)?(?<cputype>[\w-]+)[,]?(\bflags=)?(?<flags>[[\+\-][\w-]+[;]?]*)/
+      FLAGS = { spectre: 'spec-ctrl', pcid: 'pcid', ssbd: 'ssbd', ibpb: 'ibpb', virt_ssbd: 'virt-ssbd', amd_ssbd: 'amd-ssbd', amd_no_ssb: 'amd-no-ssb', md_clear: 'md-clear', pdpe1gb: 'pdpe1gb', hv_tlbflush: 'hv-tlbflush', aes: 'aes', hv_evmcs: 'hv-evmcs' }
+      def self.flags
+        FLAGS
+      end
+      
+      def self.extract(cpu, name)
+        captures_h = cpu ? CPU_REGEXP.match(cpu.to_s) : { cputype: '', flags: '' }
+        captures_h[name]
+      end
+
+      def self.extract_cputype(cpu)
+        extract(cpu, :cputype)
+      end
+
+      def self.extract_flags(cpu)
+        extract(cpu, :flags)
+      end
+
+      def self.flag_value(cpu, flag_key)
+        flag_value = '0'
+        raw_values = extract_flags(cpu).split(';').select { |flag| ['+' + flag_key, '-' + flag_key].include?(flag) }
+        unless raw_values.empty?
+          flag_value = raw_values[0].start_with?('+') ? '+1' : raw_values[0].start_with?('-') ? '-1' : '0'
+        end
+        flag_value
       end
 
-      def self.extract_type(cpu)
-        extract(cpu,2)
+      def self.hash_has_no_default_flag?(cpu_h, flag_name)
+        cpu_h.key?(flag_name) && ['-1', '+1'].include?(cpu_h[flag_name])
       end
 
-      def self.has_pcid?(cpu)
-        extract(cpu,5) == '+pcid'
+      def self.hash_flag(cpu_h, flag_name)
+        flag = ''
+        if cpu_h.key?(flag_name)
+          flag = '+' if cpu_h[flag_name] == '+1'
+          flag = '-' if cpu_h[flag_name] == '-1'
+        end
+        flag
       end
 
-      def self.has_spectre?(cpu)
-        extract(cpu,4) == '+spec-ctrl'
+      def self.flatten(cpu_h)
+        return '' unless cpu_h['cpu_type']
+    
+        cpu_type = "cputype=#{cpu_h['cpu_type']}"
+        num_flags = 0
+        FLAGS.each_key { |flag_key| num_flags += 1 if hash_has_no_default_flag?(cpu_h, flag_key.to_s) }
+        cpu_type += ',flags=' if num_flags > 0
+        flags_with_no_default_value = FLAGS.select { |flag_key, _flag_value| hash_has_no_default_flag?(cpu_h, flag_key.to_s) }
+        flags_with_no_default_value.each_with_index do |(flag_key, flag_value), index|
+          cpu_type += hash_flag(cpu_h, flag_key.to_s) + flag_value if hash_has_no_default_flag?(cpu_h, flag_key.to_s)
+          cpu_type += ';' if num_flags > index + 1
+        end
+        cpu_type
       end
     end
   end