fog-ovirt 1.1.6 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa72e4caa6803849c4f51de7bef235366d9e22007ff13dfbdb4f72920c122d0a
-  data.tar.gz: 467de9cd7c7d14b8295d1e5eeda5e1c69d6e9274b250a81862801a5369e820f2
+  metadata.gz: e6c8f50700ff436d3f31a8c67a536c630cd6b8166dffd761f0ec3eaa751bad22
+  data.tar.gz: d3ab17d6c140811ec0843778869c416ea0323cf222efbd5c648128b63ccbe52e
 SHA512:
-  metadata.gz: a217cb09e27d68d211bb8dee856e9967c8f500b6e5a8a74d470272cda0199d80f5a536adb0d8c81ad6831312676aa2b901d0662ddf05b41db07bd45908fc33e5
-  data.tar.gz: 928a4234822357789ab89d685dc5d4addc0dbdfcc096292868d3a1c51a5b43f85762091e9bd13e29cd7782f6756061b0ba8758058370f79f772fd507a5264383
+  metadata.gz: f6a869a3392da2cb17182a5b1d4dbbcaf286757bf55dbf7b0a00bec3ee79351c4d0cd137e1ad1c03001202b1a7e0ae56854b27f65ba78ee81b0e9555291d2998
+  data.tar.gz: df66a186ce9979c987bbc62097b20dd0d1022d5f547549c42806b32441c7a5c3ca58d59e014a24b9e9b6094a3c882356d116cccd31a615504da130788aefdeb5

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-12-14 14:56:02 +0100 using RuboCop version 0.52.0.
+# on 2019-05-22 10:36:37 +0300 using RuboCop version 0.70.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -11,10 +11,10 @@
 Metrics/ClassLength:
   Max: 150
 
-# Offense count: 2
-# Configuration parameters: CountComments.
+# Offense count: 10
+# Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 30
+  Max: 26
 
 # Offense count: 1
 Style/ClassVars:
@@ -26,7 +26,7 @@ Style/CommentedKeyword:
   Exclude:
     - 'lib/fog/ovirt/models/compute/server.rb'
 
-# Offense count: 113
+# Offense count: 188
 Style/Documentation:
   Enabled: false
 
@@ -36,6 +36,13 @@ Style/DoubleNegation:
     - 'lib/fog/ovirt/models/compute/server.rb'
     - 'tests/helpers/succeeds_helper.rb'
 
+# Offense count: 133
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 # Offense count: 4
 Style/MultilineTernaryOperator:
   Exclude:

data/lib/fog/bin/ovirt.rb

@@ -1,9 +1,9 @@
-class Ovirt < Fog::Bin
+class Compute < Fog::Bin
   class << self
     def class_for(key)
       case key
       when :compute
-        Fog::Compute::Ovirt
+        Fog::Ovirt::Compute
       else
         raise ArgumentError, "Unrecognized service: #{key}"
       end
@@ -13,7 +13,7 @@ class Ovirt < Fog::Bin
       @@connections ||= Hash.new do |hash, key|
         hash[key] = case key
                     when :compute
-                      Fog::Compute.new(:provider => "Ovirt")
+                      Fog::Ovirt::Compute.new
                     else
                       raise ArgumentError, "Unrecognized service: #{key.inspect}"
                     end

data/lib/fog/ovirt.rb

@@ -3,11 +3,9 @@ require "fog/xml"
 require "fog/json"
 
 module Fog
-  module Compute
-    autoload :Ovirt, File.expand_path("ovirt/compute", __dir__)
-  end
-
   module Ovirt
+    autoload :Compute, "fog/ovirt/compute"
+
     extend Fog::Provider
 
     module Errors

data/lib/fog/ovirt/compute.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt < Fog::Service
+  module Ovirt
+    class Compute < Fog::Service
       recognizes :api_version, :ovirt_username, :ovirt_password, :ovirt_url,
                  :ovirt_datacenter, :ovirt_ca_cert_store, :public_key
 
@@ -58,9 +58,9 @@ module Fog
 
         # rubocop:disable Style/ConditionalAssignment
         if options[:api_version] == "v4"
-          @client = Fog::Compute::Ovirt::V4.new(options)
+          @client = Fog::Ovirt::Compute::V4.new(options)
         else
-          @client = Fog::Compute::Ovirt::V3.new(options)
+          @client = Fog::Ovirt::Compute::V3.new(options)
         end
         # rubocop:enable Style/ConditionalAssignment
       end
@@ -78,11 +78,11 @@ module Fog
       class Mock
         def initialize(options = {})
           if options[:api_version] == "v4"
-            Fog::Compute::Ovirt::V4::Mock.send(:include, Fog::Compute::Ovirt::Collections)
-            @client = Fog::Compute::Ovirt::V4::Mock.new(options)
+            Fog::Ovirt::Compute::V4::Mock.send(:include, Fog::Ovirt::Compute::Collections)
+            @client = Fog::Ovirt::Compute::V4::Mock.new(options)
           else
-            Fog::Compute::Ovirt::V3::Mock.send(:include, Fog::Compute::Ovirt::Collections)
-            @client = Fog::Compute::Ovirt::V3::Mock.new(options)
+            Fog::Ovirt::Compute::V3::Mock.send(:include, Fog::Ovirt::Compute::Collections)
+            @client = Fog::Ovirt::Compute::V3::Mock.new(options)
           end
         end
 
@@ -100,11 +100,11 @@ module Fog
       class Real
         def initialize(options = {})
           if options[:api_version] == "v4"
-            Fog::Compute::Ovirt::V4::Real.send(:include, Fog::Compute::Ovirt::Collections)
-            @client = Fog::Compute::Ovirt::V4::Real.new(options)
+            Fog::Ovirt::Compute::V4::Real.send(:include, Fog::Ovirt::Compute::Collections)
+            @client = Fog::Ovirt::Compute::V4::Real.new(options)
           else
-            Fog::Compute::Ovirt::V3::Real.send(:include, Fog::Compute::Ovirt::Collections)
-            @client = Fog::Compute::Ovirt::V3::Real.new(options)
+            Fog::Ovirt::Compute::V3::Real.send(:include, Fog::Ovirt::Compute::Collections)
+            @client = Fog::Ovirt::Compute::V3::Real.new(options)
           end
         end
 

data/lib/fog/ovirt/compute/v3.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class V3 < Fog::Service
         requires   :ovirt_username, :ovirt_password
         recognizes :ovirt_url,      :ovirt_server, :ovirt_port, :ovirt_api_path, :ovirt_datacenter,

data/lib/fog/ovirt/compute/v4.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class V4 < Fog::Service
         requires   :ovirt_username, :ovirt_password
         recognizes :ovirt_url,      :ovirt_server, :ovirt_port, :ovirt_api_path, :ovirt_datacenter,
@@ -95,6 +95,7 @@ module Fog
                 :address => value.address,
                 :port => value.port,
                 :secure_port => value.secure_port,
+                :keyboard_layout => value.keyboard_layout,
                 :subject => subject,
                 :monitors => value.monitors
               }
@@ -111,6 +112,7 @@ module Fog
           # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
           def convert_string_to_bool(opts)
+            return opts unless opts.present?
             opts.each do |key, value|
               if value == "true"
                 opts[key] = true

data/lib/fog/ovirt/models/compute/affinity_group.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class AffinityGroup < Fog::Model
         identity :id
 

data/lib/fog/ovirt/models/compute/affinity_groups.rb

@@ -2,10 +2,10 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/affinity_group"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class AffinityGroups < Fog::Collection
-        model Fog::Compute::Ovirt::AffinityGroup
+        model Fog::Ovirt::Compute::AffinityGroup
 
         def all(filters = {})
           load service.list_affinity_groups(filters)

data/lib/fog/ovirt/models/compute/cluster.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Cluster < Fog::Model
         identity :id
 

data/lib/fog/ovirt/models/compute/clusters.rb

@@ -2,10 +2,10 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/cluster"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Clusters < Fog::Collection
-        model Fog::Compute::Ovirt::Cluster
+        model Fog::Ovirt::Compute::Cluster
 
         def all(filters = {})
           load service.list_clusters(filters)

data/lib/fog/ovirt/models/compute/instance_type.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class InstanceType < Fog::Model
         identity :id
 

data/lib/fog/ovirt/models/compute/instance_types.rb

@@ -2,10 +2,10 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/instance_type"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class InstanceTypes < Fog::Collection
-        model Fog::Compute::Ovirt::InstanceType
+        model Fog::Ovirt::Compute::InstanceType
 
         def all(filters = {})
           load service.list_instance_types(filters)

data/lib/fog/ovirt/models/compute/interface.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Interface < Fog::Model
         attr_accessor :raw
         identity :id

data/lib/fog/ovirt/models/compute/interfaces.rb

@@ -2,19 +2,19 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/interface"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Interfaces < Fog::Collection
-        model Fog::Compute::Ovirt::Interface
+        model Fog::Ovirt::Compute::Interface
 
         attr_accessor :vm
 
         # rubocop:disable Metrics/AbcSize
         def all(_filters = {})
           requires :vm
-          if vm.is_a? Fog::Compute::Ovirt::Server
+          if vm.is_a? Fog::Ovirt::Compute::Server
             load service.list_vm_interfaces(vm.id)
-          elsif vm.is_a? Fog::Compute::Ovirt::Template
+          elsif vm.is_a? Fog::Ovirt::Compute::Template
             load service.list_template_interfaces(vm.id)
           else
             raise ::Fog::Ovirt::Errors::OvirtError, "interfaces should have vm or template"

data/lib/fog/ovirt/models/compute/operating_system.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class OperatingSystem < Fog::Model
         attr_accessor :raw
         identity :id

data/lib/fog/ovirt/models/compute/operating_systems.rb

@@ -2,10 +2,10 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/operating_system"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class OperatingSystems < Fog::Collection
-        model Fog::Compute::Ovirt::OperatingSystem
+        model Fog::Ovirt::Compute::OperatingSystem
 
         def all
           load service.list_operating_systems

data/lib/fog/ovirt/models/compute/quota.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Quota < Fog::Model
         identity :id
 

data/lib/fog/ovirt/models/compute/quotas.rb

@@ -2,10 +2,10 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/quota"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Quotas < Fog::Collection
-        model Fog::Compute::Ovirt::Quota
+        model Fog::Ovirt::Compute::Quota
 
         def all(filters = {})
           load service.list_quotas(filters)

data/lib/fog/ovirt/models/compute/server.rb

@@ -1,8 +1,8 @@
 require "fog/compute/models/server"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Server < Fog::Compute::Server
         # This will be the instance uuid which is globally unique across
         # a oVirt deployment.
@@ -53,7 +53,7 @@ module Fog
         end
 
         def interfaces
-          @interfaces ||= id.nil? ? [] : Fog::Compute::Ovirt::Interfaces.new(
+          @interfaces ||= id.nil? ? [] : Fog::Ovirt::Compute::Interfaces.new(
             :service => service,
             :vm => self
           )
@@ -75,7 +75,7 @@ module Fog
         end
 
         def volumes
-          @volumes ||= id.nil? ? [] : Fog::Compute::Ovirt::Volumes.new(
+          @volumes ||= id.nil? ? [] : Fog::Ovirt::Compute::Volumes.new(
             :service => service,
             :vm => self
           )

data/lib/fog/ovirt/models/compute/servers.rb

@@ -2,10 +2,10 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/server"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Servers < Fog::Collection
-        model Fog::Compute::Ovirt::Server
+        model Fog::Ovirt::Compute::Server
 
         def all(filters = {})
           load service.list_virtual_machines(filters)

data/lib/fog/ovirt/models/compute/template.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Template < Fog::Model
         identity :id
 
@@ -23,14 +23,14 @@ module Fog
         attribute :version
 
         def interfaces
-          attributes[:interfaces] ||= id.nil? ? [] : Fog::Compute::Ovirt::Interfaces.new(
+          attributes[:interfaces] ||= id.nil? ? [] : Fog::Ovirt::Compute::Interfaces.new(
             :service => service,
             :vm => self
           )
         end
 
         def volumes
-          attributes[:volumes] ||= id.nil? ? [] : Fog::Compute::Ovirt::Volumes.new(
+          attributes[:volumes] ||= id.nil? ? [] : Fog::Ovirt::Compute::Volumes.new(
             :service => service,
             :vm => self
           )

data/lib/fog/ovirt/models/compute/templates.rb

@@ -2,10 +2,10 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/template"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Templates < Fog::Collection
-        model Fog::Compute::Ovirt::Template
+        model Fog::Ovirt::Compute::Template
 
         def all(filters = {})
           load service.list_templates(filters)

data/lib/fog/ovirt/models/compute/volume.rb

@@ -1,6 +1,6 @@
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Volume < Fog::Model
         attr_accessor :raw
         identity :id
@@ -19,11 +19,11 @@ module Fog
         attribute :wipe_after_delete
 
         def size_gb
-          attributes[:size_gb] ||= attributes[:size].to_i / Fog::Compute::Ovirt::DISK_SIZE_TO_GB if attributes[:size]
+          attributes[:size_gb] ||= attributes[:size].to_i / Fog::Ovirt::Compute::DISK_SIZE_TO_GB if attributes[:size]
         end
 
         def size_gb=(size)
-          attributes[:size] = size.to_i * Fog::Compute::Ovirt::DISK_SIZE_TO_GB if size
+          attributes[:size] = size.to_i * Fog::Ovirt::Compute::DISK_SIZE_TO_GB if size
         end
 
         def to_s

data/lib/fog/ovirt/models/compute/volumes.rb

@@ -2,18 +2,18 @@ require "fog/core/collection"
 require "fog/ovirt/models/compute/volume"
 
 module Fog
-  module Compute
-    class Ovirt
+  module Ovirt
+    class Compute
       class Volumes < Fog::Collection
-        model Fog::Compute::Ovirt::Volume
+        model Fog::Ovirt::Compute::Volume
 
         attr_accessor :vm
 
         # rubocop:disable Metrics/AbcSize
         def all(_filters = {})
-          if vm.is_a? Fog::Compute::Ovirt::Server
+          if vm.is_a? Fog::Ovirt::Compute::Server
             load service.list_vm_volumes(vm.id)
-          elsif vm.is_a? Fog::Compute::Ovirt::Template
+          elsif vm.is_a? Fog::Ovirt::Compute::Template
             load service.list_template_volumes(vm.id)
           else
             load service.list_volumes