fog-ovirt 1.0.1 → 1.0.2

data/lib/fog/ovirt/requests/compute/v4/mock_files/vms.xml

@@ -0,0 +1,170 @@
+<vms>
+  <vm href="/api/vms/5ee86332-7b19-465b-8801-2a12ed0d6c1b" id="5ee86332-7b19-465b-8801-2a12ed0d6c1b">
+    <name>test-vm1</name>
+    <link href="/api/vms/5ee86332-7b19-465b-8801-2a12ed0d6c1b/disks" rel="disks"/>
+    <link href="/api/vms/5ee86332-7b19-465b-8801-2a12ed0d6c1b/nics" rel="nics"/>
+    <link href="/api/vms/5ee86332-7b19-465b-8801-2a12ed0d6c1b/cdroms" rel="cdroms"/>
+    <link href="/api/vms/5ee86332-7b19-465b-8801-2a12ed0d6c1b/snapshots" rel="snapshots"/>
+    <link href="/api/vms/5ee86332-7b19-465b-8801-2a12ed0d6c1b/tags" rel="tags"/>
+    <link href="/api/vms/5ee86332-7b19-465b-8801-2a12ed0d6c1b/permissions" rel="permissions"/>
+    <link href="/api/vms/5ee86332-7b19-465b-8801-2a12ed0d6c1b/statistics" rel="statistics"/>
+    <type>server</type>
+    <status>down</status>
+    <memory>1073741824</memory>
+    <cpu>
+      <topology>
+        <cores>4</cores>
+        <sockets>1</sockets>
+      </topology>
+    </cpu>
+    <os>
+      <type>unassigned</type>
+      <boot>
+        <devices>
+          <device>network</device>
+        </devices>
+      </boot>
+      <kernel/>
+      <initrd/>
+      <cmdline/>
+    </os>
+    <high_availability>
+      <enabled>false</enabled>
+      <priority>1</priority>
+    </high_availability>
+    <display>
+      <type>spice</type>
+      <monitors>1</monitors>
+    </display>
+    <cluster href="/api/clusters/99408929-82cf-4dc7-a532-9d998063fa95" id="99408929-82cf-4dc7-a532-9d998063fa95"/>
+    <template href="/api/templates/00000000-0000-0000-0000-000000000000" id="00000000-0000-0000-0000-000000000000"/>
+    <start_time>2012-02-06T10:47:32.214Z</start_time>
+    <creation_time>2012-01-31T07:45:13.068Z</creation_time>
+    <origin>rhev</origin>
+    <stateless>false</stateless>
+    <placement_policy>
+      <affinity>migratable</affinity>
+    </placement_policy>
+    <memory_policy>
+      <guaranteed>536870912</guaranteed>
+    </memory_policy>
+    <usb>
+      <enabled>true</enabled>
+    </usb>
+  </vm>
+  <vm href="/api/vms/349764bb-eba3-4466-abef-f18f4c40c9f1" id="349764bb-eba3-4466-abef-f18f4c40c9f1">
+    <name>fosdem</name>
+    <link href="/api/vms/349764bb-eba3-4466-abef-f18f4c40c9f1/disks" rel="disks"/>
+    <link href="/api/vms/349764bb-eba3-4466-abef-f18f4c40c9f1/nics" rel="nics"/>
+    <link href="/api/vms/349764bb-eba3-4466-abef-f18f4c40c9f1/cdroms" rel="cdroms"/>
+    <link href="/api/vms/349764bb-eba3-4466-abef-f18f4c40c9f1/snapshots" rel="snapshots"/>
+    <link href="/api/vms/349764bb-eba3-4466-abef-f18f4c40c9f1/tags" rel="tags"/>
+    <link href="/api/vms/349764bb-eba3-4466-abef-f18f4c40c9f1/permissions" rel="permissions"/>
+    <link href="/api/vms/349764bb-eba3-4466-abef-f18f4c40c9f1/statistics" rel="statistics"/>
+    <type>server</type>
+    <status>down</status>
+    <memory>536870912</memory>
+    <cpu>
+      <topology>
+        <cores>1</cores>
+        <sockets>1</sockets>
+      </topology>
+    </cpu>
+    <os>
+      <type>unassigned</type>
+      <boot>
+        <devices>
+          <device>hd</device>
+        </devices>
+      </boot>
+      <kernel/>
+      <initrd/>
+      <cmdline/>
+    </os>
+    <high_availability>
+      <enabled>false</enabled>
+      <priority>1</priority>
+    </high_availability>
+    <display>
+      <type>spice</type>
+      <address>host</address>
+      <port>5902</port>
+      <secure_port>5903</secure_port>
+      <monitors>1</monitors>
+    </display>
+    <host href="/api/hosts/3690fafa-4b4c-11e1-8b7b-5254009970cc" id="3690fafa-4b4c-11e1-8b7b-5254009970cc"/>
+    <cluster href="/api/clusters/99408929-82cf-4dc7-a532-9d998063fa95" id="99408929-82cf-4dc7-a532-9d998063fa95"/>
+    <template href="/api/templates/00000000-0000-0000-0000-000000000000" id="00000000-0000-0000-0000-000000000000"/>
+    <start_time>2012-02-05T11:04:39.217Z</start_time>
+    <creation_time>2012-02-05T10:53:30.484Z</creation_time>
+    <origin>rhev</origin>
+    <stateless>false</stateless>
+    <placement_policy>
+      <affinity>migratable</affinity>
+    </placement_policy>
+    <memory_policy>
+      <guaranteed>536870912</guaranteed>
+    </memory_policy>
+    <usb>
+      <enabled>true</enabled>
+    </usb>
+  </vm>
+  <vm href="/api/vms/52b9406e-cf66-4867-8655-719a094e324c" id="52b9406e-cf66-4867-8655-719a094e324c">
+    <name>vm01</name>
+    <link href="/api/vms/52b9406e-cf66-4867-8655-719a094e324c/disks" rel="disks"/>
+    <link href="/api/vms/52b9406e-cf66-4867-8655-719a094e324c/nics" rel="nics"/>
+    <link href="/api/vms/52b9406e-cf66-4867-8655-719a094e324c/cdroms" rel="cdroms"/>
+    <link href="/api/vms/52b9406e-cf66-4867-8655-719a094e324c/snapshots" rel="snapshots"/>
+    <link href="/api/vms/52b9406e-cf66-4867-8655-719a094e324c/tags" rel="tags"/>
+    <link href="/api/vms/52b9406e-cf66-4867-8655-719a094e324c/permissions" rel="permissions"/>
+    <link href="/api/vms/52b9406e-cf66-4867-8655-719a094e324c/statistics" rel="statistics"/>
+    <type>server</type>
+    <status>down</status>
+    <memory>805306368</memory>
+    <cpu>
+      <topology>
+        <cores>1</cores>
+        <sockets>1</sockets>
+      </topology>
+    </cpu>
+    <os>
+      <type>unassigned</type>
+      <boot>
+        <devices>
+          <device>network</device>
+          <device>hd</device>
+        </devices>
+      </boot>
+      <kernel/>
+      <initrd/>
+      <cmdline/>
+    </os>
+    <high_availability>
+      <enabled>false</enabled>
+      <priority>1</priority>
+    </high_availability>
+    <display>
+      <type>spice</type>
+      <address>host</address>
+      <port>5900</port>
+      <secure_port>5901</secure_port>
+      <monitors>1</monitors>
+    </display>
+    <host href="/api/hosts/3690fafa-4b4c-11e1-8b7b-5254009970cc" id="3690fafa-4b4c-11e1-8b7b-5254009970cc"/>
+    <cluster href="/api/clusters/99408929-82cf-4dc7-a532-9d998063fa95" id="99408929-82cf-4dc7-a532-9d998063fa95"/>
+    <template href="/api/templates/00000000-0000-0000-0000-000000000000" id="00000000-0000-0000-0000-000000000000"/>
+    <start_time>2012-02-05T11:00:33.222Z</start_time>
+    <creation_time>2012-01-31T07:21:10.667Z</creation_time>
+    <origin>rhev</origin>
+    <stateless>false</stateless>
+    <placement_policy>
+      <affinity>migratable</affinity>
+    </placement_policy>
+    <memory_policy>
+      <guaranteed>536870912</guaranteed>
+    </memory_policy>
+    <usb>
+      <enabled>true</enabled>
+    </usb>
+  </vm>
+</vms>

data/lib/fog/ovirt/requests/compute/v4/mock_files/volumes.xml

@@ -0,0 +1,36 @@
+<disks>
+  <disk href="/api/vms/192cdd3f-3281-4e20-b81d-93bdc57ac387/disks/9f68ecfd-218b-4f80-8e7a-e70b2ab054cd" id="9f68ecfd-218b-4f80-8e7a-e70b2ab054cd">
+    <name>Disk 2</name>
+    <link href="/api/vms/192cdd3f-3281-4e20-b81d-93bdc57ac387/disks/9f68ecfd-218b-4f80-8e7a-e70b2ab054cd/statistics" rel="statistics"/>
+    <vm href="/api/vms/192cdd3f-3281-4e20-b81d-93bdc57ac387" id="192cdd3f-3281-4e20-b81d-93bdc57ac387"/>
+    <storage_domains>
+      <storage_domain id="cba62b33-887a-410c-b367-e3d9229a72f7"/>
+    </storage_domains>
+    <provisioned_size>5368709120</provisioned_size>
+    <type>data</type>
+    <status>ok</status>
+    <interface>virtio</interface>
+    <format>raw</format>
+    <sparse>true</sparse>
+    <bootable>false</bootable>
+    <wipe_after_delete>false</wipe_after_delete>
+    <propagate_errors>false</propagate_errors>
+  </disk>
+  <disk href="/api/vms/192cdd3f-3281-4e20-b81d-93bdc57ac387/disks/e373b1a5-6c89-43f1-9a2d-cdf674412349" id="e373b1a5-6c89-43f1-9a2d-cdf674412349">
+    <name>Disk 1</name>
+    <link href="/api/vms/192cdd3f-3281-4e20-b81d-93bdc57ac387/disks/e373b1a5-6c89-43f1-9a2d-cdf674412349/statistics" rel="statistics"/>
+    <vm href="/api/vms/192cdd3f-3281-4e20-b81d-93bdc57ac387" id="192cdd3f-3281-4e20-b81d-93bdc57ac387"/>
+    <storage_domains>
+      <storage_domain id="cba62b33-887a-410c-b367-e3d9229a72f7"/>
+    </storage_domains>
+    <provisioned_size>8589934592</provisioned_size>
+    <type>system</type>
+    <status>ok</status>
+    <interface>virtio</interface>
+    <format>cow</format>
+    <sparse>true</sparse>
+    <bootable>true</bootable>
+    <wipe_after_delete>false</wipe_after_delete>
+    <propagate_errors>false</propagate_errors>
+  </disk>
+</disks>

data/lib/fog/ovirt/requests/compute/v4/storage_domains.rb

@@ -0,0 +1,27 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V4
+        class Real
+          def storage_domains(filter = {})
+            filter = filter.dup
+            role_filter = filter.delete(:role)
+            client.system_service.storage_domains_service.list(filter).collect do |sd|
+              # Filter by role is not supported by the search language. The work around is to list all, then filter.
+              role_filter.nil? || sd.type == role_filter ? sd : nil
+            end.compact
+          end
+        end
+
+        class Mock
+          def storage_domains(_filters = {})
+            xml = read_xml "storage_domains.xml"
+            Nokogiri::XML(xml).xpath("/storage_domains/storage_domain").map do |sd|
+              OvirtSDK4::Reader.read(sd.to_s)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/requests/compute/v4/update_interface.rb

@@ -0,0 +1,35 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V4
+        module Shared
+          def check_arguments(id, options)
+            raise ArgumentError, "instance id is a required parameter" unless id
+            raise ArgumentError, "interface id is a required parameter for update-interface" unless options.key? :id
+          end
+        end
+
+        class Real
+          extend ::Fog::Compute::Ovirt::V4::Shared
+
+          def update_interface(id, options)
+            check_arguments(id, options)
+
+            interface_id = options[:id]
+            nic = client.system_service.vms_service.vm_service(id).nics_service.nic_service(interface_id)
+            nic.update(nic, options)
+          end
+        end
+
+        class Mock
+          extend ::Fog::Compute::Ovirt::V4::Shared
+
+          def update_interface(id, options)
+            check_arguments(id, options)
+            true
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/requests/compute/v4/update_volume.rb

@@ -0,0 +1,36 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V4
+        module Shared
+          def check_arguments(id, options)
+            raise ArgumentError, "instance id is a required parameter" unless id
+            raise ArgumentError, "disk id is a required parameter for update-volume" unless options.key? :id
+          end
+        end
+
+        class Real
+          extend ::Fog::Compute::Ovirt::V4::Shared
+
+          def update_volume(id, options)
+            check_arguments(id, options)
+
+            disk_id = options[:id]
+            disk_attachment = client.system_service.vms_service.vm_service(id).disk_attachments_service.attachment_service(disk_id)
+            disk_attachment.update(disk_attachment, options)
+            true # If we come here, expect success and return true
+          end
+        end
+
+        class Mock
+          extend ::Fog::Compute::Ovirt::V4::Shared
+
+          def update_volume(id, options)
+            check_arguments(id, options)
+            true
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/requests/compute/v4/vm_action.rb

@@ -0,0 +1,26 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V4
+        class Real
+          def vm_action(options = {})
+            raise ArgumentError, "instance id is a required parameter" unless options.key? :id
+            raise ArgumentError, "action is a required parameter" unless options.key? :action
+
+            vm_service = client.system_service.vms_service.vm_service(options[:id])
+            vm_service.public_send(options[:action])
+            vm_service.get.status
+          end
+        end
+
+        class Mock
+          def vm_action(options = {})
+            raise ArgumentError, "id is a required parameter" unless options.key? :id
+            raise ArgumentError, "action is a required parameter" unless options.key? :action
+            true
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/requests/compute/v4/vm_ticket.rb

@@ -0,0 +1,19 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V4
+        class Real
+          def vm_ticket(id, options = {})
+            client.system_service.vms_service.vm_service(id).ticket(options)
+          end
+        end
+
+        class Mock
+          def vm_ticket(_id, _options = {})
+            "Secret"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/version.rb

@@ -1,5 +1,5 @@
 module Fog
   module Ovirt
-    VERSION = "1.0.1".freeze
+    VERSION = "1.0.2".freeze
   end
 end

data/tests/ovirt/requests/compute/v4/client_tests.rb

@@ -0,0 +1,31 @@
+Shindo.tests("Fog::Compute[:ovirt] | client", ["ovirt"]) do
+  before do
+    @client_mock = Object.new
+    def @client_mock.foo
+      raise OVIRT::OvirtException, "Test"
+    end
+
+    @object_under_test = Fog::Compute::Ovirt::ExceptionWrapper.new(@client_mock)
+  end
+
+  tests("Raises the right type of exception")
+    .raises(Fog::Ovirt::Errors::OvirtEngineError) do
+    @object_under_test.foo
+  end
+
+  tests("The exception test is as expected").returns(true) do
+    begin
+      @object_under_test.foo
+    rescue Fog::Ovirt::Errors::OvirtEngineError => e
+      e.message == "Ovirt client returned an error: Test"
+    end
+  end
+
+  tests("The original exception test is as expected").returns(true) do
+    begin
+      @object_under_test.foo
+    rescue Fog::Ovirt::Errors::OvirtEngineError => e
+      e.orig_exception.message == "Test"
+    end
+  end
+end

data/tests/ovirt/requests/compute/v4/create_vm_tests.rb

@@ -0,0 +1,17 @@
+Shindo.tests("Fog::Compute[:ovirt] v4 | vm_create request", "ovirt") do
+  compute = Fog::Compute.new(:provider => :ovirt, :api_version => "v4")
+  name_base = Time.now.to_i
+
+  tests("Create VM") do
+    response = compute.create_vm(:name => "fog-" + name_base.to_s, :cluster_name => "Default")
+    test("should be a kind of OvirtSDK4::Vm") { response.is_a? OvirtSDK4::Vm }
+  end
+
+  tests("Create VM from template (clone)") do
+    response = compute.create_vm(:name => "fog-" + (name_base + 1).to_s, :template_name => "hwp_small", :cluster_name => "Default")
+    test("should be a kind of OvirtSDK4::Vm") { response.is_a? OvirtSDK4::Vm }
+  end
+
+  # TODO: Write a test for situation where creating a VM fails
+  #  mocks never raise exceptions
+end

data/tests/ovirt/requests/compute/v4/destroy_vm_tests.rb

@@ -0,0 +1,16 @@
+Shindo.tests("Fog::Compute[:ovirt] v4 | vm_destroy request", ["ovirt"]) do
+  compute = Fog::Compute.new(:provider => :ovirt, :api_version => "v4")
+  if compute.servers.all(:search => "fog-*").empty?
+    compute.create_vm(:name => "fog-" + Time.now.to_i.to_s, :cluster_name => "Default")
+  end
+  vm_id = compute.servers.all(:search => "fog-*").last.id
+
+  tests("The response should") do
+    response = compute.destroy_vm(:id => vm_id)
+    test("be a success") { response ? true : false }
+  end
+
+  tests("The expected options") do
+    raises(ArgumentError, "raises ArgumentError when id option is missing") { compute.destroy_vm }
+  end
+end

data/tests/ovirt/requests/compute/v4/list_datacenters_tests.rb

@@ -0,0 +1,11 @@
+Shindo.tests("Fog::Compute[:ovirt] v4 | datacenters request", ["ovirt"]) do
+  compute = Fog::Compute.new(:provider => :ovirt, :api_version => "v4")
+
+  tests("When listing all datacenters") do
+    response = compute.datacenters
+    tests("The response data format ...") do
+      test("it should be a kind of Array") { response.is_a? Array }
+      test("be a kind of Hash") { response.first.is_a? Hash }
+    end
+  end
+end

data/tests/ovirt/requests/compute/v4/list_quotas_tests.rb

@@ -0,0 +1,10 @@
+Shindo.tests("Fog::Compute[:ovirt] v4 | quotas request", ["ovirt"]) do
+  compute = Fog::Compute.new(:provider => :ovirt, :api_version => "v4")
+
+  tests("When listing all quotas") do
+    response = compute.quotas
+    tests("The response data format ...") do
+      test("it should be a kind of Array") { response.is_a? Array }
+    end
+  end
+end

data/tests/ovirt/requests/compute/v4/list_storage_domains_tests.rb

@@ -0,0 +1,11 @@
+Shindo.tests("Fog::Compute[:ovirt] v4 | storage_domains request", ["ovirt"]) do
+  compute = Fog::Compute.new(:provider => :ovirt, :api_version => "v4")
+
+  tests("When listing all storage_domains") do
+    response = compute.storage_domains
+    tests("The response data format ...") do
+      test("it should be a kind of Array") { response.is_a? Array }
+      test("be a kind of OvirtSDK4::StorageDomain") { response.first.is_a? OvirtSDK4::StorageDomain }
+    end
+  end
+end

data/tests/ovirt/requests/compute/v4/update_volume_tests.rb

@@ -0,0 +1,17 @@
+Shindo.tests("Fog::Compute[:ovirt] v4 | update_volume request", ["ovirt"]) do
+  compute = Fog::Compute.new(:provider => :ovirt, :api_version => "v4")
+  if compute.servers.all(:search => "fog-*").empty?
+    compute.create_vm(:name => "fog-" + Time.now.to_i.to_s, :cluster_name => "Default")
+  end
+  vm_id = compute.servers.all(:search => "fog-*").last
+
+  tests("The expected options") do
+    raises(ArgumentError, "raises ArgumentError when vm id is missing") { compute.update_volume(nil, :id => 1) }
+    raises(ArgumentError, "raises ArgumentError when disk_id option is missing") { compute.update_volume(1, :any => 1) }
+  end
+
+  tests("The response should") do
+    response = compute.update_volume(vm_id, :id => 1)
+    test("be a success") { response ? true : false }
+  end
+end