fog-ovirt 0.1.3 → 1.0.0

data/lib/fog/ovirt/requests/compute/v3/update_vm.rb

@@ -0,0 +1,20 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V3
+        class Real
+          def update_vm(attrs)
+            client.update_vm(attrs)
+          end
+        end
+
+        class Mock
+          def update_vm(_attrs)
+            xml = read_xml("vm.xml")
+            OVIRT::VM.new(self, Nokogiri::XML(xml).root)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/requests/compute/v3/update_volume.rb

@@ -0,0 +1,37 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V3
+        module Shared
+          def check_arguments(id, options)
+            raise ArgumentError, "instance id is a required parameter" unless id
+            raise ArgumentError, "disk id is a required parameter for update-volume" unless options.key? :id
+          end
+        end
+
+        class Real
+          extend ::Fog::Compute::Ovirt::V3::Shared
+
+          def update_volume(id, options)
+            check_arguments(id, options)
+
+            disk_id = options[:id]
+            options.delete(:id)
+
+            client.update_volume(id, disk_id, options)
+            true # If we come here, expect success and return true
+          end
+        end
+
+        class Mock
+          extend ::Fog::Compute::Ovirt::V3::Shared
+
+          def update_volume(id, options)
+            check_arguments(id, options)
+            true
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/requests/compute/v3/vm_action.rb

@@ -0,0 +1,24 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V3
+        class Real
+          def vm_action(options = {})
+            raise ArgumentError, "instance id is a required parameter" unless options.key? :id
+            raise ArgumentError, "action is a required parameter" unless options.key? :action
+
+            client.vm_action options[:id], options[:action]
+          end
+        end
+
+        class Mock
+          def vm_action(options = {})
+            raise ArgumentError, "id is a required parameter" unless options.key? :id
+            raise ArgumentError, "action is a required parameter" unless options.key? :action
+            true
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/requests/compute/v3/vm_start_with_cloudinit.rb

@@ -0,0 +1,21 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V3
+        class Real
+          def vm_start_with_cloudinit(options = {})
+            raise ArgumentError, "instance id is a required parameter" unless options.key? :id
+            client.vm_start_with_cloudinit(options[:id], options[:user_data])
+          end
+        end
+
+        class Mock
+          def vm_start_with_cloudinit(options = {})
+            raise ArgumentError, "instance id is a required parameter" unless options.key? :id
+            true
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/requests/compute/v3/vm_ticket.rb

@@ -0,0 +1,19 @@
+module Fog
+  module Compute
+    class Ovirt
+      class V3
+        class Real
+          def vm_ticket(id, options = {})
+            client.set_ticket(id, options)
+          end
+        end
+
+        class Mock
+          def vm_ticket(_id, _options = {})
+            "Secret"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/fog/ovirt/version.rb

@@ -1,5 +1,5 @@
 module Fog
   module Ovirt
-    VERSION = '0.1.3'
+    VERSION = "1.0.0".freeze
   end
 end

data/tests/helper.rb

@@ -1 +1 @@
-require File.expand_path('../../lib/fog/ovirt', __FILE__)
+require File.expand_path("../lib/fog/ovirt", __dir__)

data/tests/helpers/mock_helper.rb

@@ -2,15 +2,13 @@
 #
 # FOG_MOCK=true fog
 
-if ENV["FOG_MOCK"] == "true"
-  Fog.mock!
-end
+Fog.mock! if ENV["FOG_MOCK"] == "true"
 
 # if in mocked mode, fill in some fake credentials for us
 if Fog.mock?
   Fog.credentials = {
-      :ovirt_url                        => 'http://ovirt:8080/api',
-      :ovirt_username                   => 'admin@internal',
-      :ovirt_password                   => '123123'
+    :ovirt_url => "http://ovirt:8080/api",
+    :ovirt_username                   => "admin@internal",
+    :ovirt_password                   => "123123"
   }.merge(Fog.credentials)
 end

data/tests/helpers/succeeds_helper.rb

@@ -1,7 +1,7 @@
 module Shindo
   class Tests
     def succeeds
-      test('succeeds') do
+      test("succeeds") do
         !!instance_eval(&Proc.new)
       end
     end

data/tests/ovirt/compute_tests.rb

@@ -1,24 +1,23 @@
-Shindo.tests('Fog::Compute[:ovirt]', ['ovirt']) do
-
+Shindo.tests("Fog::Compute[:ovirt]", ["ovirt"]) do
   compute = Fog::Compute[:ovirt]
 
   tests("Compute attributes") do
-    %w{ ovirt_attrs }.each do |attr|
+    %w[ovirt_attrs].each do |attr|
       test("it should respond to #{attr}") { compute.respond_to? attr }
     end
   end
 
   tests("Compute collections") do
-    %w{ servers templates clusters interfaces operating_systems }.each do |collection|
+    %w[servers templates clusters interfaces operating_systems].each do |collection|
       test("it should respond to #{collection}") { compute.respond_to? collection }
     end
   end
 
   tests("Compute requests") do
-    %w{ add_interface create_vm datacenters destroy_interface destroy_vm get_cluster get_template
+    %w[ add_interface create_vm datacenters destroy_interface destroy_vm get_cluster get_template
         get_virtual_machine list_clusters list_networks list_template_interfaces list_templates
         list_virtual_machines list_vm_interfaces storage_domains update_interface update_vm vm_action
-        api_version update_volume}.each do |collection|
+        api_version update_volume].each do |collection|
       test("it should respond to #{collection}") { compute.respond_to? collection }
     end
   end

data/tests/ovirt/models/compute/cluster_tests.rb

@@ -1,31 +1,28 @@
-Shindo.tests('Fog::Compute[:ovirt] | cluster model', ['ovirt']) do
-
+Shindo.tests("Fog::Compute[:ovirt] | cluster model", ["ovirt"]) do
   clusters = Fog::Compute[:ovirt].clusters
   cluster = clusters.last
 
-  tests('The cluster model should') do
-    tests('have the action') do
-      test('reload') { cluster.respond_to? 'reload' }
-      %w{ networks }.each do |action|
+  tests("The cluster model should") do
+    tests("have the action") do
+      test("reload") { cluster.respond_to? "reload" }
+      %w[networks].each do |action|
         test(action) { cluster.respond_to? action }
       end
     end
-    tests('have attributes') do
+    tests("have attributes") do
       model_attribute_hash = cluster.attributes
-      attributes = [ :id,
-        :name]
+      attributes = %i[id name]
       tests("The cluster model should respond to") do
         attributes.each do |attribute|
-          test("#{attribute}") { cluster.respond_to? attribute }
+          test(attribute.to_s) { cluster.respond_to? attribute }
         end
       end
       tests("The attributes hash should have key") do
         attributes.each do |attribute|
-          test("#{attribute}") { model_attribute_hash.key? attribute }
+          test(attribute.to_s) { model_attribute_hash.key? attribute }
         end
       end
     end
-    test('be a kind of Fog::Compute::Ovirt::Cluster') { cluster.kind_of? Fog::Compute::Ovirt::Cluster }
+    test("be a kind of Fog::Compute::Ovirt::Cluster") { cluster.is_a? Fog::Compute::Ovirt::Cluster }
   end
-
 end

data/tests/ovirt/models/compute/clusters_tests.rb

@@ -1,9 +1,7 @@
-Shindo.tests('Fog::Compute[:ovirt] | clusters collection', ['ovirt']) do
-
+Shindo.tests("Fog::Compute[:ovirt] | clusters collection", ["ovirt"]) do
   clusters = Fog::Compute[:ovirt].clusters
 
-  tests('The clusters collection') do
-    test('should be a kind of Fog::Compute::Ovirt::Clusters') { clusters.kind_of? Fog::Compute::Ovirt::Clusters }
+  tests("The clusters collection") do
+    test("should be a kind of Fog::Compute::Ovirt::Clusters") { clusters.is_a? Fog::Compute::Ovirt::Clusters }
   end
-
 end

data/tests/ovirt/models/compute/interface_tests.rb

@@ -1,27 +1,25 @@
-Shindo.tests('Fog::Compute[:ovirt] | interface model', ['ovirt']) do
-
+Shindo.tests("Fog::Compute[:ovirt] | interface model", ["ovirt"]) do
   interfaces = Fog::Compute[:ovirt].servers.last.interfaces
   interface = interfaces.last
 
-  tests('The interface model should') do
-    tests('have the action') do
-      test('reload') { interface.respond_to? 'reload' }
+  tests("The interface model should") do
+    tests("have the action") do
+      test("reload") { interface.respond_to? "reload" }
     end
-    tests('have attributes') do
+    tests("have attributes") do
       model_attribute_hash = interface.attributes
-      attributes = [ :id, :name, :network]
+      attributes = %i[id name network]
       tests("The interface model should respond to") do
         attributes.each do |attribute|
-          test("#{attribute}") { interface.respond_to? attribute }
+          test(attribute.to_s) { interface.respond_to? attribute }
         end
       end
       tests("The attributes hash should have key") do
         attributes.each do |attribute|
-          test("#{attribute}") { model_attribute_hash.key? attribute }
+          test(attribute.to_s) { model_attribute_hash.key? attribute }
         end
       end
     end
-    test('be a kind of Fog::Compute::Ovirt::Interface') { interface.kind_of? Fog::Compute::Ovirt::Interface }
+    test("be a kind of Fog::Compute::Ovirt::Interface") { interface.is_a? Fog::Compute::Ovirt::Interface }
   end
-
 end

data/tests/ovirt/models/compute/interfaces_tests.rb

@@ -1,9 +1,7 @@
-Shindo.tests('Fog::Compute[:ovirt] | interfaces collection', ['ovirt']) do
-
+Shindo.tests("Fog::Compute[:ovirt] | interfaces collection", ["ovirt"]) do
   interfaces = Fog::Compute[:ovirt].interfaces
 
-  tests('The interfaces collection') do
-    test('should be a kind of Fog::Compute::Ovirt::Interfaces') { interfaces.kind_of? Fog::Compute::Ovirt::Interfaces }
+  tests("The interfaces collection") do
+    test("should be a kind of Fog::Compute::Ovirt::Interfaces") { interfaces.is_a? Fog::Compute::Ovirt::Interfaces }
   end
-
 end

data/tests/ovirt/models/compute/operating_system_tests.rb

@@ -1,29 +1,23 @@
-Shindo.tests('Fog::Compute[:ovirt] | operating_system model', ['ovirt']) do
-
+Shindo.tests("Fog::Compute[:ovirt] | operating_system model", ["ovirt"]) do
   operating_systems = Fog::Compute[:ovirt].operating_systems
   operating_system = operating_systems.last
 
-  tests('The operating_system model should') do
-    tests('have attributes') do
+  tests("The operating_system model should") do
+    tests("have attributes") do
       model_attribute_hash = operating_system.attributes
-      attributes = [ :id,
-                     :name,
-                     :href,
-                     :description
-                    ]
+      attributes = %i[id name href description]
 
       tests("The operating_system model should respond to") do
         attributes.each do |attribute|
-          test("#{attribute}") { operating_system.respond_to? attribute }
+          test(attribute.to_s) { operating_system.respond_to? attribute }
         end
       end
       tests("The attributes hash should have key") do
         attributes.each do |attribute|
-          test("#{attribute}") { model_attribute_hash.key? attribute }
+          test(attribute.to_s) { model_attribute_hash.key? attribute }
         end
       end
     end
-    test('be a kind of Fog::Compute::Ovirt::OperatingSystem') { operating_system.kind_of? Fog::Compute::Ovirt::OperatingSystem }
+    test("be a kind of Fog::Compute::Ovirt::OperatingSystem") { operating_system.is_a? Fog::Compute::Ovirt::OperatingSystem }
   end
-
 end

data/tests/ovirt/models/compute/operating_systems_tests.rb

@@ -1,10 +1,8 @@
-Shindo.tests('Fog::Compute[:ovirt] | operating_systems collection', ['ovirt']) do
-
+Shindo.tests("Fog::Compute[:ovirt] | operating_systems collection", ["ovirt"]) do
   operating_systems = Fog::Compute[:ovirt].operating_systems
 
-  tests('The servers collection') do
-    test('should not be empty') { not operating_systems.empty? }
-    test('should be a kind of Fog::Compute::Ovirt::OperatingSystems') { operating_systems.kind_of? Fog::Compute::Ovirt::OperatingSystems }
+  tests("The servers collection") do
+    test("should not be empty") { !operating_systems.empty? }
+    test("should be a kind of Fog::Compute::Ovirt::OperatingSystems") { operating_systems.is_a? Fog::Compute::Ovirt::OperatingSystems }
   end
-
 end

data/tests/ovirt/models/compute/server_tests.rb

@@ -1,51 +1,48 @@
-Shindo.tests('Fog::Compute[:ovirt] | server model', ['ovirt']) do
-
+# rubocop:disable Metrics/BlockLength
+Shindo.tests("Fog::Compute[:ovirt] | server model", ["ovirt"]) do
   servers = Fog::Compute[:ovirt].servers
   server = servers.last
 
-  tests('The server model should') do
-    tests('have the action') do
-      test('reload') { server.respond_to? 'reload' }
-      %w{ start stop destroy reboot suspend }.each do |action|
+  tests("The server model should") do
+    tests("have the action") do
+      test("reload") { server.respond_to? "reload" }
+      %w[start stop destroy reboot suspend].each do |action|
         test(action) { server.respond_to? action }
       end
-      %w{ start reboot suspend stop }.each do |action|
-        test("#{action} returns successfully") {
-          begin
-            server.send(action.to_sym) ? true : false
-          rescue OVIRT::OvirtException
-            #ovirt exceptions are acceptable for the above actions.
-            true
-          end
-        }
+      %w[start reboot suspend stop].each do |action|
+        test("#{action} returns successfully") do
+          server.send(action.to_sym) ? true : false
+        end
       end
     end
-    tests('have attributes') do
+    tests("have attributes") do
       model_attribute_hash = server.attributes
-      attributes = [ :id,
-        :name,
-        :description,
-        :profile,
-        :display,
-        :creation_time,
-        :os,
-        :status,
-        :cores,
-        :memory,
-        :cluster,
-        :template]
+      attributes = %i[
+        id
+        name
+        description
+        profile
+        display
+        creation_time
+        os
+        status
+        cores
+        memory
+        cluster
+        template
+      ]
       tests("The server model should respond to") do
         attributes.each do |attribute|
-          test("#{attribute}") { server.respond_to? attribute }
+          test(attribute.to_s) { server.respond_to? attribute }
         end
       end
       tests("The attributes hash should have key") do
         attributes.each do |attribute|
-          test("#{attribute}") { model_attribute_hash.key? attribute }
+          test(attribute.to_s) { model_attribute_hash.key? attribute }
         end
       end
     end
-    test('be a kind of Fog::Compute::Ovirt::Server') { server.kind_of? Fog::Compute::Ovirt::Server }
+    test("be a kind of Fog::Compute::Ovirt::Server") { server.is_a? Fog::Compute::Ovirt::Server }
   end
-
 end
+# rubocop:enable Metrics/BlockLength