fog-kubevirt 1.2.4 → 1.2.5

data/spec/integration/pvcs_spec.rb

@@ -0,0 +1,57 @@
+require_relative './shared_context'
+
+describe Fog::Kubevirt::Compute do
+  before :all do
+    conn = KubevirtConnection.new()
+    @client = conn.client.pvcs
+  end
+
+  it 'CRD pvc' do
+    pvc = {
+      :name => 'test-pvc',
+      :namespace => 'default',
+      :storage_class => '',
+      :access_modes => ['ReadWriteOnce'],
+      :requests => { storage: "1Gi" }
+    }
+    @client.create(pvc)
+
+    created = @client.get(pvc[:name])
+    assert_equal(created.name, pvc[:name])
+    assert_equal(created.requests, pvc[:requests])
+
+    @client.delete(pvc[:name])
+
+    begin
+      @client.get('no_pvc')
+      fail "pvc should not exist"
+    rescue ::Fog::Kubevirt::Errors::ClientError
+      # expected
+    end
+  end
+
+  it 'deletes non-existing pvc' do
+    begin
+      @client.delete('not_there')
+    rescue ::Fog::Kubevirt::Errors::ClientError
+      # it ignores non-existing object
+      fail "pvc should not exist"
+    end
+  end
+
+  it 'fails with wrong size format' do
+    pvc = {
+      :name => 'test-pvc',
+      :namespace => 'default',
+      :storage_class => '',
+      :access_modes => ['ReadWriteOnce'],
+      :requests => { storage: "X" }
+    }
+    begin
+      @client.create(pvc)
+      fail "requested size is not correct"
+    rescue ::Fog::Kubevirt::Errors::ValidationError
+      # expected
+    end
+  end
+end

data/spec/integration/shared_context.rb

@@ -0,0 +1,22 @@
+require 'minitest/autorun'
+require 'fog/core'
+require 'fog/kubevirt'
+
+class KubevirtConnection
+
+  def initialize(options={})
+    @host = ENV.key?('KUBE_HOST') ? ENV['KUBE_HOST'] : options[:host]
+    @port = ENV.key?('KUBE_PORT') ? ENV['KUBE_PORT'] : options[:port]
+    @token = ENV.key?('KUBE_TOKEN') ? ENV['KUBE_TOKEN'] : options[:token]
+  end
+
+  def client
+    if !ENV.key?('KUBECONFIG') 
+      return Fog::Kubevirt::Compute.new(:kubevirt_hostname => @host,
+        :kubevirt_port     => @port,
+        :kubevirt_token    => @token)
+    else
+      return Fog::Kubevirt::Compute.new(:kubevirt_token => nil)
+    end
+  end
+end

data/spec/{compute_v1alpha2_spec.rb → unit/compute_v1alpha2_spec.rb}

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require_relative './spec_helper'
 require_relative './shared_context'
 
 require 'fog/kubevirt/compute/compute'

data/spec/{create_vm_spec.rb → unit/create_vm_spec.rb}

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require_relative './spec_helper'
 require_relative './shared_context'
 
 require 'fog/kubevirt'

data/spec/{network_attachment_definition_v1alpha2_spec.rb → unit/network_attachment_definition_v1alpha2_spec.rb}

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require_relative './spec_helper'
 require_relative './shared_context'
 
 require 'fog/kubevirt/compute/compute'

data/spec/{persistent_volumes_v1alpha2_spec.rb → unit/persistent_volumes_v1alpha2_spec.rb}

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require_relative './spec_helper'
  require_relative './shared_context'
 
   require 'fog/kubevirt'

data/spec/{pvcs_v1alpha2_spec.rb → unit/pvcs_v1alpha2_spec.rb}

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require_relative './spec_helper'
  require_relative './shared_context'
 
   require 'fog/kubevirt/compute/compute'

data/spec/unit/server_v1alpha3_spec.rb

@@ -0,0 +1,34 @@
+require_relative './spec_helper'
+require_relative './shared_context'
+
+describe Fog::Compute do
+  before :all do
+    vcr = KubevirtVCR.new(
+      vcr_directory: 'spec/fixtures/kubevirt/server',
+      :service_class => Fog::Kubevirt::Compute
+    )
+    @service = vcr.service
+  end
+
+  it 'fetches, starts, stops and destroy server' do
+    VCR.use_cassette('server_ops') do
+      server = @service.servers.get('vm-cirros')
+      assert(server)
+
+      server.stop
+      server = @service.servers.get('vm-cirros')
+      assert(server)
+
+      server.start
+      # no validation - this operation takes too long
+
+      server.destroy
+      begin
+        server = @service.servers.get('vm-cirros')
+        fail "server should not exist"
+      rescue Fog::Kubevirt::Errors::ClientError
+        # expected
+      end 
+    end
+  end
+end

data/spec/{storage_classes_v1_spec.rb → unit/storage_classes_v1_spec.rb}

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require_relative './spec_helper'
  require_relative './shared_context'
 
   require 'fog/kubevirt'

data/spec/unit/unit_converter_spec.rb

@@ -0,0 +1,126 @@
+require_relative './spec_helper'
+
+describe Fog::Kubevirt::Compute::Shared::UnitConverter do
+
+  described_class = Fog::Kubevirt::Compute::Shared::UnitConverter
+
+  describe '.convert' do
+    it 'converts correctly units that correspond to powers of 10' do
+      assert_equal(described_class.convert('1KB', :b).to_i, 10**3)
+      assert_equal(described_class.convert('1MB', :b).to_i, 10**6)
+      assert_equal(described_class.convert('1GB', :b).to_i, 10**9)
+      assert_equal(described_class.convert('1TB', :b).to_i, 10**12)
+      assert_equal(described_class.convert('1PB', :b).to_i, 10**15)
+      assert_equal(described_class.convert('1EB', :b).to_i, 10**18)
+      assert_equal(described_class.convert('1ZB', :b).to_i, 10**21)
+      assert_equal(described_class.convert('1YB', :b).to_i, 10**24)
+    end
+
+    it 'converts correctly units that correspond to powers of 2' do
+      assert_equal(described_class.convert('1KiB', :b).to_i, 2**10)
+      assert_equal(described_class.convert('1MiB', :b).to_i, 2**20)
+      assert_equal(described_class.convert('1GiB', :b).to_i, 2**30)
+      assert_equal(described_class.convert('1TiB', :b).to_i, 2**40)
+      assert_equal(described_class.convert('1PiB', :b).to_i, 2**50)
+      assert_equal(described_class.convert('1EiB', :b).to_i, 2**60)
+      assert_equal(described_class.convert('1ZiB', :b).to_i, 2**70)
+      assert_equal(described_class.convert('1YiB', :b).to_i, 2**80)
+    end
+  
+    it 'converts correclty powers of 10 to powers of 2' do
+      assert_equal(described_class.convert('1000KB', :kib).to_i, 976)
+      assert_equal(described_class.convert('1000MB', :mib).to_i, 953)
+      assert_equal(described_class.convert('1000GB', :gib).to_i, 931)
+      assert_equal(described_class.convert('1000TB', :tib).to_i, 909)
+      assert_equal(described_class.convert('1000PB', :pib).to_i, 888)
+      assert_equal(described_class.convert('1000EB', :eib).to_i, 867)
+      assert_equal(described_class.convert('1000ZB', :zib).to_i, 847)
+      assert_equal(described_class.convert('1000YB', :yib).to_i, 827)
+    end
+  
+    it 'converts correclty powers of 2 to powers of 10' do
+      assert_equal(described_class.convert('1000KiB', :kb).to_i, 1024)
+      assert_equal(described_class.convert('1000MiB', :mb).to_i, 1048)
+      assert_equal(described_class.convert('1000GiB', :gb).to_i, 1073)
+      assert_equal(described_class.convert('1000TiB', :tb).to_i, 1099)
+      assert_equal(described_class.convert('1000PiB', :pb).to_i, 1125)
+      assert_equal(described_class.convert('1000EiB', :eb).to_i, 1152)
+      assert_equal(described_class.convert('1000ZiB', :zb).to_i, 1180)
+      assert_equal(described_class.convert('1000YiB', :yb).to_i, 1208)
+    end
+  
+    it 'converts to smaller powers of 10 correclty' do
+      assert_equal(described_class.convert('1KB', 'B').to_i, 10**3)
+      assert_equal(described_class.convert('1MB', 'KB').to_i, 10**3)
+      assert_equal(described_class.convert('1GB', 'MB').to_i, 10**3)
+      assert_equal(described_class.convert('1TB', 'GB').to_i, 10**3)
+      assert_equal(described_class.convert('1PB', 'TB').to_i, 10**3)
+      assert_equal(described_class.convert('1EB', 'PB').to_i, 10**3)
+      assert_equal(described_class.convert('1ZB', 'EB').to_i, 10**3)
+      assert_equal(described_class.convert('1YB', 'ZB').to_i, 10**3)
+    end
+  
+    it 'converts to smaller powers of 2 correclty' do
+      assert_equal(described_class.convert('1KiB', 'B').to_i, 2**10)
+      assert_equal(described_class.convert('1MiB', 'KiB').to_i, 2**10)
+      assert_equal(described_class.convert('1GiB', 'MiB').to_i, 2**10)
+      assert_equal(described_class.convert('1TiB', 'GiB').to_i, 2**10)
+      assert_equal(described_class.convert('1PiB', 'TiB').to_i, 2**10)
+      assert_equal(described_class.convert('1EiB', 'PiB').to_i, 2**10)
+      assert_equal(described_class.convert('1ZiB', 'EiB').to_i, 2**10)
+      assert_equal(described_class.convert('1YiB', 'ZiB').to_i, 2**10)
+    end
+  
+    it 'converts to larger powers of 10 correclty' do
+      assert_equal(described_class.convert('1000b', 'kb').to_i, 1)
+      assert_equal(described_class.convert('1000kb', 'mb').to_i, 1)
+      assert_equal(described_class.convert('1000mb', 'gb').to_i, 1)
+      assert_equal(described_class.convert('1000gb', 'tb').to_i, 1)
+      assert_equal(described_class.convert('1000tb', 'pb').to_i, 1)
+      assert_equal(described_class.convert('1000pb', 'eb').to_i, 1)
+      assert_equal(described_class.convert('1000eb', 'zb').to_i, 1)
+      assert_equal(described_class.convert('1000zb', 'yb').to_i, 1)
+    end
+  
+    it 'converts to larger powers of 2 correclty' do
+      assert_equal(described_class.convert('1024b', 'ki').to_i, 1)
+      assert_equal(described_class.convert('1024kib', 'mi').to_i, 1)
+      assert_equal(described_class.convert('1024mib', 'gi').to_i, 1)
+      assert_equal(described_class.convert('1024gib', 'ti').to_i, 1)
+      assert_equal(described_class.convert('1024tib', 'pi').to_i, 1)
+      assert_equal(described_class.convert('1024pib', 'ei').to_i, 1)
+      assert_equal(described_class.convert('1024eib', 'zi').to_i, 1)
+      assert_equal(described_class.convert('1024zib', 'yi').to_i, 1)
+    end
+  
+    it 'accepts spaces between the numeric value and the unit suffix' do
+      assert_equal(described_class.convert('2 KiB', :b).to_i, 2048)
+    end
+  
+    it 'accepts spaces before the numeric value' do
+      assert_equal(described_class.convert(' 2KiB', :b).to_i, 2048)
+    end
+  
+    it 'accepts spaces after the unit suffix' do
+      assert_equal(described_class.convert('2KiB ', :b).to_i, 2048)
+    end
+  
+    it 'returns nil if no value is given' do
+      assert_nil(described_class.convert(nil, :b))
+    end
+  end
+
+  describe '.validate' do
+    it 'fails to validate' do
+      assert_raises ::Fog::Kubevirt::Errors::ValidationError do
+        described_class.validate('X')
+      end
+    end
+
+    it 'validates correctly' do
+      data = described_class.validate('2Gi')
+      assert_equal(data[:value], '2')
+      assert_equal(data[:suffix], 'Gi')
+    end
+  end
+end

data/spec/{vm_parse_spec.rb → unit/vm_parse_spec.rb}

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require_relative './spec_helper'
 
 describe Fog::Kubevirt::Compute do
   it 'parses vm' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fog-kubevirt
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.5
 platform: ruby
 authors:
 - Piotr Kliczewski
@@ -14,36 +14,36 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-18 00:00:00.000000000 Z
+date: 2019-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.11'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -62,44 +62,44 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.67'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.67'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: fog-core
   requirement: !ruby/object:Gem::Requirement
@@ -120,14 +120,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.2
+        version: 4.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.2
+        version: 4.3.0
 description: This library can be used as a module for `fog`.
 email:
 - piotr.kliczewski@gmail.com
@@ -210,24 +210,29 @@ files:
 - lib/fog/kubevirt/compute/requests/list_volumes.rb
 - lib/fog/kubevirt/compute/requests/update_vm.rb
 - lib/fog/kubevirt/version.rb
-- spec/compute_v1alpha2_spec.rb
-- spec/create_vm_spec.rb
 - spec/fixtures/kubevirt/networkattachmentdefinition/networkattachmentdefinitions_crud.yml
 - spec/fixtures/kubevirt/persistentvolume/persistent_volumes_crud.yml
 - spec/fixtures/kubevirt/pvc/pvcs_crud.yml
 - spec/fixtures/kubevirt/pvc/pvcs_no_selector_crud.yml
+- spec/fixtures/kubevirt/server/server_ops.yml
 - spec/fixtures/kubevirt/service/services_crud.yml
 - spec/fixtures/kubevirt/storageclass/storageclasses_crud.yml
 - spec/fixtures/kubevirt/vm/vm_create_multi.yml
 - spec/fixtures/kubevirt/vm/vm_create_single.yml
-- spec/network_attachment_definition_v1alpha2_spec.rb
-- spec/persistent_volumes_v1alpha2_spec.rb
-- spec/pvcs_v1alpha2_spec.rb
-- spec/shared_context.rb
-- spec/spec_helper.rb
-- spec/storage_classes_v1_spec.rb
-- spec/vm_parse_spec.rb
-homepage: https://github.com/pkliczewski/fog-kubevirt
+- spec/integration/pvcs_spec.rb
+- spec/integration/shared_context.rb
+- spec/unit/compute_v1alpha2_spec.rb
+- spec/unit/create_vm_spec.rb
+- spec/unit/network_attachment_definition_v1alpha2_spec.rb
+- spec/unit/persistent_volumes_v1alpha2_spec.rb
+- spec/unit/pvcs_v1alpha2_spec.rb
+- spec/unit/server_v1alpha3_spec.rb
+- spec/unit/shared_context.rb
+- spec/unit/spec_helper.rb
+- spec/unit/storage_classes_v1_spec.rb
+- spec/unit/unit_converter_spec.rb
+- spec/unit/vm_parse_spec.rb
+homepage: https://github.com/fog/fog-kubevirt
 licenses:
 - Apache-2.0
 metadata: {}
@@ -252,20 +257,25 @@ signing_key:
 specification_version: 4
 summary: Module for the 'fog' gem to support Kubevirt.
 test_files:
-- spec/compute_v1alpha2_spec.rb
-- spec/create_vm_spec.rb
 - spec/fixtures/kubevirt/networkattachmentdefinition/networkattachmentdefinitions_crud.yml
 - spec/fixtures/kubevirt/persistentvolume/persistent_volumes_crud.yml
 - spec/fixtures/kubevirt/pvc/pvcs_crud.yml
 - spec/fixtures/kubevirt/pvc/pvcs_no_selector_crud.yml
+- spec/fixtures/kubevirt/server/server_ops.yml
 - spec/fixtures/kubevirt/service/services_crud.yml
 - spec/fixtures/kubevirt/storageclass/storageclasses_crud.yml
 - spec/fixtures/kubevirt/vm/vm_create_multi.yml
 - spec/fixtures/kubevirt/vm/vm_create_single.yml
-- spec/network_attachment_definition_v1alpha2_spec.rb
-- spec/persistent_volumes_v1alpha2_spec.rb
-- spec/pvcs_v1alpha2_spec.rb
-- spec/shared_context.rb
-- spec/spec_helper.rb
-- spec/storage_classes_v1_spec.rb
-- spec/vm_parse_spec.rb
+- spec/integration/pvcs_spec.rb
+- spec/integration/shared_context.rb
+- spec/unit/compute_v1alpha2_spec.rb
+- spec/unit/create_vm_spec.rb
+- spec/unit/network_attachment_definition_v1alpha2_spec.rb
+- spec/unit/persistent_volumes_v1alpha2_spec.rb
+- spec/unit/pvcs_v1alpha2_spec.rb
+- spec/unit/server_v1alpha3_spec.rb
+- spec/unit/shared_context.rb
+- spec/unit/spec_helper.rb
+- spec/unit/storage_classes_v1_spec.rb
+- spec/unit/unit_converter_spec.rb
+- spec/unit/vm_parse_spec.rb