fog-brightbox 1.4.0 → 1.5.0.rc1

data/lib/fog/brightbox/requests/compute/update_volume.rb

@@ -0,0 +1,26 @@
+module Fog
+  module Brightbox
+    class Compute
+      class Real
+        # Update some volume attributes.
+        #
+        # @param [String] identifier Unique reference to identify the resource
+        # @param [Hash] options
+        # @option options [Boolean] :nested passed through with the API request. When true nested resources are expanded.
+        # @option options [Boolean] :delete_with_server Set +true+ the volume will be removed if attached to a server that is deleted
+        # @option options [String] :description
+        # @option options [String] :name
+        # @option options [String] :serial
+        #
+        # @return [Hash] if successful Hash version of JSON object
+        # @return [NilClass] if no options were passed
+        #
+        def update_volume(identifier, options)
+          return nil if identifier.nil? || identifier == ""
+          return nil if options.empty? || options.nil?
+          wrapped_request("put", "/1.0/volumes/#{identifier}", [202], options)
+        end
+      end
+    end
+  end
+end

data/lib/fog/brightbox/version.rb

@@ -1,5 +1,5 @@
 module Fog
   module Brightbox
-    VERSION = "1.4.0"
+    VERSION = "1.5.0.rc1"
   end
 end

data/spec/fog/compute/brightbox/image_selector_spec.rb

@@ -0,0 +1,34 @@
+require "spec_helper"
+
+describe Fog::Brightbox::Compute::ImageSelector do
+  subject { Fog::Brightbox::Compute::ImageSelector }
+
+  describe "#latest_ubuntu" do
+    it do
+      image_list = [
+        {"id"=>"img-kppxh", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-kppxh", "name"=>"ubuntu-xenial-16.04-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:server:16.04:amd64/20211001/disk1.img, Release: release", "source"=>"tmp54tt71pg", "arch"=>"x86_64", "created_at"=>"2021-10-02T06:57:09.000Z", "owner"=>"acc-kg71m", "official"=>true, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>394, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-bugr2", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-bugr2", "name"=>"ubuntu-xenial-16.04-i386-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:server:16.04:i386/20211001/disk1.img, Release: release", "source"=>"tmplj717rjf", "arch"=>"i686", "created_at"=>"2021-10-02T06:58:18.000Z", "owner"=>"acc-kg71m", "official"=>true, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>385, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-6vfpp", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-6vfpp", "name"=>"ubuntu-xenial-daily-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:daily:download/com.ubuntu.cloud.daily:server:16.04:amd64/20211001/disk1.img, Release: daily", "source"=>"tmp3aj5trto", "arch"=>"x86_64", "created_at"=>"2021-10-02T06:58:57.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>394, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-x08p6", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-x08p6", "name"=>"ubuntu-bionic-18.04-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:server:18.04:amd64/20220523/disk1.img, Release: release", "source"=>"tmpcyevpow5", "arch"=>"x86_64", "created_at"=>"2022-05-24T06:57:15.000Z", "owner"=>"acc-kg71m", "official"=>true, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>480, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-jrbnn", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-jrbnn", "name"=>"ubuntu-bionic-18.04-i386-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:server:18.04:i386/20220523/disk1.img, Release: release", "source"=>"tmpw502837r", "arch"=>"i686", "created_at"=>"2022-05-24T06:57:44.000Z", "owner"=>"acc-kg71m", "official"=>true, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>450, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-1cbbg", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-1cbbg", "name"=>"ubuntu-focal-daily-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:daily:download/com.ubuntu.cloud.daily:server:20.04:amd64/20220530/disk1.img, Release: daily", "source"=>"tmpa2iezlb7", "arch"=>"x86_64", "created_at"=>"2022-06-01T07:06:08.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>685, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-cjc8m", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-cjc8m", "name"=>"ubuntu-focal-20.04-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:server:20.04:amd64/20220530/disk1.img, Release: release", "source"=>"tmppadp2ka9", "arch"=>"x86_64", "created_at"=>"2022-06-02T06:57:21.000Z", "owner"=>"acc-kg71m", "official"=>true, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>685, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-yes2q", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-yes2q", "name"=>"ubuntu-bionic-daily-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:daily:download/com.ubuntu.cloud.daily:server:18.04:amd64/20220530/disk1.img, Release: daily", "source"=>"tmp7b0ty_cz", "arch"=>"x86_64", "created_at"=>"2022-06-02T06:59:06.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>480, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-44xv2", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-44xv2", "name"=>"ubuntu-bionic-daily-i386-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:daily:download/com.ubuntu.cloud.daily:server:18.04:i386/20220530/disk1.img, Release: daily", "source"=>"tmpcsk_ejc9", "arch"=>"i686", "created_at"=>"2022-06-02T06:59:33.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>450, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-axy3r", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-axy3r", "name"=>"ubuntu-impish-daily-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:daily:download/com.ubuntu.cloud.daily:server:21.10:amd64/20220604/disk1.img, Release: daily", "source"=>"tmpq4xcgkhd", "arch"=>"x86_64", "created_at"=>"2022-06-05T06:57:52.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>699, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-5sf6z", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-5sf6z", "name"=>"ubuntu-jammy-daily-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:daily:download/com.ubuntu.cloud.daily:server:22.04:amd64/20220604/disk1.img, Release: daily", "source"=>"tmp6lwsv5cb", "arch"=>"x86_64", "created_at"=>"2022-06-05T06:58:33.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>709, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-vuptu", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-vuptu", "name"=>"ubuntu-kinetic-daily-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:daily:download/com.ubuntu.cloud.daily:server:22.10:amd64/20220605/disk1.img, Release: daily", "source"=>"tmpj_k3e6u1", "arch"=>"x86_64", "created_at"=>"2022-06-06T06:57:58.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>752, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-tqaxd", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-tqaxd", "name"=>"ubuntu-impish-21.10-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:server:21.10:amd64/20220604/disk1.img, Release: release", "source"=>"tmp_xphnxch", "arch"=>"x86_64", "created_at"=>"2022-06-07T06:57:33.000Z", "owner"=>"acc-kg71m", "official"=>true, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>699, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-7d1e3", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-7d1e3", "name"=>"ubuntu-jammy-22.04-amd64-server", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:server:22.04:amd64/20220604/disk1.img, Release: release", "source"=>"tmp11_42l44", "arch"=>"x86_64", "created_at"=>"2022-06-07T06:58:16.000Z", "owner"=>"acc-kg71m", "official"=>true, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>709, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-kg2oa", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-kg2oa", "name"=>"ubuntu-bionic-18.04-amd64-minimal", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:minimal:18.04:amd64/20220607/disk1.img, Release: minimal release", "source"=>"tmpd7d5lvyb", "arch"=>"x86_64", "created_at"=>"2022-06-08T07:01:21.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>258, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-sdofr", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-sdofr", "name"=>"ubuntu-focal-20.04-amd64-minimal", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:minimal:20.04:amd64/20220607/disk1.img, Release: minimal release", "source"=>"tmpl6wvuqu9", "arch"=>"x86_64", "created_at"=>"2022-06-08T07:01:49.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>330, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-7wwg7", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-7wwg7", "name"=>"ubuntu-impish-21.10-amd64-minimal", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:minimal:21.10:amd64/20220607/disk1.img, Release: minimal release", "source"=>"tmpfkqj3pjo", "arch"=>"x86_64", "created_at"=>"2022-06-08T07:02:13.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>328, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil},
+        {"id"=>"img-ielp9", "resource_type"=>"image", "url"=>"https://api.gb1s.brightbox.com/1.0/images/img-ielp9", "name"=>"ubuntu-jammy-22.04-amd64-minimal", "username"=>"ubuntu", "status"=>"available", "locked"=>false, "description"=>"ID: com.ubuntu.cloud:released:download/com.ubuntu.cloud:minimal:22.04:amd64/20220607/disk1.img, Release: minimal release", "source"=>"tmpd0ctsx1v", "arch"=>"x86_64", "created_at"=>"2022-06-08T07:02:38.000Z", "owner"=>"acc-yw7i0", "official"=>false, "public"=>true, "compatibility_mode"=>false, "source_type"=>"upload", "source_trigger"=>"manual", "disk_size"=>353, "virtual_size"=>2252, "min_ram"=>nil, "ancestor"=>nil}
+      ]
+
+      selector = subject.new(image_list)
+
+      assert_equal "img-7d1e3", selector.latest_ubuntu
+    end
+  end
+end

data/spec/fog/compute/brightbox/volume_spec.rb

@@ -0,0 +1,348 @@
+require "spec_helper"
+require "fog/brightbox/models/compute/volume"
+
+describe Fog::Brightbox::Compute::Volume do
+  include ModelSetup
+  include SupportsResourceLocking
+
+  subject { service.volumes.new }
+
+  describe "when state is 'creating'" do
+    it do
+      subject.state = "creating"
+
+      assert subject.creating?
+      refute subject.attached?
+      refute subject.detached?
+      refute subject.deleting?
+      refute subject.deleted?
+      refute subject.failed?
+
+      refute subject.ready?
+      refute subject.finished?
+    end
+  end
+
+  describe "when state is 'attached'" do
+    it do
+      subject.state = "attached"
+
+      refute subject.creating?
+      assert subject.attached?
+      refute subject.detached?
+      refute subject.deleting?
+      refute subject.deleted?
+      refute subject.failed?
+
+      assert subject.ready?
+      refute subject.finished?
+    end
+  end
+
+  describe "when state is 'detached'" do
+    it do
+      subject.state = "detached"
+
+      refute subject.creating?
+      refute subject.attached?
+      assert subject.detached?
+      refute subject.deleting?
+      refute subject.deleted?
+      refute subject.failed?
+
+      assert subject.ready?
+      refute subject.finished?
+    end
+  end
+
+  describe "when state is 'deleting'" do
+    it do
+      subject.state = "deleting"
+
+      refute subject.creating?
+      refute subject.attached?
+      refute subject.detached?
+      assert subject.deleting?
+      refute subject.deleted?
+      refute subject.failed?
+
+      refute subject.ready?
+      refute subject.finished?
+    end
+  end
+
+  describe "when state is 'deleted'" do
+    it do
+      subject.state = "deleted"
+
+      refute subject.creating?
+      refute subject.attached?
+      refute subject.detached?
+      refute subject.deleting?
+      assert subject.deleted?
+      refute subject.failed?
+
+      refute subject.ready?
+      assert subject.finished?
+    end
+  end
+
+  describe "when state is 'failed'" do
+    it do
+      subject.state = "failed"
+
+      refute subject.creating?
+      refute subject.attached?
+      refute subject.detached?
+      refute subject.deleting?
+      refute subject.deleted?
+      assert subject.failed?
+
+      refute subject.ready?
+      assert subject.finished?
+    end
+  end
+
+  describe "#attach" do
+    it do
+      subject.id = "vol-12345"
+      assert subject.persisted?
+
+      server = service.servers.new
+      server.id = "srv-12345"
+
+      stub_request(:post, "http://localhost/1.0/volumes/vol-12345/attach").
+        with(:query => hash_including(:account_id),
+             :headers => { "Authorization" => "Bearer FAKECACHEDTOKEN",
+                          "Content-Type" => "application/json" },
+             :body => hash_including(:server => "srv-12345")).
+        to_return(:status => 202,
+                  :body => %q({"id":"vol-12345","status":"attached"}),
+                  :headers => {})
+
+      subject.attach(server)
+
+      assert subject.attached?
+    end
+  end
+
+  describe "#collection_name" do
+    it "responds 'volumes'" do
+      assert_equal "volumes", subject.collection_name
+    end
+  end
+
+  describe "#copy" do
+    it do
+      subject.id = "vol-12345"
+      subject.state = "attached"
+      subject.delete_with_server = false
+
+      refute subject.delete_with_server
+      assert subject.persisted?
+
+      stub_request(:post, "http://localhost/1.0/volumes/vol-12345/copy").
+        with(:query => hash_including(:account_id),
+             :headers => { "Authorization" => "Bearer FAKECACHEDTOKEN",
+                          "Content-Type" => "application/json" },
+             :body => hash_including(:delete_with_server => true)).
+        to_return(:status => 202,
+                  :body => %q({"id":"vol-abcde","delete_with_server":true,"name":"Copy of vol-12345 (Impish Image)","status":"detached"}),
+                  :headers => {})
+
+      copy = subject.copy(delete_with_server: true)
+
+      assert copy.persisted?
+      assert_equal "vol-abcde", copy.id
+      assert copy.delete_with_server
+      assert copy.detached?
+    end
+  end
+
+  describe "#detach" do
+    it do
+      subject.id = "vol-12345"
+      subject.state = "attached"
+
+      assert subject.persisted?
+
+      stub_request(:post, "http://localhost/1.0/volumes/vol-12345/detach").
+        with(:query => hash_including(:account_id),
+             :headers => { "Authorization" => "Bearer FAKECACHEDTOKEN",
+                          "Content-Type" => "application/json" }).
+        to_return(:status => 202,
+                  :body => %q({"id":"vol-12345","status":"detached"}),
+                  :headers => {})
+
+      subject.detach
+
+      assert subject.detached?
+    end
+  end
+
+  describe "#destroy" do
+    it do
+      subject.id = "vol-12345"
+      assert subject.persisted?
+
+      stub_request(:delete, "http://localhost/1.0/volumes/vol-12345").
+        with(:query => hash_including(:account_id),
+             :headers => { "Authorization" => "Bearer FAKECACHEDTOKEN",
+                           "Content-Type" => "application/json" }).
+        to_return(:status => 202,
+                  :body => %q({"id":"vol-12345","status":"deleting"}),
+                  :headers => {})
+
+      subject.destroy
+      assert_equal "deleting", subject.state
+    end
+  end
+
+  describe "#ready?" do
+    describe "when state is 'creating'" do
+      it do
+        subject.state = "creating"
+
+        refute subject.ready?
+      end
+    end
+
+    describe "when state is 'attached'" do
+      it do
+        subject.state = "attached"
+
+        assert subject.ready?
+      end
+    end
+
+    describe "when state is 'detached'" do
+      it do
+        subject.state = "detached"
+
+        assert subject.ready?
+      end
+    end
+  end
+
+  describe "#resize" do
+    it do
+      subject.id = "vol-12345"
+      subject.size = 40_000
+
+      assert subject.persisted?
+
+      stub_request(:post, "http://localhost/1.0/volumes/vol-12345/resize").
+        with(:query => hash_including(:account_id),
+             :headers => { "Authorization" => "Bearer FAKECACHEDTOKEN",
+                          "Content-Type" => "application/json" },
+             :body => hash_including(:from => 40_000, :to => 50_000)).
+        to_return(:status => 202,
+                  :body => %q({"id":"vol-12345","size": 50000}),
+                  :headers => {})
+
+      subject.resize(to: 50_000)
+
+      assert 50_000, subject.size
+    end
+  end
+
+  describe "#resource_name" do
+    it "responds 'volume'" do
+      assert_equal "volume", subject.resource_name
+    end
+  end
+
+  describe "#save" do
+    describe "when creating" do
+      describe "with mutually exclusive arguments" do
+        it "raises Fog::Errors::Error" do
+          options = {
+            filesystem_type: "ext4",
+            image_id: "img-12345"
+          }
+
+          @volume = Fog::Brightbox::Compute::Volume.new({ :service => service }.merge(options))
+
+          assert_raises Fog::Errors::Error do
+            @volume.save
+          end
+        end
+      end
+
+      describe "with filesytem type" do
+        it "sends correct JSON" do
+          options = {
+            description: "An ext4 volume",
+            filesystem_type: "ext4"
+          }
+
+          stub_request(:post, "http://localhost/1.0/volumes").
+            with(:query => hash_including(:account_id),
+                 :headers => { "Authorization" => "Bearer FAKECACHEDTOKEN",
+                               "Content-Type" => "application/json" },
+                 :body => hash_including(:filesystem_type => "ext4")).
+            to_return(:status => 202,
+                      :body => %q({"id":"vol-12345","image":{"id":"img-blank"}}),
+                      :headers => {})
+
+          @volume = Fog::Brightbox::Compute::Volume.new({ :service => service }.merge(options))
+          assert @volume.save
+          assert_equal @volume.filesystem_type, "ext4"
+          assert_equal @volume.image_id, "img-blank"
+          assert_equal @volume.description, "An ext4 volume"
+        end
+      end
+
+      describe "with image" do
+        it "sends correct JSON" do
+          options = {
+            image_id: "img-12345",
+            name: "My Volume"
+          }
+
+          stub_request(:post, "http://localhost/1.0/volumes").
+            with(:query => hash_including(:account_id),
+                 :headers => { "Authorization" => "Bearer FAKECACHEDTOKEN",
+                               "Content-Type" => "application/json" },
+                 :body => hash_including(:image => "img-12345")).
+            to_return(:status => 202,
+                      :body => %q({"id":"vol-12345","image":{"id":"img-12345"}}),
+                      :headers => {})
+
+
+          @volume = Fog::Brightbox::Compute::Volume.new({ :service => service }.merge(options))
+          assert @volume.save
+          assert_equal @volume.image_id, "img-12345"
+          assert_equal @volume.name, "My Volume"
+        end
+      end
+    end
+
+    describe "when updating" do
+      it do
+        subject.id = "vol-12345"
+
+        assert subject.persisted?
+
+        subject.delete_with_server = true
+        subject.description = "Updated description"
+        subject.name = "New name"
+        subject.serial = "NewSerial"
+
+        stub_request(:put, "http://localhost/1.0/volumes/vol-12345").
+          with(:query => hash_including(:account_id),
+               :headers => { "Authorization" => "Bearer FAKECACHEDTOKEN",
+                             "Content-Type" => "application/json" },
+               :body => hash_including(:delete_with_server => true,
+                                       :description => "Updated description",
+                                       :name => "New name",
+                                       :serial => "NewSerial")).
+          to_return(:status => 202,
+                    :body => %q({"id":"vol-12345"}),
+                    :headers => {})
+
+        subject.save
+      end
+    end
+  end
+end

data/tests/brightbox/compute/schema.rb

@@ -252,6 +252,29 @@ class Brightbox
           "inviter"         => Brightbox::Compute::Formats::Nested::USER
         }
 
+        VOLUME = {
+          "id"              => String,
+          "resource_type"   => String,
+          "url"             => String,
+          "status"          => String,
+          "name"            => Fog::Nullable::String,
+          "delete_with_server" => Fog::Boolean,
+          "description"     => Fog::Nullable::String,
+          "boot"            => Fog::Boolean,
+          "encrypted"       => Fog::Boolean,
+          "filesystem_label" => Fog::Nullable::String,
+          "filesystem_type" => Fog::Nullable::String,
+          "locked"          => Fog::Boolean,
+          "serial"          => String,
+          "size"            => Integer,
+          "source"          => Fog::Nullable::String,
+          "source_type"     => String,
+          "storage_type"    => String,
+          "created_at"      => String,
+          "updated_at"      => String,
+          "deleted_at"      => Fog::Nullable::String
+        }
+
         ZONE = {
           "id"              => String,
           "resource_type"   => String,
@@ -482,6 +505,29 @@ class Brightbox
           "inviter"         => Brightbox::Compute::Formats::Nested::USER
         }
 
+        VOLUME = {
+          "id"              => String,
+          "resource_type"   => String,
+          "url"             => String,
+          "status"          => String,
+          "name"            => Fog::Nullable::String,
+          "delete_with_server" => Fog::Boolean,
+          "description"     => Fog::Nullable::String,
+          "boot"            => Fog::Boolean,
+          "encrypted"       => Fog::Boolean,
+          "filesystem_label" => Fog::Nullable::String,
+          "filesystem_type" => Fog::Nullable::String,
+          "locked"          => Fog::Boolean,
+          "serial"          => String,
+          "size"            => Integer,
+          "source"          => Fog::Nullable::String,
+          "source_type"     => String,
+          "storage_type"    => String,
+          "created_at"      => String,
+          "updated_at"      => String,
+          "deleted_at"      => Fog::Nullable::String
+        }
+
         ZONE = {
           "id"              => String,
           "resource_type"   => String,
@@ -706,6 +752,7 @@ class Brightbox
           "snapshots"       => [Brightbox::Compute::Formats::Nested::IMAGE],
           "server_groups"   => [Brightbox::Compute::Formats::Nested::SERVER_GROUP],
           "interfaces"      => [Brightbox::Compute::Formats::Nested::INTERFACE],
+          "volumes"         => [Brightbox::Compute::Formats::Nested::VOLUME],
           "zone"            => Fog::Brightbox::Nullable::Zone,
           "licence_name"    => Fog::Nullable::String,
           "username"        => Fog::Nullable::String,
@@ -763,6 +810,32 @@ class Brightbox
           "inviter"         => Brightbox::Compute::Formats::Nested::USER
         }
 
+        VOLUME = {
+          "id"              => String,
+          "resource_type"   => String,
+          "url"             => String,
+          "status"          => String,
+          "name"            => Fog::Nullable::String,
+          "delete_with_server" => Fog::Boolean,
+          "description"     => Fog::Nullable::String,
+          "boot"            => Fog::Boolean,
+          "encrypted"       => Fog::Boolean,
+          "filesystem_label" => Fog::Nullable::String,
+          "filesystem_type" => Fog::Nullable::String,
+          "locked"          => Fog::Boolean,
+          "serial"          => String,
+          "size"            => Integer,
+          "source"          => Fog::Nullable::String,
+          "source_type"     => String,
+          "storage_type"    => String,
+          "created_at"      => String,
+          "updated_at"      => String,
+          "deleted_at"      => Fog::Nullable::String,
+          "account"         => Brightbox::Compute::Formats::Nested::ACCOUNT,
+          "image"           => Fog::Brightbox::Nullable::Image,
+          "server"          => Fog::Brightbox::Nullable::Server
+        }
+
         ZONE = {
           "id"              => String,
           "resource_type"   => String,
@@ -787,6 +860,7 @@ class Brightbox
         SERVER_GROUPS = [Brightbox::Compute::Formats::Collected::SERVER_GROUP]
         SERVER_TYPES = [Brightbox::Compute::Formats::Collected::SERVER_TYPE]
         USERS = [Brightbox::Compute::Formats::Collected::USER]
+        VOLUMES = [Brightbox::Compute::Formats::Collected::VOLUME]
         ZONES = [Brightbox::Compute::Formats::Collected::ZONE]
       end
     end

data/tests/brightbox/requests/compute/volume_tests.rb

@@ -0,0 +1,57 @@
+Shindo.tests("Fog::Compute[:brightbox] | volume requests", ["brightbox"]) do
+  pending if Fog.mocking?
+  image_id = Brightbox::Compute::TestSupport.image_id
+
+  tests("success") do
+    create_options = { image: image_id }
+
+    tests("#create_volume(#{create_options.inspect})") do
+      result = Fog::Compute[:brightbox].create_volume(create_options)
+      @volume_id = result["id"]
+      data_matches_schema(Brightbox::Compute::Formats::Full::VOLUME, :allow_extra_keys => true) { result }
+    end
+
+    tests("#list_volumes") do
+      result = Fog::Compute[:brightbox].list_volumes
+      data_matches_schema(Brightbox::Compute::Formats::Collection::VOLUMES, :allow_extra_keys => true) { result }
+
+      test("#{@volume_id} is listed") do
+        result.any? do |volume|
+          volume["id"] == @volume_id
+        end
+      end
+    end
+
+    tests("#get_volume('#{@volume_id}')") do
+      result = Fog::Compute[:brightbox].get_volume(@volume_id)
+      data_matches_schema(Brightbox::Compute::Formats::Full::VOLUME, :allow_extra_keys => true) { result }
+    end
+
+    update_options = {
+      name: "New name"
+    }
+    tests("#update_volume('#{@volume_id}', ...)") do
+      result = Fog::Compute[:brightbox].update_volume(@volume_id, update_options)
+      data_matches_schema(Brightbox::Compute::Formats::Full::VOLUME, :allow_extra_keys => true) { result }
+
+      test("name has updated") { result["name"] == "New name" }
+    end
+
+    Fog::Compute[:brightbox].volumes.get(@volume_id).wait_for { ready? }
+
+    tests("#delete_volume('#{@volume_id}')") do
+      result = Fog::Compute[:brightbox].delete_volume(@volume_id)
+      data_matches_schema(Brightbox::Compute::Formats::Full::VOLUME, :allow_extra_keys => true) { result }
+    end
+  end
+
+  tests("failure") do
+    tests("create_volume without options").raises(ArgumentError) do
+      Fog::Compute[:brightbox].create_volume
+    end
+
+    tests("get_volume with invalid ID").raises(Excon::Errors::NotFound) do
+      Fog::Compute[:brightbox].get_volume("vol-00000")
+    end
+  end
+end