fog-brightbox 0.6.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52897a886916a22c81a1739e501b85f1c5cc31b9
-  data.tar.gz: de27f7575f275ef77bb7469996cd3dd57e93e826
+  metadata.gz: 496e29fce89925667624be224c1f667295ee92fc
+  data.tar.gz: 86fca89817bccee070cdb86701a811cdb604cfa7
 SHA512:
-  metadata.gz: af4897d9093f4aa615f4250f0a5d33f07b5ecf0639cacb25c4972862c58f8017c4aaae2d05e46651e370471cd19810e48873017df191016fead34ebfdb7c0762
-  data.tar.gz: 862944dce4be95bdd31f6c9572ae024c16d61924b99db947eaeca644d8bbfae567b8d99826857411e9035f97be87ed925079d6b0ff0718abebd3671cd0870563
+  metadata.gz: e0725ecbd7084c492e79ef187183b1adebde76de09ac082d61b748784bb30fe73a91c47d7272c2cd96a28f27d78ff6462c0df951e1e898a88bf85e5bba56dae5
+  data.tar.gz: fbe5f43f457c4d2306bd8bbdcff03edb5dd002a07cb7bb7ffdbf65c20e092459dd93de159395543a15e4727cc4adaa8da3f8aa3f152cb6d0336eb000a851dc7b

data/.gitignore

@@ -1,2 +1,5 @@
 Gemfile.lock
 gemfiles/*.lock
+pkg
+doc/*
+.yardoc

data/.rubocop.yml

@@ -0,0 +1,20 @@
+inherit_from: .rubocop_todo.yml
+
+HashSyntax:
+  EnforcedStyle: hash_rockets
+
+LineLength:
+  Max: 100
+  Enabled: false
+
+StringLiterals:
+  EnforcedStyle: double_quotes
+
+Encoding:
+  Description: 'Use UTF-8 as the source file encoding.'
+  Enabled: false
+
+SignalException:
+  Description: 'Do not enforce use of fail when raising exceptions.'
+  # Valid values are: semantic, only_raise and only_fail
+  EnforcedStyle: only_raise

data/.rubocop_todo.yml

@@ -0,0 +1,81 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2014-10-23 16:16:50 +0100 using RuboCop version 0.23.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Enabled: false
+
+# Offense count: 4
+Style/AccessorMethodName:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/Blocks:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: CountComments.
+Style/ClassLength:
+  Max: 165
+
+# Offense count: 4
+Style/CyclomaticComplexity:
+  Max: 8
+
+# Offense count: 190
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 26
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/DotPosition:
+  Enabled: false
+
+# Offense count: 5
+Style/DoubleNegation:
+  Enabled: false
+
+# Offense count: 2
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Offense count: 23
+# Configuration parameters: CountComments.
+Style/MethodLength:
+  Max: 24
+
+# Offense count: 2
+Style/MultilineBlockChain:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/Next:
+  Enabled: false
+
+# Offense count: 9
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/RaiseArgs:
+  Enabled: false
+
+# Offense count: 3
+Style/RegexpLiteral:
+  MaxSlashes: 0
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
+Style/TrivialAccessors:
+  Enabled: false

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+### 0.7.0 / 2014-11-27
+
+Enhancements:
+
+* Can read `Link` headers returned from snapshot actions
+* Optionally allow return or `Snapshot` objects from snapshot actions.
+
+Bug fixes:
+
+* Ignore select directories from version control.
+* Removed duplicate spec_helper
+* Addition of style rules using `rubocop`
+* Automated clean up of style rules
+* Be pessimistic about `inflecto` gem.
+  Next release of Inflecto gem will introduce 1.9 constraint so we need to be
+  pessimistic about the version to depend on for now.
+
 ### 0.6.1 / 2014-10-22
 
 Bug fixes:

data/README.md

@@ -39,6 +39,12 @@ and its modules:
 * http://fog.io/
 * http://rubydoc.info/gems/fog/
 
+### Ruby 1.8.7
+
+If you are still using Ruby 1.8.7 in production, see `gemfiles/Gemfile.1.8.7`
+for a gemfile of 1.8.7 compatible version of dependencies you may need to
+specify in your application's `Gemfile`
+
 ## Contributing
 
 `fog` modules are kept within the main repo.

data/fog-brightbox.gemspec

@@ -1,31 +1,32 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'fog/brightbox/version'
+require "fog/brightbox/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "fog-brightbox"
   spec.version       = Fog::Brightbox::VERSION
   spec.authors       = ["Paul Thornthwaite"]
   spec.email         = ["tokengeek@gmail.com"]
-  spec.description   = %q{Module for the 'fog' gem to support Brightbox Cloud}
-  spec.summary       = %q{This library can be used as a module for `fog` or as standalone provider
-                        to use the Brightbox Cloud in applications}
+  spec.description   = %q(Module for the 'fog' gem to support Brightbox Cloud)
+  spec.summary       = %q(This library can be used as a module for `fog` or as standalone provider
+                        to use the Brightbox Cloud in applications)
   spec.homepage      = ""
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
   spec.add_dependency "fog-core", "~> 1.22"
   spec.add_dependency "fog-json"
-  spec.add_dependency "inflecto"
+  spec.add_dependency "inflecto", "~> 0.0.2"
 
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "pry"
   spec.add_development_dependency "minitest"
+  spec.add_development_dependency "pry"
+  spec.add_development_dependency "rake"
   spec.add_development_dependency "webmock"
+  spec.add_development_dependency "yard"
 end

data/gemfiles/Gemfile.1.8.7

@@ -2,5 +2,6 @@ source "https://rubygems.org"
 
 gem "fog-core", :github => "fog/fog-core"
 gem "mime-types", "~> 1.22"
+gem "inflecto", "~> 0.0.2"
 
 gemspec :path => ".."

data/lib/fog/brightbox.rb

@@ -1,2 +1,2 @@
-require 'fog/brightbox/compute'
-require 'fog/brightbox/storage'
+require "fog/brightbox/compute"
+require "fog/brightbox/storage"

data/lib/fog/brightbox/compute.rb

@@ -1,12 +1,12 @@
-require 'fog/brightbox/core'
-require 'fog/brightbox/compute/config'
-require 'fog/brightbox/compute/shared'
-require 'fog/brightbox/compute/image_selector'
+require "fog/brightbox/core"
+require "fog/brightbox/compute/config"
+require "fog/brightbox/compute/shared"
+require "fog/brightbox/compute/image_selector"
+require "fog/brightbox/link_helper"
 
 module Fog
   module Compute
     class Brightbox < Fog::Service
-
       # Client credentials
       requires :brightbox_client_id, :brightbox_secret
 
@@ -25,47 +25,47 @@ module Fog
       # Excon connection settings
       recognizes :persistent
 
-      model_path 'fog/brightbox/models/compute'
-      collection  :accounts
-      model       :account
-      collection  :applications
-      model       :application
-      collection  :api_clients
-      model       :api_client
-      collection  :collaborations
-      model       :collaboration
-      collection  :servers
-      model       :server
-      collection  :server_groups
-      model       :server_group
-      collection  :events
-      model       :event
-      collection  :firewall_policies
-      model       :firewall_policy
-      collection  :firewall_rules
-      model       :firewall_rule
-      collection  :flavors
-      model       :flavor
-      collection  :images
-      model       :image
-      collection  :load_balancers
-      model       :load_balancer
-      collection  :database_servers
-      model       :database_server
-      collection  :database_snapshots
-      model       :database_snapshot
-      collection  :database_types
-      model       :database_type
-      collection  :zones
-      model       :zone
-      collection  :cloud_ips
-      model       :cloud_ip
-      collection  :users
-      model       :user
-      collection  :user_collaborations
-      model       :user_collaboration
+      model_path "fog/brightbox/models/compute"
+      collection :accounts
+      model :account
+      collection :applications
+      model :application
+      collection :api_clients
+      model :api_client
+      collection :collaborations
+      model :collaboration
+      collection :servers
+      model :server
+      collection :server_groups
+      model :server_group
+      collection :events
+      model :event
+      collection :firewall_policies
+      model :firewall_policy
+      collection :firewall_rules
+      model :firewall_rule
+      collection :flavors
+      model :flavor
+      collection :images
+      model :image
+      collection :load_balancers
+      model :load_balancer
+      collection :database_servers
+      model :database_server
+      collection :database_snapshots
+      model :database_snapshot
+      collection :database_types
+      model :database_type
+      collection :zones
+      model :zone
+      collection :cloud_ips
+      model :cloud_ip
+      collection :users
+      model :user
+      collection :user_collaborations
+      model :user_collaboration
 
-      request_path 'fog/brightbox/requests/compute'
+      request_path "fog/brightbox/requests/compute"
       request :accept_user_collaboration
       request :activate_console_server
       request :add_listeners_load_balancer
@@ -192,11 +192,11 @@ module Fog
       class Mock
         include Fog::Brightbox::Compute::Shared
 
-        def request(method, path, expected_responses, parameters = {})
+        def request(_method, _path, _expected_responses, _parameters = {})
           _request
         end
 
-        def request_access_token(connection, credentials)
+        def request_access_token(_connection, _credentials)
           _request
         end
 
@@ -315,7 +315,6 @@ module Fog
           Fog::Brightbox::Compute::ImageSelector.new(list_images).latest_ubuntu
         end
       end
-
     end
   end
 end

data/lib/fog/brightbox/compute/resource_locking.rb

@@ -1,27 +1,33 @@
-module ResourceLocking
-  def locked?
-    if attributes.key?("locked") || attributes.key?(:locked)
-      attributes["locked"] || attributes[:locked] || false
-    else
-      false
-    end
-  end
+module Fog
+  module Brightbox
+    module Compute
+      module ResourceLocking
+        def locked?
+          if attributes.key?("locked") || attributes.key?(:locked)
+            attributes["locked"] || attributes[:locked] || false
+          else
+            false
+          end
+        end
 
-  def lock!
-    locking_request(:lock)
-  end
+        def lock!
+          locking_request(:lock)
+        end
 
-  def unlock!
-    locking_request(:unlock)
-  end
+        def unlock!
+          locking_request(:unlock)
+        end
 
-  private
+        private
 
-  def locking_request(lock_setting)
-    requires :identity
+        def locking_request(lock_setting)
+          requires :identity
 
-    data = service.send(:"#{lock_setting}_resource_#{resource_name}", identity)
-    merge_attributes(data)
-    true
+          data = service.send(:"#{lock_setting}_resource_#{resource_name}", identity)
+          merge_attributes(data)
+          true
+        end
+      end
+    end
   end
 end

data/lib/fog/brightbox/compute/shared.rb

@@ -3,13 +3,14 @@ require "fog/brightbox/oauth2"
 module Fog
   module Brightbox
     module Compute
-
       # The Shared module consists of code that was duplicated between the Real
       # and Mock implementations.
       #
       module Shared
         include Fog::Brightbox::OAuth2
 
+        attr_writer :scoped_account
+
         API_URL = "https://api.gb1.brightbox.com/"
 
         # Creates a new instance of the Brightbox Compute service
@@ -59,12 +60,6 @@ module Fog
           @token_management    = @config.managed_tokens?
         end
 
-        # Sets the scoped account for future requests
-        # @param [String] scoped_account Identifier of the account to scope request to
-        def scoped_account=(scoped_account)
-          @scoped_account = scoped_account
-        end
-
         # This returns the account identifier that the request should be scoped by
         # based on the options passed to the request and current configuration
         #

data/lib/fog/brightbox/config.rb

@@ -9,6 +9,8 @@ module Fog
     # is told a token has expired then another will not retry it.
     #
     class Config
+      attr_writer :storage_management_url
+
       # Creates a new set of configuration settings based on the options provided.
       #
       # @param [Hash] options The configuration settings
@@ -53,12 +55,12 @@ module Fog
 
       # @return [OAuth2::CredentialSet]
       def credentials
-        @credentials ||= OAuth2::CredentialSet.new(client_id, client_secret, {
-          :username => username,
-          :password => password,
-          :access_token => cached_access_token,
-          :refresh_token => cached_refresh_token
-        })
+        @credentials ||= OAuth2::CredentialSet.new(client_id, client_secret,
+                                                   :username => username,
+                                                   :password => password,
+                                                   :access_token => cached_access_token,
+                                                   :refresh_token => cached_refresh_token
+                                                  )
       end
 
       # @return [Boolean]
@@ -94,15 +96,10 @@ module Fog
 
       def storage_management_url
         @storage_management_url ||= if @options.key?(:brightbox_storage_management_url)
-          URI.parse(@options[:brightbox_storage_management_url])
-        else
-          nil
-        end
-      end
-
-      # @param [URI] management_url The URI to use for management requests.
-      def storage_management_url=(management_url)
-        @storage_management_url = management_url
+                                      URI.parse(@options[:brightbox_storage_management_url])
+                                    else
+                                      nil
+                                    end
       end
 
       # @return [String] The configured identifier of the API client or user application.