fog-azure-rm 0.0.1 → 0.0.2

data/lib/fog/azurerm/requests/compute/list_available_sizes_for_virtual_machine.rb

@@ -7,7 +7,7 @@ module Fog
           begin
             response = @compute_mgmt_client.virtual_machines.list_available_sizes(resource_group, name)
             result = response.value!
-            result.body.value
+            Azure::ARM::Compute::Models::VirtualMachineSizeListResult.serialize_object(result.body)['value']
           rescue MsRestAzure::AzureOperationError => e
             msg = "Error listing Sizes for Virtual Machine #{name} in Resource Group '#{resource_group}'. #{e.body['error']['message']}"
             raise msg
@@ -17,6 +17,32 @@ module Fog
       # This class provides the mock implementation for unit tests.
       class Mock
         def list_available_sizes_for_virtual_machine(resource_group, name)
+          [
+            {
+              "name"=>"Standard_A0",
+              "numberOfCores"=>1,
+              "osDiskSizeInMB"=>1047552,
+              "resourceDiskSizeInMB"=>20480,
+              "memoryInMB"=>768,
+              "maxDataDiskCount"=>1
+            },
+            {
+              "name"=>"Standard_A1",
+              "numberOfCores"=>1,
+              "osDiskSizeInMB"=>1047552,
+              "resourceDiskSizeInMB"=>71680,
+              "memoryInMB"=>1792,
+              "maxDataDiskCount"=>2
+            },
+            {
+              "name"=>"Standard_A2",
+              "numberOfCores"=>2,
+              "osDiskSizeInMB"=>1047552,
+              "resourceDiskSizeInMB"=>138240,
+              "memoryInMB"=>3584,
+              "maxDataDiskCount"=>4
+            }
+        ]
         end
       end
     end

data/lib/fog/azurerm/requests/compute/power_off_virtual_machine.rb

@@ -7,9 +7,9 @@ module Fog
           Fog::Logger.debug "Powering off Virtual Machine #{name} in Resource Group #{resource_group}."
           begin
             promise = @compute_mgmt_client.virtual_machines.power_off(resource_group, name)
-            result = promise.value!
+            promise.value!
             Fog::Logger.debug "Virtual Machine #{name} Powered off Successfully."
-            result
+            true
           rescue  MsRestAzure::AzureOperationError => e
             msg = "Error Powering off Virtual Machine '#{name}' in Resource Group '#{resource_group}'. #{e.body['error']['message']}"
             raise msg
@@ -19,6 +19,8 @@ module Fog
       # This class provides the mock implementation for unit tests.
       class Mock
         def power_off_virtual_machine(resource_group, name)
+          Fog::Logger.debug "Virtual Machine #{name} from Resource group #{resource_group} Powered off successfully."
+          return true
         end
       end
     end

data/lib/fog/azurerm/requests/compute/redeploy_virtual_machine.rb

@@ -7,9 +7,9 @@ module Fog
           Fog::Logger.debug "Redeploying Virtual Machine #{name} in Resource Group #{resource_group}."
           begin
             promise = @compute_mgmt_client.virtual_machines.redeploy(resource_group, name)
-            result = promise.value!
+            promise.value!
             Fog::Logger.debug "Virtual Machine #{name} Redeployed Successfully."
-            result
+            true
           rescue  MsRestAzure::AzureOperationError => e
             msg = "Error Redeploying Virtual Machine '#{name}' in Resource Group '#{resource_group}'. #{e.body['error']['message']}"
             raise msg
@@ -19,6 +19,8 @@ module Fog
       # This class provides the mock implementation for unit tests.
       class Mock
         def redeploy_virtual_machine(resource_group, name)
+          Fog::Logger.debug "Virtual Machine #{name} from Resource group #{resource_group} Redeployed successfully."
+          return true
         end
       end
     end

data/lib/fog/azurerm/requests/compute/restart_virtual_machine.rb

@@ -7,9 +7,9 @@ module Fog
           Fog::Logger.debug "Restarting Virtual Machine #{name} in Resource Group #{resource_group}."
           begin
             promise = @compute_mgmt_client.virtual_machines.restart(resource_group, name)
-            result = promise.value!
+            promise.value!
             Fog::Logger.debug "Virtual Machine #{name} Restarted Successfully."
-            result
+            true
           rescue  MsRestAzure::AzureOperationError => e
             msg = "Error Restarting Virtual Machine '#{name}' in Resource Group '#{resource_group}'. #{e.body['error']['message']}"
             raise msg
@@ -19,6 +19,8 @@ module Fog
       # This class provides the mock implementation for unit tests.
       class Mock
         def restart_virtual_machine(resource_group, name)
+          Fog::Logger.debug "Virtual Machine #{name} from Resource group #{resource_group} Restarted successfully."
+          return true
         end
       end
     end

data/lib/fog/azurerm/requests/compute/start_virtual_machine.rb

@@ -7,9 +7,9 @@ module Fog
           Fog::Logger.debug "Starting Virtual Machine #{name} in Resource Group #{resource_group}."
           begin
             promise = @compute_mgmt_client.virtual_machines.start(resource_group, name)
-            result = promise.value!
+            promise.value!
             Fog::Logger.debug "Virtual Machine #{name} started Successfully."
-            result
+            true
           rescue  MsRestAzure::AzureOperationError => e
             msg = "Error starting Virtual Machine '#{name}' in Resource Group '#{resource_group}'. #{e.body['error']['message']}"
             raise msg
@@ -19,6 +19,8 @@ module Fog
       # This class provides the mock implementation for unit tests.
       class Mock
         def start_virtual_machine(resource_group, name)
+          Fog::Logger.debug "Virtual Machine #{name} from Resource group #{resource_group} started successfully."
+          return true
         end
       end
     end

data/lib/fog/azurerm/requests/dns/check_for_zone.rb

@@ -1,37 +1,36 @@
 module Fog
   module DNS
     class AzureRM
+      # Real class for DNS Request
       class Real
         def check_for_zone(resource_group, name)
           resource_url = "#{AZURE_RESOURCE}/subscriptions/#{@subscription_id}/resourceGroups/#{resource_group}/providers/Microsoft.Network/dnsZones/#{name}?api-version=2015-05-04-preview"
           begin
             token = Fog::Credentials::AzureRM.get_token(@tenant_id, @client_id, @client_secret)
-            dns_response = RestClient.get(
-                resource_url,
-                accept: 'application/json',
-                content_type: 'application/json',
-                authorization: token)
-            dns_hash = JSON.parse(dns_response)
-            if dns_hash.key?('id') && !dns_hash['id'].nil?
-              true
-            else
-              false
-            end
+            RestClient.get(
+              resource_url,
+              accept: 'application/json',
+              content_type: 'application/json',
+              authorization: token)
+            true
           rescue RestClient::Exception => e
-            if e.http_code == 404
+            body = JSON.parse(e.response)
+            if(body['error']['code']) == 'ResourceNotFound'
               false
             else
-              body = JSON.parse(e.http_body)
-              msg = "Exception checking if the zone exists: #{body['code']}, #{body['message']}"
-              fail msg
+              Fog::Logger.warning "Exception checking if the zone exists in resource group #{resource_group}"
+              msg = "Exception checking if the zone exists: #{body['error']['code']}, #{body['error']['message']}"
+              raise msg
             end
           end
         end
       end
 
+      # Mock class for DNS Request
       class Mock
-        def check_for_zone(resource_group, name)
-
+        def check_for_zone(_resource_group, _name)
+          Fog::Logger.debug "Zone name #{_name} is available."
+          return true
         end
       end
     end

data/lib/fog/azurerm/requests/dns/create_record_set.rb

@@ -1,61 +1,104 @@
 module Fog
   module DNS
     class AzureRM
+      # Real class for DNS Request
       class Real
-        def create_record_set(dns_resource_group, zone_name, record_set_name, records, record_type, ttl)
-          resource_url = "#{AZURE_RESOURCE}/subscriptions/#{@subscription_id}/resourceGroups/#{dns_resource_group}/providers/Microsoft.Network/dnsZones/#{zone_name}/#{record_type}/#{record_set_name}?api-version=2015-05-04-preview"
-          Fog::Logger.debug "Creating/Updating RecordSet #{record_set_name} of type '#{record_type}' in zone #{zone_name}"
+        def create_record_set(resource_group, name, zone_name, records, record_type, ttl)
+          resource_url = "#{AZURE_RESOURCE}/subscriptions/#{@subscription_id}/resourceGroups/#{resource_group}/providers/Microsoft.Network/dnsZones/#{zone_name}/#{record_type}/#{name}?api-version=2015-05-04-preview"
+          Fog::Logger.debug "Creating/Updating RecordSet #{name} of type '#{record_type}' in zone #{zone_name}"
 
           case record_type
-            when 'A'
-              a_type_records_array = Array.new
-              records.each do |ip|
-                a_type_records_array.push({'ipv4Address' => ip})
-              end
-              body = {
-                  :location => 'global',
-                  :tags => '',
-                  :properties => {
-                      :TTL => ttl,
-                      :ARecords => a_type_records_array
-                  }
+          when 'A'
+            a_type_records_array = []
+            records.each do |ip|
+              a_type_records_array.push(ipv4Address: ip)
+            end
+            body = {
+              location: 'global',
+              tags: '',
+              properties: {
+                TTL: ttl,
+                ARecords: a_type_records_array
               }
-            when 'CNAME'
-              body = {
-                  :location => 'global',
-                  :tags => '',
-                  :properties => {
-                      :TTL => ttl,
-                      :CNAMERecord => {
-                          'cname' => records.first # because cname only has 1 value and we know the object is an array passed in.
-                      }
-                  }
+            }
+          when 'CNAME'
+            body = {
+              location: 'global',
+              tags: '',
+              properties: {
+                TTL: ttl,
+                CNAMERecord: {
+                  cname: records.first # because cname only has 1 value and we know the object is an array passed in.
+                }
               }
+            }
           end
 
           begin
             token = Fog::Credentials::AzureRM.get_token(@tenant_id, @client_id, @client_secret)
-            RestClient.put(
-                resource_url,
-                body.to_json,
-                accept: 'application/json',
-                content_type: 'application/json',
-                authorization: token
-            )
-            Fog::Logger.debug "RecordSet #{record_set_name} Created/Updated Successfully!"
+            response = RestClient.put(
+              resource_url,
+              body.to_json,
+              accept: 'application/json',
+              content_type: 'application/json',
+              authorization: token)
+            Fog::Logger.debug "RecordSet #{name} Created/Updated Successfully!"
+            parsed_response = JSON.parse(response)
+            parsed_response
           rescue Exception => e
-            Fog::Logger.warning "Exception setting #{record_type} records for the record set: #{record_set_name}"
+            Fog::Logger.warning "Exception creating recordset #{name} in zone #{zone_name}."
             msg = "AzureDns::RecordSet - Exception is: #{e.message}"
             raise msg
           end
         end
       end
 
+      # Mock class for DNS Request
       class Mock
-        def create_record_set(dns_resource_group, zone_name, record_set_name, records, record_type, ttl)
-
+        def create_record_set(_resource_group, _name, _zone_name, _records, _record_type, _ttl)
+          if _record_type == 'A'
+            {
+              "id"=>"/subscriptions/########-####-####-####-############/resourceGroups/#{_dns_resource_group}/providers/Microsoft.Network/dnszones/#{_zone_name}/#{_record_type}/#{_name}",
+              "name"=>_name,
+              "type"=>"Microsoft.Network/dnszones/#{_record_type}",
+              "etag"=>"7f159cb1-653d-4920-bc03-153c700412a2",
+              "location"=>"global",
+              "tags"=>{},
+              "properties"=>
+                {
+                  "metadata"=>{},
+                  "fqdn"=>"#{_name}.#{_zone_name}.",
+                  "TTL"=>_ttl,
+                  "ARecords"=>
+                    [
+                      {
+                        "ipv4Address"=>_records[0]
+                      }
+                    ]
+                }
+            }
+          elsif _record_type == 'CNAME'
+            {
+              "id"=>"/subscriptions/########-####-####-####-############/resourceGroups/#{_resource_group}/providers/Microsoft.Network/dnszones/#{_zone_name}/#{_record_type}/#{_name}",
+              "name"=>_name,
+              "type"=>"Microsoft.Network/dnszones/#{_record_type}",
+              "etag"=>"cc5ceb6e-16ad-4a5f-bbd7-9bc31c12d0cf",
+              "location"=>"global",
+              "tags"=>{},
+              "properties"=>
+                {
+                  "metadata"=>{},
+                  "fqdn"=>"#{_name}.#{_zone_name}.",
+                  "TTL"=>_ttl,
+                  "CNAMERecord"=>
+                    {
+                      "cname"=>_records[0]
+                    }
+                }
+            }
+          end
         end
       end
     end
   end
-end
+end

data/lib/fog/azurerm/requests/dns/create_zone.rb

@@ -1,45 +1,61 @@
 module Fog
   module DNS
     class AzureRM
+      # Real class for DNS Request
       class Real
-        def create_zone(dns_resource_group, zone_name)
-          Fog::Logger.debug "Creating Zone #{zone_name} ..."
-          resource_url = "#{AZURE_RESOURCE}/subscriptions/#{@subscription_id}/resourceGroups/#{dns_resource_group}/providers/Microsoft.Network/dnsZones/#{zone_name}?api-version=2015-05-04-preview"
-          
+        def create_zone(resource_group, name)
+          Fog::Logger.debug "Creating Zone #{name} ..."
+          resource_url = "#{AZURE_RESOURCE}/subscriptions/#{@subscription_id}/resourceGroups/#{resource_group}/providers/Microsoft.Network/dnsZones/#{name}?api-version=2015-05-04-preview"
+
           body = {
-              location: 'global',
-              tags: {},
-              properties: {}
+            location: 'global',
+            tags: {},
+            properties: {}
           }
 
           begin
             token = Fog::Credentials::AzureRM.get_token(@tenant_id, @client_id, @client_secret)
-            dns_response = RestClient.put(
-                resource_url,
-                body.to_json,
-                accept: 'application/json',
-                content_type: 'application/json',
-                authorization: token)
-            response_hash = JSON.parse(dns_response)
-            Fog::Logger.debug "Zone #{zone_name} created successfully."
-            response_hash
-          rescue RestClient::Exception => e
-            body = JSON.parse(e.http_body)
-            if body.key?('error')
-              body = body['error']
-              msg = "Exception creating zone: #{body['code']}, #{body['message']}"
-            else
-              msg = "Exception creating zone: #{body['code']}, #{body['message']}"
-            end
-
+            response = RestClient.put(
+              resource_url,
+              body.to_json,
+              accept: 'application/json',
+              content_type: 'application/json',
+              authorization: token)
+            Fog::Logger.debug "Zone #{name} created successfully."
+            parsed_response = JSON.parse(response)
+            parsed_response
+          rescue Exception => e
+            Fog::Logger.warning "Exception creating zone #{name} in resource group #{resource_group}"
+            msg = "AzureDns::Zone - Exception is: #{e.message}"
             raise msg
           end
         end
       end
 
+      # Mock class for DNS Request
       class Mock
-        def create_zone(dns_resource_group, zone_name)
-
+        def create_zone(_resource_group, _name)
+          {
+            "id" => "/subscriptions/########-####-####-####-############/resourceGroups/#{_resource_group}/providers/Microsoft.Network/dnszones/#{_name}",
+            "name" => _name,
+            "type" => "Microsoft.Network/dnszones",
+            "etag" => "00000002-0000-0000-76c2-f7ad90b5d101",
+            "location" => "global",
+            "tags" => {},
+            "properties" =>
+              {
+                "maxNumberOfRecordSets" => 5000,
+                "nameServers" =>
+                [
+                  "ns1-05.azure-dns.com.",
+                  "ns2-05.azure-dns.net.",
+                  "ns3-05.azure-dns.org.",
+                  "ns4-05.azure-dns.info."
+                ],
+                "numberOfRecordSets" => 2,
+                "parentResourceGroupName" => _resource_group
+              }
+          }
         end
       end
     end

data/lib/fog/azurerm/requests/dns/delete_record_set.rb

@@ -1,39 +1,37 @@
 module Fog
   module DNS
     class AzureRM
+      # Real class for DNS Request
       class Real
-        def delete_record_set(record_set_name, dns_resource_group, zone_name, record_type)
-          resource_url = "#{AZURE_RESOURCE}/subscriptions/#{@subscription_id}/resourceGroups/#{dns_resource_group}/providers/Microsoft.Network/dnsZones/#{zone_name}/#{record_type}/#{record_set_name}?api-version=2015-05-04-preview"
-          Fog::Logger.debug "Deleting RecordSet #{record_set_name} of type '#{record_type}' in zone #{zone_name}"
+        def delete_record_set(resource_group, name, zone_name, record_type)
+          resource_url = "#{AZURE_RESOURCE}/subscriptions/#{@subscription_id}/resourceGroups/#{resource_group}/providers/Microsoft.Network/dnsZones/#{zone_name}/#{record_type}/#{name}?api-version=2015-05-04-preview"
+          Fog::Logger.debug "Deleting RecordSet #{name} of type '#{record_type}' in zone #{zone_name}"
 
           begin
             token = Fog::Credentials::AzureRM.get_token(@tenant_id, @client_id, @client_secret)
             RestClient.delete(
-                resource_url,
-                accept: 'application/json',
-                content_type: 'application/json',
-                authorization: token
+              resource_url,
+              accept: 'application/json',
+              content_type: 'application/json',
+              authorization: token
             )
-            Fog::Logger.debug "RecordSet #{record_set_name} Deleted Successfully!"
+            Fog::Logger.debug "RecordSet #{name} Deleted Successfully!"
             true
-          rescue RestClient::Exception => e
-            body = JSON.parse(e.http_body)
-            if body.key?('error')
-              body = body['error']
-              msg = "Exception deleting zone: #{body['code']}, #{body['message']}"
-            else
-              msg = "Exception deleting zone: #{body['code']}, #{body['message']}"
-            end
+          rescue Exception => e
+            Fog::Logger.warning "Exception deleting record set #{name} from resource group #{resource_group}"
+            msg = "AzureDns::RecordSet - Exception is: #{e.message}"
             raise msg
           end
         end
       end
 
+      # Mock class for DNS Request
       class Mock
-        def delete_record_set(record_set_name, dns_resource_group, zone_name, record_type)
-
+        def delete_record_set(_resource_group, _name, _zone_name, _record_type)
+          Fog::Logger.debug "Record Set #{_name} deleted successfully."
+          return true
         end
       end
     end
   end
-end
+end