flydata 0.5.4 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d35ee35146966b2d980eb979c3d36c23ce0c5d36
-  data.tar.gz: 9789cbe06d27163a5afc8cfaf9c44a2bf9de495a
+  metadata.gz: 0882affb434c077a4d37f2127b7ca91aab356603
+  data.tar.gz: 83d402b1b492178d70a4bb6f71a2ada8c515e43e
 SHA512:
-  metadata.gz: 4a7fc6bf22d826f3f7444b0ca85724576f517ded96ed56023a1497b2bc2e2e6e6cc1d561a899d01be0d55b7e1de7cba78aec158e7a78a125b588cd07b7e04479
-  data.tar.gz: f2390bf2dd00890e0cb7e2948d5a7930a2266d3d87aecabe0119e20bb7c97ebe3d3cacf6a6f82348495a9374bd3652ce8fa248d17dda19178128ad68b4bf4dc4
+  metadata.gz: add50b1e166a42d338de4c386272e207bc4089b4ba746cdf52f961f8a344ecd0a676b6411bd0552239b6960d208d51bb9ac13f01448f85704a55a8805ec87104
+  data.tar.gz: 3028bb9b76675e98bf31eac4c6226ceb1abd001f019fa5702403632d29310b79b7e1a7b3f21a5e5bf71146ef3a778dfa62efe9db47c6f792f2552d505245bf44

data/VERSION

@@ -1 +1 @@
-0.5.4
+0.5.5

data/flydata-core/lib/flydata-core/table_def/redshift_table_def.rb

@@ -193,7 +193,7 @@ EOS
 
     case redshift_type
     when 'timestamp'
-      if default_value.upcase == "CURRENT_TIMESTAMP"
+      if /^CURRENT_TIMESTAMP/ === default_value.upcase
         'SYSDATE'
       else
         "'#{self.parse_timestamp(remove_single_quote(default_value))}'"

data/flydata-core/spec/table_def/redshift_table_def_spec.rb

@@ -334,6 +334,12 @@ EOT
           it_behaves_like *examples
         end
 
+        context 'when default_value is CURRENT_TIMESTAMP(6)' do
+          let(:default_value) { 'CURRENT_TIMESTAMP(6)' }
+          let(:default_value_sql) { "SYSDATE" }
+          it_behaves_like *examples
+        end
+
         context 'when default_value is 0000-00-00 00:00:00' do
           let(:default_value) { "'0000-00-00 00:00:00'" }
           let(:default_value_sql) { "'0001-01-01 00:00:00.000000'" }

data/flydata.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: flydata 0.5.4 ruby lib
+# stub: flydata 0.5.5 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "flydata"
-  s.version = "0.5.4"
+  s.version = "0.5.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Koichi Fujikawa", "Masashi Miyazaki", "Matthew Luu", "Mak Inada", "Sriram NS"]
-  s.date = "2015-09-08"
+  s.date = "2015-09-11"
   s.description = "FlyData Agent"
   s.email = "sysadmin@flydata.com"
   s.executables = ["fdmysqldump", "flydata", "serverinfo"]
@@ -101,6 +101,7 @@ Gem::Specification.new do |s|
     "lib/flydata/command/conf.rb",
     "lib/flydata/command/crontab.rb",
     "lib/flydata/command/encrypt.rb",
+    "lib/flydata/command/exclusive_runnable.rb",
     "lib/flydata/command/helper.rb",
     "lib/flydata/command/kill_all.rb",
     "lib/flydata/command/login.rb",
@@ -174,6 +175,7 @@ Gem::Specification.new do |s|
     "spec/flydata/command/conf_spec.rb",
     "spec/flydata/command/crontab_spec.rb",
     "spec/flydata/command/encrypt_spec.rb",
+    "spec/flydata/command/exclusive_runnable_spec.rb",
     "spec/flydata/command/helper_spec.rb",
     "spec/flydata/command/kill_all_spec.rb",
     "spec/flydata/command/login_spec.rb",

data/lib/flydata/command/base.rb

@@ -1,6 +1,7 @@
 require 'slop'
 require 'flydata/api_client'
 require 'flydata/command_loggable'
+require 'flydata/command/exclusive_runnable'
 require 'flydata/preference/data_entry_preference'
 
 
@@ -8,6 +9,9 @@ module Flydata
   module Command
     class Base
       include CommandLoggable
+      include ExclusiveRunnable
+
+      self.exclusive_run_home = FLYDATA_HOME
 
       def initialize(options = Slop.new)
         @api_client = ApiClient.instance

data/lib/flydata/command/exclusive_runnable.rb

@@ -0,0 +1,74 @@
+require 'json'
+
+module Flydata
+module Command
+
+module ExclusiveRunnable
+  def self.included base
+    base.extend ClassMethods
+
+    base.class_variable_set(:@@exclusive_run_home, ENV['HOME'])
+  end
+
+  module ClassMethods
+    def run_exclusive(method, options = {})
+      saved_method = :"__#{method}"
+      alias_method saved_method, method
+
+      define_method(method) do |*args|
+        result = nil
+        exclusive_run_info = nil
+        begin
+          info = self.class.load_exclusive_run_info
+          if info
+            raise "Command `#{info['command']}` is already running.  Wait until the command completes or stop the command.  (pid:#{info['pid']})"
+          end
+          exclusive_run_info = { command: self.class.command(method, options), pid: Process.pid }
+          self.class.save_exclusive_run_info(exclusive_run_info)
+          result = send(saved_method, *args)
+        ensure
+          self.class.delete_exclusive_run_info if exclusive_run_info
+        end
+        result
+      end
+    end
+    def exclusive_run_home
+      @@exclusive_run_home
+    end
+    def exclusive_run_home=(value)
+      @@exclusive_run_home = value
+    end
+    def exclusive_run_info_path
+      File.join(exclusive_run_home, "exclusive_run.info")
+    end
+
+    def load_exclusive_run_info
+      path = exclusive_run_info_path
+      return nil unless File.exists?(path)
+
+      JSON.parse(File.open(path){|f| f.read})
+    end
+
+    def save_exclusive_run_info(info)
+      path = exclusive_run_info_path
+      File.open(path, "w"){|f| f.write(info.to_json)}
+    end
+
+    def delete_exclusive_run_info
+      path = exclusive_run_info_path
+      File.delete(path) if File.exists?(path)
+    end
+
+    def command(subcommand, options = {})
+      return options[:command] if options[:command]
+
+      modules = self.name.split('::')
+
+      cmd = modules.last.downcase
+      subcommand == :run ? cmd : "#{cmd}:#{subcommand}"
+    end
+  end
+end
+
+end
+end

data/lib/flydata/command/helper.rb

@@ -17,7 +17,8 @@ module Flydata
         log: nil,
         log_level: 'info',
         log_rotate_age: 10,
-        log_rotate_size: 10*1024*1024
+        log_rotate_size: 4294967295 # Set 4GB For disabling log rotation
+        #log_rotate_size: 10*1024*1024
       }
 
       def self.slop_start

data/lib/flydata/command/restart.rb

@@ -19,6 +19,7 @@ module Flydata
           helper.restart
         end
       end
+      run_exclusive :run
     end
   end
 end

data/lib/flydata/command/start.rb

@@ -21,6 +21,7 @@ module Flydata
           helper.start
         end
       end
+      run_exclusive :run
     end
   end
 end

data/lib/flydata/command/stop.rb

@@ -18,6 +18,7 @@ module Flydata
           helper.stop
         end
       end
+      run_exclusive :run
     end
   end
 end

data/lib/flydata/command/sync.rb

@@ -1,4 +1,3 @@
-require 'fiber'
 require 'msgpack'
 require 'mysql2'
 require 'rest_client'
@@ -23,6 +22,7 @@ module Flydata
 
     class Sync < Base
       include Helpers
+
       INSERT_PROGRESS_INTERVAL = 1000
       SERVER_DATA_PROCESSING_TIMEOUT = 3600 # seconds
 
@@ -101,6 +101,7 @@ module Flydata
         last_message = ALL_DONE_MESSAGE_TEMPLATE % [redshift_console_url, dashboard_url]
         log_info_stdout(last_message)
       end
+      run_exclusive :run
 
       # Public method
       #  - Called from Sender#start/restart
@@ -136,6 +137,7 @@ EOS
         end
         log_info_stdout("Buffers have been flushed and the sender process has been stopped.")
       end
+      run_exclusive :flush
 
       # Command: flydata sync:reset
       #  - Arguments
@@ -204,7 +206,7 @@ EOS
           sync_fm.table_rev_file_paths(*@input_tables),
           sync_fm.table_ddl_file_paths(*@input_tables)
         ]
-        new_tables_after_reset = @new_tables + @input_tables
+        new_tables_after_reset = @unsynced_tables + @input_tables
         if @input_tables.empty? or @full_tables.empty? or @full_tables.all?{|ft| new_tables_after_reset.include?(ft)}
           delete_files << sync_fm.binlog_path
           delete_files << sync_fm.sent_binlog_path
@@ -215,6 +217,7 @@ EOS
         sync_fm.close
         log_info_stdout("Reset completed successfully.")
       end
+      run_exclusive :reset
 
       # Depricated Command: flydata sync:skip
       # skip initial sync
@@ -228,6 +231,7 @@ EOS
         log_info_stdout("-> #{binlog_path}")
         log_info_stdout("Run 'flydata start' to start continuous sync.")
       end
+      run_exclusive :skip
 
       # Command: flydata sync:generate_table_ddl
       #  - Arguments
@@ -249,10 +253,11 @@ EOS
         Flydata::MysqlCompatibilityCheck.new(dp, de['mysql_data_entry_preference']).check
 
         # Set instance variables
-        set_current_tables(tables, include_invalid_tables: true)
+        set_current_tables(tables, include_all_tables: true)
 
         do_generate_table_ddl(de)
       end
+      run_exclusive :generate_table_ddl
 
       # Command: flydata sync:fix_binlogpos
       #  - Arguments
@@ -301,6 +306,7 @@ EOS
         sync_fm.save_binlog(new_binlog_info)
         log_info_stdout("Done!")
       end
+      run_exclusive :fix_binlogpos
 
       private
 
@@ -317,9 +323,9 @@ EOS
           # #initial_sync knows where to resume from.
           log_info_stdout("Resuming the initial sync...")
           initial_sync(de, options.merge(sync_resumed: true))
-        elsif !@new_tables.empty?
+        elsif !@unsynced_tables.empty?
           show_purpose_name
-          unsynced_table_message = "We've noticed that these tables have not been synced yet: #{@new_tables.join(", ")}\n"
+          unsynced_table_message = "We've noticed that these tables have not been synced yet: #{@unsynced_tables.join(", ")}\n"
           unless @ddl_tables.empty?
             unsynced_table_message <<
             "  WARNING: We've noticed that at least one of these tables have not had their DDL generated yet.\n" +
@@ -847,7 +853,7 @@ EOM
         schema_name = (de['schema_name'] || nil)
         mp = de['mysql_data_entry_preference']
 
-        tables = opts.all_tables? ? @full_tables : (@input_tables.empty? ? @new_tables : @input_tables)
+        tables = opts.all_tables? ? @full_tables : (@input_tables.empty? ? @unsynced_tables : @input_tables)
 
         raise "There are no valid unsynced tables, if you want to just get ddl for all tables, please run \`flydata sync:generate_table_ddl --all-tables\`" if tables.empty?
 
@@ -897,8 +903,7 @@ EOS
           end
         end
 
-        fixed_tables = @invalid_tables & tables_without_error
-        fixed_tables.each {|table| table_validity_hash[table] = nil }
+        tables_without_error.each {|table| table_validity_hash[table] = nil }
         flydata.data_entry.update_table_validity(de['id'], {updated_tables: table_validity_hash}) unless table_validity_hash.empty?
 
         sync_fm = create_sync_file_manager(de)
@@ -944,16 +949,17 @@ Thank you for using FlyData!
         sync_info = sync_fm.load_sync_info
         sync_resumed = options[:resume] && !!sync_info
 
-        @invalid_tables = de['mysql_data_entry_preference']['invalid_tables'] # tables marked as invalid as a result of previous check
-        @full_tables = options[:include_invalid_tables] ? de['mysql_data_entry_preference']['tables'] + @invalid_tables : de['mysql_data_entry_preference']['tables']
+        #full_tables will either include all tables including invalid tables or all valid tables that aren't new tables
+        @full_tables = options[:include_all_tables] ? de['mysql_data_entry_preference']['tables'] + de['mysql_data_entry_preference']['invalid_tables'] :
+                                                      de['mysql_data_entry_preference']['tables'] - de['mysql_data_entry_preference']['new_tables']
 
-        @new_tables = sync_fm.get_new_table_list(@full_tables, "pos")
+        @unsynced_tables = sync_fm.get_new_table_list(@full_tables, "pos") # Get list of tables that do not have a .pos file
         @ddl_tables = sync_fm.get_new_table_list(@full_tables, "generated_ddl")
 
         @input_tables = sync_resumed ? sync_info[:tables] : input_tables
         @input_tables ||= []
         @full_initial_sync = sync_resumed ? sync_info[:initial_sync] :
-                                            (@new_tables == @full_tables)
+                                            (@unsynced_tables == @full_tables)
 
         sync_fm.close
 
@@ -980,7 +986,7 @@ Thank you for using FlyData!
         elsif !@input_tables.empty?
           @input_tables
         else
-          @new_tables
+          @unsynced_tables
         end
       end
 
@@ -991,7 +997,7 @@ Thank you for using FlyData!
         elsif !@input_tables.empty?
           @input_tables
         else
-          @new_tables
+          @unsynced_tables
         end
       end
 
@@ -1012,6 +1018,7 @@ Thank you for using FlyData!
             mp['tables'] = mp['tables'].split(",").uniq
           end
           mp['invalid_tables'] = mp['invalid_tables'].kind_of?(String) ? mp['invalid_tables'].split(",").uniq : []
+          mp['new_tables'] = mp['new_tables'].kind_of?(String) ? mp['new_tables'].split(",").uniq : []
 
           unless mp['ssl_ca_content'].to_s.strip.empty?
             sync_fm = create_sync_file_manager(de)

data/spec/flydata/command/exclusive_runnable_spec.rb

@@ -0,0 +1,129 @@
+require 'spec_helper'
+require 'flydata/command/exclusive_runnable'
+
+module Flydata
+module Command
+
+class Exclusiverunnabletest
+  include ExclusiveRunnable
+
+  def long_running_command
+    sleep 0.2
+    "result1"
+  end
+  run_exclusive :long_running_command
+
+  def normal_method_call
+    "result2"
+  end
+  run_exclusive :normal_method_call
+end
+
+describe Exclusiverunnabletest do
+  let(:subject_object) { described_class.new }
+
+  let(:file_path) { "/tmp" }
+  let(:lock_file) { File.join(file_path, 'exclusive_run.info') }
+  let(:lock_file_content) { { command: 'exclusiverunnabletest:long_running_command', pid: 234 } }
+
+  before do
+    described_class.exclusive_run_home = file_path
+  end
+
+  describe '#normal_method_call' do
+    subject { subject_object.normal_method_call }
+    it "runs the method body normally" do
+      is_expected.to eq "result2"
+    end
+
+    context "when a lock file already exists" do
+      before do
+        File.open(lock_file, "w") {|f| f.write(lock_file_content)}
+      end
+
+      it "does not delete the lock file" do
+        expect{ subject }.to raise_error
+
+        expect(File.exists?(lock_file)).to eq true
+      end
+
+      after do
+        File.delete(lock_file) if File.exists?(lock_file)
+      end
+    end
+  end
+
+  describe '#long_running_command' do
+    subject { subject_object.long_running_command }
+    context 'run alone' do
+      context "check while the command is running" do
+        it "creates a lock file" do
+          th = Thread.new{ subject }
+
+          sleep 0.1
+
+          expect(File.exists?(lock_file)).to eq true
+
+          th.join
+        end
+      end
+      context "check after the command is finished" do
+        it "creates a lock file but it's gone" do
+          th = Thread.new{ subject }
+
+          th.join
+
+          expect(File.exists?(lock_file)).to eq false
+        end
+      end
+    end
+
+    context 'run two commands concurrently' do
+      it "raises an error for the second command" do
+        th = Thread.new{ subject }
+        sleep 0.1
+        expect{ subject_object.normal_method_call }.to raise_exception(
+         /`exclusiverunnabletest:long_running_command` is already running\..*\(pid: *[0-9]+\)/)
+
+        th.join
+      end
+    end
+    context 'run two commands sequentially' do
+      it "runs both commands successfully" do
+        th = Thread.new{ subject }
+
+        th.join
+
+        expect( subject_object.normal_method_call ).to eq "result2"
+      end
+    end
+  end
+
+  describe '.command' do
+    subject { described_class.command(method_symbol, options) }
+
+    let(:options) { {} }
+    context 'with :run' do
+      let(:method_symbol) { :run }
+      it 'uses the class name as the command' do
+        is_expected.to eq "exclusiverunnabletest"
+      end
+    end
+    context 'with a method' do
+      let(:method_symbol) { :a_method }
+      it 'uses the class name and the method as the command ' do
+        is_expected.to eq "exclusiverunnabletest:a_method"
+      end
+    end
+    context 'with a :command option' do
+      let(:options) { { command: 'another_command' } }
+      let(:method_symbol) { :a_method }
+      it 'uses the command given as an option' do
+        is_expected.to eq "another_command"
+      end
+    end
+  end
+end
+
+end
+end

data/spec/flydata/command/sync_spec.rb

@@ -33,8 +33,9 @@ module Flydata
         "data_port_key"=>"a458c641",
         "mysql_data_entry_preference" =>
           { "host"=>"localhost", "port"=>3306, "username"=>"masashi",
-            "password"=>"welcome", "database"=>"sync_test", "tables"=>["table1", "table2"],
+            "password"=>"welcome", "database"=>"sync_test", "tables"=>["table1", "table2", "table4"],
             "invalid_tables"=>["table3"],
+            "new_tables"=>["table4"],
             "mysqldump_dir"=>default_mysqldump_dir, "forwarder" => "tcpforwarder",
             "data_servers"=>"localhost:9905" }
          }
@@ -91,8 +92,9 @@ module Flydata
         let (:db_byte) { 1 }
         let (:disk_byte) { 100 }
         before do
-          expect(subject).to receive(:flydata).and_return(flydata)
+          expect(subject).to receive(:flydata).and_return(flydata).at_least(:once)
           expect(flydata).to receive(:data_port).and_return(dp)
+          allow(flydata).to receive(:data_entry).and_return(default_data_entry)
           expect(dp).to receive(:get).and_return(default_data_port)
           allow(File).to receive(:exists?).and_return(false)
           expect(default_sync_fm).to receive(:load_dump_pos).and_return(default_dump_pos)
@@ -110,7 +112,7 @@ module Flydata
           before do
             expect(default_sync_fm).to receive(:save_sync_info).once
             expect(subject).to receive(:free_disk_space).and_return(disk_byte)
-          expect(File).to receive(:dirname)
+            expect(File).to receive(:dirname)
           end
           it 'will export to dump file' do
             expect(subject).to receive(:call_block_or_return_io)
@@ -140,7 +142,7 @@ module Flydata
         before do
           allow(subject).to receive(:data_entry).and_return(default_data_entry)
           allow_any_instance_of(Flydata::Api::DataEntry).to receive(:update_table_validity).and_return(true)
-          subject.send(:set_current_tables, nil, include_invalid_tables: true)
+          subject.send(:set_current_tables, nil, include_all_tables: true)
         end
         shared_examples 'throws an error' do
           it "throws an error" do
@@ -152,7 +154,7 @@ module Flydata
         context 'with full options' do
           it 'issues mysqldump command with expected parameters' do
             expect(Open3).to receive(:popen3).with(
-             'mysqldump -h localhost -P 3306 -umasashi -p"welcome" --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table3')
+             'mysqldump -h localhost -P 3306 -umasashi -p"welcome" --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table4 table3')
             subject.send(:do_generate_table_ddl, default_data_entry)
           end
         end
@@ -174,7 +176,7 @@ module Flydata
           end
           it "uses the default port" do
             expect(Open3).to receive(:popen3).with(
-             'mysqldump -h localhost -umasashi -p"welcome" --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table3')
+             'mysqldump -h localhost -umasashi -p"welcome" --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table4 table3')
             subject.send(:do_generate_table_ddl, default_data_entry)
           end
         end
@@ -184,7 +186,7 @@ module Flydata
           end
           it "uses the specified port" do
             expect(Open3).to receive(:popen3).with(
-             'mysqldump -h localhost -P 1234 -umasashi -p"welcome" --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table3')
+             'mysqldump -h localhost -P 1234 -umasashi -p"welcome" --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table4 table3')
             subject.send(:do_generate_table_ddl, default_data_entry)
           end
         end
@@ -206,7 +208,7 @@ module Flydata
           end
           it "call mysqldump without MYSQL_PW set" do
             expect(Open3).to receive(:popen3).with(
-             'mysqldump -h localhost -P 3306 -umasashi --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table3')
+             'mysqldump -h localhost -P 3306 -umasashi --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table4 table3')
             subject.send(:do_generate_table_ddl, default_data_entry)
           end
         end
@@ -217,7 +219,7 @@ module Flydata
           end
           it "call mysqldump with MYSQL_PW set with correct symbols" do
             expect(Open3).to receive(:popen3).with(
-             'mysqldump -h localhost -P 3306 -umasashi -p"welcome&!@^@#^" --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table3')
+             'mysqldump -h localhost -P 3306 -umasashi -p"welcome&!@^@#^" --default-character-set=utf8 --protocol=tcp -d sync_test table1 table2 table4 table3')
             subject.send(:do_generate_table_ddl, default_data_entry)
           end
         end
@@ -238,8 +240,9 @@ module Flydata
           before do
             default_data_entry['mysql_data_entry_preference']['tables'] = []
             default_data_entry['mysql_data_entry_preference']['invalid_tables'] = []
+            default_data_entry['mysql_data_entry_preference']['new_tables'] = []
             allow(sync_cmd).to receive(:data_entry).and_return(default_data_entry)
-            sync_cmd.send(:set_current_tables, nil, include_invalid_tables: true)
+            sync_cmd.send(:set_current_tables, nil, include_all_tables: true)
           end
           it 'should raise error' do
             expect{sync_cmd.send(:do_generate_table_ddl, default_data_entry)}.to raise_error

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flydata
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.5.5
 platform: ruby
 authors:
 - Koichi Fujikawa
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-08 00:00:00.000000000 Z
+date: 2015-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -538,6 +538,7 @@ files:
 - lib/flydata/command/conf.rb
 - lib/flydata/command/crontab.rb
 - lib/flydata/command/encrypt.rb
+- lib/flydata/command/exclusive_runnable.rb
 - lib/flydata/command/helper.rb
 - lib/flydata/command/kill_all.rb
 - lib/flydata/command/login.rb
@@ -611,6 +612,7 @@ files:
 - spec/flydata/command/conf_spec.rb
 - spec/flydata/command/crontab_spec.rb
 - spec/flydata/command/encrypt_spec.rb
+- spec/flydata/command/exclusive_runnable_spec.rb
 - spec/flydata/command/helper_spec.rb
 - spec/flydata/command/kill_all_spec.rb
 - spec/flydata/command/login_spec.rb