fluoride-analyzer 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1637ac26ca7cc98d39f42c0fc3efd8c4ca4929ed
-  data.tar.gz: fae4b689619bb34b1216d27c9fa6b5c4c811acdd
+  metadata.gz: 27aad46700d207c15bb61903807aa942698295d5
+  data.tar.gz: 01de20a80c6011090dcc43bcc9ec29b0a42d628f
 SHA512:
-  metadata.gz: 226647f9f585b51ce79feefe029c0b00da5b26b1014d6b80d3c31e114c9b7f11fd2804b22c6c497371592b47c9012a73b1b733cc4567e9cbfd0258a4520d382b
-  data.tar.gz: b40af17fbba3a67c0218ac27487ed80982e39c2965e7c8d345713f3ef4c194a1e272b3c680951d29f64b9de82b52f3612003d3cc07bcfcda0833d3a479aac0b3
+  metadata.gz: 8a1e63ea059d32e68d735b242d44e2d21e80ee4e56791ce69c34231eb5996430a0c915bed12f89f4c85000a7cf93baf27cbcf333b0348d7855f0f56f4c54bfbe
+  data.tar.gz: ed9f524f94a23abfe1e87488bda04425332d04de0c0f914fb7ab18d1ba2dbe1f4ce1017e4b8c7895c890b2084cae48d2bce20258dabbb4eca9274e751cd6f5de

data/lib/fluoride-analyzer/group-collapser.rb

@@ -44,7 +44,8 @@ module Fluoride::Analyzer
       end
 
       reduced_hash.each do |(path, query_params), requests|
-      yield GroupContext.new(method, status, requests, path, query_params)
+        next if status == 304
+        yield GroupContext.new(method, status, requests, path, query_params)
       end
     end
   end

data/lib/fluoride-analyzer/group-context.rb

@@ -48,12 +48,18 @@ module Fluoride::Analyzer
     end
 
     def redirect_path
-      request['redirect_location'].sub(%r[^https?://#{request['host']}], '')
+      if request['redirect_location'].nil?
+        pp request
+        pp response
+        exit
+      else
+        request['redirect_location'].sub(%r[^https?://#{request['host']}], '')
+      end
     end
 
     def test_result
       case @status_code.to_i
-      when 300..399
+      when 300..303,305..399
         ["response.should redirect_to(\"#{redirect_path}\")"]
       else
         ["response.should be_success", "response.status.should == 200"]

data/lib/fluoride-analyzer/parser.rb

@@ -98,6 +98,18 @@ module Fluoride::Analyzer
     def patterner
       @patterner ||= Patterner.for(Rails.application.routes)
     end
+    attr_writer :patterner
+
+    def warnings
+      @warnings ||= Hash.new do |h,k|
+        warn k
+        h[k] = true
+      end
+    end
+
+    def warning(message)
+      warnings[message]
+    end
 
     def collect_record(file, record, index)
       if exclude?(record)
@@ -124,11 +136,12 @@ module Fluoride::Analyzer
 
       if pattern.path_spec == :unrecognized
         @counts[:no_matching_route] += 1
-        warn "Unrecognized route: #{record['request']['path'].inspect}"
+        warning "Unrecognized route: #{record['request']['method']} #{record['request']['path'].inspect}"
+        return
       else
         route_path = pattern.path_spec
         path_params = Hash[pattern.segment_keys.map do |key|
-          [key, params[key]]
+          [key, pattern.params[key]]
         end]
       end
 

data/lib/fluoride-analyzer/patterner.rb

@@ -31,7 +31,7 @@ module Fluoride::Analyzer
     end
     attr_reader :rails_routes
 
-    def build_request(result_env)
+    def build_request(request_env)
       ActionDispatch::Request.new(base_env.merge(request_env))
     end
 
@@ -85,6 +85,7 @@ module Fluoride::Analyzer
 
       def build(env)
         req = build_request(env)
+
         pattern = nil
         route_set.recognize(req) do |route, matches, params|
           rails_route = route_map[route]
@@ -97,7 +98,14 @@ module Fluoride::Analyzer
             path_spec = rails_route.path.spec.to_s
             segment_keys = rails_route.segment_keys
           end
-
+#          require 'pp'
+#          puts "\n#{__FILE__}:#{__LINE__} => #{{
+#            :req => req, :route => route, :matches => matches, :params => params,
+#              :rails_route => rails_route,
+#              :path_spec => path_spec,
+#              :segment_keys => segment_keys
+#          }.pretty_inspect}"
+#
           pattern = RoutePattern.new(route, matches, params, path_spec, segment_keys)
         end
         if pattern.nil?

data/lib/fluoride-analyzer/request-templater.rb

@@ -13,13 +13,18 @@ module Fluoride::Analyzer
     end
 
     def go
+      require 'pp'
       results.each_pair do |pattern, statuses|
-        context = PatternContext.new(pattern, statuses)
+        if pattern.nil?
+          pp statuses
+        else
+          context = PatternContext.new(pattern, statuses)
 
-        path = File.join(context.filename)
-        contents = template.result(context.context_binding)
+          path = File.join(context.filename)
+          contents = template.result(context.context_binding)
 
-        yield(path, contents)
+          yield(path, contents)
+        end
       end
     end
   end

data/lib/fluoride-analyzer/tasklib.rb

@@ -38,7 +38,7 @@ module Fluoride::Analyzer
 
           recordings_list.find_all do |prereq|
             next unless File.file?(prereq) && __FILE__ != prereq
-            parser.parse_stream(File.read(prereq))
+            parser.parse_stream(prereq, File.read(prereq))
           end
 
           parser.limit = limit

data/spec/result-parser.rb

@@ -107,4 +107,56 @@ describe Fluoride::Analyzer::Parser do
   it "should be a well formatted version of the results" do
     expect(results).to match("/" => {"GET" => {200 => match([ a_hash_including("path" => "/") ])}})
   end
+
+  xdescribe "for Rails3" do
+    let :route_set do
+      double("Rails Route set")
+    end
+
+    let :route do
+      double("Rails route")
+    end
+
+    let :matches do
+      double("match list")
+    end
+
+    let :params do
+      double("route params")
+    end
+
+    let :routes do
+      double("Rails routes").tap do |routes|
+        allow(routes).to receive(:set).and_return(route_set)
+        allow(routes).to receive(:recognize).and_return([[route, matches, params]]).any_number_of_times
+      end
+    end
+
+    let :patterner do
+      Fluoride::Analyzer::Patterner::Rails3.new(routes)
+    end
+
+    let :parser do
+      Fluoride::Analyzer::Parser.new.tap do |parser|
+        parser.patterner = patterner
+        parser.parse_stream("test-file.yaml", requests_stream)
+      end
+    end
+
+    it "should have a Rails3 patterner" do
+      expect(parser.patterner.class.name).to match(/Rails3/)
+    end
+
+    it "should have excluded 1 request" do
+      expect(parser.counts[:excluded]).to eq(1)
+    end
+
+    it "should have 0 unrecognized requests" do
+      expect(parser.counts[:unrecognized]).to eq(0)
+    end
+
+    it "should be a well formatted version of the results" do
+      expect(results).to match("/" => {"GET" => {200 => match([ a_hash_including("path" => "/") ])}})
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fluoride-analyzer
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Judson Lester
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-14 00:00:00.000000000 Z
+date: 2015-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mattock
@@ -82,7 +82,7 @@ rdoc_options:
 - --main
 - doc/README
 - --title
-- fluoride-analyzer-0.0.7 Documentation
+- fluoride-analyzer-0.0.8 Documentation
 require_paths:
 - lib/
 required_ruby_version: !ruby/object:Gem::Requirement