fluentd 1.16.0 → 1.16.7

data/test/plugin_helper/test_server.rb

@@ -15,7 +15,7 @@ class ServerPluginHelperTest < Test::Unit::TestCase
   TMP_DIR = File.expand_path(File.dirname(__FILE__) + "/../tmp/plugin_helper_server")
 
   setup do
-    @port = unused_port
+    @port = unused_port(protocol: :tcp)
     if Fluent.windows?
       @socket_manager_server = ServerEngine::SocketManager::Server.open
       @socket_manager_path = @socket_manager_server.path
@@ -29,6 +29,7 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     ENV['SERVERENGINE_SOCKETMANAGER_PATH'] = @socket_manager_path.to_s
 
     @d = Dummy.new
+    @d.under_plugin_development = true
     @d.start
     @d.after_start
   end
@@ -232,11 +233,12 @@ class ServerPluginHelperTest < Test::Unit::TestCase
       # 'server_create_connection tcp' => [:server_create_connection, :unix],
     )
     test 'raise error if udp options specified for tcp/tls/unix' do |(m, proto)|
+      port = unused_port(protocol: proto)
       assert_raise ArgumentError do
-        @d.__send__(m, :myserver, @port, proto: proto, max_bytes: 128){|x| x }
+        @d.__send__(m, :myserver, port, proto: proto, max_bytes: 128){|x| x }
       end
       assert_raise ArgumentError do
-        @d.__send__(m, :myserver, @port, proto: proto, flags: 1){|x| x }
+        @d.__send__(m, :myserver, port, proto: proto, flags: 1){|x| x }
       end
     end
 
@@ -244,8 +246,9 @@ class ServerPluginHelperTest < Test::Unit::TestCase
       'server_create udp' => [:server_create, :udp],
     )
     test 'raise error if tcp/tls options specified for udp' do |(m, proto)|
+      port = unused_port(protocol: proto)
       assert_raise(ArgumentError.new("BUG: linger_timeout is available for tcp/tls")) do
-        @d.__send__(m, :myserver, @port, proto: proto, linger_timeout: 1, max_bytes: 128){|x| x }
+        @d.__send__(m, :myserver, port, proto: proto, linger_timeout: 1, max_bytes: 128){|x| x }
       end
     end
 
@@ -253,8 +256,9 @@ class ServerPluginHelperTest < Test::Unit::TestCase
       'server_create udp' => [:server_create, :udp],
     )
     test 'raise error if tcp/tls/unix backlog options specified for udp' do |(m, proto)|
+      port = unused_port(protocol: proto)
       assert_raise(ArgumentError.new("BUG: backlog is available for tcp/tls")) do
-        @d.__send__(m, :myserver, @port, proto: proto, backlog: 500){|x| x }
+        @d.__send__(m, :myserver, port, proto: proto, backlog: 500){|x| x }
       end
     end
 
@@ -262,8 +266,9 @@ class ServerPluginHelperTest < Test::Unit::TestCase
       'server_create udp' => [:server_create, :udp],
     )
     test 'raise error if tcp/tls send_keepalive_packet option is specified for udp' do |(m, proto)|
+      port = unused_port(protocol: proto)
       assert_raise(ArgumentError.new("BUG: send_keepalive_packet is available for tcp/tls")) do
-        @d.__send__(m, :myserver, @port, proto: proto, send_keepalive_packet: true){|x| x }
+        @d.__send__(m, :myserver, port, proto: proto, send_keepalive_packet: true){|x| x }
       end
     end
 
@@ -275,8 +280,9 @@ class ServerPluginHelperTest < Test::Unit::TestCase
       # 'server_create_connection unix' => [:server_create_connection, :unix, {}],
     )
     test 'raise error if tls options specified for tcp/udp/unix' do |(m, proto, kwargs)|
+      port = unused_port(protocol: proto)
       assert_raise(ArgumentError.new("BUG: tls_options is available only for tls")) do
-        @d.__send__(m, :myserver, @port, proto: proto, tls_options: {}, **kwargs){|x| x }
+        @d.__send__(m, :myserver, port, proto: proto, tls_options: {}, **kwargs){|x| x }
       end
     end
 
@@ -288,7 +294,8 @@ class ServerPluginHelperTest < Test::Unit::TestCase
       'server_create_connection tls' => [:server_create_connection, :tls, {tls_options: {insecure: true}}],
     )
     test 'can bind specified IPv4 address' do |(m, proto, kwargs)|
-      @d.__send__(m, :myserver, @port, proto: proto, bind: "127.0.0.1", **kwargs){|x| x }
+      port = unused_port(protocol: proto)
+      @d.__send__(m, :myserver, port, proto: proto, bind: "127.0.0.1", **kwargs){|x| x }
       assert_equal "127.0.0.1", @d._servers.first.bind
       assert_equal "127.0.0.1", @d._servers.first.server.instance_eval{ instance_variable_defined?(:@listen_socket) ? @listen_socket : @_io }.addr[3]
     end
@@ -302,7 +309,8 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     )
     test 'can bind specified IPv6 address' do |(m, proto, kwargs)| # if available
       omit "IPv6 unavailable here" unless ipv6_enabled?
-      @d.__send__(m, :myserver, @port, proto: proto, bind: "::1", **kwargs){|x| x }
+      port = unused_port(protocol: proto)
+      @d.__send__(m, :myserver, port, proto: proto, bind: "::1", **kwargs){|x| x }
       assert_equal "::1", @d._servers.first.bind
       assert_equal "::1", @d._servers.first.server.instance_eval{ instance_variable_defined?(:@listen_socket) ? @listen_socket : @_io }.addr[3]
     end
@@ -319,10 +327,11 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     test 'can create 2 or more servers which share same bind address and port if shared option is true' do |(m, proto, kwargs)|
       begin
         d2 = Dummy.new; d2.start; d2.after_start
+        port = unused_port(protocol: proto)
 
         assert_nothing_raised do
-          @d.__send__(m, :myserver, @port, proto: proto, **kwargs){|x| x }
-          d2.__send__(m, :myserver, @port, proto: proto, **kwargs){|x| x }
+          @d.__send__(m, :myserver, port, proto: proto, **kwargs){|x| x }
+          d2.__send__(m, :myserver, port, proto: proto, **kwargs){|x| x }
         end
       ensure
         d2.stop; d2.before_shutdown; d2.shutdown; d2.after_shutdown; d2.close; d2.terminate
@@ -343,12 +352,13 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     test 'cannot create 2 or more servers using same bind address and port if shared option is false' do |(m, proto, kwargs)|
       begin
         d2 = Dummy.new; d2.start; d2.after_start
+        port = unused_port(protocol: proto)
 
         assert_nothing_raised do
-          @d.__send__(m, :myserver, @port, proto: proto, shared: false, **kwargs){|x| x }
+          @d.__send__(m, :myserver, port, proto: proto, shared: false, **kwargs){|x| x }
         end
         assert_raise(Errno::EADDRINUSE, Errno::EACCES) do
-          d2.__send__(m, :myserver, @port, proto: proto, **kwargs){|x| x }
+          d2.__send__(m, :myserver, port, proto: proto, **kwargs){|x| x }
         end
       ensure
         d2.stop; d2.before_shutdown; d2.shutdown; d2.after_shutdown; d2.close; d2.terminate
@@ -364,16 +374,18 @@ class ServerPluginHelperTest < Test::Unit::TestCase
       # 'unix' => [:unix, {}],
     )
     test 'raise error if block argument is not specified or too many' do |(proto, kwargs)|
+      port = unused_port(protocol: proto)
       assert_raise(ArgumentError.new("BUG: block must have 1 or 2 arguments")) do
-        @d.server_create(:myserver, @port, proto: proto, **kwargs){ 1 }
+        @d.server_create(:myserver, port, proto: proto, **kwargs){ 1 }
       end
       assert_raise(ArgumentError.new("BUG: block must have 1 or 2 arguments")) do
-        @d.server_create(:myserver, @port, proto: proto, **kwargs){|sock, conn, what_is_this| 1 }
+        @d.server_create(:myserver, port, proto: proto, **kwargs){|sock, conn, what_is_this| 1 }
       end
     end
 
     test 'creates udp server if specified in proto' do
-      @d.server_create(:myserver, @port, proto: :udp, max_bytes: 512){|x| x }
+      port = unused_port(protocol: :udp)
+      @d.server_create(:myserver, port, proto: :udp, max_bytes: 512){|x| x }
 
       created_server_info = @d._servers.first
       assert_equal :udp, created_server_info.proto
@@ -586,7 +598,8 @@ class ServerPluginHelperTest < Test::Unit::TestCase
   sub_test_case '#server_create_udp' do
     test 'can accept all keyword arguments valid for udp server' do
       assert_nothing_raised do
-        @d.server_create_udp(:s, @port, bind: '127.0.0.1', shared: false, resolve_name: true, max_bytes: 100, flags: 1) do |data, conn|
+        port = unused_port(protocol: :udp)
+        @d.server_create_udp(:s, port, bind: '127.0.0.1', shared: false, resolve_name: true, max_bytes: 100, flags: 1) do |data, conn|
           # ...
         end
       end
@@ -594,14 +607,15 @@ class ServerPluginHelperTest < Test::Unit::TestCase
 
     test 'creates a udp server just to read data' do
       received = ""
-      @d.server_create_udp(:s, @port, max_bytes: 128) do |data|
+      port = unused_port(protocol: :udp)
+      @d.server_create_udp(:s, port, max_bytes: 128) do |data|
         received << data
       end
       bind_port = unused_port(protocol: :udp, bind: "127.0.0.1")
       3.times do
         sock = UDPSocket.new(Socket::AF_INET)
         sock.bind("127.0.0.1", bind_port)
-        sock.connect("127.0.0.1", @port)
+        sock.connect("127.0.0.1", port)
         sock.puts "yay"
         sock.puts "foo"
         sock.close
@@ -613,16 +627,17 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     test 'creates a udp server to read and write data' do
       received = ""
       responses = []
-      @d.server_create_udp(:s, @port, max_bytes: 128) do |data, sock|
+      port = unused_port(protocol: :udp)
+      @d.server_create_udp(:s, port, max_bytes: 128) do |data, sock|
         received << data
         sock.write "ack\n"
       end
-      bind_port = unused_port
+      bind_port = unused_port(protocol: :udp)
       3.times do
         begin
           sock = UDPSocket.new(Socket::AF_INET)
           sock.bind("127.0.0.1", bind_port)
-          sock.connect("127.0.0.1", @port)
+          sock.connect("127.0.0.1", port)
           th = Thread.new do
             while true
               begin
@@ -653,11 +668,12 @@ class ServerPluginHelperTest < Test::Unit::TestCase
 
       received = ""
       responses = []
-      @d.server_create_udp(:s, @port, bind: "::1", max_bytes: 128) do |data, sock|
+      port = unused_port(protocol: :udp)
+      @d.server_create_udp(:s, port, bind: "::1", max_bytes: 128) do |data, sock|
         received << data
         sock.write "ack\n"
       end
-      bind_port = unused_port
+      bind_port = unused_port(protocol: :udp)
       3.times do
         begin
           sock = UDPSocket.new(Socket::AF_INET6)
@@ -666,7 +682,7 @@ class ServerPluginHelperTest < Test::Unit::TestCase
             responses << sock.recv(16)
             true
           end
-          sock.connect("::1", @port)
+          sock.connect("::1", port)
           sock.write "yay\nfoo\n"
           th.join(5)
         ensure
@@ -681,13 +697,14 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     test 'does not resolve name of client address in default' do
       received = ""
       sources = []
-      @d.server_create_udp(:s, @port, max_bytes: 128) do |data, sock|
+      port = unused_port(protocol: :udp)
+      @d.server_create_udp(:s, port, max_bytes: 128) do |data, sock|
         received << data
         sources << sock.remote_host
       end
       3.times do
         sock = UDPSocket.new(Socket::AF_INET)
-        sock.connect("127.0.0.1", @port)
+        sock.connect("127.0.0.1", port)
         sock.puts "yay"
         sock.close
       end
@@ -701,13 +718,14 @@ class ServerPluginHelperTest < Test::Unit::TestCase
 
       received = ""
       sources = []
-      @d.server_create_udp(:s, @port, resolve_name: true, max_bytes: 128) do |data, sock|
+      port = unused_port(protocol: :udp)
+      @d.server_create_udp(:s, port, resolve_name: true, max_bytes: 128) do |data, sock|
         received << data
         sources << sock.remote_host
       end
       3.times do
         sock = UDPSocket.new(Socket::AF_INET)
-        sock.connect("127.0.0.1", @port)
+        sock.connect("127.0.0.1", port)
         sock.puts "yay"
         sock.close
       end
@@ -719,7 +737,8 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     test 'raises error if plugin registers data callback for connection object from #server_create' do
       received = ""
       errors = []
-      @d.server_create_udp(:s, @port, max_bytes: 128) do |data, sock|
+      port = unused_port(protocol: :udp)
+      @d.server_create_udp(:s, port, max_bytes: 128) do |data, sock|
         received << data
         begin
           sock.data{|d| received << d.upcase }
@@ -728,7 +747,7 @@ class ServerPluginHelperTest < Test::Unit::TestCase
         end
       end
       sock = UDPSocket.new(Socket::AF_INET)
-      sock.connect("127.0.0.1", @port)
+      sock.connect("127.0.0.1", port)
       sock.write "foo\n"
       sock.close
 
@@ -741,7 +760,8 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     test 'raise error if plugin registers write_complete callback for udp' do
       received = ""
       errors = []
-      @d.server_create_udp(:s, @port, max_bytes: 128) do |data, sock|
+      port = unused_port(protocol: :udp)
+      @d.server_create_udp(:s, port, max_bytes: 128) do |data, sock|
         received << data
         begin
           sock.on(:write_complete){|conn| "" }
@@ -750,7 +770,7 @@ class ServerPluginHelperTest < Test::Unit::TestCase
         end
       end
       sock = UDPSocket.new(Socket::AF_INET)
-      sock.connect("127.0.0.1", @port)
+      sock.connect("127.0.0.1", port)
       sock.write "foo\n"
       sock.close
 
@@ -763,7 +783,8 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     test 'raises error if plugin registers close callback for udp' do
       received = ""
       errors = []
-      @d.server_create_udp(:s, @port, max_bytes: 128) do |data, sock|
+      port = unused_port(protocol: :udp)
+      @d.server_create_udp(:s, port, max_bytes: 128) do |data, sock|
         received << data
         begin
           sock.on(:close){|d| "" }
@@ -772,7 +793,7 @@ class ServerPluginHelperTest < Test::Unit::TestCase
         end
       end
       sock = UDPSocket.new(Socket::AF_INET)
-      sock.connect("127.0.0.1", @port)
+      sock.connect("127.0.0.1", port)
       sock.write "foo\n"
       sock.close
 
@@ -785,15 +806,62 @@ class ServerPluginHelperTest < Test::Unit::TestCase
     test 'can bind IPv4 / IPv6 together' do
       omit "IPv6 unavailable here" unless ipv6_enabled?
 
+      port = unused_port(protocol: :udp)
       assert_nothing_raised do
-        @d.server_create_udp(:s_ipv4_udp, @port, bind: '0.0.0.0', shared: false, max_bytes: 128) do |data, sock|
+        @d.server_create_udp(:s_ipv4_udp, port, bind: '0.0.0.0', shared: false, max_bytes: 128) do |data, sock|
           # ...
         end
-        @d.server_create_udp(:s_ipv6_udp, @port, bind: '::', shared: false, max_bytes: 128) do |data, sock|
+        @d.server_create_udp(:s_ipv6_udp, port, bind: '::', shared: false, max_bytes: 128) do |data, sock|
           # ...
         end
       end
     end
+
+    sub_test_case 'over max_bytes' do
+      data("cut off on Non-Windows", { max_bytes: 32, records: ["a" * 40], expected: ["a" * 32] }, keep: true) unless Fluent.windows?
+      data("drop on Windows", { max_bytes: 32, records: ["a" * 40], expected: [] }, keep: true) if Fluent.windows?
+      test 'with sock' do |data|
+        max_bytes, records, expected = data.values
+
+        actual_records = []
+        port = unused_port(protocol: :udp)
+        @d.server_create_udp(:myserver, port, max_bytes: max_bytes) do |data, sock|
+          actual_records << data
+        end
+
+        open_client(:udp, "127.0.0.1", port) do |sock|
+          records.each do |record|
+            sock.send(record, 0)
+          end
+        end
+
+        waiting(10) { sleep 0.1 until actual_records.size >= expected.size }
+        sleep 1 if expected.size == 0 # To confirm no record recieved.
+
+        assert_equal expected, actual_records
+      end
+
+      test 'without sock' do |data|
+        max_bytes, records, expected = data.values
+
+        actual_records = []
+        port = unused_port(protocol: :udp)
+        @d.server_create_udp(:myserver, port, max_bytes: max_bytes) do |data|
+          actual_records << data
+        end
+
+        open_client(:udp, "127.0.0.1", port) do |sock|
+          records.each do |record|
+            sock.send(record, 0)
+          end
+        end
+
+        waiting(10) { sleep 0.1 until actual_records.size >= expected.size }
+        sleep 1 if expected.size == 0 # To confirm no record recieved.
+
+        assert_equal expected, actual_records
+      end
+    end
   end
 
   module CertUtil
@@ -1284,7 +1352,7 @@ class ServerPluginHelperTest < Test::Unit::TestCase
           # OpenSSL 1.1.1: "TLSv1.2"
           if tls_version == "TLSv1/SSLv3" || tls_version == "TLSv1.2"
             matched = true
-            unless cipher_name.match(/#{conf.ciphers}/)
+            unless cipher_name.match?(/#{conf.ciphers}/)
               matched = false
               break
             end
@@ -1575,6 +1643,10 @@ class ServerPluginHelperTest < Test::Unit::TestCase
 
   def open_client(proto, addr, port)
     client = case proto
+             when :udp
+               c = UDPSocket.open
+               c.connect(addr, port)
+               c
              when :tcp
                TCPSocket.open(addr, port)
              when :tls

data/test/plugin_helper/test_socket.rb

@@ -11,7 +11,7 @@ class SocketHelperTest < Test::Unit::TestCase
   CERT_CHAINS_DIR = File.expand_path(File.dirname(__FILE__) + '/data/cert/cert_chains')
 
   def setup
-    @port = unused_port
+    @port = unused_port(protocol: :tcp)
   end
 
   def teardown

data/test/test_config.rb

@@ -167,6 +167,7 @@ class ConfigTest < Test::Unit::TestCase
             tag: tag.dummy
         - source:
             $type: tcp
+            $log_level: info
             tag: tag.tcp
             parse:
               $arg:
@@ -176,6 +177,7 @@ class ConfigTest < Test::Unit::TestCase
         - match:
             $tag: tag.*
             $type: stdout
+            $log_level: debug
             buffer:
               $type: memory
               flush_interval: 1s
@@ -208,10 +210,12 @@ class ConfigTest < Test::Unit::TestCase
           'tag.dummy',
           'tcp',
           'tag.tcp',
+          'info',
           'none',
           'why.parse.section.doesnot.have.arg,huh',
           'stdout',
           'tag.*',
+          'debug',
           'null',
           '**',
           '@FLUENT_LOG',
@@ -224,10 +228,12 @@ class ConfigTest < Test::Unit::TestCase
           dummy_source_conf['tag'],
           tcp_source_conf['@type'],
           tcp_source_conf['tag'],
+          tcp_source_conf['@log_level'],
           parse_tcp_conf['@type'],
           parse_tcp_conf.arg,
           match_conf['@type'],
           match_conf.arg,
+          match_conf['@log_level'],
           fluent_log_conf['@type'],
           fluent_log_conf.arg,
           label_conf.arg,

data/test/test_event_router.rb

@@ -175,7 +175,7 @@ class EventRouterTest < ::Test::Unit::TestCase
       test "don't call default collector when tag matched" do
         event_router.add_rule('test', output)
         assert_rr do
-          dont_allow(default_collector).emit_events('test', is_a(OneEventStream))
+          mock(default_collector).emit_events('test', is_a(OneEventStream)).never
           event_router.emit('test', Engine.now, 'k' => 'v')
         end
         # check emit handler doesn't catch rr error
@@ -201,7 +201,7 @@ class EventRouterTest < ::Test::Unit::TestCase
         event_router.add_rule('test', filter)
 
         assert_rr do
-          dont_allow(filter).filter_stream('test', is_a(OneEventStream)) { events }
+          mock(filter).filter_stream('test', is_a(OneEventStream)).never
           event_router.emit('foo', Engine.now, 'k' => 'v')
         end
       end

data/test/test_log.rb

@@ -472,6 +472,43 @@ class LogTest < Test::Unit::TestCase
       ]
       assert_equal(expected, log.out.logs)
     end
+
+    def test_reject_on_max_size
+      ignore_same_log_interval = 10
+
+      logger = Fluent::Log.new(
+        ServerEngine::DaemonLogger.new(@log_device, log_level: ServerEngine::DaemonLogger::INFO),
+        ignore_same_log_interval: ignore_same_log_interval,
+      )
+
+      # Output unique log every second.
+      Fluent::Log::IGNORE_SAME_LOG_MAX_CACHE_SIZE.times do |i|
+        logger.info "Test #{i}"
+        Timecop.freeze(@timestamp + i)
+      end
+      logger.info "Over max size!"
+
+      # The newest cache and the latest caches in `ignore_same_log_interval` should exist.
+      assert { Thread.current[:last_same_log].size == ignore_same_log_interval + 1 }
+    end
+
+    def test_clear_on_max_size
+      ignore_same_log_interval = 10
+
+      logger = Fluent::Log.new(
+        ServerEngine::DaemonLogger.new(@log_device, log_level: ServerEngine::DaemonLogger::INFO),
+        ignore_same_log_interval: ignore_same_log_interval,
+      )
+
+      # Output unique log at the same time.
+      Fluent::Log::IGNORE_SAME_LOG_MAX_CACHE_SIZE.times do |i|
+        logger.info "Test #{i}"
+      end
+      logger.info "Over max size!"
+
+      # Can't reject old logs, so all cache should be cleared and only the newest should exist.
+      assert { Thread.current[:last_same_log].size == 1 }
+    end
   end
 
   def test_dup
@@ -660,7 +697,7 @@ class LogTest < Test::Unit::TestCase
     log.reopen!
     log.info message
 
-    assert { path.read.lines.select{ |line| line.include?(message) }.size == 2 }
+    assert { path.read.lines.count{ |line| line.include?(message) } == 2 }
     # Assert reopening the same file.
     # Especially, on Windows, the filepath is fixed for each process with rotate,
     # so we need to care about this.

data/test/test_msgpack_factory.rb

@@ -15,4 +15,36 @@ class MessagePackFactoryTest < Test::Unit::TestCase
     assert mp.msgpack_factory
     assert mp.msgpack_factory
   end
+
+  sub_test_case 'thread_local_msgpack_packer' do
+    test 'packer is cached' do
+      packer1 = Fluent::MessagePackFactory.thread_local_msgpack_packer
+      packer2 = Fluent::MessagePackFactory.thread_local_msgpack_packer
+      assert_equal packer1, packer2
+    end
+  end
+
+  sub_test_case 'thread_local_msgpack_unpacker' do
+    test 'unpacker is cached' do
+      unpacker1 = Fluent::MessagePackFactory.thread_local_msgpack_unpacker
+      unpacker2 = Fluent::MessagePackFactory.thread_local_msgpack_unpacker
+      assert_equal unpacker1, unpacker2
+    end
+
+    # We need to reset the buffer every time so that received incomplete data
+    # must not affect data from other senders.
+    test 'reset the internal buffer of unpacker every time' do
+      unpacker1 = Fluent::MessagePackFactory.thread_local_msgpack_unpacker
+      unpacker1.feed_each("\xA6foo") do |result|
+        flunk("This callback must not be called since the data is uncomplete.")
+      end
+
+      records = []
+      unpacker2 = Fluent::MessagePackFactory.thread_local_msgpack_unpacker
+      unpacker2.feed_each("\xA3foo") do |result|
+        records.append(result)
+      end
+      assert_equal ["foo"], records
+    end
+  end
 end

data/test/test_supervisor.rb

@@ -621,6 +621,19 @@ class SupervisorTest < ::Test::Unit::TestCase
       assert_equal 10, $log.out.instance_variable_get(:@shift_size)
     end
 
+    def test_can_start_with_rotate_but_no_log_path
+      config_path = "#{@tmp_dir}/empty.conf"
+      write_config config_path, ""
+
+      sv = Fluent::Supervisor.new(
+        config_path: config_path,
+        log_rotate_age: 5,
+      )
+      sv.__send__(:setup_global_logger)
+
+      assert_true $log.stdout?
+    end
+
     sub_test_case "system log rotation" do
       def parse_text(text)
         basepath = File.expand_path(File.dirname(__FILE__) + '/../../')