fluent-plugin-scalyr 0.8.10 → 0.8.15

data/test/test_events.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Scalyr Output Plugin for Fluentd
 #
@@ -15,234 +17,388 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-
-require 'helper'
-require 'fluent/event'
+require "helper"
+require "flexmock/test_unit"
+require "fluent/event"
 
 class EventsTest < Scalyr::ScalyrOutTest
-
   def test_format
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
-    mock.should_receive( :post_request ).with_any_args.and_return( response )
-
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    d.emit( { "a" => 1 }, time )
-    d.expect_format [ "test", time, { "a" => 1 } ].to_msgpack
-    d.run
+
+    time = event_time("2015-04-01 10:00:00 UTC")
+
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
+    mock.should_receive(:post_request).with_any_args.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, {"a" => 1})
+    end
+
+    expected = [
+      ["test", time.sec, time.nsec, {"a" => 1}].to_msgpack
+    ]
+
+    assert_equal(expected, d.formatted)
   end
 
   def test_build_add_events_body_basic_values
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
 
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    attrs = { "a" => 1 }
-    d.emit( attrs, time )
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"a" => 1}
+    attrs["logfile"] = "/fluentd/test"
+
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
 
-    attrs["logfile"] = "/fluentd/test";
+    mock_called = false
 
-    mock.should_receive( :post_request ).with( 
+    mock.should_receive(:post_request).with(
       URI,
-      on { |request_body|
-        body = JSON.parse( request_body )
-        assert( body.key?( "token" ), "Missing token field"  )
-        assert( body.key?( "client_timestamp" ), "Missing client_timestamp field" )
-        assert( body.key?( "session" ), "Missing session field" )
-        assert( !body.key?( "sessionInfo"), "sessionInfo field set, but no sessionInfo" )
-        assert( body.key?( "events" ), "missing events field" )
-        assert( body.key?( "threads" ), "missing threads field" )
-        assert_equal( 1, body['events'].length, "Only expecting 1 event" )
-        assert_equal( d.instance.to_nanos( time ), body['events'][0]['ts'].to_i, "Event timestamp differs" )
-        assert_equal( attrs, body['events'][0]['attrs'], "Value of attrs differs from log" )
-        true
+      on {|request_body|
+        body = JSON.parse(request_body)
+        assert(body.key?("token"), "Missing token field")
+        assert(body.key?("client_timestamp"), "Missing client_timestamp field")
+        assert(body.key?("sessionInfo"), "sessionInfo field set, but no sessionInfo")
+        assert(body.key?("events"), "missing events field")
+        assert(body.key?("threads"), "missing threads field")
+        assert_equal(1, body["events"].length, "Only expecting 1 event")
+        assert_equal(time.sec * 1_000_000_000, body["events"][0]["ts"].to_i,
+                     "Event timestamp differs")
+        assert_equal(attrs, body["events"][0]["attrs"], "Value of attrs differs from log")
+        mock_called = true
       }
-      ).and_return( response )
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
 
-    d.run
+    assert_equal(mock_called, true, "mock method was never called!")
   end
 
   def test_build_add_events_body_dont_override_logfile_field
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
 
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    attrs = { "a" => 1 }
-    attrs["logfile"] = "/some/log/file";
-    d.emit( attrs, time )
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"a" => 1}
+    attrs["logfile"] = "/some/log/file"
 
-    mock.should_receive( :post_request ).with(
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
+
+    mock_called = false
+
+    mock.should_receive(:post_request).with(
       URI,
-      on { |request_body|
-        body = JSON.parse( request_body )
-        assert_equal( attrs, body['events'][0]['attrs'], "Value of attrs differs from log" )
+      on {|request_body|
+        body = JSON.parse(request_body)
+        assert_equal(attrs, body["events"][0]["attrs"], "Value of attrs differs from log")
+        mock_called = true
         true
       }
-      ).and_return( response )
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
 
-    d.run
+    assert_equal(mock_called, true, "mock method was never called!")
   end
 
   def test_build_add_events_body_with_server_attributes
     d = create_driver CONFIG + 'server_attributes { "test":"value" }'
 
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"a" => 1}
 
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    attrs = { "a" => 1 }
-    d.emit( attrs, time )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
 
-    mock.should_receive( :post_request ).with( 
+    mock_called = false
+
+    mock.should_receive(:post_request).with(
       URI,
-      on { |request_body|
-        body = JSON.parse( request_body )
-        assert( body.key?( "sessionInfo"), "sessionInfo field set, but no sessionInfo" )
-        assert_equal( "value", body["sessionInfo"]["test"] )
+      on {|request_body|
+        body = JSON.parse(request_body)
+        assert(body.key?("sessionInfo"), "sessionInfo field set, but no sessionInfo")
+        assert_equal("value", body["sessionInfo"]["test"])
+        mock_called = true
         true
       }
-      ).and_return( response )
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
 
-    d.run
+    assert_equal(mock_called, true, "mock method was never called!")
   end
 
-  def test_build_add_events_body_incrementing_timestamps
-    d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
+  def test_build_add_events_body_with_parser
+    d = create_driver CONFIG + "parser test_parser"
 
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    d.emit( { "a" => 1 }, time )
-    d.emit( { "a" => 2 }, time )
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"a" => 1}
 
-    time = Time.parse("2015-04-01 09:59:00 UTC").to_i
-    d.emit( { "a" => 3 }, time )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
 
-    mock.should_receive( :post_request ).with( 
+    mock_called = false
+
+    mock.should_receive(:post_request).with(
       URI,
-      on { |request_body|
-        body = JSON.parse( request_body )
-        events = body['events']
-        assert_equal( 3, events.length, "Expecting 3 events" )
-        #test equal timestamps are increased
-        assert events[1]['ts'].to_i > events[0]['ts'].to_i, "Event timestamps must increase"
+      on {|request_body|
+        body = JSON.parse(request_body)
+        assert_equal("test_parser", body["events"][0]["attrs"]["parser"])
+        mock_called = true
+        true
+      }
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
+
+    assert_equal(mock_called, true, "mock method was never called!")
+  end
+
+  def test_build_add_events_body_incrementing_timestamps
+    d = create_driver
 
-        #test earlier timestamps are increased
-        assert events[2]['ts'].to_i > events[1]['ts'].to_i, "Event timestamps must increase"
+    time1 = event_time("2015-04-01 10:00:00 UTC")
+    time2 = event_time("2015-04-01 09:59:00 UTC")
 
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
+
+    mock_called = false
+
+    mock.should_receive(:post_request).with(
+      URI,
+      on {|request_body|
+        body = JSON.parse(request_body)
+        events = body["events"]
+        assert_equal(3, events.length, "Expecting 3 events")
+        # Since 0.8.10 timestamps dont need to increase anymore
+        assert events[1]["ts"].to_i == events[0]["ts"].to_i, "Event timestamps must be the same"
+        assert events[2]["ts"].to_i < events[0]["ts"].to_i, "Event timestamps must be less"
+        mock_called = true
         true
       }
-      ).and_return( response )
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time1, {"a" => 1})
+      d.feed(time1, {"a" => 2})
+      d.feed(time2, {"a" => 3})
+    end
 
-    d.run
+    assert_equal(mock_called, true, "mock method was never called!")
   end
 
-  def test_build_add_events_body_thread_ids
+  def test_build_add_events_body_non_json_serializable_value
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
 
-    entries = []
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"a" => 1}
+    attrs["int1"] = 1_601_923_119
+    attrs["int2"] = Integer(1_601_923_119)
+    attrs["int3"] = Integer(9_223_372_036_854_775_807)
+    attrs["int4"] = Integer(-1)
+    attrs["nil"] = nil
+    attrs["array"] = [1, 2, "a", "b", nil]
+    attrs["hash"] = {
+      "a" => "1",
+      "b" => "c"
+    }
+    attrs["logfile"] = "/some/log/file"
+
+    # This partial unicode sequence will fail encoding so we make sure it doesn't break the plugin
+    # and we correctly cast it to a value which we can send to the API
+    attrs["partial_unicode_sequence"] = "\xC2"
+    attrs["array_with_partial_unicode_sequence"] = [1, 2, "a", "b", nil, "7", "\xC2"]
+    attrs["nested_array_with_partial_unicode_sequence"] = [1, 2, "a", "b", nil, "7",
+                                                           [8, 9, [10, "\xC2"]],
+                                                           {"a" => 1, "b" => "\xC2"}]
+    attrs["hash_with_partial_unicode_sequence"] = {
+      "a" => "1",
+      "b" => "\xC2",
+      "c" => nil
+    }
+    attrs["nested_hash_with_partial_unicode_sequence"] = {
+      "a" => "1",
+      "b" => {
+        "c" => "\xC2",
+        "d" => "e",
+        "f" => nil,
+        "g" => {
+          "h" => "\xC2",
+          "b" => 3
+        }
+      }
+    }
+
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
 
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    entries << [time, { "a" => 1 }]
+    mock_called = false
 
-    es = Fluent::ArrayEventStream.new(entries)
-    buffer = d.instance.format_stream("test1", es)
+    # NOTE: We need to perform a deep clone / copy
+    expected_attrs = Marshal.load(Marshal.dump(attrs))
 
-    chunk = d.instance.buffer.new_chunk('')
-    chunk << buffer
+    expected_attrs["partial_unicode_sequence"] = "<?>"
+    expected_attrs["array_with_partial_unicode_sequence"][-1] = "<?>"
+    expected_attrs["nested_array_with_partial_unicode_sequence"][-2][-1][-1] = "<?>"
+    expected_attrs["nested_array_with_partial_unicode_sequence"][-1]["b"] = "<?>"
+    expected_attrs["hash_with_partial_unicode_sequence"]["b"] = "<?>"
+    expected_attrs["nested_hash_with_partial_unicode_sequence"]["b"]["c"] = "<?>"
+    expected_attrs["nested_hash_with_partial_unicode_sequence"]["b"]["g"]["h"] = "<?>"
 
-    buffer = d.instance.format_stream("test2", es)
-    chunk << buffer
+    # Verify that clone / copy was correct and the original object wasn't modified
+    assert_not_equal(expected_attrs, attrs, "Objects are the same but should be different")
+    assert_not_equal(Marshal.load(Marshal.dump(attrs)), Marshal.load(Marshal.dump(expected_attrs)))
+    assert_equal(attrs["partial_unicode_sequence"], "\xC2")
+    assert_equal(attrs["array_with_partial_unicode_sequence"][-1], "\xC2")
+    assert_equal(attrs["nested_hash_with_partial_unicode_sequence"]["b"]["g"]["h"], "\xC2")
 
-    mock.should_receive( :post_request ).with( 
+    mock.should_receive(:post_request).with(
       URI,
-      on { |request_body|
-        body = JSON.parse( request_body )
-        events = body['events']
-        threads = body['threads']
-
-        assert_equal( 2, threads.length, "Expecting 2 threads, #{threads.length} found" )
-        assert_equal( 2, events.length, "Expecting 2 events, #{events.length} found" )
-        assert_equal( events[0]['thread'], threads[0]['id'].to_s, "thread id should match event thread id" )
-        assert_equal( events[1]['thread'], threads[1]['id'].to_s, "thread id should match event thread id" )
+      on {|request_body|
+        body = JSON.parse(request_body)
+        assert_equal(expected_attrs, body["events"][0]["attrs"], "Value of attrs differs from log")
+        mock_called = true
         true
       }
-      ).at_least.once.and_return( response )
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
 
-    d.instance.start
-    d.instance.write( chunk )
-    d.instance.shutdown
+    assert_equal(mock_called, true, "mock method was never called!")
   end
 
   def test_default_message_field
     d = create_driver CONFIG
 
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"log" => "this is a test", "logfile" => "/fluentd/test"}
 
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    attrs = { "log" => "this is a test", "logfile" => "/fluentd/test" }
-    d.emit( attrs, time )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
 
-    mock.should_receive( :post_request ).with(
+    mock_called = false
+
+    mock.should_receive(:post_request).with(
       URI,
-      on { |request_body|
-        body = JSON.parse( request_body )
-        events = body['events']
-        assert_equal( attrs, body['events'][0]['attrs'], "Value of attrs differs from log" )
+      on {|request_body|
+        body = JSON.parse(request_body)
+        assert_equal(attrs, body["events"][0]["attrs"], "Value of attrs differs from log")
+        mock_called = true
         true
       }
-      ).and_return( response )
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
 
-    d.run
+    assert_equal(mock_called, true, "mock method was never called!")
   end
 
   def test_different_message_field
-    d = create_driver CONFIG + 'message_field log'
+    d = create_driver CONFIG + "message_field log"
 
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"log" => "this is a test"}
 
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    attrs = { "log" => "this is a test" }
-    d.emit( attrs, time )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
 
-    mock.should_receive( :post_request ).with(
+    mock_called = false
+
+    mock.should_receive(:post_request).with(
       URI,
-      on { |request_body|
-        body = JSON.parse( request_body )
-        events = body['events']
-        assert( events[0]['attrs'].key?( 'message'), "'message' field not found in event" )
-        assert_equal( "this is a test", events[0]['attrs']['message'], "'message' field incorrect" )
-        assert( !events[0]['attrs'].key?( 'log' ), "'log' field should no longer exist in event" )
+      on {|request_body|
+        body = JSON.parse(request_body)
+        events = body["events"]
+        assert(events[0]["attrs"].key?("message"), "'message' field not found in event")
+        assert_equal("this is a test", events[0]["attrs"]["message"], "'message' field incorrect")
+        assert(!events[0]["attrs"].key?("log"), "'log' field should no longer exist in event")
+        mock_called = true
         true
       }
-      ).and_return( response )
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
 
-    d.run
+    assert_equal(mock_called, true, "mock method was never called!")
   end
 
   def test_different_message_field_message_already_exists
-    d = create_driver CONFIG + 'message_field log'
+    d = create_driver CONFIG + "message_field log"
 
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    mock = flexmock( d.instance )
-    mock.should_receive( :post_request ).and_return( response )
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"log" => "this is a test", "message" => "uh oh"}
 
-    time = Time.parse("2015-04-01 10:00:00 UTC").to_i
-    attrs = { "log" => "this is a test", "message" => "uh oh" }
-    d.emit( attrs, time )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
 
-    logger = flexmock( $log )
-    logger.should_receive( :warn ).with( /overwriting log record field 'message'/i ).at_least().once()
+    mock.should_receive(:post_request).once.and_return(response)
 
-    d.run
+    logger = flexmock($log)
+    logger.should_receive(:warn).with(/overwriting log record field 'message'/i).at_least.once
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
   end
 
-end
+  def test_truncated_large_event
+    d = create_driver CONFIG + "max_request_buffer 4000"
+
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"log" => "this is a test", "message" => "0123456789" * 500}
 
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    mock = flexmock(d.instance)
+
+    mock.should_receive(:post_request).with(
+      URI,
+      on {|request_body|
+        body = JSON.parse(request_body)
+        events = body["events"]
+        assert(events[0]["attrs"].key?("message"), "'message' field not found in event")
+        assert_equal(
+          "0123456789" * 388 + "012...",
+          events[0]["attrs"]["message"],
+          "'message' field incorrect"
+        )
+        true
+      }
+    ).once.and_return(response)
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
+  end
+
+  def test_dropped_large_event
+    d = create_driver CONFIG + "max_request_buffer 4000"
+
+    time = event_time("2015-04-01 10:00:00 UTC")
+    attrs = {"message" => "this is a test", "not_message" => "0123456789" * 500}
+
+    mock = flexmock(d.instance)
+
+    mock.should_receive(:post_request).never
+
+    d.run(default_tag: "test") do
+      d.feed(time, attrs)
+    end
+  end
+end

data/test/test_handle_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Scalyr Output Plugin for Fluentd
 #
@@ -15,76 +17,73 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+require "helper"
+require "flexmock/test_unit"
 
-require 'helper'
-require 'flexmock/test_unit'
-
+# rubocop:disable Layout/LineLength
 class HandleResponseTest < Scalyr::ScalyrOutTest
-
   def test_handle_response_missing_status
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "message":"An invalid message" }'  )
-    exception = assert_raise( Scalyr::ServerError, "Server error not raised for missing status" ) {
-      d.instance.handle_response( response )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "message":"An invalid message" }')
+    exception = assert_raise(Scalyr::ServerError, "Server error not raised for missing status") {
+      d.instance.handle_response(response)
     }
 
-    assert_equal( "JSON response does not contain status message", exception.message )
+    assert_equal("JSON response does not contain status message", exception.message)
   end
 
   def test_handle_response_discard_buffer
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "message":"An invalid message", "status":"error/server/discardBuffer" }'  )
-    logger = flexmock( $log )
-    logger.should_receive( :warn ).with( /buffer dropped/i )
-    assert_nothing_raised( Scalyr::ServerError, Scalyr::ClientError, "Nothing should be raised when discarding the buffer" ) {
-      d.instance.handle_response( response )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "message":"An invalid message", "status":"error/server/discardBuffer" }')
+    logger = flexmock($log)
+    logger.should_receive(:warn).once.with(/buffer dropped/i)
+    assert_nothing_raised(Scalyr::ServerError, Scalyr::ClientError, "Nothing should be raised when discarding the buffer") {
+      d.instance.handle_response(response)
     }
-
   end
 
   def test_handle_response_unknown_error
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "message":"An invalid message", "status":"error/other" }'  )
-    exception = assert_raise( Scalyr::ServerError, "Server error not raised for error status" ) {
-      d.instance.handle_response( response )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "message":"An invalid message", "status":"error/other" }')
+    exception = assert_raise(Scalyr::ServerError, "Server error not raised for error status") {
+      d.instance.handle_response(response)
     }
-    assert_equal( "error/other", exception.message )
+    assert_equal("error/other", exception.message)
   end
 
   def test_handle_response_client_error
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "message":"An invalid message", "status":"error/client/test" }'  )
-    exception = assert_raise( Scalyr::ClientError, "Client  error not raised for error status" ) {
-      d.instance.handle_response( response )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "message":"An invalid message", "status":"error/client/test" }')
+    exception = assert_raise(Scalyr::ClientError, "Client  error not raised for error status") {
+      d.instance.handle_response(response)
     }
-    assert_equal( "error/client/test", exception.message )
+    assert_equal("error/client/test", exception.message)
   end
 
   def test_handle_response_server_error
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "message":"An invalid message", "status":"error/server/test" }'  )
-    exception = assert_raise( Scalyr::ServerError, "Server error not raised for error status" ) {
-      d.instance.handle_response( response )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "message":"An invalid message", "status":"error/server/test" }')
+    exception = assert_raise(Scalyr::ServerError, "Server error not raised for error status") {
+      d.instance.handle_response(response)
     }
-    assert_equal( "error/server/test", exception.message )
+    assert_equal("error/server/test", exception.message)
   end
 
   def test_handle_response_code_4xx
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '404', :body =>'{ "status":"error/server/fileNotFound" }'  )
-    exception = assert_raise( Scalyr::Client4xxError, "No 4xx exception raised" ) {
-      d.instance.handle_response( response )
+    response = flexmock(Net::HTTPResponse, code: "404", body: '{ "status":"error/server/fileNotFound" }')
+    exception = assert_raise(Scalyr::Client4xxError, "No 4xx exception raised") {
+      d.instance.handle_response(response)
     }
-    assert_equal( "error/server/fileNotFound", exception.message )
+    assert_equal("error/server/fileNotFound", exception.message)
   end
 
   def test_handle_response_code_200
     d = create_driver
-    response = flexmock( Net::HTTPResponse, :code => '200', :body =>'{ "status":"success" }'  )
-    exception = assert_nothing_raised( Scalyr::ServerError, Scalyr::ClientError, "Error raised on success" ) {
-      d.instance.handle_response( response )
+    response = flexmock(Net::HTTPResponse, code: "200", body: '{ "status":"success" }')
+    assert_nothing_raised(Scalyr::ServerError, Scalyr::ClientError, "Error raised on success") {
+      d.instance.handle_response(response)
     }
   end
-
 end
-
+# rubocop:enable Layout/LineLength