fluent-plugin-notifier 0.3.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 661e25eea2608a53c2d916f2b70ef0c4b7ffcbb6
-  data.tar.gz: 5672d2a300cb2009442b678a8bd88caeb3c4ff37
+  metadata.gz: 9dff806a4a4e3d1c5301c80cb450e129a3d2a772
+  data.tar.gz: c164675d4de2e69db7c28105439924c8a71b5a3a
 SHA512:
-  metadata.gz: 65ed2a3ff591e1c35f0d5b423daae24e12e7fbbc4bfbd8eda4282b8ad74a6b7ca63878200a015124433de9f178203d9d45328ab974e7c74e42e0604c64597b17
-  data.tar.gz: 63cc3d73f7d5daea73f57fa3366c033834e8b93c9348c375382c432b3ef93fcc51e672d264c7a69f2b6c667cf79b4cbf3414dedebe824ef4155ce67db8f65b7b
+  metadata.gz: 0d1fbf77d6b32db55cf3d9a9712480794fc80ee52a1114b1e749b343c57411e6ed3d077eb7c156946d8181ba104d52b9265151e8ad007df4b7c714fa54bb4c73
+  data.tar.gz: e8ab3552f88d2fb5a870ec4b7d4087d642ea9741166b05a6df5cc029780cd41c55dd38d989fd645b4b99ffbcbca3efdd43fa98349139b194053292985ccc0827

data/.travis.yml

@@ -1,4 +1,7 @@
 language: ruby
+sudo: false
 rvm:
-  - 1.9.3
-  - 2.0.0
+  - 2.1
+  - 2.2
+  - 2.3.3
+  - 2.4.0

data/Appraisals

@@ -0,0 +1,3 @@
+appraise "fluentd v0.14" do
+  gem "fluentd", "~> 0.14.0"
+end

data/README.md

@@ -1,9 +1,5 @@
 # fluent-plugin-notifier
 
-## Component
-
-### NotifierOutput
-
 [Fluentd](http://fluentd.org) plugin to emit notifications for messages, with numbers over/under threshold, or specified pattern strings.
 
 ## Configuration
@@ -11,7 +7,8 @@
 To notify apache logs with over 1000000 (microseconds) duration for CRITICAL , or status '500' by string pattern match:
 
     <match apache.log.**>
-      type notifier
+      @type notifier
+      @label @notification_events
       <def>
         pattern apache_duration
         check numeric_upward
@@ -29,7 +26,7 @@ To notify apache logs with over 1000000 (microseconds) duration for CRITICAL , o
       </def>
     </match>
 
-With this configuration, you will get notification message like this:
+With this configuration, you will get notification messages in `<label @notification_events>` section, like this:
 
     2012-05-15 19:44:29 +0900 notification: {"pattern":"apache_duration","target_tag":"apache.log.xxx","target_key":"duration","check_type":"numeric_upward","level":"crit","threshold":1000000,"value":"1057231","message_time":"2012-05-15 19:44:27 +0900"}
     2012-05-15 19:44:29 +0900 notification: {"pattern":"status_500","target_tag":"apache.log.xxx","target_key":"status","check_type":"string_find","level":"crit","regexp":"/500/","value":"500","message_time":"2012-05-15 19:44:27 +0900"}
@@ -55,7 +52,8 @@ If you want to get every 5 minutes notifications (after 1 minutes notifications)
 To include specified messages into check target, or to exclude specified messages from check target, <test> directive is useful.
 
     <match apache.log.**>
-      type notifier
+      @type notifier
+      @label @notifications
       <test>
         check numeric
         target_key duration     # microseconds
@@ -70,6 +68,12 @@ To include specified messages into check target, or to exclude specified message
         target_key_pattern ^status.*$
       </def>
     </match>
+    
+    <label @notifications>
+      <match **>
+        # send notifications to Slack, email or ...
+      </match>
+    </label>
 
 With configuration above, fluent-plugin-notifier checks messages with specified duration value (d: 5000 <= d <= 5000000), and others are ignored.
 
@@ -84,7 +88,8 @@ Available 'check' types are: 'numeric', 'regexp' and 'tag'.
 Multiple <test> directives means logical AND of each tests.
 
     <match apache.log.**>
-      type notifier
+      @type notifier
+      @label @notifications
       input_tag_remove_prefix apache.log
       <test>
         check tag

data/fluent-plugin-notifier.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |gem|
   gem.name          = "fluent-plugin-notifier"
-  gem.version       = "0.3.0"
+  gem.version       = "1.0.0"
   gem.authors       = ["TAGOMORI Satoshi"]
   gem.email         = ["tagomoris@gmail.com"]
   gem.summary       = %q{check matched messages and emit alert message}
@@ -14,7 +14,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_development_dependency "test-unit"
+  gem.add_runtime_dependency "fluentd", [">= 0.14.0"]
+  gem.add_development_dependency "test-unit", "~> 3.0"
   gem.add_development_dependency "rake"
-  gem.add_runtime_dependency "fluentd", "< 0.14.0"
 end

data/gemfiles/fluentd_v0.14.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "fluentd", "~> 0.14.0"
+
+gemspec :path => "../"

data/lib/fluent/plugin/out_notifier.rb

@@ -1,89 +1,125 @@
-class Fluent::NotifierOutput < Fluent::Output
+require "fluent/plugin/output"
+
+class Fluent::Plugin::NotifierOutput < Fluent::Plugin::Output
   Fluent::Plugin.register_output('notifier', self)
 
+  helpers :event_emitter
+
   NOTIFICATION_LEVELS = ['OK', 'WARN', 'CRIT', 'LOST'].freeze
 
   STATES_CLEAN_INTERVAL = 3600 # 1hours
   STATES_EXPIRE_SECONDS = 14400 # 4hours
 
-  config_param :default_tag, :string, :default => 'notification'
-  config_param :default_tag_warn, :string, :default => nil
-  config_param :default_tag_crit, :string, :default => nil
+  config_param :default_tag, :string, default: 'notification'
+  config_param :default_tag_warn, :string, default: nil
+  config_param :default_tag_crit, :string, default: nil
 
-  config_param :default_interval_1st, :time, :default => 60
-  config_param :default_repetitions_1st, :integer, :default => 5
-  config_param :default_interval_2nd, :time, :default => 300
-  config_param :default_repetitions_2nd, :integer, :default => 5
-  config_param :default_interval_3rd, :time, :default => 1800
+  config_param :default_intervals, :array, value_type: :time, default: [60, 300, 1800]
+  config_param :default_repetitions, :array, value_type: :integer, default: [5, 5]
 
-  config_param :input_tag_remove_prefix, :string, :default => nil
+  config_param :default_interval_1st, :time, default: nil
+  config_param :default_interval_2nd, :time, default: nil
+  config_param :default_interval_3rd, :time, default: nil
+  config_param :default_repetitions_1st, :integer, default: nil
+  config_param :default_repetitions_2nd, :integer, default: nil
 
-  attr_accessor :tests, :defs, :states, :match_cache, :negative_cache
+  config_param :input_tag_remove_prefix, :string, default: nil
 
-### output
-# {
-#  'pattern' => 'http_status_errors',
-#  'target_tag' => 'httpstatus.blog',
-#  'target_key' => 'blog_5xx_percentage',
-#  'check_type' => 'numeric_upward'
-#  'level' => 'warn',
-#  'threshold' => 25,  # or 'regexp' => ....,
-#  'value' => 49,      # or 'value' => 'matched some string...',
-#  'message_time' => Time.instance
-# }
-
-# <match httpstatus.blog>
-#   type notifier
-#   default_tag notification
-#   default_interval_1st 1m
-#   default_repetitions_1st 5
-#   default_interval_2nd 5m
-#   default_repetitions_2nd 5
-#   default_interval_3rd 30m
-#   <test>
-#     check numeric
-#     target_key xxx
-#     lower_threshold xxx
-#     upper_threshold xxx
-#   </test>
-#   <test>
-#     check regexp
-#     target_key xxx
-#     include_pattern ^.$
-#     exclude_pattern ^.$
-#   </test>
-#   <def>
-#     pattern http_status_errors
-#     check numeric_upward
-#     warn_threshold 25
-#     crit_threshold 50
-#     tag alert
-# #    tag_warn alert.warn
-# #    tag_crit alert.crit
-#     # target_keys blog_5xx_percentage
-#     target_key_pattern ^.*_5xx_percentage$
-#   </def>
-#   <def>
-#     pattern log_checker
-#     check string_find
-#     crit_pattern 'ERROR'
-#     warn_pattern 'WARNING'
-#     tag alert
-#     # target_keys message
-#     target_key_pattern ^.*_message$
-#   </def>
-# </match>
-
-  # Define `log` method for v0.10.42 or earlier
-  unless method_defined?(:log)
-    define_method("log") { $log }
+  config_section :test, multi: true, param_name: :test_configs do
+    config_param :check, :enum, list: [:tag, :numeric, :regexp]
+    config_param :target_key, :string, default: nil
+    config_param :lower_threshold, :float, default: nil
+    config_param :upper_threshold, :float, default: nil
+    config_param :include_pattern, :string, default: nil
+    config_param :exclude_pattern, :string, default: nil
   end
 
-  # Define `log` method for v0.10.57 or earlier
-  unless method_defined?(:router)
-    define_method(:router) { Fluent::Engine }
+  config_section :def, multi: true, param_name: :def_configs do
+    config_param :pattern, :string
+    config_param :check, :enum, list: [:numeric_upward, :numeric_downward, :string_find]
+
+    config_param :target_keys, :array, value_type: :string, default: nil
+    config_param :target_key_pattern, :string, default: nil
+    config_param :exclude_key_pattern, :string, default: '^$'
+
+    config_param :tag, :string, default: nil
+    config_param :tag_warn, :string, default: nil
+    config_param :tag_crit, :string, default: nil
+
+    # numeric_upward/downward
+    config_param :crit_threshold, :float, default: nil
+    config_param :warn_threshold, :float, default: nil
+
+    # string_find
+    config_param :crit_regexp, :string, default: nil
+    config_param :warn_regexp, :string, default: nil
+
+    # repeat & interval
+    config_param :intervals, :array, value_type: :time, default: nil
+    config_param :interval_1st, :time, default: nil
+    config_param :interval_2nd, :time, default: nil
+    config_param :interval_3rd, :time, default: nil
+    config_param :repetitions, :array, value_type: :integer, default: nil
+    config_param :repetitions_1st, :integer, default: nil
+    config_param :repetitions_2nd, :integer, default: nil
   end
 
+  attr_accessor :tests, :defs, :states, :match_cache, :negative_cache
+
+  ### output
+  # {
+  #  'pattern' => 'http_status_errors',
+  #  'target_tag' => 'httpstatus.blog',
+  #  'target_key' => 'blog_5xx_percentage',
+  #  'check_type' => 'numeric_upward'
+  #  'level' => 'warn',
+  #  'threshold' => 25,  # or 'regexp' => ....,
+  #  'value' => 49,      # or 'value' => 'matched some string...',
+  #  'message_time' => Time.instance
+  # }
+
+  # <match httpstatus.blog>
+  #   type notifier
+  #   default_tag notification
+  #   default_interval_1st 1m
+  #   default_repetitions_1st 5
+  #   default_interval_2nd 5m
+  #   default_repetitions_2nd 5
+  #   default_interval_3rd 30m
+  #   <test>
+  #     check numeric
+  #     target_key xxx
+  #     lower_threshold xxx
+  #     upper_threshold xxx
+  #   </test>
+  #   <test>
+  #     check regexp
+  #     target_key xxx
+  #     include_pattern ^.$
+  #     exclude_pattern ^.$
+  #   </test>
+  #   <def>
+  #     pattern http_status_errors
+  #     check numeric_upward
+  #     warn_threshold 25
+  #     crit_threshold 50
+  #     tag alert
+  # #    tag_warn alert.warn
+  # #    tag_crit alert.crit
+  #     # target_keys blog_5xx_percentage
+  #     target_key_pattern ^.*_5xx_percentage$
+  #   </def>
+  #   <def>
+  #     pattern log_checker
+  #     check string_find
+  #     crit_pattern 'ERROR'
+  #     warn_pattern 'WARNING'
+  #     tag alert
+  #     # target_keys message
+  #     target_key_pattern ^.*_message$
+  #   </def>
+  # </match>
+
   def configure(conf)
     super
 
@@ -98,35 +134,40 @@ class Fluent::NotifierOutput < Fluent::Output
       @input_tag_remove_prefix_length = @input_tag_remove_prefix_string.length
     end
 
-    defaults = {
-      :tag => @default_tag, :tag_warn => @default_tag_warn, :tag_crit => @default_tag_crit,
-      :interval_1st => @default_interval_1st, :repetitions_1st => @default_repetitions_1st,
-      :interval_2nd => @default_interval_2nd, :repetitions_2nd => @default_repetitions_2nd,
-      :interval_3rd => @default_interval_3rd,
-    }
-
-    conf.elements.each do |element|
-      case element.name
-      when 'test'
-        @tests.push(Test.new(element))
-      when 'def'
-        @defs.push(Definition.new(element, defaults))
-      else
-        raise Fluent::ConfigError, "invalid section name for out_notifier: #{element.name}"
-      end
+    if @default_interval_1st || @default_interval_2nd || @default_interval_3rd
+      @default_intervals = [
+        @default_interval_1st || @default_intervals[0],
+        @default_interval_2nd || @default_intervals[1],
+        @default_interval_3rd || @default_intervals[2],
+      ]
+    end
+    if @default_repetitions_1st || @default_repetitions_2nd
+      @default_repetitions = [
+        @default_repetitions_1st || @default_repetitions[0],
+        @default_repetitions_2nd || @default_repetitions[1],
+      ]
+    end
+
+    @test_configs.each do |test_config|
+      @tests << Test.new(test_config)
+    end
+    @def_configs.each do |def_config|
+      @defs << Definition.new(def_config, self)
     end
   end
 
+  def multi_workers_ready?
+    true
+  end
+
   def start
     super
     @mutex = Mutex.new
     @last_status_cleaned = Fluent::Engine.now
   end
 
-  # def shutdown
-  # end
-
   def suppressed_emit(notifications)
+    now = Fluent::Engine.now
     notifications.each do |n|
       hashkey = n.delete(:hashkey)
       definition = n.delete(:match_def)
@@ -135,11 +176,11 @@ class Fluent::NotifierOutput < Fluent::Output
       state = @states[hashkey]
       if state
         unless state.suppress?(definition, n)
-          router.emit(tag, Fluent::Engine.now, n)
+          router.emit(tag, now, n)
           state.update_notified(definition, n)
         end
       else
-        router.emit(tag, Fluent::Engine.now, n)
+        router.emit(tag, now, n)
         @states[hashkey] = State.new(n)
       end
     end
@@ -191,7 +232,7 @@ class Fluent::NotifierOutput < Fluent::Output
     notifications
   end
 
-  def emit(tag, es, chain)
+  def process(tag, es)
     notifications = check(tag, es)
 
     if notifications.size > 0
@@ -206,8 +247,6 @@ class Fluent::NotifierOutput < Fluent::Output
         @last_status_cleaned = Fluent::Engine.now
       end
     end
-
-    chain.next
   end
 
   class Test
@@ -215,45 +254,32 @@ class Fluent::NotifierOutput < Fluent::Output
     attr_accessor :lower_threshold, :upper_threshold
     attr_accessor :include_pattern, :exclude_pattern
 
-    def initialize(element)
-      element.keys.each do |k|
-        v = element[k]
-        case k
-        when 'check'
-          case v
-          when 'tag'
-            @check = :tag
-            @include_pattern = element['include_pattern'] ? Regexp.compile(element['include_pattern']) : nil
-            @exclude_pattern = element['exclude_pattern'] ? Regexp.compile(element['exclude_pattern']) : nil
-            if @include_pattern.nil? and @exclude_pattern.nil?
-              raise Fluent::ConfigError, "At least one of include_pattern or exclude_pattern must be specified for 'check tag'"
-            end
-          when 'numeric'
-            @check = :numeric
-            @lower_threshold = element['lower_threshold'] ? element['lower_threshold'].to_f : nil
-            @upper_threshold = element['upper_threshold'] ? element['upper_threshold'].to_f : nil
-            if @lower_threshold.nil? and @upper_threshold.nil?
-              raise Fluent::ConfigError, "At least one of lower_threshold or upper_threshold must be specified for 'check numeric'"
-            end
-          when 'regexp'
-            @check = :regexp
-            @include_pattern = element['include_pattern'] ? Regexp.compile(element['include_pattern']) : nil
-            @exclude_pattern = element['exclude_pattern'] ? Regexp.compile(element['exclude_pattern']) : nil
-            if @include_pattern.nil? and @exclude_pattern.nil?
-              raise Fluent::ConfigError, "At least one of include_pattern or exclude_pattern must be specified for 'check regexp'"
-            end
-          else
-            raise Fluent::ConfigError, "invalid check value of test [numeric/regexp]: '#{v}'"
-          end
-        when 'target_key'
-          @target_key = v
+    def initialize(section)
+      @check = section.check
+      @target_key = section.target_key
+      case @check
+      when :tag
+        if !section.include_pattern && !section.exclude_pattern
+          raise Fluent::ConfigError, "At least one of include_pattern or exclude_pattern must be specified for 'check tag'"
         end
-      end
-      unless @check
-        raise Fluent::ConfigError, "'check' missing in <test> section"
-      end
-      if @target_key.nil? and @check != :tag
-        raise Fluent::ConfigError, "'target_key' missing in <test> section"
+        @include_pattern = section.include_pattern ? Regexp.compile(section.include_pattern) : nil
+        @exclude_pattern = section.exclude_pattern ? Regexp.compile(section.exclude_pattern) : nil
+      when :numeric
+        if !section.lower_threshold && !section.upper_threshold
+          raise Fluent::ConfigError, "At least one of lower_threshold or upper_threshold must be specified for 'check numeric'"
+        end
+        raise Fluent::ConfigError, "'target_key' is needed for 'check numeric'" unless @target_key
+        @lower_threshold = section.lower_threshold
+        @upper_threshold = section.upper_threshold
+      when :regexp
+        if !section.include_pattern && !section.exclude_pattern
+          raise Fluent::ConfigError, "At least one of include_pattern or exclude_pattern must be specified for 'check regexp'"
+        end
+        raise Fluent::ConfigError, "'target_key' is needed for 'check regexp'" unless @target_key
+        @include_pattern = section.include_pattern ? Regexp.compile(section.include_pattern) : nil
+        @exclude_pattern = section.exclude_pattern ? Regexp.compile(section.exclude_pattern) : nil
+      else
+        raise "BUG: unknown check: #{@check}"
       end
     end
 
@@ -280,66 +306,64 @@ class Fluent::NotifierOutput < Fluent::Output
   class Definition
     attr_accessor :tag, :tag_warn, :tag_crit
     attr_accessor :intervals, :repetitions
-    attr_accessor :pattern, :check, :target_keys, :target_key_pattern, :exclude_key_pattern
+    attr_accessor :pattern, :target_keys, :target_key_pattern, :exclude_key_pattern
     attr_accessor :crit_threshold, :warn_threshold # for 'numeric_upward', 'numeric_downward'
     attr_accessor :crit_regexp, :warn_regexp # for 'string_find'
 
-    def initialize(element, defaults)
-      element.keys.each do |k|
-        case k
-        when 'pattern'
-          @pattern = element[k]
-        when 'check'
-          case element[k]
-          when 'numeric_upward'
-            @check = :upward
-            unless element.has_key?('crit_threshold') and element.has_key?('warn_threshold')
-              raise Fluent::ConfigError, "Both of crit_threshold and warn_threshold must be specified for 'check numeric_upward'"
-            end
-            @crit_threshold = element['crit_threshold'].to_f
-            @warn_threshold = element['warn_threshold'].to_f
-          when 'numeric_downward'
-            @check = :downward
-            unless element.has_key?('crit_threshold') and element.has_key?('warn_threshold')
-              raise Fluent::ConfigError, "Both of crit_threshold and warn_threshold must be specified for 'check_numeric_downward'"
-            end
-            @crit_threshold = element['crit_threshold'].to_f
-            @warn_threshold = element['warn_threshold'].to_f
-          when 'string_find'
-            @check = :find
-            unless element.has_key?('crit_regexp') and element.has_key?('warn_regexp')
-              raise Fluent::ConfigError, "Both of crit_regexp and warn_regexp must be specified for 'check string_find'"
-            end
-            @crit_regexp = Regexp.compile(element['crit_regexp'].to_s)
-            @warn_regexp = Regexp.compile(element['warn_regexp'].to_s)
-          else
-            raise Fluent::ConfigError, "invalid check type: #{element[k]}"
-          end
-        when 'target_keys'
-          @target_keys = element['target_keys'].split(',')
-        when 'target_key_pattern'
-          @target_key_pattern = Regexp.compile(element['target_key_pattern'])
-          @exclude_key_pattern = Regexp.compile(element['exclude_key_pattern'] || '^$')
-        end
-      end
-      if @pattern.nil? or @pattern.length < 1
-        raise Fluent::ConfigError, "pattern must be set"
+    def initialize(section, plugin)
+      @pattern = section.pattern
+
+      @tag = section.tag || plugin.default_tag
+      @tag_warn = section.tag_warn || plugin.default_tag_warn
+      @tag_crit = section.tag_crit || plugin.default_tag_crit
+
+      @target_keys = section.target_keys
+      @target_key_pattern = section.target_key_pattern ? Regexp.compile(section.target_key_pattern) : nil
+      @exclude_key_pattern = section.exclude_key_pattern ? Regexp.compile(section.exclude_key_pattern) : nil
+      if !@target_keys and !@target_key_pattern
+        raise Fluent::ConfigError, "out_notifier needs one of target_keys or target_key_pattern in <def>"
       end
-      if @target_keys.nil? and @target_key_pattern.nil?
-        raise Fluent::ConfigError, "out_notifier needs one of target_keys or target_key_pattern"
+
+      case section.check
+      when :numeric_upward
+        @check = :upward
+        if !section.crit_threshold || !section.warn_threshold
+          raise Fluent::ConfigError, "Both of crit_threshold and warn_threshold must be specified for 'check numeric_upward'"
+        end
+        @crit_threshold = section.crit_threshold
+        @warn_threshold = section.warn_threshold
+      when :numeric_downward
+        @check = :downward
+        if !section.crit_threshold || !section.warn_threshold
+          raise Fluent::ConfigError, "Both of crit_threshold and warn_threshold must be specified for 'check numeric_downward'"
+        end
+        @crit_threshold = section.crit_threshold
+        @warn_threshold = section.warn_threshold
+      when :string_find
+        @check = :find
+        if !section.crit_regexp || !section.warn_regexp
+          raise Fluent::ConfigError, "Both of crit_regexp and warn_regexp must be specified for 'check string_find'"
+        end
+        @crit_regexp = Regexp.compile(section.crit_regexp)
+        @warn_regexp = Regexp.compile(section.warn_regexp)
+      else
+        raise "BUG: unknown check: #{section.check}"
       end
-      @tag = element['tag'] || defaults[:tag]
-      @tag_warn = element['tag_warn'] || defaults[:tag_warn]
-      @tag_crit = element['tag_crit'] || defaults[:tag_crit]
-      @intervals = [
-                    (element['interval_1st'] || defaults[:interval_1st]).to_f,
-                    (element['interval_2nd'] || defaults[:interval_2nd]).to_f,
-                    (element['interval_3rd'] || defaults[:interval_3rd]).to_f
-                   ]
-      @repetitions = [
-                      (element['repetitions_1st'] || defaults[:repetitions_1st]).to_f,
-                      (element['repetitions_2nd'] || defaults[:repetitions_2nd]).to_f
-                     ]
+
+      @intervals = if section.intervals
+                     section.intervals
+                   elsif section.interval_1st || section.interval_2nd || section.interval_3rd
+                     [section.interval_1st || plugin.default_intervals[0], section.interval_2nd || plugin.default_intervals[1], section.interval_3rd || plugin.default_intervals[2]]
+                   else
+                     plugin.default_intervals
+                   end
+      @repetitions = if section.repetitions
+                       section.repetitions
+                     elsif section.repetitions_1st || section.repetitions_2nd
+                       [section.repetitions_1st || plugin.default_repetitions[0], section.repetitions_2nd || plugin.default_repetitions[1]]
+                     else
+                       plugin.default_repetitions
+                     end
     end
 
     def match?(key)
@@ -350,16 +374,16 @@ class Fluent::NotifierOutput < Fluent::Output
       end
     end
 
-# {
-#  'pattern' => 'http_status_errors',
-#  'target_tag' => 'httpstatus.blog',
-#  'target_key' => 'blog_5xx_percentage',
-#  'check_type' => 'numeric_upward'
-#  'level' => 'warn', # 'regexp' => '[WARN] .* MUST BE CHECKED!$'
-#  'threshold' => 25,
-#  'value' => 49, # 'value' => '2012/05/15 18:01:59 [WARN] wooooops, MUST BE CHECKED!'
-#  'message_time' => Time.instance
-# }
+    # {
+    #  'pattern' => 'http_status_errors',
+    #  'target_tag' => 'httpstatus.blog',
+    #  'target_key' => 'blog_5xx_percentage',
+    #  'check_type' => 'numeric_upward'
+    #  'level' => 'warn', # 'regexp' => '[WARN] .* MUST BE CHECKED!$'
+    #  'threshold' => 25,
+    #  'value' => 49, # 'value' => '2012/05/15 18:01:59 [WARN] wooooops, MUST BE CHECKED!'
+    #  'message_time' => Time.instance
+    # }
     def check(tag, time, record, key)
       case @check
       when :upward