fluent-plugin-hipchat 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05583b44258b849316908fb2876939ac01ec29b3
-  data.tar.gz: 77b650a614878b2abdfdf3bb27ccc37876c935eb
+  metadata.gz: 41892c64df61d3496d02924d73f14089e969ab09
+  data.tar.gz: 4d7545f990da26894984c0eb2e7148a7bf98567b
 SHA512:
-  metadata.gz: bee6c20e5389de9d77134d07f402d0f57a58eb7930369b820155b30b766f5b09fcd01cb77588894c0b6dfcff9def758489a13c44a63dbe8df77924415f113e66
-  data.tar.gz: e26c011ea2707f9c401e4f99ef1f775fcf9e07854e4363bf8c1275f415933cdbb121a444b381a4642f7bd88a07b43b23a8e38562f9a8cea404d559dcd439112d
+  metadata.gz: 0645335bd45ddafe75bd9fd034568a05083ef691408f2ab954ecd37b52b7f476744090b2ba3262b9c196444259e0e2528e03d71795eb484cf56e47f758d73476
+  data.tar.gz: f8883ccf6e965bf0eb74b24c64a224d005a8f4eefb09637405308f516613e1eb524ae1eca7a5b414369973e2fc5085507a1a575a783ff236ca9b900beeed3192

data/VERSION

@@ -1 +1 @@
-0.1.4
+0.1.5

data/lib/fluent/plugin/out_hipchat.rb

@@ -52,7 +52,7 @@ module Fluent
           send_message(record) if record['message']
           set_topic(record) if record['topic']
         rescue => e
-          $log.error("HipChat Error: #{e} / #{e.message}")
+          $log.error("HipChat Error:", :error_class => e.class, :error => e.message)
         end
       end
     end
@@ -68,14 +68,16 @@ module Fluent
       end
       color = COLORS.include?(record['color']) ? record['color'] : @default_color
       message_format = FORMAT.include?(record['format']) ? record['format'] : @default_format
-      @hipchat.rooms_message(room, from, message, notify, color, message_format)
+      response = @hipchat.rooms_message(room, from, message, notify, color, message_format)
+      raise StandardError, response['error']['message'].to_s if defined?(response['error']['message'])
     end
 
     def set_topic(record)
       room = record['room'] || @default_room
       from = record['from'] || @default_from
       topic = record['topic']
-      @hipchat.rooms_topic(room, topic, from)
+      response = @hipchat.rooms_topic(room, topic, from)
+      raise StandardError, response['error']['message'].to_s if defined?(response['error']['message'])
     end
   end
 end

data/test/plugin/out_hipchat.rb

@@ -70,6 +70,26 @@ class HipchatOutputTest < Test::Unit::TestCase
     d.run
   end
 
+  def test_set_topic_response_error
+    d = create_driver
+    stub(d.instance.hipchat).rooms_topic('testroom', 'foo', 'testuser') {
+      {'error' => { 'code' => 400, 'type' => 'Bad Request', 'message' => 'Topic body must be between 1 and 250 characters.' } }
+    }
+    stub($log).error("HipChat Error:", :error_class => StandardError, :error => 'Topic body must be between 1 and 250 characters.')
+    d.emit({'topic' => 'foo'})
+    d.run
+  end
+
+  def test_send_message_response_error
+    d = create_driver
+    stub(d.instance.hipchat).rooms_message('testroom', '<abc>', 'foo', 0, 'yellow', 'html') {
+      {'error' => { 'code' => 400, 'type' => 'Bad Request', 'message' => 'From name may not contain HTML.' } }
+    }
+    stub($log).error("HipChat Error:", :error_class => StandardError, :error => 'From name may not contain HTML.')
+    d.emit({'from' => '<abc>', 'message' => 'foo'})
+    d.run
+  end
+
   def test_color_validate
     d = create_driver
     stub(d.instance.hipchat).rooms_message('testroom', 'testuser', 'foo', 0, 'yellow', 'html')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fluent-plugin-hipchat
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Yuichi Tateno
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-22 00:00:00.000000000 Z
+date: 2014-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fluentd