fluent-plugin-google-cloud 0.8.6 → 0.10.1

data/test/plugin/asserts.rb

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+require 'prometheus/client'
+
 # Additional assert functions.
 module Asserts
   # For an optional field with default values, Protobuf omits the field when it

data/test/plugin/base_test.rb

@@ -19,11 +19,12 @@ Coveralls.wear!
 require 'google/apis'
 require 'helper'
 require 'mocha/test_unit'
-require 'webmock/test_unit'
 require 'prometheus/client'
+require 'webmock/test_unit'
 
 require_relative 'asserts'
 require_relative 'constants'
+require_relative 'utils'
 
 module Monitoring
   # Prevent OpenCensus from writing to the network.
@@ -38,21 +39,11 @@ end
 module BaseTest
   include Asserts
   include Constants
+  include Utils
 
   def setup
     Fluent::Test.setup
-    # delete environment variables that googleauth uses to find credentials.
-    ENV.delete(CREDENTIALS_PATH_ENV_VAR)
-    # service account env.
-    ENV.delete(PRIVATE_KEY_VAR)
-    ENV.delete(CLIENT_EMAIL_VAR)
-    ENV.delete(PROJECT_ID_VAR)
-    # authorized_user env.
-    ENV.delete(CLIENT_ID_VAR)
-    ENV.delete(CLIENT_SECRET_VAR)
-    ENV.delete(REFRESH_TOKEN_VAR)
-    # home var, which is used to find $HOME/.gcloud/...
-    ENV.delete('HOME')
+    delete_env_vars
 
     # Unregister Prometheus metrics.
     registry = Prometheus::Client.registry
@@ -62,7 +53,7 @@ module BaseTest
     registry.unregister(:stackdriver_dropped_entries_count)
     registry.unregister(:stackdriver_retried_entries_count)
 
-    setup_auth_stubs
+    setup_auth_stubs('https://www.googleapis.com/oauth2/v4/token')
     @logs_sent = []
   end
 
@@ -107,7 +98,7 @@ module BaseTest
 
   def test_configure_metadata_missing_parts_on_other_platforms
     setup_no_metadata_service_stubs
-    Fluent::GoogleCloudOutput::CredentialsInfo.stubs(:project_id).returns(nil)
+    Common::Utils::CredentialsInfo.stubs(:project_id).returns(nil)
     [[CONFIG_MISSING_METADATA_PROJECT_ID, ['project_id'], false],
      [CONFIG_MISSING_METADATA_ZONE, [], true],
      [CONFIG_MISSING_METADATA_VM_ID, [], true],
@@ -131,8 +122,8 @@ module BaseTest
 
   def test_configure_ignores_unknown_monitoring_type
     # Verify that driver creation succeeds when monitoring type is not
-    # "prometheus" (in which case, we simply don't record metrics),
-    # and that the counters are set to nil.
+    # "prometheus" or "opencensus" (in which case, we simply don't record
+    # metrics), and that the counters are set to nil.
     setup_gce_metadata_stubs
     create_driver(CONFIG_UNKNOWN_MONITORING_TYPE)
     assert_nil(Prometheus::Client.registry.get(
@@ -145,6 +136,67 @@ module BaseTest
                  :stackdriver_dropped_entries_count))
     assert_nil(Prometheus::Client.registry.get(
                  :stackdriver_retried_entries_count))
+    assert_nil(OpenCensus::Stats::MeasureRegistry.get(
+                 Monitoring::MetricTranslator.new(
+                   :stackdriver_successful_requests_count, {})))
+    assert_nil(OpenCensus::Stats::MeasureRegistry.get(
+                 Monitoring::MetricTranslator.new(
+                   :stackdriver_failed_requests_count, {})))
+    assert_nil(OpenCensus::Stats::MeasureRegistry.get(
+                 Monitoring::MetricTranslator.new(
+                   :stackdriver_ingested_entries_count, {})))
+    assert_nil(OpenCensus::Stats::MeasureRegistry.get(
+                 Monitoring::MetricTranslator.new(
+                   :stackdriver_dropped_entries_count, {})))
+    assert_nil(OpenCensus::Stats::MeasureRegistry.get(
+                 Monitoring::MetricTranslator.new(
+                   :stackdriver_retried_entries_count, {})))
+  end
+
+  def test_configure_uses_metrics_resource
+    setup_gce_metadata_stubs
+    [CONFIG_METRICS_RESOURCE_JSON,
+     CONFIG_METRICS_RESOURCE_HASH,
+     CONFIG_METRICS_RESOURCE_JSON_HASH
+    ].each_with_index do |config, index|
+      d = create_driver(config)
+      assert_equal 'custom_resource', d.instance.monitoring_resource.type, \
+                   "Index #{index}"
+      assert_equal '123', d.instance.monitoring_resource.labels['label1'], \
+                   "Index #{index}"
+      assert_equal 'abc', d.instance.monitoring_resource.labels['label2'], \
+                   "Index #{index}"
+      assert_true d.instance.instance_variable_get(:@enable_monitoring)
+      registry = d.instance.instance_variable_get(:@registry)
+      assert_not_nil registry
+      exporter = registry.instance_variable_get(:@exporter)
+      assert_equal 'custom_resource', exporter.resource_type, "Index #{index}"
+      assert_equal({ 'label1' => '123', 'label2' => 'abc' },
+                   exporter.resource_labels, "Index #{index}")
+    end
+  end
+
+  def test_configure_metrics_resource_validation
+    setup_gce_metadata_stubs
+    {
+      CONFIG_METRICS_RESOURCE_JSON_NO_TYPE => /type must be a string/,
+      CONFIG_METRICS_RESOURCE_JSON_BAD_LABELS => /labels must be a hash/,
+      CONFIG_METRICS_RESOURCE_JSON_BAD_KEYS =>
+        /unrecognized keys: \[:random\]/,
+      CONFIG_METRICS_RESOURCE_JSON_BAD_KEYS_LABELS =>
+        /unrecognized keys: \[:"labels\.random"\]/,
+      CONFIG_METRICS_RESOURCE_JSON_BAD_KEYS_NO_LABELS =>
+        /unrecognized keys: \[:random\]/
+    }.each_with_index do |(config, pattern), index|
+      begin
+        create_driver(config)
+        assert false,
+               "Invalid config at index #{index} should have raised an error."
+      rescue Fluent::ConfigError => error
+        assert error.message.match?(pattern), \
+               "Index #{index} failed: got #{error.message}."
+      end
+    end
   end
 
   def test_metadata_loading
@@ -1925,116 +1977,6 @@ module BaseTest
 
   private
 
-  def stub_metadata_request(metadata_path, response_body)
-    stub_request(:get, 'http://169.254.169.254/computeMetadata/v1/' +
-                 metadata_path)
-      .to_return(body: response_body, status: 200,
-                 headers: { 'Content-Length' => response_body.length })
-  end
-
-  def setup_no_metadata_service_stubs
-    # Simulate a machine with no metadata service present
-    stub_request(:any, %r{http://169.254.169.254/.*})
-      .to_raise(Errno::EHOSTUNREACH)
-  end
-
-  def setup_gce_metadata_stubs
-    # Stub the root, used for platform detection by the plugin and 'googleauth'.
-    stub_request(:get, 'http://169.254.169.254')
-      .to_return(status: 200, headers: { 'Metadata-Flavor' => 'Google' })
-
-    # Create stubs for all the GCE metadata lookups the agent needs to make.
-    stub_metadata_request('project/project-id', PROJECT_ID)
-    stub_metadata_request('instance/zone', FULLY_QUALIFIED_ZONE)
-    stub_metadata_request('instance/id', VM_ID)
-    stub_metadata_request('instance/attributes/',
-                          "attribute1\nattribute2\nattribute3")
-
-    # Used by 'googleauth' to fetch the default service account credentials.
-    stub_request(:get, 'http://169.254.169.254/computeMetadata/v1/' \
-                 'instance/service-accounts/default/token')
-      .to_return(body: %({"access_token": "#{FAKE_AUTH_TOKEN}"}),
-                 status: 200,
-                 headers: { 'Content-Length' => FAKE_AUTH_TOKEN.length,
-                            'Content-Type' => 'application/json' })
-  end
-
-  def setup_ec2_metadata_stubs
-    # Stub the root, used for platform detection.
-    stub_request(:get, 'http://169.254.169.254')
-      .to_return(status: 200, headers: { 'Server' => 'EC2ws' })
-
-    # Stub the identity document lookup made by the agent.
-    stub_request(:get, 'http://169.254.169.254/latest/dynamic/' \
-                 'instance-identity/document')
-      .to_return(body: EC2_IDENTITY_DOCUMENT, status: 200,
-                 headers: { 'Content-Length' => EC2_IDENTITY_DOCUMENT.length })
-  end
-
-  def setup_auth_stubs
-    # Used when loading credentials from a JSON file.
-    stub_request(:post, 'https://www.googleapis.com/oauth2/v4/token')
-      .with(body: hash_including(grant_type: AUTH_GRANT_TYPE))
-      .to_return(body: %({"access_token": "#{FAKE_AUTH_TOKEN}"}),
-                 status: 200,
-                 headers: { 'Content-Length' => FAKE_AUTH_TOKEN.length,
-                            'Content-Type' => 'application/json' })
-
-    stub_request(:post, 'https://www.googleapis.com/oauth2/v4/token')
-      .with(body: hash_including(grant_type: 'refresh_token'))
-      .to_return(body: %({"access_token": "#{FAKE_AUTH_TOKEN}"}),
-                 status: 200,
-                 headers: { 'Content-Length' => FAKE_AUTH_TOKEN.length,
-                            'Content-Type' => 'application/json' })
-  end
-
-  def setup_managed_vm_metadata_stubs
-    stub_metadata_request(
-      'instance/attributes/',
-      "attribute1\ngae_backend_name\ngae_backend_version\nlast_attribute")
-    stub_metadata_request('instance/attributes/gae_backend_name',
-                          MANAGED_VM_BACKEND_NAME)
-    stub_metadata_request('instance/attributes/gae_backend_version',
-                          MANAGED_VM_BACKEND_VERSION)
-  end
-
-  def setup_k8s_metadata_stubs(should_respond = true)
-    if should_respond
-      stub_metadata_request(
-        'instance/attributes/',
-        "attribute1\ncluster-location\ncluster-name\nlast_attribute")
-      stub_metadata_request('instance/attributes/cluster-location',
-                            K8S_LOCATION2)
-      stub_metadata_request('instance/attributes/cluster-name',
-                            K8S_CLUSTER_NAME)
-    else
-      ['cluster-location', 'cluster-name'].each do |metadata_name|
-        stub_request(:get, %r{.*instance/attributes/#{metadata_name}.*})
-          .to_return(status: 404,
-                     body: 'The requested URL /computeMetadata/v1/instance/' \
-                           "attributes/#{metadata_name} was not found on this" \
-                           ' server.')
-      end
-    end
-  end
-
-  def setup_dataproc_metadata_stubs
-    stub_metadata_request(
-      'instance/attributes/',
-      "attribute1\ndataproc-cluster-uuid\ndataproc-cluster-name")
-    stub_metadata_request('instance/attributes/dataproc-cluster-name',
-                          DATAPROC_CLUSTER_NAME)
-    stub_metadata_request('instance/attributes/dataproc-cluster-uuid',
-                          DATAPROC_CLUSTER_UUID)
-    stub_metadata_request('instance/attributes/dataproc-region',
-                          DATAPROC_REGION)
-  end
-
-  def clear_metrics
-    Prometheus::Client.registry.instance_variable_set('@metrics', {})
-    OpenCensus::Stats.ensure_recorder.clear_stats
-  end
-
   # Provide a stub context that initializes @logs_sent, executes the block and
   # resets WebMock at the end.
   def new_stub_context
@@ -2076,18 +2018,6 @@ module BaseTest
     }
   end
 
-  def gke_container_log_entry(log)
-    {
-      log: log,
-      LOCAL_RESOURCE_ID_KEY =>
-        "#{CONTAINER_LOCAL_RESOURCE_ID_PREFIX}.#{CONTAINER_NAMESPACE_ID}" \
-        ".#{K8S_POD_NAME}.#{K8S_CONTAINER_NAME}"
-    }
-  end
-
-  # TODO(qingling128): Temporary fallback for metadata agent restarts.
-  # k8s resources.
-
   def k8s_container_log_entry(log,
                               local_resource_id: K8S_LOCAL_RESOURCE_ID)
     {

data/test/plugin/constants.rb

@@ -45,7 +45,7 @@ end
 
 # Constants used by unit tests for Google Cloud Logging plugin.
 module Constants
-  include Fluent::GoogleCloudOutput::ServiceConstants
+  include Common::ServiceConstants
   include Fluent::GoogleCloudOutput::ConfigConstants
   include Fluent::GoogleCloudOutput::InternalConstants
 
@@ -433,6 +433,56 @@ module Constants
     monitoring_type    not_prometheus
   ).freeze
 
+  # rubocop:disable Metrics/LineLength
+  CONFIG_METRICS_RESOURCE_JSON = %(
+    enable_monitoring  true
+    monitoring_type    opencensus
+    metrics_resource   {"type":"custom_resource","labels":{"label1":"123","label2":"abc"}}
+  ).freeze
+
+  CONFIG_METRICS_RESOURCE_HASH = %(
+    enable_monitoring  true
+    monitoring_type    opencensus
+    metrics_resource   type:custom_resource, labels.label1:123, labels.label2:abc
+  ).freeze
+
+  CONFIG_METRICS_RESOURCE_JSON_HASH = %(
+    enable_monitoring  true
+    monitoring_type    opencensus
+    metrics_resource   {"type":"custom_resource","labels.label1":"123","labels.label2":"abc"}
+  ).freeze
+
+  CONFIG_METRICS_RESOURCE_JSON_NO_TYPE = %(
+    enable_monitoring  true
+    monitoring_type    opencensus
+    metrics_resource   {"labels":{"label1":"123","label2":"abc"}}
+  ).freeze
+
+  CONFIG_METRICS_RESOURCE_JSON_BAD_LABELS = %(
+    enable_monitoring  true
+    monitoring_type    opencensus
+    metrics_resource   {"type":"custom_resource","labels":"123"}
+  ).freeze
+
+  CONFIG_METRICS_RESOURCE_JSON_BAD_KEYS = %(
+    enable_monitoring  true
+    monitoring_type    opencensus
+    metrics_resource   {"type":"custom_resource","labels":{"label1":"123"},"random":"x"}
+  ).freeze
+
+  CONFIG_METRICS_RESOURCE_JSON_BAD_KEYS_LABELS = %(
+    enable_monitoring  true
+    monitoring_type    opencensus
+    metrics_resource   {"type":"custom_resource","labels":{"label1":"123"},"labels.random":"x"}
+  ).freeze
+
+  CONFIG_METRICS_RESOURCE_JSON_BAD_KEYS_NO_LABELS = %(
+    enable_monitoring  true
+    monitoring_type    opencensus
+    metrics_resource   {"type":"custom_resource","labels.label1":"123","random":"x"}
+  ).freeze
+  # rubocop:enable Metrics/LineLength
+
   # For statusz.
   CONFIG_STATUSZ = %(
     statusz_port                  5678
@@ -472,11 +522,19 @@ module Constants
   ).freeze
 
   # For analyze_config.
-  CONFIG_ANALYZE_CONFIG = %(
+  CONFIG_ANALYZE_CONFIG_PROMETHEUS = %(
+    google_fluentd_config_path          \
+      test/plugin/data/google-fluentd-custom.conf
+    google_fluentd_baseline_config_path \
+      test/plugin/data/google-fluentd-baseline.conf
+    monitoring_type prometheus
+  ).freeze
+  CONFIG_ANALYZE_CONFIG_OPENCENSUS = %(
     google_fluentd_config_path          \
       test/plugin/data/google-fluentd-custom.conf
     google_fluentd_baseline_config_path \
       test/plugin/data/google-fluentd-baseline.conf
+    monitoring_type opencensus
   ).freeze
 
   # Service configurations for various services.

data/test/plugin/test_driver.rb

@@ -16,19 +16,6 @@ require 'fluent/engine'
 require 'fluent/event'
 require 'fluent/test/input_test'
 
-module Fluent
-  module Test
-    # rubocop:disable Style/ClassVars
-    class BufferedOutputTestDriver < InputTestDriver
-      @@run_method = BufferedOutputTestDriver.instance_method(:run)
-      def run(num_waits = 0)
-        @@run_method.bind(self).call(num_waits)
-      end
-    end
-    # rubocop:enable Style/ClassVars
-  end
-end
-
 module Fluent
   module Test
     # Similar to the standard BufferedOutputTestDriver, but allows multiple tags
@@ -46,7 +33,7 @@ module Fluent
         self
       end
 
-      def run(num_waits = 0)
+      def run(num_waits = 10)
         result = nil
         super(num_waits) do
           chunk = @instance.buffer.generate_chunk(

data/test/plugin/test_filter_analyze_config.rb

@@ -15,6 +15,7 @@
 require_relative '../helper'
 require_relative 'asserts'
 require_relative 'constants'
+require_relative 'utils'
 
 require 'fluent/test/driver/filter'
 require 'fluent/plugin/filter_analyze_config'
@@ -24,11 +25,13 @@ class FilterAnalyzeConfigTest < Test::Unit::TestCase
   include Asserts
   include Constants
   include Fluent::AnalyzeConfigFilter::Constants
+  include Utils
 
   APPLICATION_DEFAULT_CONFIG = ''.freeze
 
   def setup
     Fluent::Test.setup
+    delete_env_vars
   end
 
   def test_config_file_does_not_exist
@@ -39,145 +42,155 @@ class FilterAnalyzeConfigTest < Test::Unit::TestCase
   end
 
   def test_analyze_config
-    create_driver(CONFIG_ANALYZE_CONFIG)
+    setup_auth_stubs('https://oauth2.googleapis.com/token')
+    setup_gce_metadata_stubs
+    [
+      [CONFIG_ANALYZE_CONFIG_PROMETHEUS,
+       method(:assert_prometheus_metric_value)],
+      [CONFIG_ANALYZE_CONFIG_OPENCENSUS,
+       method(:assert_opencensus_metric_value)]
+    ].each do |config, assert_metric_value|
+      clear_metrics
+      create_driver(config)
 
-    # Default plugins, with default config.
-    assert_prometheus_metric_value(
-      :stackdriver_enabled_plugins,
-      1,
-      plugin_name: 'source/syslog/tcp',
-      is_default_plugin: true,
-      has_default_value: true,
-      has_ruby_snippet: false)
-    assert_prometheus_metric_value(
-      :stackdriver_enabled_plugins,
-      1,
-      plugin_name: 'source/tail/apache-access',
-      is_default_plugin: true,
-      has_default_value: true,
-      has_ruby_snippet: false)
-    assert_prometheus_metric_value(
-      :stackdriver_enabled_plugins,
-      1,
-      plugin_name: 'filter/add_insert_ids',
-      is_default_plugin: true,
-      has_default_value: true,
-      has_ruby_snippet: false)
+      # Default plugins, with default config.
+      assert_metric_value.call(
+        :stackdriver_enabled_plugins,
+        1,
+        plugin_name: 'source/syslog/tcp',
+        is_default_plugin: true,
+        has_default_value: true,
+        has_ruby_snippet: false)
+      assert_metric_value.call(
+        :stackdriver_enabled_plugins,
+        1,
+        plugin_name: 'source/tail/apache-access',
+        is_default_plugin: true,
+        has_default_value: true,
+        has_ruby_snippet: false)
+      assert_metric_value.call(
+        :stackdriver_enabled_plugins,
+        1,
+        plugin_name: 'filter/add_insert_ids',
+        is_default_plugin: true,
+        has_default_value: true,
+        has_ruby_snippet: false)
 
-    # Default plugins, with custom config.
-    assert_prometheus_metric_value(
-      :stackdriver_enabled_plugins,
-      1,
-      plugin_name: 'match/google_cloud',
-      is_default_plugin: true,
-      has_default_value: false,
-      has_ruby_snippet: false)
+      # Default plugins, with custom config.
+      assert_metric_value.call(
+        :stackdriver_enabled_plugins,
+        1,
+        plugin_name: 'match/google_cloud',
+        is_default_plugin: true,
+        has_default_value: false,
+        has_ruby_snippet: false)
 
-    # Custom plugins, some with embedded Ruby.
-    assert_prometheus_metric_value(
-      :stackdriver_enabled_plugins,
-      1,
-      plugin_name: 'filter',
-      is_default_plugin: false,
-      has_default_value: false,
-      has_ruby_snippet: false)
-    assert_prometheus_metric_value(
-      :stackdriver_enabled_plugins,
-      1,
-      plugin_name: 'filter/record_transformer',
-      is_default_plugin: false,
-      has_default_value: false,
-      has_ruby_snippet: true)
-    assert_prometheus_metric_value(
-      :stackdriver_enabled_plugins,
-      1,
-      plugin_name: 'match/stdout',
-      is_default_plugin: false,
-      has_default_value: false,
-      has_ruby_snippet: true)
+      # Custom plugins, some with embedded Ruby.
+      assert_metric_value.call(
+        :stackdriver_enabled_plugins,
+        1,
+        plugin_name: 'filter',
+        is_default_plugin: false,
+        has_default_value: false,
+        has_ruby_snippet: false)
+      assert_metric_value.call(
+        :stackdriver_enabled_plugins,
+        1,
+        plugin_name: 'filter/record_transformer',
+        is_default_plugin: false,
+        has_default_value: false,
+        has_ruby_snippet: true)
+      assert_metric_value.call(
+        :stackdriver_enabled_plugins,
+        1,
+        plugin_name: 'match/stdout',
+        is_default_plugin: false,
+        has_default_value: false,
+        has_ruby_snippet: true)
 
-    # For out_google_cloud, 3 params are present.
-    assert_prometheus_metric_value(
-      :stackdriver_config_usage,
-      1,
-      plugin_name: 'google_cloud',
-      param: 'adjust_invalid_timestamps',
-      is_present: true,
-      has_default_value: true)
-    assert_prometheus_metric_value(
-      :stackdriver_config_usage,
-      1,
-      plugin_name: 'google_cloud',
-      param: 'autoformat_stackdriver_trace',
-      is_present: true,
-      has_default_value: false)
-    assert_prometheus_metric_value(
-      :stackdriver_config_usage,
-      1,
-      plugin_name: 'google_cloud',
-      param: 'coerce_to_utf8',
-      is_present: true,
-      has_default_value: false)
-    # The remaining "google_cloud" params are not present.
-    # The are no params for "detect_exceptions".
-    %w(
-      auth_method
-      detect_json
-      enable_monitoring
-      gcm_service_address
-      grpc_compression_algorithm
-      http_request_key
-      insert_id_key
-      label_map
-      labels
-      labels_key
-      logging_api_url
-      monitoring_type
-      non_utf8_replacement_string
-      operation_key
-      private_key_email
-      private_key_passphrase
-      private_key_path
-      project_id
-      source_location_key
-      span_id_key
-      statusz_port
-      trace_key
-      trace_sampled_key
-      use_grpc
-      use_metadata_service
-      vm_id
-      vm_name
-      zone
-    ).each do |p|
-      assert_prometheus_metric_value(
+      # For out_google_cloud, 3 params are present.
+      assert_metric_value.call(
         :stackdriver_config_usage,
         1,
         plugin_name: 'google_cloud',
-        param: p,
-        is_present: false,
+        param: 'adjust_invalid_timestamps',
+        is_present: true,
+        has_default_value: true)
+      assert_metric_value.call(
+        :stackdriver_config_usage,
+        1,
+        plugin_name: 'google_cloud',
+        param: 'autoformat_stackdriver_trace',
+        is_present: true,
         has_default_value: false)
-    end
+      assert_metric_value.call(
+        :stackdriver_config_usage,
+        1,
+        plugin_name: 'google_cloud',
+        param: 'coerce_to_utf8',
+        is_present: true,
+        has_default_value: false)
+      # The remaining "google_cloud" params are not present.
+      # The are no params for "detect_exceptions".
+      %w(
+        auth_method
+        detect_json
+        enable_monitoring
+        gcm_service_address
+        grpc_compression_algorithm
+        http_request_key
+        insert_id_key
+        label_map
+        labels
+        labels_key
+        logging_api_url
+        monitoring_type
+        non_utf8_replacement_string
+        operation_key
+        private_key_email
+        private_key_passphrase
+        private_key_path
+        project_id
+        source_location_key
+        span_id_key
+        statusz_port
+        trace_key
+        trace_sampled_key
+        use_grpc
+        use_metadata_service
+        vm_id
+        vm_name
+        zone
+      ).each do |p|
+        assert_metric_value.call(
+          :stackdriver_config_usage,
+          1,
+          plugin_name: 'google_cloud',
+          param: p,
+          is_present: false,
+          has_default_value: false)
+      end
 
-    # We also export values for the bools.
-    assert_prometheus_metric_value(
-      :stackdriver_config_bool_values,
-      1,
-      plugin_name: 'google_cloud',
-      param: 'adjust_invalid_timestamps',
-      value: true)
-    assert_prometheus_metric_value(
-      :stackdriver_config_bool_values,
-      1,
-      plugin_name: 'google_cloud',
-      param: 'autoformat_stackdriver_trace',
-      value: false)
-    assert_prometheus_metric_value(
-      :stackdriver_config_bool_values,
-      1,
-      plugin_name: 'google_cloud',
-      param: 'coerce_to_utf8',
-      value: true)
+      # We also export values for the bools.
+      assert_metric_value.call(
+        :stackdriver_config_bool_values,
+        1,
+        plugin_name: 'google_cloud',
+        param: 'adjust_invalid_timestamps',
+        value: true)
+      assert_metric_value.call(
+        :stackdriver_config_bool_values,
+        1,
+        plugin_name: 'google_cloud',
+        param: 'autoformat_stackdriver_trace',
+        value: false)
+      assert_metric_value.call(
+        :stackdriver_config_bool_values,
+        1,
+        plugin_name: 'google_cloud',
+        param: 'coerce_to_utf8',
+        value: true)
+    end
   end
 
   def create_driver(conf = APPLICATION_DEFAULT_CONFIG)