fluent-plugin-amplitude 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 269720e5fb9a25129b61a720c5730c4fe0ebd6b1
-  data.tar.gz: 37b6a8bbba072c7ec877097cc2975ace8bfaf281
+  metadata.gz: 87356ba6323e223e3ce8b3b34424a1f942d2ee58
+  data.tar.gz: 5f4552341e234469911d09c064d692d6851da300
 SHA512:
-  metadata.gz: 98be3d4367705664da866e9c964a39bed8d1e19849839c10c006b6652987c4ec93a19212149bac2f6f6161d8a8766c5852cb9c3ff2110cd0bbcf1b843e42ff21
-  data.tar.gz: 89e3919f449e4256e99528b6b8a032ea0e0f252a4bffe91d05e67fe3e5df3afe22c85ec9e3a8cd42c19238022c8dae7f5ccc983a6fb3dd95656c6e3d54d02ae0
+  metadata.gz: 7afeee3c37fe492271e6db7d04caff6d59277c30f65fac72f24b2427b2085390578e59d80a15f0c0e15f1d5cf5f4f49194e6a43a99aaf4ac05d2198bb443d931
+  data.tar.gz: 056333c1581a72a259ff89e42c9bc9c3ec77d2e7e227bebef478eafd2a6ecc388d47b5d60beed25a876c97c3bd769d92d425f22c52b0a2cd6dba0f46a56b0fd2

data/fluent-plugin-amplitude.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'fluent-plugin-amplitude'
-  spec.version       = '0.0.7'
+  spec.version       = '0.0.8'
   spec.authors       = ['Vijay Ramesh']
   spec.email         = ['vijay@change.org']
   spec.summary       = 'Fluentd plugin to output event data to Amplitude'

data/lib/fluent/plugin/out_amplitude.rb

@@ -54,9 +54,11 @@ module Fluent
         next if @events_whitelist && !@events_whitelist.include?(tag)
         next if @events_blacklist && @events_blacklist.include?(tag)
         record = simple_symbolize_keys(record)
-        verify_user_and_device_or_fail(record)
-
-        records << AmplitudeAPI::Event.new(record)
+        if verify_user_and_device(record)
+          records << AmplitudeAPI::Event.new(record)
+        else
+          log.info("Error: either user_id or device_id must be set for tag #{tag}")
+        end
       end
 
       send_to_amplitude(records) unless records.empty?
@@ -88,11 +90,10 @@ module Fluent
       end
     end
 
-    def verify_user_and_device_or_fail(amplitude_hash)
+    def verify_user_and_device(amplitude_hash)
       user_id = amplitude_hash[:user_id]
       device_id = amplitude_hash[:device_id]
-      return if present?(user_id) || present?(device_id)
-      raise AmplitudeError, 'Error: either user_id or device_id must be set'
+      return present?(user_id) || present?(device_id)
     end
 
     def extract_user_properties!(amplitude_hash, record)

data/spec/out_amplitude_spec.rb

@@ -137,10 +137,9 @@ describe Fluent::AmplitudeOutput do
           'recruiter_id' => 710
         }
       end
-      it 'raises a Fluent::AmplitudeOutput::AmplitudeError' do
-        expect { amplitude.run }.to raise_error(
-          Fluent::AmplitudeOutput::AmplitudeError
-        )
+      it 'does not track the event' do
+        expect(AmplitudeAPI).to_not receive(:track)
+        amplitude.run
       end
     end
 
@@ -156,10 +155,9 @@ describe Fluent::AmplitudeOutput do
           'recruiter_id' => 710
         }
       end
-      it 'raises a Fluent::AmplitudeOutput::AmplitudeError' do
-        expect { amplitude.run }.to raise_error(
-          Fluent::AmplitudeOutput::AmplitudeError
-        )
+      it 'does not track the event' do
+        expect(AmplitudeAPI).to_not receive(:track)
+        amplitude.run
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fluent-plugin-amplitude
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Vijay Ramesh