fluent-plugin-amplitude 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f5f2237ec43b951cfb7576f887db3b348b17e715
-  data.tar.gz: 186f689b78f3730f49105784f8f18eb033a4c594
+  metadata.gz: 01e61239e194c3e3ed6d86efc525edcd1b45df04
+  data.tar.gz: 629c94af197ff1b8c0e59b06cc78d7e2f00a47f6
 SHA512:
-  metadata.gz: cbf0925b1d932001abcb0a04d235a72859dbe1f32ef992883bec8c07365b5ad4b95941c3b4b00386a3b325a077ff072d0ffaf5244ebe975723da33aa79374b93
-  data.tar.gz: dff860a1922798a7e9f83daf258cb3c00f96523fd846e1e307bf8a35d9609ec3754f953ce00130ed60e91d2741b3582af6066a2e2e52353dfc1293d966fb098c
+  metadata.gz: 699c3638100a649487f63f19eac4b3e48f2cb2bff4e7501998e3b2a3411342d3ee8710747cc20c46fdc0617d4faf5ebe7490684967d14cfea5c31c95b8061b34
+  data.tar.gz: 6431d376d1862d0cc5fa819b4f51d49efe84a25b446d2af10bc7ff14d31264e7838274b9ad5d8a1edb5adaadbd94c2f5f4f91d4114adc558ec6a17528829faa2

data/fluent-plugin-amplitude.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'fluent-plugin-amplitude'
-  spec.version       = '0.0.2'
+  spec.version       = '0.0.3'
   spec.authors       = ['Vijay Ramesh']
   spec.email         = ['vijay@change.org']
   spec.summary       = 'Fluentd plugin to output event data to Amplitude'

data/lib/fluent/plugin/fake_active_support.rb

@@ -0,0 +1,22 @@
+# Some things we want from ActiveSupport
+module FakeActiveSupport
+  def simple_symbolize_keys(hsh)
+    Hash[hsh.map do |k, v|
+      begin
+        [k.to_sym, v]
+      rescue
+        [k, v]
+      end
+    end]
+  end
+
+  def blank?(var)
+    # rubocop:disable DoubleNegation
+    var.respond_to?(:empty?) ? !!var.empty? : !var
+    # rubocop:enable DoubleNegation
+  end
+
+  def present?(var)
+    !blank?(var)
+  end
+end

data/lib/fluent/plugin/out_amplitude.rb

@@ -1,9 +1,11 @@
+require './lib/fluent/plugin/fake_active_support'
 module Fluent
   # Fluent::AmplitudeOutput plugin
   class AmplitudeOutput < Fluent::BufferedOutput
     Fluent::Plugin.register_output('amplitude', self)
 
     include Fluent::HandleTagNameMixin
+    include FakeActiveSupport
 
     config_param :api_key, :string, secret: true
     config_param :device_id_key, :string
@@ -76,7 +78,9 @@ module Fluent
     end
 
     def verify_user_and_device_or_fail(amplitude_hash)
-      return if amplitude_hash[:user_id] || amplitude_hash[:device_id]
+      user_id = amplitude_hash[:user_id]
+      device_id = amplitude_hash[:device_id]
+      return if present?(user_id) || present?(device_id)
       raise AmplitudeError, 'Error: either user_id or device_id must be set'
     end
 
@@ -116,15 +120,5 @@ module Fluent
         raise AmplitudeError, "Error: #{e.message}"
       end
     end
-
-    def simple_symbolize_keys(hsh)
-      Hash[hsh.map do |k, v|
-        begin
-          [k.to_sym, v]
-        rescue
-          [k, v]
-        end
-      end]
-    end
   end
 end

data/spec/out_amplitude_spec.rb

@@ -144,6 +144,25 @@ describe Fluent::AmplitudeOutput do
       end
     end
 
+    context 'the input only contains empty user_id and device_id fields' do
+      let(:event) do
+        {
+          'user_id' => '',
+          'uuid' => '',
+          'first_name' => 'Bobby',
+          'last_name' => 'Weir',
+          'state' => 'CA',
+          'current_source' => 'fb_share',
+          'recruiter_id' => 710
+        }
+      end
+      it 'raises a Fluent::AmplitudeOutput::AmplitudeError' do
+        expect { amplitude.run }.to raise_error(
+          Fluent::AmplitudeOutput::AmplitudeError
+        )
+      end
+    end
+
     context 'properties_blacklist is specified' do
       let(:conf) do
         %(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fluent-plugin-amplitude
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Vijay Ramesh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-08 00:00:00.000000000 Z
+date: 2016-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fluentd
@@ -141,6 +141,7 @@ files:
 - README.md
 - Rakefile
 - fluent-plugin-amplitude.gemspec
+- lib/fluent/plugin/fake_active_support.rb
 - lib/fluent/plugin/out_amplitude.rb
 - spec/out_amplitude_spec.rb
 - spec/spec_helper.rb