flowdock 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2e8c2164455898ff017ff0cbe2a0fe9c0615de15
-  data.tar.gz: 67af9f77904b26d42864b709d1a8ed112bc4009c
+  metadata.gz: 13576628fd2b05aaa9ece16cd6944c8d9b02224a
+  data.tar.gz: 4ca310fb95bf29d2c9342387623e62813a5609c2
 SHA512:
-  metadata.gz: 20cf692d3e6f09405972d71b9888fd60c3eac5e27978a63c545f4e9d2ac782e390a33cf8773be14d5592d498f079557b92d195178c8d078711cf56c3469723a7
-  data.tar.gz: fea63857c0f2130a68f79f634a9c17feba1b46022efe437adb383499d14136aad8cb421d5e2c71ca103f0e83b2a7a9b9b59606b16f9d8a89dc183be1ebc47681
+  metadata.gz: 10b82d9fdabb95fa80af828f6593bde4d143813aed8646724db51ae8614d00512348c36f7bef486f6173a7a6101a203539cd584b32b29651b87b1537b596e89b
+  data.tar.gz: f58a5de79dbb5de06e4ab85eb28b83987634a675b903bcc3631297add7b263e87b20c78fa46fc1efe45621d75e27f434907ffff380cedb41442b29489428ad9e

data/README.md

@@ -176,7 +176,7 @@ There are separate gems for deployment notifications:
 * [mina-flowdock](https://github.com/elskwid/mina-flowdock)
 
 ## Changelog
-
+* 0.7.0 - Added `post_to_thread`
 * 0.5.0 - Added `Flowdock::Client` that authenticates using user credentials and can be used to interact with the API. Better threads support for both `Flow` and `Client` so that comments can be made.
 
 ## Copyright

data/VERSION

@@ -1 +1 @@
-0.7.0
+0.7.1

data/flowdock.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: flowdock 0.7.0 ruby lib
+# stub: flowdock 0.7.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "flowdock"
-  s.version = "0.7.0"
+  s.version = "0.7.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Antti Pitk\u{e4}nen"]
-  s.date = "2015-07-21"
+  s.date = "2015-11-17"
   s.email = "team@flowdock.com"
   s.extra_rdoc_files = [
     "LICENSE",
@@ -34,7 +34,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/flowdock/flowdock-api"
   s.licenses = ["MIT"]
-  s.rubygems_version = "2.4.1"
+  s.rubygems_version = "2.4.8"
   s.summary = "Ruby Gem for using Flowdock's API"
 
   if s.respond_to? :specification_version then

data/lib/flowdock.rb

@@ -6,6 +6,7 @@ module Flowdock
   FLOWDOCK_API_URL = "https://api.flowdock.com/v1"
 
   class InvalidParameterError < StandardError; end
+  class NotFoundError < StandardError; end
   class ApiError < StandardError; end
 
   module Helpers
@@ -14,7 +15,14 @@ module Flowdock
     end
 
     def handle_response(resp)
-      json = MultiJson.decode(resp.body || '{}')
+      body = (resp.body.nil? || resp.body.strip.empty?) ? '{}' : resp.body
+
+      json = MultiJson.decode(body)
+
+      if resp.code == 404
+        raise NotFoundError, "Flowdock API returned error:\nStatus: #{resp.code}\n Message: #{json["message"]}"
+      end
+
       unless resp.code >= 200 && resp.code < 300
         errors = json["errors"].map {|k,v| "#{k}: #{v.join(',')}"}.join("\n") unless json["errors"].nil?
         raise ApiError, "Flowdock API returned error:\nStatus: #{resp.code}\n Message: #{json["message"]}\n Errors:\n#{errors}"

data/spec/flowdock_spec.rb

@@ -21,6 +21,25 @@ describe Flowdock do
     end
   end
 
+  describe "handle_response" do
+    it "parses a response body that contains an empty string" do
+      class TestResponse
+        attr_reader :body, :code
+
+        def initialize
+          @body = ""
+          @code = 200
+        end
+      end
+
+      class TestHelper
+        include Flowdock::Helpers
+      end
+
+      expect(TestHelper.new.handle_response(TestResponse.new)).to eq({})
+    end
+  end
+
   describe "with sending Team Inbox messages" do
     before(:each) do
       @token = "test"
@@ -224,6 +243,25 @@ describe Flowdock do
         @flow.push_to_team_inbox(:subject => "Hello World", :content => @example_content).should be_false
       }.should raise_error(Flowdock::ApiError)
     end
+
+    it "should raise error if backend returns 404 NotFound" do
+      lambda {
+        stub_request(:post, push_to_team_inbox_url(@token)).
+          with(:body => {
+            :source => "myapp",
+            :project => "myproject",
+            :format => "html",
+            :from_name => "Eric Example",
+            :from_address => "eric@example.com",
+            :reply_to => "john@example.com",
+            :subject => "Hello World",
+            :content => @example_content
+          }).
+          to_return(:body => "{}", :status => 404)
+
+        @flow.push_to_team_inbox(:subject => "Hello World", :content => @example_content).should be_false
+      }.should raise_error(Flowdock::NotFoundError)
+    end
   end
 
   describe "with sending Chat messages" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flowdock
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Antti Pitkänen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-21 00:00:00.000000000 Z
+date: 2015-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -163,7 +163,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Ruby Gem for using Flowdock's API