flog 4.7.0 → 4.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bde1a28d5e030ce021a8f20e9d7e877714e2c91e030b7560c3da7337a8a1e916
-  data.tar.gz: 6b4dffe1d2a47f688deb1665a0a31a4c9ef5b901add108aac37489c97cb8f7ee
+  metadata.gz: 9047c8b22acece9cd9e5c1dbb2e44d486fd903c40bd80967d1e4c257fa8669a9
+  data.tar.gz: 69a903441dcc41ab504399e173f8d231a242869ffbc5b6aebfa74e758822c4af
 SHA512:
-  metadata.gz: 56c6a3005252c00d8d61257f35f6eb9bf3d07b232acb316ebf5807dee9144c6bc76f24478ba64a000885677e1ba04d3d0af5ad8677934f90a5f8a965a2227f87
-  data.tar.gz: 876c48e4a05cf087fb924f5c10977870facdec0f07c3cabd09eccee03360fca82d19a3b5a708e2a9bd51cd57f109d525b29cc50d22399fac17df3062b0d3c272
+  metadata.gz: 88c867edf9e72b5b1f392697f3de483dfd18234a620028eeb6a60527b5dbdc21e994afb103870fa2d79fd4d88a91301a35fc37c0d095b330d1469be72595b879
+  data.tar.gz: f57466932cb71074ae085276bb9dbc9f47e684f4da599ce52a33d2a94198d2e9d86b22a41094bf2f65f6a8afa3a3c4be369ded47f970bcaad21fe82d9e334dbd

data/History.rdoc

@@ -1,3 +1,50 @@
+=== 4.9.4 / 2026-01-06
+
+* 2 bug fixes:
+
+  * Namespace NotRubyParser to avoid problems with bundler's horrid eager loading. (nateberkopec)
+  * Patch prism to recognize `it` as a local. (faisal)
+
+=== 4.9.3 / 2026-01-05
+
+* 1 bug fix:
+
+  * Fixed bug caused by last release duplicating (frozen) options hash. (nateberkopec)
+
+=== 4.9.2 / 2026-01-04
+
+* 2 bug fixes:
+
+  * Duplicate passed in options in case frozen.
+  * Oops! Fixed --legacy option definition.
+
+=== 4.9.1 / 2025-12-20
+
+* 4 bug fixes:
+
+  * Bumped dependency to prism to get some upstreamed fixes.
+  * Dropped ruby_parser dependency (now considered soft dep for --legacy flag).
+  * Minor cleanup of some of the upstreamed fixes.
+  * Re-add ruby_parser dependency until I can get a patch into prism to loosen it up.
+
+=== 4.9.0 / 2025-12-11
+
+* 2 minor enhancements:
+
+  * Bumped path_expander to 2.0.0.
+  * Switched to prism for ruby parsing. Use --legacy for RubyParser.
+
+=== 4.8.0 / 2023-09-28
+
+* 2 minor enhancements:
+
+  * Added ability to pass down option overrides through Flog.run.
+  * Removed ancient File.binread alias.
+
+* 1 bug fix:
+
+  * Added missing rdoc.
+
 === 4.7.0 / 2023-07-18
 
 * 3 minor enhancements:

data/Rakefile

@@ -3,9 +3,7 @@
 require 'rubygems'
 require 'hoe'
 
-Hoe.add_include_dirs("../../ruby_parser/dev/lib",
-                     "../../RubyInline/dev/lib",
-                     "../../sexp_processor/dev/lib",
+Hoe.add_include_dirs("../../sexp_processor/dev/lib",
                      "../../ZenTest/dev/lib",
                      "../../path_expander/dev/lib",
                      "lib")
@@ -24,10 +22,8 @@ Hoe.spec 'flog' do
   license "MIT"
 
   dependency "sexp_processor", "~> 4.8"
-  dependency "ruby_parser",    ["~> 3.1", "> 3.1.0"]
-  dependency "path_expander", "~> 1.0"
-
-  dependency "minitest",       "~> 5.0", :dev
+  dependency "prism",          "~> 1.7"
+  dependency "path_expander",  "~> 2.0"
 end
 
 task :debug do
@@ -40,17 +36,19 @@ task :debug do
   file = ENV["F"]
   ruby = ENV["R"]
   details = ENV["D"]
+  continue = ENV["C"]
 
-  flog = FlogCLI.new :parser => RubyParser
+  flog = FlogCLI.new
 
   flog.option[:details] = true if details
+  flog.option[:continue] = true if continue
 
   if file then
     if File.directory? file then # quick hack to get directory scanning going
       argv = [file]
       argv.unshift "-v" if ENV["V"]
 
-      FlogCLI.run argv
+      FlogCLI.run argv, flog.option
       exit 0
     end
     flog.flog file

data/bin/flog

@@ -1,6 +1,6 @@
-#!/usr/local/bin/ruby -w
+#!/usr/bin/env -S ruby -w
 
-require "flog_cli"
+require_relative "../lib/flog_cli"
 
 FlogCLI.run
 

data/lib/flog.rb

@@ -1,25 +1,37 @@
 require "sexp_processor"
-require "ruby_parser"
+require "prism"
+require "prism/translation/ruby_parser"
 require "timeout"
+require "racc" # for Racc::ParseError
 
-class File
-  RUBY19 = "<3".respond_to? :encoding unless defined? RUBY19 # :nodoc:
-
-  class << self
-    alias :binread :read unless RUBY19
+class Prism::Translation::RubyParser
+  module TweakIt
+    def visit_it_local_variable_read_node(node) # TODO: upstream
+      s(node, :lvar, :it)
+    end
   end
+  Compiler.prepend TweakIt
 end
 
+##
+# Flog is a SexpProcessor that calculates a ABC (assignments,
+# branches, conditionals) complexity metric with some ruby-aware
+# enhancements and a compounding penalty for increasing depth.
+#
+# In essence, this calculates the most tortured code. The higher the
+# score, the more pain the code is in and the harder it is to
+# thoroughly test.
+
 class Flog < MethodBasedSexpProcessor
-  VERSION = "4.7.0" # :nodoc:
+  VERSION = "4.9.4" # :nodoc:
+
+  NotRubyParser = Class.new Prism::Translation::RubyParser # compatibility layer :nodoc:
 
   ##
   # Cut off point where the report should stop unless --all given.
 
   DEFAULT_THRESHOLD = 0.60
 
-  THRESHOLD = DEFAULT_THRESHOLD # :nodoc:
-
   ##
   # The scoring system hash. Maps node type to score.
 
@@ -208,7 +220,7 @@ class Flog < MethodBasedSexpProcessor
   # methods. Does not handle timeouts or syntax errors. See #flog_ruby.
 
   def flog_ruby! ruby, file="-", timeout = 10
-    @parser = (option[:parser] || RubyParser).new
+    @parser = option[:parser].new
 
     warn "** flogging #{file}" if option[:verbose]
 
@@ -225,10 +237,11 @@ class Flog < MethodBasedSexpProcessor
 
   def initialize option = {}
     super()
-    @option              = option
+    @option              = option = option.dup
     @mass                = {}
     @parser              = nil
     @threshold           = option[:threshold] || DEFAULT_THRESHOLD
+    option[:parser]    ||= NotRubyParser
     self.auto_shift_type = true
     self.reset
   end

data/lib/flog_cli.rb

@@ -5,6 +5,10 @@ require "forwardable"
 require "path_expander"
 require "flog"
 
+##
+# This is the CLI interface for Flog, responsible for processing
+# options, finding files, loading plugins, and reporting results.
+
 class FlogCLI
   extend Forwardable
 
@@ -13,13 +17,16 @@ class FlogCLI
   def_delegators :@flog, :threshold, :total_score, :no_method, :calculate_total_scores
   def_delegators :@flog, :max_method
 
-  def self.run args = ARGV
+  ##
+  # This kicks off the whole thing.
+
+  def self.run args = ARGV, extra = {}
     load_plugins
 
     expander = PathExpander.new args, "**/*.{rb,rake}"
-    files = expander.process
+    files = expander.process.to_a
 
-    options = parse_options args
+    options = parse_options args, extra
 
     abort "no files or stdin (-) to process, aborting." if
       files.empty? and args.empty?
@@ -66,12 +73,12 @@ class FlogCLI
   ##
   # Parse options in +args+ (defaults to ARGV).
 
-  def self.parse_options args = ARGV
+  def self.parse_options args = ARGV, extra_options = {}
     option = {
       :quiet    => false,
       :continue => false,
-      :parser   => RubyParser,
-    }
+      :parser   => nil,
+    }.merge extra_options
 
     OptionParser.new do |opts|
       opts.separator "Standard options:"
@@ -123,6 +130,11 @@ class FlogCLI
         option[:score] = true
       end
 
+      opts.on "--legacy", "Use RubyParser for parsing." do
+        require "ruby_parser"
+        option[:parser] = RubyParser
+      end
+
       opts.on("-tN", "--threshold=N", Integer, "Set the report cutoff threshold (def: 60%).") do |n|
         option[:threshold] = n / 100.0
       end

data/lib/flog_task.rb

@@ -1,5 +1,9 @@
 require 'rake/tasklib'
 
+##
+# A rake front-end for flog, allowing task creation with options for
+# verbosity, reporting, and a failure threshold.
+
 class FlogTask < Rake::TaskLib
   ##
   # The name of the task. Defaults to :flog

data/test/test_flog.rb

@@ -19,7 +19,7 @@ end
 
 class TestFlog < FlogTest
   def setup
-    @flog = Flog.new :parser => RubyParser
+    @flog = Flog.new
   end
 
   def test_add_to_score
@@ -344,6 +344,17 @@ class TestFlog < FlogTest
     assert_process sexp, 2.326, :loop => 1.0, :branch => 1.1, :block_call => 1
   end
 
+  def test_process_iter__it
+    ruby = "blah { puts it }"
+    sexp = s(:iter,
+             s(:call, nil, :blah), 0,
+             s(:call, nil, :puts, s(:lvar, :it)))
+
+    assert_parse sexp, ruby
+
+    assert_process sexp, 2.326, blah: 1, block_call: 1, puts: 1.1
+  end
+
   def test_process_iter_dsl
     # task :blah do
     #   something
@@ -465,7 +476,7 @@ class TestFlog < FlogTest
   end
 
   def test_process_lit_complex
-    sexp = s(:lit, (0+1i))
+    sexp = eval 's(:lit, 0+1i)' # stupid emacs is borking on the complex
     assert_process sexp, 0.25
   end
 
@@ -571,6 +582,10 @@ class TestFlog < FlogTest
     end
   end
 
+  def assert_parse sexp, ruby
+    assert_equal sexp, Flog::NotRubyParser.new.process(ruby)
+  end
+
   def assert_process sexp, score = -1, hash = {}
     setup
     @flog.process sexp
@@ -697,3 +712,15 @@ class TestFlog < FlogTest
     @flog.add_to_score "blah", 42
   end
 end
+
+class TestFlogDefaultOptions < Minitest::Test
+  def test_flog_with_default_options
+    # Regression test for issue #84
+    # Flog should work with default options (no explicit parser)
+    flog = Flog.new
+    flog.flog_ruby "2 + 3", "test.rb"
+    flog.calculate_total_scores
+
+    assert_in_epsilon 1.6, flog.total_score
+  end
+end

data/test/test_flog_cli.rb

@@ -9,7 +9,7 @@ end
 
 class TestFlogCLI < FlogTest
   def setup
-    @flog = FlogCLI.new :parser => RubyParser
+    @flog = FlogCLI.new
   end
 
   def test_cls_parse_options

metadata

@@ -1,18 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: flog
 version: !ruby/object:Gem::Version
-  version: 4.7.0
+  version: 4.9.4
 platform: ruby
 authors:
 - Ryan Davis
-autorequire:
 bindir: bin
 cert_chain:
 - |
   -----BEGIN CERTIFICATE-----
-  MIIDPjCCAiagAwIBAgIBBzANBgkqhkiG9w0BAQsFADBFMRMwEQYDVQQDDApyeWFu
+  MIIDPjCCAiagAwIBAgIBCjANBgkqhkiG9w0BAQsFADBFMRMwEQYDVQQDDApyeWFu
   ZC1ydWJ5MRkwFwYKCZImiZPyLGQBGRYJemVuc3BpZGVyMRMwEQYKCZImiZPyLGQB
-  GRYDY29tMB4XDTIzMDEwMTA3NTExN1oXDTI0MDEwMTA3NTExN1owRTETMBEGA1UE
+  GRYDY29tMB4XDTI2MDEwNzAxMDkxNFoXDTI3MDEwNzAxMDkxNFowRTETMBEGA1UE
   AwwKcnlhbmQtcnVieTEZMBcGCgmSJomT8ixkARkWCXplbnNwaWRlcjETMBEGCgmS
   JomT8ixkARkWA2NvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALda
   b9DCgK+627gPJkB6XfjZ1itoOQvpqH1EXScSaba9/S2VF22VYQbXU1xQXL/WzCkx
@@ -22,14 +21,14 @@ cert_chain:
   qhtV7HJxNKuPj/JFH0D2cswvzznE/a5FOYO68g+YCuFi5L8wZuuM8zzdwjrWHqSV
   gBEfoTEGr7Zii72cx+sCAwEAAaM5MDcwCQYDVR0TBAIwADALBgNVHQ8EBAMCBLAw
   HQYDVR0OBBYEFEfFe9md/r/tj/Wmwpy+MI8d9k/hMA0GCSqGSIb3DQEBCwUAA4IB
-  AQAkg3y+PBnBAPWdxxITm5sPHqdWQgSyCpRA20o4LTuWr8BWhSXBkfQNa7cY6fOn
-  xyM34VPzBFbExv6XOGDfOMFBVaYTHuN9peC/5/umL7kLl+nflXzL2QA7K6LYj5Bg
-  sM574Onr0dZDM6Vn69bzQ7rBIFDfK/OhlPzqKZad4nsdcsVH8ODCiT+ATMIZyz5K
-  WCnNtqlyiWXI8tdTpahDgcUwfcN/oN7v4K8iU5IbLJX6HQ5DKgmKjfb6XyMth16k
-  ROfWo9Uyp8ba/j9eVG14KkYRaLydAY1MNQk2yd3R5CGfeOpD1kttxjoypoUJ2dOG
-  nsNBRuQJ1UfiCG97a6DNm+Fr
+  AQA/X8/PKTTc/IkYQEUL6XWtfK8fAfbuLJzmLcz6f2ZWrtBvPsYvqRuwI1bWUtil
+  2ibJEfIuSIHX6BsUTX18+hlaIussf6EWq/YkE7e2BKmgQE42vSOZMce0kCEAPbx0
+  rQtqonfWTHQ8UbQ7GqCL3gDQ0QDD2B+HUlb4uaCZ2icxqa/eOtxMvHC2tj+h0xKY
+  xL84ipM5kr0bHGf9/MRZJWcw51urueNycBXu1Xh+pEN8qBmYsFRR4SIODLClybAO
+  6cbm2PyPQgKNiqE4H+IQrDVHd9bJs1XgLElk3qoaJBWXc/5fy0J1imYb25UqmiHG
+  snGe1hrppvBRdcyEzvhfIPjI
   -----END CERTIFICATE-----
-date: 2023-07-18 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sexp_processor
@@ -46,87 +45,67 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4.8'
 - !ruby/object:Gem::Dependency
-  name: ruby_parser
+  name: prism
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: path_expander
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: hoe
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '4.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '4.5'
 description: |-
   Flog reports the most tortured code in an easy to read pain
   report. The higher the score, the more pain the code is in.
@@ -158,7 +137,6 @@ licenses:
 metadata:
   homepage_uri: http://ruby.sadi.st/
   source_code_uri: https://github.com/seattlerb/flog
-post_install_message:
 rdoc_options:
 - "--main"
 - README.rdoc
@@ -175,8 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
-signing_key:
+rubygems_version: 3.7.2
 specification_version: 4
 summary: Flog reports the most tortured code in an easy to read pain report
 test_files: []

metadata.gz.sig

@@ -1 +1 @@
-a���M�˒zl�m�e��h��ᱣ�{(�8�C���m��lJ%(ߞ%��J�#�دW(�{u`B��ĩ�o7�<q�Nr��D���"�q
+o�Z��q��˧T4}P�E#?hO������r�v��eZ�Ԡ�lÛ�BwK4���G-�~���6`�ӥ4���EB� H:,,�u�Ac���x��M�A���Ǜ�j����v����	�
k��2y<V,��$C0��-둴��s��#��;7�*���n�4RX��y;�����j�Gq�>L��z�}��|FG��r��l-���VH?9��;YQ�i��#,�}��0qP
pyR��Fv3R ��18o����h0T'�