flog 3.2.2 → 3.2.3

data/History.txt

@@ -1,3 +1,9 @@
+=== 3.2.3 / 2013-03-21
+
+* 1 bug fix:
+
+  * Don't blow up if a path doesn't exist or isn't readable.
+
 === 3.2.2 / 2013-01-22
 
 * 1 bug fix:

data/lib/flog.rb

@@ -13,7 +13,7 @@ class File
 end
 
 class Flog < SexpProcessor
-  VERSION = "3.2.2"
+  VERSION = "3.2.3"
 
   THRESHOLD = 0.60
   SCORES = Hash.new 1
@@ -251,6 +251,8 @@ class Flog < SexpProcessor
     files = Flog.expand_dirs_to_files(*files_or_dirs)
 
     files.each do |file|
+      next unless file == '-' or File.readable? file
+
       ruby = file == '-' ? $stdin.read : File.binread(file)
 
       flog_ruby ruby, file
@@ -574,13 +576,17 @@ class Flog < SexpProcessor
     add_to_score :block_pass
 
     case arg.first
-    when :lvar, :dvar, :ivar, :cvar, :self, :const, :colon2, :nil then
+    when :lvar, :dvar, :ivar, :cvar, :self, :const, :colon2, :nil then # f(&b)
       # do nothing
-    when :lit, :call then
+    when :lit, :call then                                              # f(&:b)
       add_to_score :to_proc_normal
-    when :lasgn then # blah(&l = proc { ... })
+    when :lasgn then                                                   # f(&l=b)
       add_to_score :to_proc_lasgn
-    when :iter, :dsym, :dstr, *BRANCHING then
+    when :iter, :dsym, :dstr, *BRANCHING then                          # below
+      # f(&proc { ... })
+      # f(&"#{...}")
+      # f(&:"#{...}")
+      # f(&if ... then ... end") and all other branching forms
       add_to_score :to_proc_icky!
     else
       raise({:block_pass_even_ickier! => arg}.inspect)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: flog
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: 
   segments: 
   - 3
   - 2
-  - 2
-  version: 3.2.2
+  - 3
+  version: 3.2.3
 platform: ruby
 authors: 
 - Ryan Davis
@@ -36,7 +36,7 @@ cert_chain:
   FBHgymkyj/AOSqKRIpXPhjC6
   -----END CERTIFICATE-----
 
-date: 2013-01-23 00:00:00 Z
+date: 2013-03-21 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: sexp_processor
@@ -84,11 +84,11 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 19
+        hash: 21
         segments: 
         - 4
-        - 4
-        version: "4.4"
+        - 7
+        version: "4.7"
   type: :development
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
@@ -176,7 +176,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: seattlerb
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Flog reports the most tortured code in an easy to read pain report