flock_os 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b4344db63440885fbd91ac908f218ccf10d380a8fb4027e73f13b4fe4676da6c
-  data.tar.gz: c7ab15fb63bd81c90bb96ce23c03a86b5941f0b595034ec4005206b7d6a8627f
+  metadata.gz: c2744e0d6da7cf08099fe98a00fcb03667bff47ba224f5a31a937bc3a52e3838
+  data.tar.gz: 34d4c7690b38cadd8c69de2ec39d5a1751216017c33597364d6f010775e467a7
 SHA512:
-  metadata.gz: d54e36365b3c0151fe0fdb432f5ad257d3acb7bc6eb88d48a008796d9e73f13e9954f857251f416378ba7725e843c744479f387251ac59d2d7df2f7a6e59c870
-  data.tar.gz: 031cd9a483e246cea0f005309b078cb908084475413b329c7953413e8c2e98d2f27548eee27e70f1d22c0dd9885177732fe4134165758b74ca4a35a84b6f49c5
+  metadata.gz: eafc8df537f37515b1ed94fc017558fe98a07e4a732d3500c86bda8cb81885615b0c07bf7a98a4fcaa952e6ef55bc82e82b0de0f1aabe0cf2a5996e4dc0aeb93
+  data.tar.gz: 606987185ba26f60429924fcbc8ce13ac0bee6454a081e2c75b73ab74e1810fc8ff8fa6a46643b87b9b3e5fc2e57370994a899119b07e3d19b61f63c487d58bf

data/lib/flock_os/api/channels.rb

@@ -35,10 +35,8 @@ module FlockOs
         FlockOs::Collection::Channel.new(response)
       end
       
-      def list_members(channel_id)
-        response = @client.post("#{PATH}.listMembers", {
-          channelId: channel_id
-        })
+      def list_members(params)
+        response = @client.post("#{PATH}.listMembers", params)
         
         FlockOs::Collection::ChannelMember.new(response)
       end

data/lib/flock_os/version.rb

@@ -1,3 +1,3 @@
 module FlockOs
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/api/channels_spec.rb

@@ -2,73 +2,32 @@ require 'spec_helper'
 
 describe FlockOs::Api::Channels do
   let(:client) { FlockOs::Client.new }
-  let(:stub_fetch_response) do
-    [ 
-      { 
-        "from": "u:xxx",
-        "to": "u:xxx",
-        "uid": "fd4877b719b1",
-        "text": "Hello" 
-      }
-    ]
-  end
-
-  let(:send_message_params) do
+  let(:stub_add_members_response) do
     {
-      "to": "u:xxx",
-      "text": "Hello"
+      members: {
+        "u:id1": { status: "added" },
+        "u:id2": { status: "failed", error: "UserNotFound" }
+      }
     }
   end
-
-  let(:stub_send_response) { { uid: 'uuid' } }
   
   subject(:chat) { described_class.new(client) }
+  subject(:add_member) { chat.add_members('channel_id', ['member']) }
 
   describe '#add_members' do
+    before do
+      allow_any_instance_of(FlockOs::Client).to receive(:post).and_return(stub_add_members_response)
+    end
+
     context 'when successfully fetch messages' do
       it 'return message collection class' do
-        expect(chat.add_members('channel_id', ['member'])).to be_an FlockOs::Collection::Message
+        expect(add_member).to be_an FlockOs::Model::ModifyChannelMember
       end
       
-      it 'return message collection class' do
-        allow_any_instance_of(FlockOs::Client).to receive(:post).and_return(stub_fetch_response)
-
-        response = chat.fetch_messages('chat', 'user_uids')
-        messages = response.collection
-        message = messages.first
-
-        expect(messages.count).to eq 1
-
-        expect(message.text).to eq stub_fetch_response.first[:text]
-        expect(message.from).to eq stub_fetch_response.first[:from]
-        expect(message.to).to eq stub_fetch_response.first[:to]
-        expect(message.uid).to eq stub_fetch_response.first[:uid]
-      end
-    end
-  end
-
-  describe '#send_message' do
-    context 'when successfully send message' do
-      it 'return message model class' do
-        expect(chat.send_message(send_message_params)).to be_an FlockOs::Model::SendMessage
-      end
-
-      it 'return uuid' do
-        allow_any_instance_of(FlockOs::Client).to receive(:post).and_return(stub_send_response)
-
-        response = chat.send_message(send_message_params)
-        
-        expect(response.uid).to eq stub_send_response[:uid]
-      end
-    end
-    
-    pending 'when send message failed' do
-      it 'uuid nil' do
-        allow_any_instance_of(FlockOs::Client).to receive(:post).and_return({})
+      it 'return correct attribute values' do
+        response = add_member
 
-        response = chat.send_message(send_message_params)
-        
-        expect(response.uid).to eq nil
+        expect(response.members).to eq stub_add_members_response[:members]
       end
     end
   end

data/spec/collection/channel_member_spec.rb

@@ -5,13 +5,7 @@ describe FlockOs::Collection::ChannelMember do
     (1..3).map do |n|
       {
         userId: "u:#{n}",
-        affiliation: "member",
-        publicProfile: {
-          id: "u:#{n}",
-          firstName: "Nicole #{n}",
-          lastName: "Sullivan",
-          profileImage: "https://i.flockusercontent.com/xxxxxx"
-        }
+        affiliation: "member"
       }
     end
   end
@@ -19,20 +13,56 @@ describe FlockOs::Collection::ChannelMember do
   subject(:collection) { described_class.new(channel_members) }
 
   describe '#initialize' do
-    it 'return described class' do
-      expect(collection).to be_an described_class
-    end
-    
-    it 'collection is not empty' do
-      expect(collection.collection).to be_an Array
+    context 'without show public profile' do
+      it 'return described class' do
+        expect(collection).to be_an described_class
+      end
+      
+      it 'collection is not empty' do
+        expect(collection.collection).to be_an Array
+      end
+      
+      it 'first collection has correct attributes' do
+        first_collection = collection.collection.first
+
+        expect(first_collection.user_id).to eq 'u:1'
+        expect(first_collection.affiliation).to eq 'member'
+        expect(first_collection.public_profile).to eq nil
+      end
     end
-    
-    it 'first collection has correct attributes' do
-      first_collection = collection.collection.first
 
-      expect(first_collection.user_id).to eq 'u:1'
-      expect(first_collection.affiliation).to eq 'member'
-      expect(first_collection.public_profile).to be_an Hash
+    context 'with show public profile' do
+      let(:channel_members) do
+        (1..3).map do |n|
+          {
+            userId: "u:#{n}",
+            affiliation: "member",
+            publicProfile: {
+              id: "u:#{n}",
+              firstName: "Nicole #{n}",
+              lastName: "Sullivan",
+              profileImage: "https://i.flockusercontent.com/xxxxxx"
+            }
+          }
+        end
+      end
+
+      it 'return described class' do
+        expect(collection).to be_an described_class
+      end
+      
+      it 'collection is not empty' do
+        expect(collection.collection).to be_an Array
+      end
+      
+      it 'first collection has correct attributes' do
+        first_collection = collection.collection.first
+
+        expect(first_collection.user_id).to eq 'u:1'
+        expect(first_collection.affiliation).to eq 'member'
+        expect(first_collection.public_profile).to be_an Hash
+        expect(first_collection.public_profile[:firstName]).to eq 'Nicole 1'
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flock_os
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Risal Hidayat