floatable-rails 0.1.3 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: edb701a8b2d34308e5a086f5a01943c3e0e240278367f79315e1dbcff3bb7937
-  data.tar.gz: '0982c58d7ffea82bae36e0119af731daa15e6e5a239a10ae3dffa79b7801a30e'
+  metadata.gz: 4c125142ad80b216bb4877b12f84b9cbed92d61225c13486ea3468aca4247f72
+  data.tar.gz: 8693d60951dc3bb1631a1399f3bab47d9a2758d989cdf950542f738a9fe46053
 SHA512:
-  metadata.gz: 9a94cc87a936389b7f2c314308007169e749c33a4af2d45f355de8c4713915205a4d1368245db70573a6a8e9566f86456a88ce51d9d91f6aee83736de111447c
-  data.tar.gz: 25ff3bc99798da03cb4121b4d6e27f0d27eaf92ab7e38af66b3d11d580d5b3693cc2bcc81f59182c8c9615c301caad6ad39e2a79f3870bd57bb8b2f7b8c55bd2
+  metadata.gz: f4a76a6b78be41abf4f1ac7cf5d889aea041486560bfe0ae394197c2c3761b439239c01ddf4a3350a8952586d41fcde1739c23dd5732a22b4a4e789cc6502c56
+  data.tar.gz: 7058a3f4efa223046b51057393ae68c5ed0f69fed2070fff360b7ed266cfd74fd4ebf57a1df2df3322bb9b7cb517f343209ebfdf1aa35f95c1565fa3571aaf60

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.1.5
+
+- Preserve Vue-style directive/event attributes by using the HTML5 parser when available.
+
+## 0.1.4
+
+- Fix Slim marker insertion to avoid interfering with block rendering.
+
 ## 0.1.3
 
 - Add `instrumentation_enabled` config to toggle HTML instrumentation separately from script injection.

data/lib/floatable/rails/response_middleware.rb

@@ -69,7 +69,7 @@ module Floatable
         return html if html.strip.empty?
 
         doctype = html[/\A\s*<!DOCTYPE[^>]*>/i]
-        doc = Nokogiri::HTML.parse(html)
+        doc = parse_html(html)
 
         doc.css("*").each do |node|
           name = node.name.to_s.downcase
@@ -132,6 +132,14 @@ module Floatable
         ::Rails.logger.debug("[Floatable::Rails] apply_view_markers_and_assign_ids failed: #{e.class} - #{e.message}")
       end
 
+      def parse_html(html)
+        if defined?(Nokogiri::HTML5)
+          Nokogiri::HTML5.parse(html)
+        else
+          Nokogiri::HTML.parse(html)
+        end
+      end
+
       def app_views_path?(path)
         str = path.to_s
         str.include?("/app/views/") || str.start_with?("app/views/")

data/lib/floatable/rails/slim_view_instrumentation.rb

@@ -10,42 +10,39 @@ module Floatable
 
         first_non_empty = lines.index { |l| !l.strip.empty? } || 0
 
-        # Keep optional Slim headers (doctype/html) at the very top if present.
-        doctype_idx = if lines[first_non_empty]&.lstrip&.match?(/\A(doctype\b|!!!\b)/)
-          first_non_empty
-        end
-
-        html_idx = nil
-        if doctype_idx
-          rel = lines[(doctype_idx + 1)..].to_a.index { |l| !l.strip.empty? && l.lstrip.match?(/\Ahtml\b/) }
-          html_idx = rel ? (doctype_idx + 1 + rel) : nil
-        end
+        # Keep optional Slim headers (doctype) at the very top if present.
+        doctype_idx =
+          if lines[first_non_empty]&.lstrip&.match?(/\A(doctype\b|!!!\b)/)
+            first_non_empty
+          end
 
-        insert_after = html_idx || doctype_idx || first_non_empty
-        insert_after = [ insert_after, lines.length - 1 ].min
+        # Insert before the first real line to avoid nesting inside blocks.
+        insert_at = doctype_idx ? (doctype_idx + 1) : first_non_empty
+        insert_at = [ insert_at, lines.length ].min
 
-        # Choose indentation that won't break Slim parsing.
         marker_indent =
-          begin
-            next_non_empty = lines[(insert_after + 1)..].to_a.find { |l| !l.strip.empty? }
-            if next_non_empty
-              next_non_empty[/\A[ \t]*/] || ""
-            else
-              base_line = lines[insert_after] || ""
-              (base_line[/\A[ \t]*/] || "") + "  "
-            end
+          if insert_at < lines.length
+            lines[insert_at].to_s[/\A[ \t]*/] || ""
+          else
+            lines[first_non_empty].to_s[/\A[ \t]*/] || ""
           end
 
-        begin_marker = "#{marker_indent}== (Thread.current[:floatable_enabled] && defined?(@output_buffer)) ? '<!-- #{::Floatable::Rails::VIEW_COMMENT_BEGIN} #{view_path} -->' : ''"
-        end_marker = "#{marker_indent}== (Thread.current[:floatable_enabled] && defined?(@output_buffer)) ? '<!-- #{::Floatable::Rails::VIEW_COMMENT_END} #{view_path} -->' : ''"
+        begin_marker = [
+          "#{marker_indent}- (@output_buffer.safe_concat('<!-- #{::Floatable::Rails::VIEW_COMMENT_BEGIN} #{view_path} -->') if Thread.current[:floatable_enabled] && defined?(@output_buffer)); nil"
+        ]
+        end_marker = [
+          "#{marker_indent}- (@output_buffer.safe_concat('<!-- #{::Floatable::Rails::VIEW_COMMENT_END} #{view_path} -->') if Thread.current[:floatable_enabled] && defined?(@output_buffer)); nil"
+        ]
 
         out = []
         lines.each_with_index do |line, idx|
+          out.concat(begin_marker) if idx == insert_at
           out << line
-          out << begin_marker if idx == insert_after
         end
 
-        out << end_marker
+        out.concat(begin_marker) if insert_at == lines.length
+
+        out.concat(end_marker)
         out.join("\n")
       end
     end

data/lib/floatable/rails/version.rb

@@ -1,5 +1,5 @@
 module Floatable
   module Rails
-    VERSION = "0.1.3"
+    VERSION = "0.1.5"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: floatable-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.5
 platform: ruby
 authors:
 - Tobias Almstrand