flipper 1.3.4 → 1.4.2

data/spec/flipper/poller_spec.rb

@@ -1,19 +1,23 @@
 require "flipper/poller"
+require "flipper/adapters/http"
 
 RSpec.describe Flipper::Poller do
-  let(:remote_adapter) { Flipper::Adapters::Memory.new }
-  let(:remote) { Flipper.new(remote_adapter) }
+  let(:url) { "http://app.com/flipper" }
+  let(:remote_adapter) { Flipper::Adapters::Http.new(url: url) }
   let(:local) { Flipper.new(subject.adapter) }
 
   subject do
     described_class.new(
       remote_adapter: remote_adapter,
       start_automatically: false,
-      interval: Float::INFINITY
+      interval: 3600 # 1 hour
     )
   end
 
   before do
+    stub_request(:get, "#{url}/features?exclude_gate_names=true")
+      .to_return(status: 200, body: JSON.generate(features: []))
+
     allow(subject).to receive(:loop).and_yield # Make loop just call once
     allow(subject).to receive(:sleep)          # Disable sleep
     allow(Thread).to receive(:new).and_yield   # Disable separate thread
@@ -28,12 +32,320 @@ RSpec.describe Flipper::Poller do
 
   describe "#sync" do
     it "syncs remote adapter to local adapter" do
-      remote.enable :polling
+      stub_request(:get, "#{url}/features?exclude_gate_names=true")
+        .to_return(status: 200, body: JSON.generate(
+          features: [
+            {
+              key: "polling",
+              gates: [
+                { key: "boolean", value: true }
+              ]
+            }
+          ]
+        ))
 
       expect(local.enabled?(:polling)).to be(false)
       subject.sync
       expect(local.enabled?(:polling)).to be(true)
     end
+
+    context "when poll-shutdown header is present" do
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            ),
+            headers: { "poll-shutdown" => "true" }
+          )
+      end
+
+      it "stops the poller when poll-shutdown header is true" do
+        expect(subject).to receive(:stop).and_call_original
+        subject.sync
+      end
+
+      it "prevents poller from restarting after shutdown" do
+        subject.sync # This should trigger shutdown
+
+        # Try to start again - should be a no-op
+        expect(Thread).not_to receive(:new)
+        subject.start
+      end
+
+      it "instruments the shutdown_requested event" do
+        instrumenter = subject.instance_variable_get(:@instrumenter)
+
+        expect(instrumenter).to receive(:instrument).with(
+          "poller.#{Flipper::InstrumentationNamespace}",
+          { operation: :poll }
+        ).and_call_original
+
+        expect(instrumenter).to receive(:instrument).with(
+          "poller.#{Flipper::InstrumentationNamespace}",
+          { operation: :shutdown_requested }
+        ).and_call_original
+
+        expect(instrumenter).to receive(:instrument).with(
+          "poller.#{Flipper::InstrumentationNamespace}",
+          { operation: :stop }
+        )
+
+        subject.sync
+      end
+    end
+
+    context "when poll-shutdown header is present on error response" do
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 404,
+            body: JSON.generate({ error: "Not found" }),
+            headers: { "poll-shutdown" => "true" }
+          )
+      end
+
+      it "stops polling even when sync fails with error response" do
+        # sync will raise an error, but should still check shutdown header
+        expect { subject.sync }.to raise_error(Flipper::Adapters::Http::Error)
+
+        # Verify shutdown was triggered
+        expect(Thread).not_to receive(:new)
+        subject.start
+      end
+    end
+
+    context "when poll-shutdown header is false" do
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            ),
+            headers: { "poll-shutdown" => "false" }
+          )
+      end
+
+      it "does not stop the poller" do
+        expect(subject).not_to receive(:stop)
+        subject.sync
+      end
+    end
+
+    context "when poll-shutdown header is missing" do
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            )
+          )
+      end
+
+      it "does not stop the poller" do
+        expect(subject).not_to receive(:stop)
+        subject.sync
+      end
+    end
+
+    context "when poll-interval header is lower than initial interval" do
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            ),
+            headers: { "poll-interval" => "30" }
+          )
+      end
+
+      it "uses the initial interval as minimum" do
+        expect(subject.interval).to eq(3600.0)
+        subject.sync
+        expect(subject.interval).to eq(3600.0) # Keeps 3600 because it's the initial interval
+      end
+    end
+
+    context "when poll-interval header is below minimum" do
+      subject do
+        described_class.new(
+          remote_adapter: remote_adapter,
+          start_automatically: false,
+          interval: 10 # Set initial to minimum
+        )
+      end
+
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            ),
+            headers: { "poll-interval" => "5" }
+          )
+      end
+
+      it "enforces minimum poll interval" do
+        expect(subject.interval).to eq(10.0)
+        subject.sync
+        # Header says 5, minimum is 10, initial is 10, so max(5->10, 10) = 10
+        expect(subject.interval).to eq(Flipper::Poller::MINIMUM_POLL_INTERVAL)
+      end
+    end
+
+    context "when poll-interval header is higher than initial interval" do
+      subject do
+        described_class.new(
+          remote_adapter: remote_adapter,
+          start_automatically: false,
+          interval: 20
+        )
+      end
+
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            ),
+            headers: { "poll-interval" => "60" }
+          )
+      end
+
+      it "updates to the higher interval from header" do
+        expect(subject.interval).to eq(20.0)
+        subject.sync
+        expect(subject.interval).to eq(60.0) # Uses 60 because it's higher than initial 20
+      end
+    end
+
+    context "when poll-interval header can decrease back to initial interval" do
+      subject do
+        described_class.new(
+          remote_adapter: remote_adapter,
+          start_automatically: false,
+          interval: 10
+        )
+      end
+
+      before do
+        # First sync increases interval to 60
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            ),
+            headers: { "poll-interval" => "60" }
+          ).times(1).then
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            ),
+            headers: { "poll-interval" => "10" }
+          )
+      end
+
+      it "allows interval to go back down to initial after being increased" do
+        expect(subject.interval).to eq(10.0)
+
+        # First sync: header says 60, initial is 10, so use 60
+        subject.sync
+        expect(subject.interval).to eq(60.0)
+
+        # Second sync: header says 10, initial is 10, so use 10
+        subject.sync
+        expect(subject.interval).to eq(10.0)
+      end
+    end
+
+    context "when poll-interval header is missing" do
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(
+              features: [
+                {
+                  key: "polling",
+                  gates: [
+                    { key: "boolean", value: true }
+                  ]
+                }
+              ]
+            )
+          )
+      end
+
+      it "does not change the interval" do
+        original_interval = subject.interval
+        subject.sync
+        expect(subject.interval).to eq(original_interval)
+      end
+    end
   end
 
   describe "#start" do
@@ -43,5 +355,36 @@ RSpec.describe Flipper::Poller do
       expect(subject).to receive(:sync)
       subject.start
     end
+
+    context "after shutdown_requested" do
+      before do
+        stub_request(:get, "#{url}/features?exclude_gate_names=true")
+          .to_return(
+            status: 200,
+            body: JSON.generate(features: []),
+            headers: { "poll-shutdown" => "true" }
+          )
+      end
+
+      it "does not start when shutdown was requested" do
+        subject.sync # This triggers shutdown
+
+        expect(Thread).not_to receive(:new)
+        subject.start
+      end
+
+      it "allows starting after a fork" do
+        subject.sync # This triggers shutdown
+
+        # Simulate fork by changing PID
+        allow(Process).to receive(:pid).and_return(subject.instance_variable_get(:@pid) + 1)
+
+        # After fork, start should work again
+        expect(Thread).to receive(:new).and_yield
+        expect(subject).to receive(:loop).and_yield
+        expect(subject).to receive(:sync)
+        subject.start
+      end
+    end
   end
 end

data/spec/flipper_integration_spec.rb

@@ -600,6 +600,139 @@ RSpec.describe Flipper do
     end
   end
 
+  context "for FeatureEnabled" do
+    before do
+      @original_instance = Flipper.instance
+      Flipper.instance = flipper
+    end
+
+    after do
+      Flipper.instance = @original_instance
+      Thread.current[:flipper_evaluating_features] = nil
+    end
+
+    it "returns true when referenced feature is enabled" do
+      flipper.enable(:search_beta)
+      feature.enable Flipper.feature_enabled(:search_beta)
+
+      expect(feature.enabled?).to be(true)
+    end
+
+    it "returns false when referenced feature is disabled" do
+      feature.enable Flipper.feature_enabled(:search_beta)
+
+      expect(feature.enabled?).to be(false)
+    end
+
+    it "passes actor through to referenced feature" do
+      flipper.enable_actor(:search_beta, pitt)
+      feature.enable Flipper.feature_enabled(:search_beta)
+
+      expect(feature.enabled?(pitt)).to be(true)
+      expect(feature.enabled?(clooney)).to be(false)
+    end
+
+    it "returns false on circular dependency" do
+      feature.enable Flipper.feature_enabled(:other)
+      flipper[:other].enable Flipper.feature_enabled(:search)
+
+      expect(feature.enabled?).to be(false)
+    end
+
+    it "returns false on self-reference" do
+      feature.enable Flipper.feature_enabled(:search)
+
+      expect(feature.enabled?).to be(false)
+    end
+
+    it "cleans up thread-local state after evaluation" do
+      flipper.enable(:search_beta)
+      feature.enable Flipper.feature_enabled(:search_beta)
+
+      feature.enabled?
+      evaluating = Thread.current[:flipper_evaluating_features]
+      expect(evaluating.nil? || evaluating.empty?).to be(true)
+    end
+
+    it "cleans up thread-local state after self-reference" do
+      feature.enable Flipper.feature_enabled(:search)
+
+      feature.enabled?
+      evaluating = Thread.current[:flipper_evaluating_features]
+      expect(evaluating.nil? || evaluating.empty?).to be(true)
+    end
+
+    it "cleans up thread-local state after circular dependency" do
+      feature.enable Flipper.feature_enabled(:other)
+      flipper[:other].enable Flipper.feature_enabled(:search)
+
+      feature.enabled?
+      evaluating = Thread.current[:flipper_evaluating_features]
+      expect(evaluating.nil? || evaluating.empty?).to be(true)
+    end
+  end
+
+  context "for FeatureDisabled" do
+    before do
+      @original_instance = Flipper.instance
+      Flipper.instance = flipper
+    end
+
+    after do
+      Flipper.instance = @original_instance
+      Thread.current[:flipper_evaluating_features] = nil
+    end
+
+    it "returns true when referenced feature is disabled" do
+      feature.enable Flipper.feature_disabled(:old_checkout)
+
+      expect(feature.enabled?).to be(true)
+    end
+
+    it "returns false when referenced feature is enabled" do
+      flipper.enable(:old_checkout)
+      feature.enable Flipper.feature_disabled(:old_checkout)
+
+      expect(feature.enabled?).to be(false)
+    end
+  end
+
+  context "for FeatureEnabled composed with other expressions" do
+    before do
+      @original_instance = Flipper.instance
+      Flipper.instance = flipper
+    end
+
+    after do
+      Flipper.instance = @original_instance
+      Thread.current[:flipper_evaluating_features] = nil
+    end
+
+    it "works with Any" do
+      feature.enable Flipper.any(
+        Flipper.feature_enabled(:beta_program),
+        Flipper.property(:plan).eq("basic")
+      )
+
+      expect(feature.enabled?(basic_plan_actor)).to be(true)
+      expect(feature.enabled?(premium_plan_actor)).to be(false)
+
+      flipper.enable(:beta_program)
+      expect(feature.enabled?(premium_plan_actor)).to be(true)
+    end
+
+    it "works with All" do
+      flipper.enable(:basic_search)
+      feature.enable Flipper.all(
+        Flipper.feature_enabled(:basic_search),
+        Flipper.property(:plan).eq("basic")
+      )
+
+      expect(feature.enabled?(basic_plan_actor)).to be(true)
+      expect(feature.enabled?(premium_plan_actor)).to be(false)
+    end
+  end
+
   context "for All" do
     it "works" do
       true_actor = Flipper::Actor.new("User;1", {

data/spec/flipper_spec.rb

@@ -218,6 +218,11 @@ RSpec.describe Flipper do
       expect(described_class.adapter).to eq(described_class.instance.adapter)
     end
 
+    it 'delegates adapter_stack to instance' do
+      expect(described_class.adapter_stack).to eq(described_class.instance.adapter_stack)
+      expect(described_class.adapter_stack).to eq("memoizable -> memory")
+    end
+
     it 'delegates memoize= to instance' do
       expect(described_class.adapter.memoizing?).to be(false)
       described_class.memoize = true

data/spec/spec_helper.rb

@@ -39,6 +39,13 @@ RSpec.configure do |config|
     Flipper.configuration = nil
   end
 
+  config.after(:example) do
+    # Stop any pollers started during the test BEFORE WebMock clears stubs
+    # in its own after hook (RSpec runs after hooks in reverse registration
+    # order, so ours runs first since webmock/rspec was required before this).
+    Flipper::Poller.reset if defined?(Flipper::Poller)
+  end
+
   config.disable_monkey_patching!
 
   config.filter_run focus: true