flipper 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cec73aaf335a08edc58718f2ab05e7ab51e3796a2c8426763a179ffed031a09f
-  data.tar.gz: 666c50ae76807729db78b0d04d27f3fe4fd4f9c8499befeea9c4c58134897ca9
+  metadata.gz: 8078cb39434d25df42e6eb6b254386568da4eed95f519f6675b79eba2bdb74c2
+  data.tar.gz: 6dbefd84a3553b00d0654cdeef452404a5e25980984ee2e6a07abbb8885e2b61
 SHA512:
-  metadata.gz: 58fa61222b6d56458b8f7855969a0d55ef96058b4a6bc2a0b570ecbcacec191478677fbd7aee954e70cfca6eb64286477fb707c9b7dd9662497f16c31383a256
-  data.tar.gz: 310657db11afe2233674afbe0ce07f029a991977e77813bcd88d49993e232e0937dc3258828ebbd6bdbbceb1910e2af64776ca3353e81381cd6d95ccb7e8c551
+  metadata.gz: dd0b492e592bbdf9a969d9ae027de871c8f298aaaa7be9c011d6b258918e4a45421ec4a253d1bd6eed6f246f0dae35124670e91c7c4d6e6617d7f90f4f2acb42
+  data.tar.gz: 70006d2e9bcddd9cf4085555b8d7cae79bdcbc93848abe1e6ee4efe0f3fd4d5dc76cae073ab1a8f981f2bd29cc5ed1e7f90795428e53acf0c571f166c1406a82

data/.github/workflows/ci.yml

@@ -84,7 +84,7 @@ jobs:
       - name: Setup memcached
         uses: KeisukeYamashita/memcached-actions@v1
       - name: Start MongoDB
-        uses: supercharge/mongodb-github-action@1.11.0
+        uses: supercharge/mongodb-github-action@1.12.0
         with:
           mongodb-version: 4.0
       - name: Check out repository code

data/.github/workflows/examples.yml

@@ -66,7 +66,7 @@ jobs:
       - name: Setup memcached
         uses: KeisukeYamashita/memcached-actions@v1
       - name: Start MongoDB
-        uses: supercharge/mongodb-github-action@1.11.0
+        uses: supercharge/mongodb-github-action@1.12.0
         with:
           mongodb-version: 4.0
       - name: Check out repository code

data/Gemfile

@@ -6,16 +6,19 @@ Dir['flipper-*.gemspec'].each do |gemspec|
   gemspec(name: "flipper-#{plugin}", development_group: plugin)
 end
 
+gem 'concurrent-ruby', '1.3.4'
+gem 'connection_pool'
 gem 'debug'
 gem 'rake'
 gem 'statsd-ruby', '~> 1.2.1'
 gem 'rspec', '~> 3.0'
 gem 'rack-test'
 gem 'rackup', '= 1.0.0'
-gem 'sqlite3', "~> #{ENV['SQLITE3_VERSION'] || '1.4.1'}"
-gem 'rails', "~> #{ENV['RAILS_VERSION'] || '7.1'}"
+gem 'sqlite3', "~> #{ENV['SQLITE3_VERSION'] || '2.1.0'}"
+gem 'rails', "~> #{ENV['RAILS_VERSION'] || '8.0'}"
 gem 'minitest', '~> 5.18'
 gem 'minitest-documentation'
+gem 'pstore'
 gem 'webmock'
 gem 'ice_age'
 gem 'redis-namespace'
@@ -28,6 +31,7 @@ gem 'mysql2'
 gem 'pg'
 gem 'cuprite'
 gem 'puma'
+gem 'warning'
 
 group(:guard) do
   gem 'guard'

data/examples/cloud/backoff_policy.rb

@@ -5,7 +5,7 @@ require 'flipper/cloud/telemetry/backoff_policy'
 intervals = []
 policy = Flipper::Cloud::Telemetry::BackoffPolicy.new
 
-10.times do |n|
+5.times do |n|
   intervals << policy.next_interval
 end
 

data/lib/flipper/adapters/http/error.rb

@@ -20,7 +20,7 @@ module Flipper
             if more_info = data["more_info"]
               message << "\n#{data["more_info"]}"
             end
-          rescue => exception
+          rescue
             # welp we tried
           end
 

data/lib/flipper/adapters/http.rb

@@ -59,8 +59,8 @@ module Flipper
         response = @client.get("/features?exclude_gate_names=true")
         raise Error, response unless response.is_a?(Net::HTTPOK)
 
-        parsed_response = Typecast.from_json(response.body)
-        parsed_features = parsed_response.fetch('features')
+        parsed_response = response.body.empty? ? {} : Typecast.from_json(response.body)
+        parsed_features = parsed_response['features'] || []
         gates_by_key = parsed_features.each_with_object({}) do |parsed_feature, hash|
           hash[parsed_feature['key']] = parsed_feature['gates']
           hash

data/lib/flipper/adapters/poll.rb

@@ -18,6 +18,21 @@ module Flipper
         @adapter = adapter
         @poller = poller
         @last_synced_at = 0
+
+        # If the adapter is empty, we need to sync before starting the poller.
+        # Yes, this will block the main thread, but that's better than thinking
+        # nothing is enabled.
+        if adapter.features.empty?
+          begin
+            @poller.sync
+          rescue
+            # TODO: Warn here that it's possible that no data has been synced
+            # and flags are being evaluated without flag data being present
+            # until a sync completes. We rescue to avoid flipper being down
+            # causing your processes to crash.
+          end
+        end
+
         @poller.start
       end
 

data/lib/flipper/cloud/configuration.rb

@@ -3,7 +3,6 @@ require "socket"
 require "flipper/adapters/http"
 require "flipper/adapters/poll"
 require "flipper/poller"
-require "flipper/adapters/memory"
 require "flipper/adapters/dual_write"
 require "flipper/adapters/sync/synchronizer"
 require "flipper/cloud/telemetry"
@@ -135,6 +134,10 @@ module Flipper
         logger.send(level, "name=flipper_cloud #{message}")
       end
 
+      def instrument(name, payload = {}, &block)
+        instrumenter.instrument(name, payload, &block)
+      end
+
       private
 
       def app_adapter

data/lib/flipper/cloud/telemetry/backoff_policy.rb

@@ -3,10 +3,10 @@ module Flipper
     class Telemetry
       class BackoffPolicy
         # Private: The default minimum timeout between intervals in milliseconds.
-        MIN_TIMEOUT_MS = 1_000
+        MIN_TIMEOUT_MS = 30_000
 
         # Private: The default maximum timeout between intervals in milliseconds.
-        MAX_TIMEOUT_MS = 30_000
+        MAX_TIMEOUT_MS = 120_000
 
         # Private: The value to multiply the current interval with for each
         # retry attempt.
@@ -67,7 +67,10 @@ module Flipper
 
           @attempts += 1
 
-          [interval, @max_timeout_ms].min
+          # cap the interval to the max timeout
+          result = [interval, @max_timeout_ms].min
+          # jitter even when maxed out
+          result == @max_timeout_ms ? add_jitter(result, 0.05) : result
         end
 
         def reset

data/lib/flipper/cloud/telemetry/submitter.rb

@@ -34,7 +34,7 @@ module Flipper
           return if drained.empty?
           body = to_body(drained)
           return if body.nil? || body.empty?
-          retry_with_backoff(10) { submit(body) }
+          retry_with_backoff(5) { submit(body) }
         end
 
         private
@@ -51,6 +51,7 @@ module Flipper
 
           Typecast.to_gzip(json)
         rescue => exception
+          @cloud_configuration.instrument "telemetry_error.#{Flipper::InstrumentationNamespace}", exception: exception, request_id: request_id
           @cloud_configuration.log "action=to_body request_id=#{request_id} error=#{exception.inspect}", level: :error
         end
 
@@ -63,6 +64,7 @@ module Flipper
             result, should_retry = yield
             return [result, nil] unless should_retry
           rescue => error
+            @cloud_configuration.instrument "telemetry_retry.#{Flipper::InstrumentationNamespace}", attempts_remaining: attempts_remaining, exception: error
             @cloud_configuration.log "action=post_to_cloud attempts_remaining=#{attempts_remaining} error=#{error.inspect}", level: :error
             should_retry = true
             caught_exception = error

data/lib/flipper/cloud/telemetry.rb

@@ -75,8 +75,8 @@ module Flipper
 
         @metric_storage = MetricStorage.new
 
-        @pool = Concurrent::FixedThreadPool.new(2, {
-          max_queue: 5,
+        @pool = Concurrent::FixedThreadPool.new(1, {
+          max_queue: 20, # ~ 20 minutes of data at 1 minute intervals
           fallback_policy: :discard,
           name: "flipper-telemetry-post-to-cloud-pool".freeze,
         })

data/lib/flipper/export.rb

@@ -1,5 +1,3 @@
-require "flipper/adapters/memory"
-
 module Flipper
   class Export
     attr_reader :contents, :format, :version

data/lib/flipper/expressions/all.rb

@@ -1,5 +1,3 @@
-require "flipper/expression"
-
 module Flipper
   module Expressions
     class All

data/lib/flipper/feature.rb

@@ -100,7 +100,14 @@ module Flipper
     #
     # Returns true if enabled, false if not.
     def enabled?(*actors)
-      actors = actors.flatten.compact.map { |actor| Types::Actor.wrap(actor) }
+      actors = Array(actors).
+        # Avoids to_ary warning that happens when passing DelegateClass of an 
+        # ActiveRecord object and using flatten here. This is tested in 
+        # spec/flipper/model/active_record_spec.rb.
+        flat_map { |actor| actor.is_a?(Array) ? actor : [actor] }. 
+        # Allows null object pattern. See PR for more. https://github.com/flippercloud/flipper/pull/887
+        reject(&:nil?). 
+        map { |actor| Types::Actor.wrap(actor) }
       actors = nil if actors.empty?
 
       # thing is left for backwards compatibility

data/lib/flipper/instrumentation/log_subscriber.rb

@@ -53,7 +53,6 @@ module Flipper
 
         feature_name = event.payload[:feature_name]
         adapter_name = event.payload[:adapter_name]
-        gate_name = event.payload[:gate_name]
         operation = event.payload[:operation]
         result = event.payload[:result]
 

data/lib/flipper/instrumentation/statsd.rb

@@ -2,5 +2,7 @@ require 'securerandom'
 require 'active_support/notifications'
 require 'flipper/instrumentation/statsd_subscriber'
 
-ActiveSupport::Notifications.subscribe /\.flipper$/,
-                                       Flipper::Instrumentation::StatsdSubscriber
+ActiveSupport::Notifications.subscribe(
+  /\.flipper$/,
+  Flipper::Instrumentation::StatsdSubscriber
+)

data/lib/flipper/instrumentation/subscriber.rb

@@ -42,7 +42,6 @@ module Flipper
       # Private
       def update_feature_operation_metrics
         feature_name = @payload[:feature_name]
-        gate_name = @payload[:gate_name]
         operation = strip_trailing_question_mark(@payload[:operation])
         result = @payload[:result]
 
@@ -64,9 +63,6 @@ module Flipper
       def update_adapter_operation_metrics
         adapter_name = @payload[:adapter_name]
         operation = @payload[:operation]
-        result = @payload[:result]
-        value = @payload[:value]
-        key = @payload[:key]
 
         update_timer "flipper.adapter.#{adapter_name}.#{operation}"
       end

data/lib/flipper/metadata.rb

@@ -7,5 +7,6 @@ module Flipper
     "source_code_uri"   => "https://github.com/flippercloud/flipper",
     "bug_tracker_uri"   => "https://github.com/flippercloud/flipper/issues",
     "changelog_uri"     => "https://github.com/flippercloud/flipper/releases/tag/v#{Flipper::VERSION}",
+    "funding_uri"       => "https://github.com/sponsors/flippercloud",
   }.freeze
 end

data/lib/flipper/poller.rb

@@ -59,10 +59,10 @@ module Flipper
     def run
       loop do
         sleep jitter
-        start = Concurrent.monotonic_time
+
         begin
           sync
-        rescue => exception
+        rescue
           # you can instrument these using poller.flipper
         end
 

data/lib/flipper/version.rb

@@ -1,5 +1,5 @@
 module Flipper
-  VERSION = '1.3.2'.freeze
+  VERSION = '1.3.3'.freeze
 
   REQUIRED_RUBY_VERSION = '2.6'.freeze
   NEXT_REQUIRED_RUBY_VERSION = '3.0'.freeze

data/lib/generators/flipper/setup_generator.rb

@@ -4,10 +4,15 @@ module Flipper
   module Generators
     class SetupGenerator < ::Rails::Generators::Base
       desc 'Peform any necessary steps to install Flipper'
+      source_paths << File.expand_path('templates', __dir__)
 
       class_option :token, type: :string, default: nil, aliases: '-t',
         desc: "Your personal environment token for Flipper Cloud"
 
+      def generate_initializer
+        template 'initializer.rb', 'config/initializers/flipper.rb'
+      end
+
       def generate_active_record
         invoke 'flipper:active_record' if defined?(Flipper::Adapters::ActiveRecord)
       end

data/lib/generators/flipper/templates/initializer.rb

@@ -0,0 +1,45 @@
+Rails.application.configure do
+  ## Memoization ensures that only one adapter call is made per feature per request.
+  ## For more info, see https://www.flippercloud.io/docs/optimization#memoization
+  # config.flipper.memoize = true
+
+  ## Flipper preloads all features before each request, which is recommended if:
+  ##   * you have a limited number of features (< 100?)
+  ##   * most of your requests depend on most of your features
+  ##   * you have limited gate data combined across all features (< 1k enabled gates, like individual actors, across all features)
+  ##
+  ## For more info, see https://www.flippercloud.io/docs/optimization#preloading
+  # config.flipper.preload = true
+
+  ## Warn or raise an error if an unknown feature is checked
+  ## Can be set to `:warn`, `:raise`, or `false`
+  # config.flipper.strict = Rails.env.development? && :warn
+
+  ## Show Flipper checks in logs
+  # config.flipper.log = true
+
+  ## Reconfigure Flipper to use the Memory adaper and disable Cloud in tests
+  # config.flipper.test_help = true
+
+  ## The path that Flipper Cloud will use to sync features
+  # config.flipper.cloud_path = "_flipper"
+
+  ## The instrumenter that Flipper will use. Defaults to ActiveSupport::Notifications.
+  # config.flipper.instrumenter = ActiveSupport::Notifications
+end
+
+Flipper.configure do |config|
+  ## Configure other adapters that you want to use here:
+  ## See http://flippercloud.io/docs/adapters
+  # config.use Flipper::Adapters::ActiveSupportCacheStore, Rails.cache, expires_in: 5.minutes
+end
+
+## Register a group that can be used for enabling features.
+##
+##   Flipper.enable_group :my_feature, :admins
+##
+## See https://www.flippercloud.io/docs/features#enablement-group
+#
+# Flipper.register(:admins) do |actor|
+#  actor.respond_to?(:admin?) && actor.admin?
+# end

data/spec/flipper/adapters/http_spec.rb

@@ -28,6 +28,7 @@ RSpec.describe Flipper::Adapters::Http do
       end
 
       before :all do
+        @started = false
         dir = FlipperRoot.join('tmp').tap(&:mkpath)
         log_path = dir.join('flipper_adapters_http_spec.log')
         @pstore_file = dir.join('flipper.pstore')

data/spec/flipper/adapters/poll_spec.rb

@@ -0,0 +1,41 @@
+require 'flipper/adapters/poll'
+
+RSpec.describe Flipper::Adapters::Poll do
+  let(:remote_adapter) {
+    adapter = Flipper::Adapters::Memory.new(threadsafe: true)
+    flipper = Flipper.new(adapter)
+    flipper.enable(:search)
+    flipper.enable(:analytics)
+    adapter
+  }
+  let(:local_adapter) { Flipper::Adapters::Memory.new(threadsafe: true) }
+  let(:poller) {
+    Flipper::Poller.get("for_spec", {
+      start_automatically: false,
+      remote_adapter: remote_adapter,
+    })
+  }
+
+  it "syncs in main thread if local adapter is empty" do
+    instance = described_class.new(poller, local_adapter)
+    instance.features # call something to force sync
+    expect(local_adapter.features).to eq(remote_adapter.features)
+  end
+
+  it "does not sync in main thread if local adapter is not empty" do
+    # make local not empty by importing remote
+    flipper = Flipper.new(local_adapter)
+    flipper.import(remote_adapter)
+
+    # make a fake poller to verify calls
+    poller = double("Poller", last_synced_at: Concurrent::AtomicFixnum.new(0))
+    expect(poller).to receive(:start).twice
+    expect(poller).not_to receive(:sync)
+
+    # create new instance and call something to force sync
+    instance = described_class.new(poller, local_adapter)
+    instance.features # call something to force sync
+
+    expect(local_adapter.features).to eq(remote_adapter.features)
+  end
+end

data/spec/flipper/cloud/dsl_spec.rb

@@ -45,7 +45,7 @@ RSpec.describe Flipper::Cloud::DSL do
     end
 
     let(:cloud_configuration) do
-      cloud_configuration = Flipper::Cloud::Configuration.new({
+      Flipper::Cloud::Configuration.new({
         token: "asdf",
         sync_secret: "tasty",
         local_adapter: local_adapter

data/spec/flipper/cloud/telemetry/backoff_policy_spec.rb

@@ -4,8 +4,8 @@ RSpec.describe Flipper::Cloud::Telemetry::BackoffPolicy do
   context "#initialize" do
     it "with no options" do
       policy = described_class.new
-      expect(policy.min_timeout_ms).to eq(1_000)
-      expect(policy.max_timeout_ms).to eq(30_000)
+      expect(policy.min_timeout_ms).to eq(30_000)
+      expect(policy.max_timeout_ms).to eq(120_000)
       expect(policy.multiplier).to eq(1.5)
       expect(policy.randomization_factor).to eq(0.5)
     end
@@ -87,7 +87,7 @@ RSpec.describe Flipper::Cloud::Telemetry::BackoffPolicy do
         randomization_factor: 0.5,
       })
       10.times { policy.next_interval }
-      expect(policy.next_interval).to eq(10_000)
+      expect(policy.next_interval).to be_within(10_000*0.1).of(10_000)
     end
   end
 

data/spec/flipper/cloud/telemetry/submitter_spec.rb

@@ -71,15 +71,15 @@ RSpec.describe Flipper::Cloud::Telemetry::Submitter do
         to_return(status: 429, body: "{}").
         to_return(status: 200, body: "{}")
       instance = described_class.new(cloud_configuration)
-      expect(instance.backoff_policy.min_timeout_ms).to eq(1_000)
-      expect(instance.backoff_policy.max_timeout_ms).to eq(30_000)
+      expect(instance.backoff_policy.min_timeout_ms).to eq(30_000)
+      expect(instance.backoff_policy.max_timeout_ms).to eq(120_000)
     end
 
     it "tries 10 times by default" do
       stub_request(:post, "https://www.flippercloud.io/adapter/telemetry").
         to_return(status: 500, body: "{}")
       subject.call(enabled_metrics)
-      expect(subject.backoff_policy.retries).to eq(9) # 9 retries + 1 initial attempt
+      expect(subject.backoff_policy.retries).to eq(4) # 4 retries + 1 initial attempt
     end
 
     [
@@ -105,7 +105,7 @@ RSpec.describe Flipper::Cloud::Telemetry::Submitter do
         stub_request(:post, "https://www.flippercloud.io/adapter/telemetry").
           to_raise(error_class)
         subject.call(enabled_metrics)
-        expect(subject.backoff_policy.retries).to eq(9)
+        expect(subject.backoff_policy.retries).to eq(4)
       end
     end
 

data/spec/flipper/cloud/telemetry_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
 
     expect(telemetry.interval).to eq(60)
     expect(telemetry.timer.execution_interval).to eq(60)
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
   end
 
   it "phones home and updates telemetry interval if present" do
@@ -45,7 +45,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
 
     expect(telemetry.interval).to eq(120)
     expect(telemetry.timer.execution_interval).to eq(120)
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
   end
 
   it "phones home and requests shutdown if telemetry-shutdown header is true" do
@@ -67,7 +67,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
       result: true,
     })
     telemetry.stop
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
     expect(output.string).to match(/action=telemetry_shutdown message=The server has requested that telemetry be shut down./)
   end
 
@@ -90,7 +90,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
       result: true,
     })
     telemetry.stop
-    expect(stub).to have_been_requested
+    expect(stub).to have_been_requested.at_least_once
     expect(output.string).not_to match(/action=telemetry_shutdown message=The server has requested that telemetry be shut down./)
   end
 
@@ -122,7 +122,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
     # Check the conig interval and the timer interval.
     expect(telemetry.interval).to eq(120)
     expect(telemetry.timer.execution_interval).to eq(120)
-    expect(stub).to have_been_requested.times(10)
+    expect(stub).to have_been_requested.times(5)
   end
 
   it "doesn't try to update telemetry interval from error if not response error" do
@@ -152,7 +152,7 @@ RSpec.describe Flipper::Cloud::Telemetry do
 
     expect(telemetry.interval).to eq(60)
     expect(telemetry.timer.execution_interval).to eq(60)
-    expect(stub).to have_been_requested.times(10)
+    expect(stub).to have_been_requested.times(5)
   end
 
   describe '#record' do

data/spec/flipper/cloud_spec.rb

@@ -43,6 +43,7 @@ RSpec.describe Flipper::Cloud do
 
   context 'initialize with token and options' do
     it 'sets correct url' do
+      stub_request(:any, %r{fakeflipper.com}).to_return(status: 200)
       instance = described_class.new(token: 'asdf', url: 'https://www.fakeflipper.com/sadpanda')
       # pardon the nesting...
       memoized = instance.adapter
@@ -78,27 +79,31 @@ RSpec.describe Flipper::Cloud do
   end
 
   it 'can set debug_output' do
+    instance = Flipper::Adapters::Http::Client.new(token: 'asdf', url: 'https://www.flippercloud.io/adapter')
     expect(Flipper::Adapters::Http::Client).to receive(:new)
-      .with(hash_including(debug_output: STDOUT)).at_least(:once)
+      .with(hash_including(debug_output: STDOUT)).at_least(:once).and_return(instance)
     described_class.new(token: 'asdf', debug_output: STDOUT)
   end
 
   it 'can set read_timeout' do
+    instance = Flipper::Adapters::Http::Client.new(token: 'asdf', url: 'https://www.flippercloud.io/adapter')
     expect(Flipper::Adapters::Http::Client).to receive(:new)
-      .with(hash_including(read_timeout: 1)).at_least(:once)
+      .with(hash_including(read_timeout: 1)).at_least(:once).and_return(instance)
     described_class.new(token: 'asdf', read_timeout: 1)
   end
 
   it 'can set open_timeout' do
+    instance = Flipper::Adapters::Http::Client.new(token: 'asdf', url: 'https://www.flippercloud.io/adapter')
     expect(Flipper::Adapters::Http::Client).to receive(:new)
-      .with(hash_including(open_timeout: 1)).at_least(:once)
+      .with(hash_including(open_timeout: 1)).at_least(:once).and_return(instance)
     described_class.new(token: 'asdf', open_timeout: 1)
   end
 
   if RUBY_VERSION >= '2.6.0'
     it 'can set write_timeout' do
+      instance = Flipper::Adapters::Http::Client.new(token: 'asdf', url: 'https://www.flippercloud.io/adapter')
       expect(Flipper::Adapters::Http::Client).to receive(:new)
-        .with(hash_including(open_timeout: 1)).at_least(:once)
+        .with(hash_including(open_timeout: 1)).at_least(:once).and_return(instance)
       described_class.new(token: 'asdf', open_timeout: 1)
     end
   end

data/spec/flipper/dsl_spec.rb

@@ -225,9 +225,6 @@ RSpec.describe Flipper::DSL do
 
   describe '#enable_group/disable_group' do
     it 'enables and disables the feature for group' do
-      actor = Flipper::Actor.new(5)
-      group = Flipper.register(:fives) { |actor| actor.flipper_id == 5 }
-
       expect(subject[:stats].groups_value).to be_empty
       subject.enable_group(:stats, :fives)
       expect(subject[:stats].groups_value).to eq(Set['fives'])

data/spec/flipper/engine_spec.rb

@@ -12,6 +12,7 @@ RSpec.describe Flipper::Engine do
   end
 
   before do
+    stub_request(:get, /flippercloud\.io/).to_return(status: 200, body: "{}")
     Rails.application = nil
     ActiveSupport::Dependencies.autoload_paths = ActiveSupport::Dependencies.autoload_paths.dup
     ActiveSupport::Dependencies.autoload_once_paths = ActiveSupport::Dependencies.autoload_once_paths.dup

data/spec/flipper/feature_spec.rb

@@ -76,6 +76,26 @@ RSpec.describe Flipper::Feature do
         expect(subject.enabled?(actors)).to be(false)
       end
     end
+
+    context "for an object that implements .nil? == true" do
+      let(:actor) { Flipper::Actor.new("User;1") }
+
+      before do
+        def actor.nil?
+          true
+        end
+      end
+
+      it 'returns true if feature is enabled' do
+        subject.enable
+        expect(subject.enabled?(actor)).to be(true)
+      end
+
+      it 'returns false if feature is disabled' do
+        subject.disable
+        expect(subject.enabled?(actor)).to be(false)
+      end
+    end
   end
 
   describe '#to_s' do
@@ -195,7 +215,7 @@ RSpec.describe Flipper::Feature do
 
     it 'is recorded for enable' do
       actor = Flipper::Types::Actor.new(Flipper::Actor.new('1'))
-      gate = subject.gate_for(actor)
+      subject.gate_for(actor)
 
       subject.enable(actor)
 
@@ -210,7 +230,7 @@ RSpec.describe Flipper::Feature do
 
     it 'always instruments flipper type instance for enable' do
       actor = Flipper::Actor.new('1')
-      gate = subject.gate_for(actor)
+      subject.gate_for(actor)
 
       subject.enable(actor)
 
@@ -221,7 +241,6 @@ RSpec.describe Flipper::Feature do
 
     it 'is recorded for disable' do
       thing = Flipper::Types::Boolean.new
-      gate = subject.gate_for(thing)
 
       subject.disable(thing)
 
@@ -266,7 +285,6 @@ RSpec.describe Flipper::Feature do
 
     it 'always instruments flipper type instance for disable' do
       actor = Flipper::Actor.new('1')
-      gate = subject.gate_for(actor)
 
       subject.disable(actor)
 
@@ -709,7 +727,6 @@ RSpec.describe Flipper::Feature do
     context "with expression instance" do
       it "updates gate values to equal expression or clears expression" do
         expression = Flipper.property(:plan).eq("basic")
-        other_expression = Flipper.property(:age).gte(21)
         expect(subject.gate_values.expression).to be(nil)
         subject.enable_expression(expression)
         expect(subject.gate_values.expression).to eq(expression.value)
@@ -721,7 +738,6 @@ RSpec.describe Flipper::Feature do
     context "with Hash" do
       it "updates gate values to equal expression or clears expression" do
         expression = Flipper.property(:plan).eq("basic")
-        other_expression = Flipper.property(:age).gte(21)
         expect(subject.gate_values.expression).to be(nil)
         subject.enable_expression(expression.value)
         expect(subject.gate_values.expression).to eq(expression.value)
@@ -1078,8 +1094,6 @@ RSpec.describe Flipper::Feature do
   describe '#enable_group/disable_group' do
     context 'with symbol group name' do
       it 'updates the gate values to include the group' do
-        actor = Flipper::Actor.new(5)
-        group = Flipper.register(:five_only) { |actor| actor.flipper_id == 5 }
         expect(subject.gate_values.groups).to be_empty
         subject.enable_group(:five_only)
         expect(subject.gate_values.groups).to eq(Set['five_only'])
@@ -1090,8 +1104,6 @@ RSpec.describe Flipper::Feature do
 
     context 'with string group name' do
       it 'updates the gate values to include the group' do
-        actor = Flipper::Actor.new(5)
-        group = Flipper.register(:five_only) { |actor| actor.flipper_id == 5 }
         expect(subject.gate_values.groups).to be_empty
         subject.enable_group('five_only')
         expect(subject.gate_values.groups).to eq(Set['five_only'])
@@ -1102,7 +1114,6 @@ RSpec.describe Flipper::Feature do
 
     context 'with group instance' do
       it 'updates the gate values for the group' do
-        actor = Flipper::Actor.new(5)
         group = Flipper.register(:five_only) { |actor| actor.flipper_id == 5 }
         expect(subject.gate_values.groups).to be_empty
         subject.enable_group(group)

data/spec/flipper/instrumentation/log_subscriber_spec.rb

@@ -1,4 +1,5 @@
 require 'logger'
+require 'active_support/core_ext/object/blank'
 require 'flipper/instrumentation/log_subscriber'
 require 'flipper/adapters/instrumented'
 

data/spec/flipper/instrumentation/statsd_subscriber_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe Flipper::Instrumentation::StatsdSubscriber do
     Flipper.new(adapter, instrumenter: ActiveSupport::Notifications)
   end
 
-  let(:user) { user = Flipper::Actor.new('1') }
+  let(:user) { Flipper::Actor.new('1') }
 
   before do
     described_class.client = statsd_client

data/spec/flipper/middleware/memoizer_spec.rb

@@ -80,7 +80,7 @@ RSpec.describe Flipper::Middleware::Memoizer do
   context 'with preload: true' do
     let(:app) do
       # ensure scoped for builder block, annoying...
-      instance = flipper
+      flipper
       middleware = described_class
 
       Rack::Builder.new do
@@ -141,7 +141,7 @@ RSpec.describe Flipper::Middleware::Memoizer do
   context 'with preload specific' do
     let(:app) do
       # ensure scoped for builder block, annoying...
-      instance = flipper
+      flipper
       middleware = described_class
 
       Rack::Builder.new do
@@ -266,7 +266,7 @@ RSpec.describe Flipper::Middleware::Memoizer do
   context 'with multiple instances' do
     let(:app) do
       # ensure scoped for builder block, annoying...
-      instance = flipper
+      flipper
       middleware = described_class
 
       Rack::Builder.new do
@@ -316,7 +316,7 @@ RSpec.describe Flipper::Middleware::Memoizer do
   context 'with flipper setup in env' do
     let(:app) do
       # ensure scoped for builder block, annoying...
-      instance = flipper
+      flipper
       middleware = described_class
 
       Rack::Builder.new do
@@ -460,7 +460,6 @@ RSpec.describe Flipper::Middleware::Memoizer do
       cache.clear
       cached = Flipper::Adapters::ActiveSupportCacheStore.new(logged_memory, cache)
       logged_cached = Flipper::Adapters::OperationLogger.new(cached)
-      memo = {}
       flipper = Flipper.new(logged_cached)
       flipper[:stats].enable
       flipper[:shiny].enable

data/spec/flipper/model/active_record_spec.rb

@@ -30,9 +30,20 @@ RSpec.describe Flipper::Model::ActiveRecord do
     include Flipper::Model::ActiveRecord
   end
 
+  class DelegatedUser < DelegateClass(User)
+  end
+
   class Admin < User
   end
 
+  it "doesn't warn for to_ary" do
+    # looks like we should remove this but you are wrong, we have specs that
+    # fail if there are warnings and if this regresses it will print a warning
+    # so it is in fact testing something
+    user = User.create!(name: "Test")
+    Flipper.enabled?(:something, DelegatedUser.new(user))
+  end
+
   describe "flipper_id" do
     it "returns class name and id" do
       expect(User.new(id: 1).flipper_id).to eq("User;1")

data/spec/flipper_spec.rb

@@ -313,7 +313,7 @@ RSpec.describe Flipper do
 
   describe '.group_exists' do
     it 'returns true if the group is already created' do
-      group = described_class.register('admins', &:admin?)
+      described_class.register('admins', &:admin?)
       expect(described_class.group_exists?(:admins)).to eq(true)
     end
 

data/spec/spec_helper.rb

@@ -2,12 +2,14 @@ $LOAD_PATH.unshift(File.expand_path('../../lib', __FILE__))
 
 require 'pp'
 require 'pathname'
-FlipperRoot = Pathname(__FILE__).dirname.join('..').expand_path
-
-require 'rubygems'
-require 'bundler'
+require 'bundler/setup'
 
-Bundler.setup(:default)
+require 'warning'
+Warning.ignore(/lib\/statsd/)
+Warning.ignore(/lib\/debug\//)
+Warning.ignore(/lib\/ice_age\//)
+Warning.ignore(/lib\/moneta\//)
+Warning.ignore(/lib\/mongo\//)
 
 require 'debug'
 require 'statsd'
@@ -20,6 +22,7 @@ require 'flipper/spec/shared_adapter_specs'
 require 'flipper/ui'
 require 'flipper/test_help'
 
+FlipperRoot = Pathname(__FILE__).dirname.join('..').expand_path
 Dir[FlipperRoot.join('spec/support/**/*.rb')].sort.each { |f| require f }
 
 # Disable telemetry logging in specs.

data/test_rails/generators/flipper/setup_generator_test.rb

@@ -17,6 +17,11 @@ class SetupGeneratorTest < Rails::Generators::TestCase
     end
   end
 
+  test "generates an initializer" do
+    run_generator
+    assert_file 'config/initializers/flipper.rb', /Flipper\.configure/
+  end
+
   test "does not invoke flipper:active_record generator if ActiveRecord adapter not defined" do
     # Ensure adapter not defined
     Flipper::Adapters.send(:remove_const, :ActiveRecord) rescue nil

data/test_rails/generators/flipper/update_generator_test.rb

@@ -65,7 +65,7 @@ class UpdateGeneratorTest < Rails::Generators::TestCase
 
     assert_migration "db/migrate/create_flipper_tables.rb" do |migration|
       assert_method :up, migration do |up|
-        assert_match /text :value/, up
+        assert_match(/text :value/, up)
       end
     end
 

data/test_rails/helper.rb

@@ -4,6 +4,9 @@ require 'minitest/autorun'
 require 'rails'
 require 'rails/test_help'
 
+require 'warning'
+Warning.ignore(/lib\/capybara\//)
+
 begin
   ActiveSupport::TestCase.test_order = :random
 rescue NoMethodError

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - John Nunemaker
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-11-19 00:00:00.000000000 Z
+date: 2025-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -24,7 +23,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '2'
-description:
 email: support@flippercloud.io
 executables:
 - flipper
@@ -193,6 +191,7 @@ files:
 - lib/flipper/types/percentage_of_time.rb
 - lib/flipper/version.rb
 - lib/generators/flipper/setup_generator.rb
+- lib/generators/flipper/templates/initializer.rb
 - lib/generators/flipper/templates/update/migrations/01_create_flipper_tables.rb.erb
 - lib/generators/flipper/templates/update/migrations/02_change_flipper_gates_value_to_text.rb.erb
 - lib/generators/flipper/update_generator.rb
@@ -214,6 +213,7 @@ files:
 - spec/flipper/adapters/memoizable_spec.rb
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/adapters/operation_logger_spec.rb
+- spec/flipper/adapters/poll_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
 - spec/flipper/adapters/strict_spec.rb
@@ -314,8 +314,8 @@ metadata:
   homepage_uri: https://www.flippercloud.io
   source_code_uri: https://github.com/flippercloud/flipper
   bug_tracker_uri: https://github.com/flippercloud/flipper/issues
-  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.3.2
-post_install_message:
+  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.3.3
+  funding_uri: https://github.com/sponsors/flippercloud
 rdoc_options: []
 require_paths:
 - lib
@@ -330,8 +330,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.23
-signing_key:
+rubygems_version: 3.6.5
 specification_version: 4
 summary: Beautiful, performant feature flags for Ruby and Rails.
 test_files:
@@ -351,6 +350,7 @@ test_files:
 - spec/flipper/adapters/memoizable_spec.rb
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/adapters/operation_logger_spec.rb
+- spec/flipper/adapters/poll_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
 - spec/flipper/adapters/strict_spec.rb