flipper 1.3.0 → 1.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 934e0e50f2aea9b4294ed435a780f5eb55ad8b547df9c80f609022b880a4dd9c
-  data.tar.gz: 8799605783af26860795d336a66d511f35b0f644424aca80cd3f81baaadc6475
+  metadata.gz: 8f53e9dadf45ea1d00e7abd24358748347d516d761ea347c438057f62fdbc185
+  data.tar.gz: 8c2a73d793d41ce64ed26c559bf532127f73e17e20944930aa6bf14aff355a57
 SHA512:
-  metadata.gz: d0e041360e5d15966dd4f4a39be10616aff35dd56a7491297adce42b8d13d3ba7126feaf2d3798194c72fac73afad7e2355379ff51e40481f4a0ee25c49e6c8a
-  data.tar.gz: c16307b9a21775b1db67e9fd99c72c5206e7b0d6e0324e7625f349228757aea1243be676ba838ac0b853a7a48469fe8536da41085982556c0492ad985daf51ca
+  metadata.gz: af26df5e8c10540348e2b8dd31f11198dafdc8f3bcb6ef8e5361e3a764caa5a872734c64807746f1d077cfbc95df9143959e4c3446429dce1d5d871e46861fa7
+  data.tar.gz: 2005a736ea665c359154bf85f56495fcf9b326e9ecb740d2e1aca0c52a698367b44334a90ae2b1277c2a3c0dcdddcc478eab3126975f210fc796a454202913f4

data/.github/workflows/ci.yml

@@ -7,7 +7,7 @@ jobs:
     services:
       redis:
         image: redis
-        ports: ['6379:6379']
+        ports: ["6379:6379"]
         options: >-
           --health-cmd "redis-cli ping"
           --health-interval 10s
@@ -28,21 +28,35 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
-        rails: ['5.2', '6.0.0', '6.1.0', '7.0.0', '7.1.0']
+        ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
+        rails: ["5.2", "6.0.0", "6.1.0", "7.0.0", "7.1.0", "7.2.0", "8.0.0"]
         exclude:
           - ruby: "2.6"
             rails: "7.1.0"
           - ruby: "2.6"
             rails: "7.0.0"
+          - ruby: "2.6"
+            rails: "7.2.0"
+          - ruby: "2.6"
+            rails: "8.0.0"
           - ruby: "2.7"
             rails: "7.1.0"
+          - ruby: "2.7"
+            rails: "7.2.0"
+          - ruby: "2.7"
+            rails: "8.0.0"
           - ruby: "3.0"
             rails: "5.2"
+          - ruby: "3.0"
+            rails: "7.2.0"
+          - ruby: "3.0"
+            rails: "8.0.0"
           - ruby: "3.1"
             rails: "5.2"
           - ruby: "3.1"
             rails: "6.0.0"
+          - ruby: "3.1"
+            rails: "8.0.0"
           - ruby: "3.2"
             rails: "5.2"
           - ruby: "3.2"
@@ -56,7 +70,7 @@ jobs:
           - ruby: "3.3"
             rails: "6.1.0"
     env:
-      SQLITE3_VERSION: 1.4.1
+      SQLITE3_VERSION: ${{ matrix.rails == '8.0.0' && '2.1.0' || '1.4.1' }}
       REDIS_URL: redis://localhost:6379/0
       CI: true
       RAILS_VERSION: ${{ matrix.rails }}
@@ -70,7 +84,7 @@ jobs:
       - name: Setup memcached
         uses: KeisukeYamashita/memcached-actions@v1
       - name: Start MongoDB
-        uses: supercharge/mongodb-github-action@v1.10.0
+        uses: supercharge/mongodb-github-action@1.12.0
         with:
           mongodb-version: 4.0
       - name: Check out repository code

data/.github/workflows/examples.yml

@@ -8,7 +8,7 @@ jobs:
     services:
       redis:
         image: redis
-        ports: ['6379:6379']
+        ports: ["6379:6379"]
         options: >-
           --health-cmd "redis-cli ping"
           --health-interval 10s
@@ -16,21 +16,35 @@ jobs:
           --health-retries 5
     strategy:
       matrix:
-        ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
-        rails: ['5.2', '6.0.0', '6.1.0', '7.0.0', '7.1.0']
+        ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
+        rails: ["5.2", "6.0.0", "6.1.0", "7.0.0", "7.1.0", "7.2.0", "8.0.0"]
         exclude:
           - ruby: "2.6"
             rails: "7.1.0"
           - ruby: "2.6"
             rails: "7.0.0"
+          - ruby: "2.6"
+            rails: "7.2.0"
+          - ruby: "2.6"
+            rails: "8.0.0"
           - ruby: "2.7"
             rails: "7.1.0"
+          - ruby: "2.7"
+            rails: "7.2.0"
+          - ruby: "2.7"
+            rails: "8.0.0"
           - ruby: "3.0"
             rails: "5.2"
+          - ruby: "3.0"
+            rails: "7.2.0"
+          - ruby: "3.0"
+            rails: "8.0.0"
           - ruby: "3.1"
             rails: "5.2"
           - ruby: "3.1"
             rails: "6.0.0"
+          - ruby: "3.1"
+            rails: "8.0.0"
           - ruby: "3.2"
             rails: "5.2"
           - ruby: "3.2"
@@ -44,7 +58,7 @@ jobs:
           - ruby: "3.3"
             rails: "6.1.0"
     env:
-      SQLITE3_VERSION: 1.4.1
+      SQLITE3_VERSION: ${{ matrix.rails == '8.0.0' && '2.1.0' || '1.4.1' }}
       REDIS_URL: redis://localhost:6379/0
       CI: true
       RAILS_VERSION: ${{ matrix.rails }}
@@ -52,7 +66,7 @@ jobs:
       - name: Setup memcached
         uses: KeisukeYamashita/memcached-actions@v1
       - name: Start MongoDB
-        uses: supercharge/mongodb-github-action@v1.10.0
+        uses: supercharge/mongodb-github-action@1.12.0
         with:
           mongodb-version: 4.0
       - name: Check out repository code

data/CLAUDE.md

@@ -0,0 +1,74 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Development Commands
+
+### Testing
+- `bundle exec rake` - Run all tests (RSpec, Minitest, and Rails tests)
+- `bundle exec rspec` - Run RSpec tests only
+- `bundle exec rake spec:ui` - Run UI-specific specs
+- `bundle exec rake test` - Run Minitest tests only
+- `bundle exec rake test_rails` - Run Rails generator tests
+- `script/test` - Bootstrap and run tests across multiple Rails versions (5.0-8.0)
+
+### Development Setup
+- `script/bootstrap` - Bundle install dependencies and setup binstubs
+- `script/console` - Start interactive console with Flipper loaded (uses Pry)
+- `script/server` - Start local UI server on port 9999 for testing web interface
+
+### Building and Releasing
+- `bundle exec rake build` - Build all gems into pkg/ directory
+- `bundle exec rake release` - Tag version, push to remote, and push gems (requires OTP)
+
+## Architecture Overview
+
+Flipper is a feature flag library for Ruby with a modular adapter-based architecture:
+
+### Core Components
+
+**DSL Layer** (`lib/flipper/dsl.rb`):
+- Main interface for feature flag operations
+- Delegates to Feature instances
+- Handles memoization and instrumentation
+- Thread-safe instance management
+
+**Feature** (`lib/flipper/feature.rb`):
+- Represents individual feature flags
+- Manages enable/disable operations through gates
+- Handles instrumentation events
+- Works with adapters for persistence
+
+**Adapters** (`lib/flipper/adapters/`):
+- Pluggable storage backends (Redis, ActiveRecord, Memory, etc.)
+- Common interface for all storage implementations
+- Support for caching, failover, and synchronization patterns
+
+**Gates** (`lib/flipper/gates/`):
+- Different targeting mechanisms:
+  - Boolean (on/off for everyone)
+  - Actor (specific users/entities)
+  - Group (predefined user groups)
+  - Percentage of Actors (rollout to X% of users)
+  - Percentage of Time (probabilistic enabling)
+  - Expression (complex conditional logic)
+
+### Multi-Gem Structure
+
+The project is structured as multiple gems:
+- `flipper` - Core library
+- `flipper-ui` - Web interface
+- `flipper-api` - REST API
+- `flipper-cloud` - Cloud service integration
+- `flipper-*` - Various adapter gems (redis, active_record, mongo, etc.)
+
+### Key Patterns
+
+**Configuration**: Global configuration through `Flipper.configure` with per-thread instances
+**Instrumentation**: Built-in event system for monitoring and debugging
+**Memoization**: Automatic caching of feature checks within request/thread scope
+**Type Safety**: Strong typing system for actors, percentages, and other values
+
+### Testing
+
+Uses both RSpec (currently preferred for new tests) and Minitest. Shared adapter specs ensure consistency across all storage backends. Extensive testing across multiple Rails versions (5.0-8.0).

data/Gemfile

@@ -6,16 +6,19 @@ Dir['flipper-*.gemspec'].each do |gemspec|
   gemspec(name: "flipper-#{plugin}", development_group: plugin)
 end
 
+gem 'concurrent-ruby', '1.3.4'
+gem 'connection_pool'
 gem 'debug'
 gem 'rake'
 gem 'statsd-ruby', '~> 1.2.1'
 gem 'rspec', '~> 3.0'
 gem 'rack-test'
-gem 'rackup'
-gem 'sqlite3', "~> #{ENV['SQLITE3_VERSION'] || '1.4.1'}"
-gem 'rails', "~> #{ENV['RAILS_VERSION'] || '7.1'}"
+gem 'rackup', '= 1.0.0'
+gem 'sqlite3', "~> #{ENV['SQLITE3_VERSION'] || '2.1.0'}"
+gem 'rails', "~> #{ENV['RAILS_VERSION'] || '8.0'}"
 gem 'minitest', '~> 5.18'
 gem 'minitest-documentation'
+gem 'pstore'
 gem 'webmock'
 gem 'ice_age'
 gem 'redis-namespace'
@@ -28,6 +31,7 @@ gem 'mysql2'
 gem 'pg'
 gem 'cuprite'
 gem 'puma'
+gem 'warning'
 
 group(:guard) do
   gem 'guard'

data/README.md

@@ -1,6 +1,6 @@
 [![Flipper Mark](docs/images/banner.jpg)](https://www.flippercloud.io)
 
-[Website](https://flippercloud.io?utm_source=oss&utm_medium=readme&utm_campaign=website_link) | [Documentation](https://flippercloud.io/docs?utm_source=oss&utm_medium=readme&utm_campaign=docs_link) | [Examples](examples) | [Twitter](https://twitter.com/flipper_cloud) | [Ruby.social](https://ruby.social/@flipper)
+[Website](https://flippercloud.io?utm_source=oss&utm_medium=readme&utm_campaign=website_link) | [Documentation](https://flippercloud.io/docs?utm_source=oss&utm_medium=readme&utm_campaign=docs_link) | [Examples](examples) | [Chat](https://chat.flippercloud.io/join/xjHq-aJsA-BeZH) | [Twitter](https://twitter.com/flipper_cloud) | [Ruby.social](https://ruby.social/@flipper)
 
 # Flipper
 

data/examples/cloud/backoff_policy.rb

@@ -5,7 +5,7 @@ require 'flipper/cloud/telemetry/backoff_policy'
 intervals = []
 policy = Flipper::Cloud::Telemetry::BackoffPolicy.new
 
-10.times do |n|
+5.times do |n|
   intervals << policy.next_interval
 end
 

data/lib/flipper/adapter_builder.rb

@@ -3,7 +3,7 @@ module Flipper
   #
   #   adapter = Flipper::AdapterBuilder.new do
   #     use Flipper::Adapters::Strict
-  #     use Flipper::Adapters::Memoizer
+  #     use Flipper::Adapters::Memoizable
   #     store Flipper::Adapters::Memory
   #   end.to_adapter
   #

data/lib/flipper/adapters/http/error.rb

@@ -20,7 +20,7 @@ module Flipper
             if more_info = data["more_info"]
               message << "\n#{data["more_info"]}"
             end
-          rescue => exception
+          rescue
             # welp we tried
           end
 

data/lib/flipper/adapters/http.rb

@@ -59,8 +59,8 @@ module Flipper
         response = @client.get("/features?exclude_gate_names=true")
         raise Error, response unless response.is_a?(Net::HTTPOK)
 
-        parsed_response = Typecast.from_json(response.body)
-        parsed_features = parsed_response.fetch('features')
+        parsed_response = response.body.empty? ? {} : Typecast.from_json(response.body)
+        parsed_features = parsed_response['features'] || []
         gates_by_key = parsed_features.each_with_object({}) do |parsed_feature, hash|
           hash[parsed_feature['key']] = parsed_feature['gates']
           hash

data/lib/flipper/adapters/poll.rb

@@ -18,6 +18,21 @@ module Flipper
         @adapter = adapter
         @poller = poller
         @last_synced_at = 0
+
+        # If the adapter is empty, we need to sync before starting the poller.
+        # Yes, this will block the main thread, but that's better than thinking
+        # nothing is enabled.
+        if adapter.features.empty?
+          begin
+            @poller.sync
+          rescue
+            # TODO: Warn here that it's possible that no data has been synced
+            # and flags are being evaluated without flag data being present
+            # until a sync completes. We rescue to avoid flipper being down
+            # causing your processes to crash.
+          end
+        end
+
         @poller.start
       end
 

data/lib/flipper/cloud/configuration.rb

@@ -3,7 +3,6 @@ require "socket"
 require "flipper/adapters/http"
 require "flipper/adapters/poll"
 require "flipper/poller"
-require "flipper/adapters/memory"
 require "flipper/adapters/dual_write"
 require "flipper/adapters/sync/synchronizer"
 require "flipper/cloud/telemetry"
@@ -135,6 +134,10 @@ module Flipper
         logger.send(level, "name=flipper_cloud #{message}")
       end
 
+      def instrument(name, payload = {}, &block)
+        instrumenter.instrument(name, payload, &block)
+      end
+
       private
 
       def app_adapter
@@ -242,7 +245,7 @@ module Flipper
         if required
           option_value = send(name)
           if option_value.nil? || option_value.empty?
-            message = "Flipper::Cloud #{name} is missing. Please "
+            message = String.new("Flipper::Cloud #{name} is missing. Please ")
             message << "set #{env_var} or " if from_env
             message << "provide #{name} (e.g. Flipper::Cloud.new(#{name}: value))."
             raise ArgumentError, message

data/lib/flipper/cloud/telemetry/backoff_policy.rb

@@ -3,10 +3,10 @@ module Flipper
     class Telemetry
       class BackoffPolicy
         # Private: The default minimum timeout between intervals in milliseconds.
-        MIN_TIMEOUT_MS = 1_000
+        MIN_TIMEOUT_MS = 30_000
 
         # Private: The default maximum timeout between intervals in milliseconds.
-        MAX_TIMEOUT_MS = 30_000
+        MAX_TIMEOUT_MS = 120_000
 
         # Private: The value to multiply the current interval with for each
         # retry attempt.
@@ -67,7 +67,10 @@ module Flipper
 
           @attempts += 1
 
-          [interval, @max_timeout_ms].min
+          # cap the interval to the max timeout
+          result = [interval, @max_timeout_ms].min
+          # jitter even when maxed out
+          result == @max_timeout_ms ? add_jitter(result, 0.05) : result
         end
 
         def reset

data/lib/flipper/cloud/telemetry/submitter.rb

@@ -34,7 +34,7 @@ module Flipper
           return if drained.empty?
           body = to_body(drained)
           return if body.nil? || body.empty?
-          retry_with_backoff(10) { submit(body) }
+          retry_with_backoff(5) { submit(body) }
         end
 
         private
@@ -51,6 +51,7 @@ module Flipper
 
           Typecast.to_gzip(json)
         rescue => exception
+          @cloud_configuration.instrument "telemetry_error.#{Flipper::InstrumentationNamespace}", exception: exception, request_id: request_id
           @cloud_configuration.log "action=to_body request_id=#{request_id} error=#{exception.inspect}", level: :error
         end
 
@@ -63,6 +64,7 @@ module Flipper
             result, should_retry = yield
             return [result, nil] unless should_retry
           rescue => error
+            @cloud_configuration.instrument "telemetry_retry.#{Flipper::InstrumentationNamespace}", attempts_remaining: attempts_remaining, exception: error
             @cloud_configuration.log "action=post_to_cloud attempts_remaining=#{attempts_remaining} error=#{error.inspect}", level: :error
             should_retry = true
             caught_exception = error

data/lib/flipper/cloud/telemetry.rb

@@ -75,8 +75,8 @@ module Flipper
 
         @metric_storage = MetricStorage.new
 
-        @pool = Concurrent::FixedThreadPool.new(2, {
-          max_queue: 5,
+        @pool = Concurrent::FixedThreadPool.new(1, {
+          max_queue: 20, # ~ 20 minutes of data at 1 minute intervals
           fallback_policy: :discard,
           name: "flipper-telemetry-post-to-cloud-pool".freeze,
         })

data/lib/flipper/export.rb

@@ -1,5 +1,3 @@
-require "flipper/adapters/memory"
-
 module Flipper
   class Export
     attr_reader :contents, :format, :version

data/lib/flipper/expressions/all.rb

@@ -1,5 +1,3 @@
-require "flipper/expression"
-
 module Flipper
   module Expressions
     class All

data/lib/flipper/feature.rb

@@ -100,7 +100,14 @@ module Flipper
     #
     # Returns true if enabled, false if not.
     def enabled?(*actors)
-      actors = actors.flatten.compact.map { |actor| Types::Actor.wrap(actor) }
+      actors = Array(actors).
+        # Avoids to_ary warning that happens when passing DelegateClass of an 
+        # ActiveRecord object and using flatten here. This is tested in 
+        # spec/flipper/model/active_record_spec.rb.
+        flat_map { |actor| actor.is_a?(Array) ? actor : [actor] }. 
+        # Allows null object pattern. See PR for more. https://github.com/flippercloud/flipper/pull/887
+        reject(&:nil?). 
+        map { |actor| Types::Actor.wrap(actor) }
       actors = nil if actors.empty?
 
       # thing is left for backwards compatibility

data/lib/flipper/gate.rb

@@ -26,7 +26,7 @@ module Flipper
     # in subclass.
     #
     # Returns true if gate open for any actor, false if not.
-    def open?(actors, value, options = {})
+    def open?(context)
       false
     end
 

data/lib/flipper/instrumentation/log_subscriber.rb

@@ -53,11 +53,10 @@ module Flipper
 
         feature_name = event.payload[:feature_name]
         adapter_name = event.payload[:adapter_name]
-        gate_name = event.payload[:gate_name]
         operation = event.payload[:operation]
         result = event.payload[:result]
 
-        description = 'Flipper '
+        description = String.new('Flipper ')
         description << "feature(#{feature_name}) " unless feature_name.nil?
         description << "adapter(#{adapter_name}) "
         description << "#{operation} "

data/lib/flipper/instrumentation/statsd.rb

@@ -2,5 +2,7 @@ require 'securerandom'
 require 'active_support/notifications'
 require 'flipper/instrumentation/statsd_subscriber'
 
-ActiveSupport::Notifications.subscribe /\.flipper$/,
-                                       Flipper::Instrumentation::StatsdSubscriber
+ActiveSupport::Notifications.subscribe(
+  /\.flipper$/,
+  Flipper::Instrumentation::StatsdSubscriber
+)

data/lib/flipper/instrumentation/subscriber.rb

@@ -42,7 +42,6 @@ module Flipper
       # Private
       def update_feature_operation_metrics
         feature_name = @payload[:feature_name]
-        gate_name = @payload[:gate_name]
         operation = strip_trailing_question_mark(@payload[:operation])
         result = @payload[:result]
 
@@ -64,9 +63,6 @@ module Flipper
       def update_adapter_operation_metrics
         adapter_name = @payload[:adapter_name]
         operation = @payload[:operation]
-        result = @payload[:result]
-        value = @payload[:value]
-        key = @payload[:key]
 
         update_timer "flipper.adapter.#{adapter_name}.#{operation}"
       end

data/lib/flipper/metadata.rb

@@ -7,5 +7,6 @@ module Flipper
     "source_code_uri"   => "https://github.com/flippercloud/flipper",
     "bug_tracker_uri"   => "https://github.com/flippercloud/flipper/issues",
     "changelog_uri"     => "https://github.com/flippercloud/flipper/releases/tag/v#{Flipper::VERSION}",
+    "funding_uri"       => "https://github.com/sponsors/flippercloud",
   }.freeze
 end

data/lib/flipper/poller.rb

@@ -59,10 +59,10 @@ module Flipper
     def run
       loop do
         sleep jitter
-        start = Concurrent.monotonic_time
+
         begin
           sync
-        rescue => exception
+        rescue
           # you can instrument these using poller.flipper
         end
 

data/lib/flipper/version.rb

@@ -1,5 +1,5 @@
 module Flipper
-  VERSION = '1.3.0'.freeze
+  VERSION = '1.3.6'.freeze
 
   REQUIRED_RUBY_VERSION = '2.6'.freeze
   NEXT_REQUIRED_RUBY_VERSION = '3.0'.freeze

data/lib/generators/flipper/setup_generator.rb

@@ -4,10 +4,15 @@ module Flipper
   module Generators
     class SetupGenerator < ::Rails::Generators::Base
       desc 'Peform any necessary steps to install Flipper'
+      source_paths << File.expand_path('templates', __dir__)
 
       class_option :token, type: :string, default: nil, aliases: '-t',
         desc: "Your personal environment token for Flipper Cloud"
 
+      def generate_initializer
+        template 'initializer.rb', 'config/initializers/flipper.rb'
+      end
+
       def generate_active_record
         invoke 'flipper:active_record' if defined?(Flipper::Adapters::ActiveRecord)
       end

data/lib/generators/flipper/templates/initializer.rb

@@ -0,0 +1,45 @@
+Rails.application.configure do
+  ## Memoization ensures that only one adapter call is made per feature per request.
+  ## For more info, see https://www.flippercloud.io/docs/optimization#memoization
+  # config.flipper.memoize = true
+
+  ## Flipper preloads all features before each request, which is recommended if:
+  ##   * you have a limited number of features (< 100?)
+  ##   * most of your requests depend on most of your features
+  ##   * you have limited gate data combined across all features (< 1k enabled gates, like individual actors, across all features)
+  ##
+  ## For more info, see https://www.flippercloud.io/docs/optimization#preloading
+  # config.flipper.preload = true
+
+  ## Warn or raise an error if an unknown feature is checked
+  ## Can be set to `:warn`, `:raise`, or `false`
+  # config.flipper.strict = Rails.env.development? && :warn
+
+  ## Show Flipper checks in logs
+  # config.flipper.log = true
+
+  ## Reconfigure Flipper to use the Memory adapter and disable Cloud in tests
+  # config.flipper.test_help = true
+
+  ## The path that Flipper Cloud will use to sync features
+  # config.flipper.cloud_path = "_flipper"
+
+  ## The instrumenter that Flipper will use. Defaults to ActiveSupport::Notifications.
+  # config.flipper.instrumenter = ActiveSupport::Notifications
+end
+
+Flipper.configure do |config|
+  ## Configure other adapters that you want to use here:
+  ## See http://flippercloud.io/docs/adapters
+  # config.use Flipper::Adapters::ActiveSupportCacheStore, Rails.cache, expires_in: 5.minutes
+end
+
+## Register a group that can be used for enabling features.
+##
+##   Flipper.enable_group :my_feature, :admins
+##
+## See https://www.flippercloud.io/docs/features#enablement-group
+#
+# Flipper.register(:admins) do |actor|
+#  actor.respond_to?(:admin?) && actor.admin?
+# end

data/spec/flipper/adapters/http_spec.rb

@@ -28,6 +28,7 @@ RSpec.describe Flipper::Adapters::Http do
       end
 
       before :all do
+        @started = false
         dir = FlipperRoot.join('tmp').tap(&:mkpath)
         log_path = dir.join('flipper_adapters_http_spec.log')
         @pstore_file = dir.join('flipper.pstore')

data/spec/flipper/adapters/poll_spec.rb

@@ -0,0 +1,41 @@
+require 'flipper/adapters/poll'
+
+RSpec.describe Flipper::Adapters::Poll do
+  let(:remote_adapter) {
+    adapter = Flipper::Adapters::Memory.new(threadsafe: true)
+    flipper = Flipper.new(adapter)
+    flipper.enable(:search)
+    flipper.enable(:analytics)
+    adapter
+  }
+  let(:local_adapter) { Flipper::Adapters::Memory.new(threadsafe: true) }
+  let(:poller) {
+    Flipper::Poller.get("for_spec", {
+      start_automatically: false,
+      remote_adapter: remote_adapter,
+    })
+  }
+
+  it "syncs in main thread if local adapter is empty" do
+    instance = described_class.new(poller, local_adapter)
+    instance.features # call something to force sync
+    expect(local_adapter.features).to eq(remote_adapter.features)
+  end
+
+  it "does not sync in main thread if local adapter is not empty" do
+    # make local not empty by importing remote
+    flipper = Flipper.new(local_adapter)
+    flipper.import(remote_adapter)
+
+    # make a fake poller to verify calls
+    poller = double("Poller", last_synced_at: Concurrent::AtomicFixnum.new(0))
+    expect(poller).to receive(:start).twice
+    expect(poller).not_to receive(:sync)
+
+    # create new instance and call something to force sync
+    instance = described_class.new(poller, local_adapter)
+    instance.features # call something to force sync
+
+    expect(local_adapter.features).to eq(remote_adapter.features)
+  end
+end