flipper 1.0.0 → 1.1.1

data/spec/flipper_spec.rb

@@ -64,7 +64,12 @@ RSpec.describe Flipper do
 
   describe "delegation to instance" do
     let(:group) { Flipper::Types::Group.new(:admins) }
-    let(:actor) { Flipper::Actor.new("1") }
+    let(:actor) {
+      Flipper::Actor.new("1", {
+        "plan" => "basic",
+      })
+    }
+    let(:expression) { Flipper.property(:plan).eq("basic") }
 
     before do
       described_class.configure do |config|
@@ -88,6 +93,37 @@ RSpec.describe Flipper do
       expect(described_class.instance.enabled?(:search)).to be(false)
     end
 
+    it 'delegates expression to instance' do
+      expect(described_class.expression(:search)).to be(nil)
+
+      expression = Flipper.property(:plan).eq("basic")
+      Flipper.instance.enable_expression :search, expression
+
+      expect(described_class.expression(:search)).to eq(expression)
+    end
+
+    it 'delegates enable_expression to instance' do
+      described_class.enable_expression(:search, expression)
+      expect(described_class.instance.enabled?(:search, actor)).to be(true)
+    end
+
+    it 'delegates disable_expression to instance' do
+      described_class.disable_expression(:search)
+      expect(described_class.instance.enabled?(:search, actor)).to be(false)
+    end
+
+    it 'delegates add_expression to instance' do
+      described_class.add_expression(:search, expression)
+      expect(described_class.instance.enabled?(:search, actor)).to be(true)
+    end
+
+    it 'delegates remove_expression to instance' do
+      described_class.enable_expression(:search, Flipper.any(expression))
+      expect(described_class.instance.enabled?(:search, actor)).to be(true)
+      described_class.remove_expression(:search, expression)
+      expect(described_class.instance.enabled?(:search, actor)).to be(false)
+    end
+
     it 'delegates enable_actor to instance' do
       described_class.enable_actor(:search, actor)
       expect(described_class.instance.enabled?(:search, actor)).to be(true)
@@ -192,6 +228,10 @@ RSpec.describe Flipper do
       expect(described_class.memoizing?).to eq(described_class.adapter.memoizing?)
     end
 
+    it 'delegates read_only? to instance' do
+      expect(described_class.read_only?).to eq(described_class.adapter.read_only?)
+    end
+
     it 'delegates sync stuff to instance and does nothing' do
       expect(described_class.sync).to be(nil)
       expect(described_class.sync_secret).to be(nil)
@@ -326,4 +366,52 @@ RSpec.describe Flipper do
       expect(described_class.instance_variable_get('@groups_registry')).to eq(registry)
     end
   end
+
+  describe ".constant" do
+    it "returns Flipper::Expression::Constant instance" do
+      expect(described_class.constant(false)).to eq(Flipper::Expression::Constant.new(false))
+      expect(described_class.constant("string")).to eq(Flipper::Expression::Constant.new("string"))
+    end
+  end
+
+  describe ".property" do
+    it "returns Flipper::Expressions::Property expression" do
+      expect(Flipper.property("name")).to eq(Flipper::Expression.build(Property: "name"))
+    end
+  end
+
+  describe ".boolean" do
+    it "returns Flipper::Expressions::Boolean expression" do
+      expect(described_class.boolean(true)).to eq(Flipper::Expression.build(Boolean: true))
+      expect(described_class.boolean(false)).to eq(Flipper::Expression.build(Boolean: false))
+    end
+  end
+
+  describe ".random" do
+    it "returns Flipper::Expressions::Random expression" do
+      expect(Flipper.random(100)).to eq(Flipper::Expression.build(Random: 100))
+    end
+  end
+
+  describe ".any" do
+    let(:age_expression) { Flipper.property(:age).gte(21) }
+    let(:plan_expression) { Flipper.property(:plan).eq("basic") }
+
+    it "returns Flipper::Expressions::Any instance" do
+      expect(Flipper.any(age_expression, plan_expression)).to eq(
+        Flipper::Expression.build({Any: [age_expression, plan_expression]})
+      )
+    end
+  end
+
+  describe ".all" do
+    let(:age_expression) { Flipper.property(:age).gte(21) }
+    let(:plan_expression) { Flipper.property(:plan).eq("basic") }
+
+    it "returns Flipper::Expressions::All instance" do
+      expect(Flipper.all(age_expression, plan_expression)).to eq(
+        Flipper::Expression.build({All: [age_expression, plan_expression]})
+      )
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -10,6 +10,7 @@ require 'bundler'
 Bundler.setup(:default)
 
 require 'debug'
+require 'statsd'
 require 'webmock/rspec'
 WebMock.disable_net_connect!(allow_localhost: true)
 
@@ -20,8 +21,12 @@ require 'flipper/ui'
 
 Dir[FlipperRoot.join('spec/support/**/*.rb')].sort.each { |f| require f }
 
+# Disable telemetry logging in specs.
+ENV["FLIPPER_CLOUD_LOGGING_ENABLED"] = "false"
+
 RSpec.configure do |config|
   config.before(:example) do
+    Flipper::Cloud::Telemetry.reset if defined?(Flipper::Cloud::Telemetry) && Flipper::Cloud::Telemetry.respond_to?(:reset)
     Flipper::Poller.reset if defined?(Flipper::Poller)
     Flipper.unregister_groups
     Flipper.configuration = nil

data/spec/support/actor_names.yml

@@ -0,0 +1 @@
+actor_name_1: 'Actor #1'

data/spec/support/fake_backoff_policy.rb

@@ -0,0 +1,15 @@
+class FakeBackoffPolicy
+  def initialize
+    @retries = 0
+  end
+
+  attr_reader :retries
+
+  def next_interval
+    @retries += 1
+    0
+  end
+
+  def reset
+  end
+end

data/spec/support/spec_helpers.rb

@@ -42,6 +42,14 @@ module SpecHelpers
     }
   end
 
+  def api_positive_percentage_error_response
+    {
+      'code' => 3,
+      'message' => 'Percentage must be a positive number less than or equal to 100.',
+      'more_info' => api_error_code_reference_url,
+    }
+  end
+
   def api_flipper_id_is_missing_response
     {
       'code' => 4,
@@ -50,10 +58,10 @@ module SpecHelpers
     }
   end
 
-  def api_positive_percentage_error_response
+  def api_expression_invalid_response
     {
-      'code' => 3,
-      'message' => 'Percentage must be a positive number less than or equal to 100.',
+      'code' => 7,
+      'message' => 'The provided expression was not valid.',
       'more_info' => api_error_code_reference_url,
     }
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-23 00:00:00.000000000 Z
+date: 2023-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -24,20 +24,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '2'
-- !ruby/object:Gem::Dependency
-  name: brow
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.4.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.4.1
 description:
 email: support@flippercloud.io
 executables: []
@@ -45,6 +31,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".github/FUNDING.yml"
 - ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
 - ".github/workflows/examples.yml"
@@ -71,6 +58,7 @@ files:
 - examples/api/memoized.ru
 - examples/basic.rb
 - examples/cloud/app.ru
+- examples/cloud/backoff_policy.rb
 - examples/cloud/basic.rb
 - examples/cloud/cloud_setup.rb
 - examples/cloud/forked.rb
@@ -79,6 +67,7 @@ files:
 - examples/configuring_default.rb
 - examples/dsl.rb
 - examples/enabled_for_actor.rb
+- examples/expressions.rb
 - examples/group.rb
 - examples/group_dynamic_lookup.rb
 - examples/group_with_members.rb
@@ -92,11 +81,13 @@ files:
 - examples/percentage_of_actors_enabled_check.rb
 - examples/percentage_of_actors_group.rb
 - examples/percentage_of_time.rb
+- examples/strict.rb
 - flipper-cloud.gemspec
 - flipper.gemspec
 - lib/flipper.rb
 - lib/flipper/actor.rb
 - lib/flipper/adapter.rb
+- lib/flipper/adapter_builder.rb
 - lib/flipper/adapters/dual_write.rb
 - lib/flipper/adapters/failover.rb
 - lib/flipper/adapters/failsafe.rb
@@ -111,6 +102,7 @@ files:
 - lib/flipper/adapters/poll/poller.rb
 - lib/flipper/adapters/pstore.rb
 - lib/flipper/adapters/read_only.rb
+- lib/flipper/adapters/strict.rb
 - lib/flipper/adapters/sync.rb
 - lib/flipper/adapters/sync/feature_synchronizer.rb
 - lib/flipper/adapters/sync/interval_synchronizer.rb
@@ -118,10 +110,15 @@ files:
 - lib/flipper/cloud.rb
 - lib/flipper/cloud/configuration.rb
 - lib/flipper/cloud/dsl.rb
-- lib/flipper/cloud/instrumenter.rb
 - lib/flipper/cloud/message_verifier.rb
 - lib/flipper/cloud/middleware.rb
 - lib/flipper/cloud/routes.rb
+- lib/flipper/cloud/telemetry.rb
+- lib/flipper/cloud/telemetry/backoff_policy.rb
+- lib/flipper/cloud/telemetry/instrumenter.rb
+- lib/flipper/cloud/telemetry/metric.rb
+- lib/flipper/cloud/telemetry/metric_storage.rb
+- lib/flipper/cloud/telemetry/submitter.rb
 - lib/flipper/configuration.rb
 - lib/flipper/dsl.rb
 - lib/flipper/engine.rb
@@ -130,12 +127,35 @@ files:
 - lib/flipper/exporter.rb
 - lib/flipper/exporters/json/export.rb
 - lib/flipper/exporters/json/v1.rb
+- lib/flipper/expression.rb
+- lib/flipper/expression/builder.rb
+- lib/flipper/expression/constant.rb
+- lib/flipper/expressions/all.rb
+- lib/flipper/expressions/any.rb
+- lib/flipper/expressions/boolean.rb
+- lib/flipper/expressions/comparable.rb
+- lib/flipper/expressions/duration.rb
+- lib/flipper/expressions/equal.rb
+- lib/flipper/expressions/greater_than.rb
+- lib/flipper/expressions/greater_than_or_equal_to.rb
+- lib/flipper/expressions/less_than.rb
+- lib/flipper/expressions/less_than_or_equal_to.rb
+- lib/flipper/expressions/not_equal.rb
+- lib/flipper/expressions/now.rb
+- lib/flipper/expressions/number.rb
+- lib/flipper/expressions/percentage.rb
+- lib/flipper/expressions/percentage_of_actors.rb
+- lib/flipper/expressions/property.rb
+- lib/flipper/expressions/random.rb
+- lib/flipper/expressions/string.rb
+- lib/flipper/expressions/time.rb
 - lib/flipper/feature.rb
 - lib/flipper/feature_check_context.rb
 - lib/flipper/gate.rb
 - lib/flipper/gate_values.rb
 - lib/flipper/gates/actor.rb
 - lib/flipper/gates/boolean.rb
+- lib/flipper/gates/expression.rb
 - lib/flipper/gates/group.rb
 - lib/flipper/gates/percentage_of_actors.rb
 - lib/flipper/gates/percentage_of_time.rb
@@ -149,8 +169,11 @@ files:
 - lib/flipper/metadata.rb
 - lib/flipper/middleware/memoizer.rb
 - lib/flipper/middleware/setup_env.rb
+- lib/flipper/model/active_record.rb
 - lib/flipper/poller.rb
 - lib/flipper/registry.rb
+- lib/flipper/serializers/gzip.rb
+- lib/flipper/serializers/json.rb
 - lib/flipper/spec/shared_adapter_specs.rb
 - lib/flipper/test/shared_adapter_test.rb
 - lib/flipper/type.rb
@@ -165,6 +188,7 @@ files:
 - spec/fixtures/feature.json
 - spec/fixtures/flipper_pstore_1679087600.json
 - spec/flipper/actor_spec.rb
+- spec/flipper/adapter_builder_spec.rb
 - spec/flipper/adapter_spec.rb
 - spec/flipper/adapters/dual_write_spec.rb
 - spec/flipper/adapters/failover_spec.rb
@@ -176,6 +200,7 @@ files:
 - spec/flipper/adapters/operation_logger_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
+- spec/flipper/adapters/strict_spec.rb
 - spec/flipper/adapters/sync/feature_synchronizer_spec.rb
 - spec/flipper/adapters/sync/interval_synchronizer_spec.rb
 - spec/flipper/adapters/sync/synchronizer_spec.rb
@@ -184,6 +209,11 @@ files:
 - spec/flipper/cloud/dsl_spec.rb
 - spec/flipper/cloud/message_verifier_spec.rb
 - spec/flipper/cloud/middleware_spec.rb
+- spec/flipper/cloud/telemetry/backoff_policy_spec.rb
+- spec/flipper/cloud/telemetry/metric_spec.rb
+- spec/flipper/cloud/telemetry/metric_storage_spec.rb
+- spec/flipper/cloud/telemetry/submitter_spec.rb
+- spec/flipper/cloud/telemetry_spec.rb
 - spec/flipper/cloud_spec.rb
 - spec/flipper/configuration_spec.rb
 - spec/flipper/dsl_spec.rb
@@ -192,12 +222,33 @@ files:
 - spec/flipper/exporter_spec.rb
 - spec/flipper/exporters/json/export_spec.rb
 - spec/flipper/exporters/json/v1_spec.rb
+- spec/flipper/expression/builder_spec.rb
+- spec/flipper/expression_spec.rb
+- spec/flipper/expressions/all_spec.rb
+- spec/flipper/expressions/any_spec.rb
+- spec/flipper/expressions/boolean_spec.rb
+- spec/flipper/expressions/duration_spec.rb
+- spec/flipper/expressions/equal_spec.rb
+- spec/flipper/expressions/greater_than_or_equal_to_spec.rb
+- spec/flipper/expressions/greater_than_spec.rb
+- spec/flipper/expressions/less_than_or_equal_to_spec.rb
+- spec/flipper/expressions/less_than_spec.rb
+- spec/flipper/expressions/not_equal_spec.rb
+- spec/flipper/expressions/now_spec.rb
+- spec/flipper/expressions/number_spec.rb
+- spec/flipper/expressions/percentage_of_actors_spec.rb
+- spec/flipper/expressions/percentage_spec.rb
+- spec/flipper/expressions/property_spec.rb
+- spec/flipper/expressions/random_spec.rb
+- spec/flipper/expressions/string_spec.rb
+- spec/flipper/expressions/time_spec.rb
 - spec/flipper/feature_check_context_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
 - spec/flipper/gate_values_spec.rb
 - spec/flipper/gates/actor_spec.rb
 - spec/flipper/gates/boolean_spec.rb
+- spec/flipper/gates/expression_spec.rb
 - spec/flipper/gates/group_spec.rb
 - spec/flipper/gates/percentage_of_actors_spec.rb
 - spec/flipper/gates/percentage_of_time_spec.rb
@@ -208,8 +259,11 @@ files:
 - spec/flipper/instrumenters/noop_spec.rb
 - spec/flipper/middleware/memoizer_spec.rb
 - spec/flipper/middleware/setup_env_spec.rb
+- spec/flipper/model/active_record_spec.rb
 - spec/flipper/poller_spec.rb
 - spec/flipper/registry_spec.rb
+- spec/flipper/serializers/gzip_spec.rb
+- spec/flipper/serializers/json_spec.rb
 - spec/flipper/typecast_spec.rb
 - spec/flipper/types/actor_spec.rb
 - spec/flipper/types/boolean_spec.rb
@@ -220,8 +274,10 @@ files:
 - spec/flipper_integration_spec.rb
 - spec/flipper_spec.rb
 - spec/spec_helper.rb
+- spec/support/actor_names.yml
 - spec/support/climate_control.rb
 - spec/support/descriptions.yml
+- spec/support/fake_backoff_policy.rb
 - spec/support/fake_udp_socket.rb
 - spec/support/skippable.rb
 - spec/support/spec_helpers.rb
@@ -256,11 +312,12 @@ requirements: []
 rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
-summary: Feature flipper for ANYTHING
+summary: Beautiful, performant feature flags for Ruby.
 test_files:
 - spec/fixtures/feature.json
 - spec/fixtures/flipper_pstore_1679087600.json
 - spec/flipper/actor_spec.rb
+- spec/flipper/adapter_builder_spec.rb
 - spec/flipper/adapter_spec.rb
 - spec/flipper/adapters/dual_write_spec.rb
 - spec/flipper/adapters/failover_spec.rb
@@ -272,6 +329,7 @@ test_files:
 - spec/flipper/adapters/operation_logger_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
+- spec/flipper/adapters/strict_spec.rb
 - spec/flipper/adapters/sync/feature_synchronizer_spec.rb
 - spec/flipper/adapters/sync/interval_synchronizer_spec.rb
 - spec/flipper/adapters/sync/synchronizer_spec.rb
@@ -280,6 +338,11 @@ test_files:
 - spec/flipper/cloud/dsl_spec.rb
 - spec/flipper/cloud/message_verifier_spec.rb
 - spec/flipper/cloud/middleware_spec.rb
+- spec/flipper/cloud/telemetry/backoff_policy_spec.rb
+- spec/flipper/cloud/telemetry/metric_spec.rb
+- spec/flipper/cloud/telemetry/metric_storage_spec.rb
+- spec/flipper/cloud/telemetry/submitter_spec.rb
+- spec/flipper/cloud/telemetry_spec.rb
 - spec/flipper/cloud_spec.rb
 - spec/flipper/configuration_spec.rb
 - spec/flipper/dsl_spec.rb
@@ -288,12 +351,33 @@ test_files:
 - spec/flipper/exporter_spec.rb
 - spec/flipper/exporters/json/export_spec.rb
 - spec/flipper/exporters/json/v1_spec.rb
+- spec/flipper/expression/builder_spec.rb
+- spec/flipper/expression_spec.rb
+- spec/flipper/expressions/all_spec.rb
+- spec/flipper/expressions/any_spec.rb
+- spec/flipper/expressions/boolean_spec.rb
+- spec/flipper/expressions/duration_spec.rb
+- spec/flipper/expressions/equal_spec.rb
+- spec/flipper/expressions/greater_than_or_equal_to_spec.rb
+- spec/flipper/expressions/greater_than_spec.rb
+- spec/flipper/expressions/less_than_or_equal_to_spec.rb
+- spec/flipper/expressions/less_than_spec.rb
+- spec/flipper/expressions/not_equal_spec.rb
+- spec/flipper/expressions/now_spec.rb
+- spec/flipper/expressions/number_spec.rb
+- spec/flipper/expressions/percentage_of_actors_spec.rb
+- spec/flipper/expressions/percentage_spec.rb
+- spec/flipper/expressions/property_spec.rb
+- spec/flipper/expressions/random_spec.rb
+- spec/flipper/expressions/string_spec.rb
+- spec/flipper/expressions/time_spec.rb
 - spec/flipper/feature_check_context_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
 - spec/flipper/gate_values_spec.rb
 - spec/flipper/gates/actor_spec.rb
 - spec/flipper/gates/boolean_spec.rb
+- spec/flipper/gates/expression_spec.rb
 - spec/flipper/gates/group_spec.rb
 - spec/flipper/gates/percentage_of_actors_spec.rb
 - spec/flipper/gates/percentage_of_time_spec.rb
@@ -304,8 +388,11 @@ test_files:
 - spec/flipper/instrumenters/noop_spec.rb
 - spec/flipper/middleware/memoizer_spec.rb
 - spec/flipper/middleware/setup_env_spec.rb
+- spec/flipper/model/active_record_spec.rb
 - spec/flipper/poller_spec.rb
 - spec/flipper/registry_spec.rb
+- spec/flipper/serializers/gzip_spec.rb
+- spec/flipper/serializers/json_spec.rb
 - spec/flipper/typecast_spec.rb
 - spec/flipper/types/actor_spec.rb
 - spec/flipper/types/boolean_spec.rb
@@ -316,8 +403,10 @@ test_files:
 - spec/flipper_integration_spec.rb
 - spec/flipper_spec.rb
 - spec/spec_helper.rb
+- spec/support/actor_names.yml
 - spec/support/climate_control.rb
 - spec/support/descriptions.yml
+- spec/support/fake_backoff_policy.rb
 - spec/support/fake_udp_socket.rb
 - spec/support/skippable.rb
 - spec/support/spec_helpers.rb

data/lib/flipper/cloud/instrumenter.rb

@@ -1,48 +0,0 @@
-require "delegate"
-require "flipper/instrumenters/noop"
-
-module Flipper
-  module Cloud
-    class Instrumenter < SimpleDelegator
-      def initialize(options = {})
-        @brow = options.fetch(:brow)
-        @instrumenter = options.fetch(:instrumenter, Instrumenters::Noop)
-        super @instrumenter
-      end
-
-      def instrument(name, payload = {}, &block)
-        result = @instrumenter.instrument(name, payload, &block)
-        push name, payload
-        result
-      end
-
-      private
-
-      def push(name, payload)
-        return unless name == Flipper::Feature::InstrumentationName
-        return unless :enabled? == payload[:operation]
-
-        dimensions = {
-          "feature" => payload[:feature_name].to_s,
-          "result" => payload[:result].to_s,
-        }
-
-        if (thing = payload[:thing])
-          dimensions["flipper_id"] = thing.value.to_s
-        end
-
-        if (actors = payload[:actors])
-          dimensions["flipper_ids"] = actors.map { |actor| actor.value.to_s }
-        end
-
-        event = {
-          type: "enabled",
-          dimensions: dimensions,
-          measures: {},
-          ts: Time.now.utc,
-        }
-        @brow.push event
-      end
-    end
-  end
-end