flipper 0.9.2 → 0.10.0

data/spec/flipper/middleware/memoizer_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe Flipper::Middleware::Memoizer do
     flipper.adapter.memoize = nil
   end
 
-  shared_examples_for "flipper middleware" do
+  RSpec.shared_examples_for "flipper middleware" do
     it "delegates" do
       called = false
       app = lambda { |env|

data/spec/flipper/types/group_spec.rb

@@ -2,6 +2,8 @@ require 'helper'
 require 'flipper/types/group'
 
 RSpec.describe Flipper::Types::Group do
+  let(:fake_context) { double("FeatureCheckContext") }
+
   subject do
     Flipper.register(:admins) { |actor| actor.admin? }
   end
@@ -42,25 +44,48 @@ RSpec.describe Flipper::Types::Group do
     let(:non_admin_actor) { double('Actor', :admin? => false) }
 
     it "returns true if block matches" do
-      expect(subject.match?(admin_actor)).to eq(true)
+      expect(subject.match?(admin_actor, fake_context)).to eq(true)
     end
 
     it "returns false if block does not match" do
-      expect(subject.match?(non_admin_actor)).to eq(false)
+      expect(subject.match?(non_admin_actor, fake_context)).to eq(false)
     end
 
     it "returns true for truthy block results" do
       group = Flipper::Types::Group.new(:examples) do |actor|
         actor.email =~ /@example\.com/
       end
-      expect(group.match?(double('Actor', :email => "foo@example.com"))).to be_truthy
+      expect(group.match?(double('Actor', :email => "foo@example.com"), fake_context)).to be_truthy
     end
 
     it "returns false for falsey block results" do
       group = Flipper::Types::Group.new(:examples) do |actor|
         nil
       end
-      expect(group.match?(double('Actor'))).to be_falsey
+      expect(group.match?(double('Actor'), fake_context)).to be_falsey
+    end
+
+    it "can yield without context as block argument" do
+      context = Flipper::FeatureCheckContext.new(
+        feature_name: :my_feature,
+        values: Flipper::GateValues.new({}),
+        thing: Flipper::Types::Actor.new(Struct.new(:flipper_id).new(1)),
+      )
+      group = Flipper.register(:group_with_context) { |actor| actor }
+      yielded_actor = group.match?(admin_actor, context)
+      expect(yielded_actor).to be(admin_actor)
+    end
+
+    it "can yield with context as block argument" do
+      context = Flipper::FeatureCheckContext.new(
+        feature_name: :my_feature,
+        values: Flipper::GateValues.new({}),
+        thing: Flipper::Types::Actor.new(Struct.new(:flipper_id).new(1)),
+      )
+      group = Flipper.register(:group_with_context) { |actor, context| [actor, context] }
+      yielded_actor, yielded_context = group.match?(admin_actor, context)
+      expect(yielded_actor).to be(admin_actor)
+      expect(yielded_context).to be(context)
     end
   end
 end

data/spec/helper.rb

@@ -19,6 +19,8 @@ RSpec.configure do |config|
     Flipper.unregister_groups
   end
 
+  config.disable_monkey_patching!
+
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 end
@@ -52,7 +54,7 @@ RSpec.shared_examples_for 'a percentage' do
   end
 end
 
-shared_examples_for 'a DSL feature' do
+RSpec.shared_examples_for 'a DSL feature' do
   it "returns instance of feature" do
     expect(feature).to be_instance_of(Flipper::Feature)
   end
@@ -80,7 +82,7 @@ shared_examples_for 'a DSL feature' do
   end
 end
 
-shared_examples_for "a DSL boolean method" do
+RSpec.shared_examples_for "a DSL boolean method" do
   it "returns boolean with value set" do
     result = subject.send(method_name, true)
     expect(result).to be_instance_of(Flipper::Types::Boolean)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.10.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-22 00:00:00.000000000 Z
+date: 2016-11-17 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper is the act of enabling/disabling features in your application,
   ideally without re-deploying or changing anything in your code base. Flipper makes
@@ -29,11 +29,13 @@ files:
 - docs/Gates.md
 - docs/Instrumentation.md
 - docs/Optimization.md
+- docs/api/README.md
 - examples/basic.rb
 - examples/dsl.rb
 - examples/enabled_for_actor.rb
 - examples/example_setup.rb
 - examples/group.rb
+- examples/group_dynamic_lookup.rb
 - examples/group_with_members.rb
 - examples/individual_actor.rb
 - examples/instrumentation.rb
@@ -52,6 +54,7 @@ files:
 - lib/flipper/dsl.rb
 - lib/flipper/errors.rb
 - lib/flipper/feature.rb
+- lib/flipper/feature_check_context.rb
 - lib/flipper/gate.rb
 - lib/flipper/gate_values.rb
 - lib/flipper/gates/actor.rb
@@ -87,6 +90,7 @@ files:
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
 - spec/flipper/dsl_spec.rb
+- spec/flipper/feature_check_context_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
 - spec/flipper/gate_values_spec.rb
@@ -150,6 +154,7 @@ test_files:
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
 - spec/flipper/dsl_spec.rb
+- spec/flipper/feature_check_context_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
 - spec/flipper/gate_values_spec.rb