flipper 0.8.0 → 0.9.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: afbd6c749fed154fc4f131d9a100b6f475d5963c
-  data.tar.gz: 28a2fb5f3bf64365f003399cc6287e823da4ae23
+  metadata.gz: 61e55bc67bc9d28868981582af136a9d57546713
+  data.tar.gz: d8d9cd17434a08805be919c60d4072eeceb31342
 SHA512:
-  metadata.gz: 9edcf82bb9e5e600ff797c726aef6bb59c96f9ce86a5ccdc085048553c7d7112b45eb8cdf37782660f0b7d793a2f1abe4a2886d186aac06b721e80ef917bbc18
-  data.tar.gz: c0f9f0df3475ba5adee9467512fce9580d32b9398497389173cc9fb12ed5d853d9e26c6e8e4d1c98f8cfd5a4dcc3d61014bd5f366f4af0f2fd1466b432eb5852
+  metadata.gz: ce7c808ec096c1b1af7336a81b390f465b02d8b06c2eca86295b275ca0fa04d32ee6058f9dfc5a2c17150bad0a1c010522d70c97104480f51d7514086990cf16
+  data.tar.gz: 92ffbd0d092b4d4661dbe139fcfb969c878db4674aa791a4b5e7311cfe7cd724d2c1eba1199b3dd7a9dd65b75912b0fbf39009340951c5a4f05303e9e573be15

data/Changelog.md

@@ -1,3 +1,9 @@
+## master
+
+* Moves SharedAdapterTests module to Flipper::Test::SharedAdapterTests to avoid clobbering anything top level in apps that use Flipper
+* Memoizable, Instrumented and OperationLogger now delegate any missing methods to the original adapter. This was lost with the removal of the official decorator in 0.8, but is actually useful functionality for these "wrapping" adapters.
+* Instrumenting adapters is now off by default. Use Flipper::Adapters::Instrumented.new(adapter) to instrument adapters and maintain the old functionality.
+
 ## 0.8
 
 * removed Flipper::Decorator and Flipper::Adapters::Decorator in favor of just calling methods on wrapped adapter

data/docs/Adapters.md

@@ -29,10 +29,13 @@ The basic API for an adapter is this:
 * `enable(feature, gate, thing)` - Enable a gate for a thing.
 * `disable(feature, gate, thing)` - Disable a gate for a thing.
 
-If you would like to make your own adapter, there are shared adapter specs that you can use to verify that you have everything working correctly.
+If you would like to make your own adapter, there are shared adapter specs (RSpec) and tests (MiniTest) that you can use to verify that you have everything working correctly.
 
+### RSpec
 For example, here is what the in-memory adapter spec looks like:
 
+`spec/flipper/adapters/memory_spec.rb`
+
 ```ruby
 require 'helper'
 require 'flipper/adapters/memory'
@@ -51,6 +54,37 @@ describe Flipper::Adapters::Memory do
 end
 ```
 
+### MiniTest
+
+Here is what an in-memory adapter MiniTest looks like:
+
+`test/adapters/memory_test.rb`
+
+```ruby
+require 'test_helper'
+require 'flipper/adapters/memory'
+
+class MemoryTest < MiniTest::Test
+  prepend SharedAdapterTests
+
+  def setup
+    # Any code here will run before each test
+    @adapter = Flipper::Adapters::Memory.new
+  end
+
+  def teardown
+    # Any code here will run after each test
+  end
+end
+```
+1. Create a file under `test/adapters` that inherits from MiniTest::Test.
+
+2. `prepend SharedAdapterTests`.
+
+3. Initialize an instance variable `@adapter` referencing an instance of the adapter.
+
+4. Add any code to run before each test in a `setup` method and any code to run after each test in a `teardown` method.
+
 A good place to start when creating your own adapter is to copy one of the adapters mentioned above and replace the client specific code with whatever client you are attempting to adapt.
 
 I would also recommend setting `fail_fast = true` in your RSpec configuration as that will just give you one failure at a time to work through. It is also handy to have the shared adapter spec file open.

data/lib/flipper/adapters/instrumented.rb

@@ -1,10 +1,11 @@
+require 'delegate'
 require 'flipper/instrumenters/noop'
 
 module Flipper
   module Adapters
     # Internal: Adapter that wraps another adapter and instruments all adapter
     # operations. Used by flipper dsl to provide instrumentatin for flipper.
-    class Instrumented
+    class Instrumented < SimpleDelegator
       include ::Flipper::Adapter
 
       # Private: The name of instrumentation events.
@@ -24,6 +25,7 @@ module Flipper
       #           :instrumenter - What to use to instrument all the things.
       #
       def initialize(adapter, options = {})
+        super(adapter)
         @adapter = adapter
         @name = :instrumented
         @instrumenter = options.fetch(:instrumenter, Instrumenters::Noop)

data/lib/flipper/adapters/memoizable.rb

@@ -1,9 +1,11 @@
+require 'delegate'
+
 module Flipper
   module Adapters
     # Internal: Adapter that wraps another adapter with the ability to memoize
     # adapter calls in memory. Used by flipper dsl and the memoizer middleware
     # to make it possible to memoize adapter calls for the duration of a request.
-    class Memoizable
+    class Memoizable < SimpleDelegator
       include ::Flipper::Adapter
 
       FeaturesKey = :flipper_features
@@ -19,6 +21,7 @@ module Flipper
 
       # Public
       def initialize(adapter, cache = nil)
+        super(adapter)
         @adapter = adapter
         @name = :memoizable
         @cache = cache || {}

data/lib/flipper/adapters/operation_logger.rb

@@ -1,9 +1,11 @@
+require 'delegate'
+
 module Flipper
   module Adapters
     # Public: Adapter that wraps another adapter and stores the operations.
     #
     # Useful in tests to verify calls and such. Never use outside of testing.
-    class OperationLogger
+    class OperationLogger < SimpleDelegator
       include ::Flipper::Adapter
 
       Operation = Struct.new(:type, :args)
@@ -26,6 +28,7 @@ module Flipper
 
       # Public
       def initialize(adapter, operations = nil)
+        super(adapter)
         @adapter = adapter
         @name = :operation_logger
         @operations = operations || []

data/lib/flipper/dsl.rb

@@ -1,4 +1,3 @@
-require 'flipper/adapters/instrumented'
 require 'flipper/adapters/memoizable'
 require 'flipper/instrumenters/noop'
 
@@ -17,13 +16,8 @@ module Flipper
     #           :instrumenter - What should be used to instrument all the things.
     def initialize(adapter, options = {})
       @instrumenter = options.fetch(:instrumenter, Instrumenters::Noop)
-
-      instrumented = Adapters::Instrumented.new(adapter, {
-        :instrumenter => @instrumenter,
-      })
-      memoized = Adapters::Memoizable.new(instrumented)
+      memoized = Adapters::Memoizable.new(adapter)
       @adapter = memoized
-
       @memoized_features = {}
     end
 

data/lib/flipper/feature.rb

@@ -7,7 +7,7 @@ require 'flipper/instrumenters/noop'
 module Flipper
   class Feature
     # Private: The name of feature instrumentation events.
-    InstrumentationName = "feature_operation.#{InstrumentationNamespace}"
+    InstrumentationName = "feature_operation.#{InstrumentationNamespace}".freeze
 
     # Public: The name of the feature.
     attr_reader :name

data/lib/flipper/gate_values.rb

@@ -4,13 +4,13 @@ module Flipper
   class GateValues
     # Private: Array of instance variables that are readable through the []
     # instance method.
-    LegitIvars = Set.new([
-      "boolean",
-      "actors",
-      "groups",
-      "percentage_of_time",
-      "percentage_of_actors",
-    ]).freeze
+    LegitIvars = {
+      "boolean" => "@boolean",
+      "actors" => "@actors",
+      "groups" => "@groups",
+      "percentage_of_time" => "@percentage_of_time",
+      "percentage_of_actors" => "@percentage_of_actors",
+    }.freeze
 
     attr_reader :boolean
     attr_reader :actors
@@ -27,8 +27,9 @@ module Flipper
     end
 
     def [](key)
-      return nil unless LegitIvars.include?(key.to_s)
-      instance_variable_get("@#{key}")
+      if ivar = LegitIvars[key.to_s]
+        instance_variable_get(ivar)
+      end
     end
 
     def eql?(other)

data/lib/flipper/instrumentation/subscriber.rb

@@ -71,9 +71,11 @@ module Flipper
         update_timer "flipper.adapter.#{adapter_name}.#{operation}"
       end
 
+      QUESTION_MARK = "?".freeze
+
       # Private
       def strip_trailing_question_mark(operation)
-        operation.to_s.chomp('?')
+        operation.to_s.chomp(QUESTION_MARK)
       end
     end
   end

data/lib/flipper/test/shared_adapter_test.rb

@@ -1,249 +1,253 @@
-module SharedAdapterTests
-  def setup
-    super
-    @flipper = Flipper.new(@adapter)
-    @actor_class = Struct.new(:flipper_id)
-    @feature = @flipper[:stats]
-    @boolean_gate = @feature.gate(:boolean)
-    @group_gate = @feature.gate(:group)
-    @actor_gate = @feature.gate(:actor)
-    @actors_gate =  @feature.gate(:percentage_of_actors)
-    @time_gate =  @feature.gate(:percentage_of_time)
-
-    Flipper.register(:admins) do |actor|
-      actor.respond_to?(:admin?) && actor.admin?
+module Flipper
+  module Test
+    module SharedAdapterTests
+      def setup
+        super
+        @flipper = Flipper.new(@adapter)
+        @actor_class = Struct.new(:flipper_id)
+        @feature = @flipper[:stats]
+        @boolean_gate = @feature.gate(:boolean)
+        @group_gate = @feature.gate(:group)
+        @actor_gate = @feature.gate(:actor)
+        @actors_gate =  @feature.gate(:percentage_of_actors)
+        @time_gate =  @feature.gate(:percentage_of_time)
+
+        Flipper.register(:admins) do |actor|
+          actor.respond_to?(:admin?) && actor.admin?
+        end
+
+        Flipper.register(:early_access) { |actor|
+          actor.respond_to?(:early_access?) && actor.early_access?
+        }
+      end
+
+      def teardown
+        super
+        Flipper.unregister_groups
+      end
+
+      def test_has_name_that_is_a_symbol
+        refute_empty  @adapter.name
+        assert_kind_of Symbol, @adapter.name
+      end
+
+      def test_has_included_the_flipper_adapter_module
+        assert_includes  @adapter.class.ancestors, Flipper::Adapter
+      end
+
+      def test_returns_correct_default_values_for_gates_if_none_are_enabled
+        expected = {
+          :boolean => nil,
+          :groups => Set.new,
+          :actors => Set.new,
+          :percentage_of_actors => nil,
+          :percentage_of_time => nil,
+        }
+        assert_equal expected, @adapter.get(@feature)
+      end
+
+      def test_can_enable_disable_and_get_value_for_boolean_gate
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+        assert_equal 'true', @adapter.get(@feature)[:boolean]
+        assert_equal true, @adapter.disable(@feature, @boolean_gate, @flipper.boolean(false))
+        assert_equal nil, @adapter.get(@feature)[:boolean]
+      end
+
+      def test_fully_disables_all_enabled_things_when_boolean_gate_disabled
+        actor_22 = @actor_class.new('22')
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+        assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_22))
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
+        assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(45))
+        assert_equal true, @adapter.disable(@feature, @boolean_gate, @flipper.boolean(false))
+        expected = {
+          :boolean => nil,
+          :groups => Set.new,
+          :actors => Set.new,
+          :percentage_of_actors => nil,
+          :percentage_of_time => nil,
+        }
+        assert_equal expected, @adapter.get(@feature)
+      end
+
+      def test_can_enable_disable_get_value_for_group_gate
+        assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
+        assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:early_access))
+
+        result = @adapter.get(@feature)
+        assert_equal Set['admins', 'early_access'], result[:groups]
+
+        assert_equal true, @adapter.disable(@feature, @group_gate, @flipper.group(:early_access))
+        result = @adapter.get(@feature)
+        assert_equal Set['admins'], result[:groups]
+
+        assert_equal true, @adapter.disable(@feature, @group_gate, @flipper.group(:admins))
+        result = @adapter.get(@feature)
+        assert_equal Set.new, result[:groups]
+      end
+
+      def test_can_enable_disable_and_get_value_for_an_actor_gate
+        actor_22 = @actor_class.new('22')
+        actor_asdf = @actor_class.new('asdf')
+
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_22))
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_asdf))
+
+        result = @adapter.get(@feature)
+        assert_equal Set['22', 'asdf'], result[:actors]
+
+        assert true, @adapter.disable(@feature, @actor_gate, @flipper.actor(actor_22))
+        result = @adapter.get(@feature)
+        assert_equal Set['asdf'], result[:actors]
+
+        assert_equal true, @adapter.disable(@feature, @actor_gate, @flipper.actor(actor_asdf))
+        result = @adapter.get(@feature)
+        assert_equal Set.new, result[:actors]
+      end
+
+      def test_can_enable_disable_get_value_for_percentage_of_actors_gate
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(15))
+        result = @adapter.get(@feature)
+        assert_equal '15', result[:percentage_of_actors]
+
+        assert_equal true, @adapter.disable(@feature, @actors_gate, @flipper.actors(0))
+        result = @adapter.get(@feature)
+        assert_equal '0', result[:percentage_of_actors]
+      end
+
+      def test_can_enable_percentage_of_actors_gate_many_times_and_consistently_return_values
+        (1..100).each do |percentage|
+          assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(percentage))
+          result = @adapter.get(@feature)
+          assert_equal percentage.to_s, result[:percentage_of_actors]
+        end
+      end
+
+      def test_can_disable_percentage_of_actors_gate_many_times_and_consistently_return_values
+        (1..100).each do |percentage|
+          assert_equal true, @adapter.disable(@feature, @actors_gate, @flipper.actors(percentage))
+          result = @adapter.get(@feature)
+          assert_equal percentage.to_s, result[:percentage_of_actors]
+        end
+      end
+
+      def test_can_enable_disable_and_get_value_for_percentage_of_time_gate
+        assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(10))
+        result = @adapter.get(@feature)
+        assert_equal '10', result[:percentage_of_time]
+
+        assert_equal true, @adapter.disable(@feature, @time_gate, @flipper.time(0))
+        result = @adapter.get(@feature)
+        assert_equal '0', result[:percentage_of_time]
+      end
+
+      def test_can_enable_percentage_of_time_gate_many_times_and_consistently_return_values
+        (1..100).each do |percentage|
+          assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(percentage))
+          result = @adapter.get(@feature)
+          assert_equal percentage.to_s, result[:percentage_of_time]
+        end
+      end
+
+      def test_can_disable_percentage_of_time_gate_many_times_and_consistently_return_values
+        (1..100).each do |percentage|
+          assert_equal true, @adapter.disable(@feature, @time_gate, @flipper.time(percentage))
+          result = @adapter.get(@feature)
+          assert_equal percentage.to_s, result[:percentage_of_time]
+        end
+      end
+
+      def test_converts_boolean_value_to_a_string
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+        result = @adapter.get(@feature)
+        assert_equal 'true', result[:boolean]
+      end
+
+      def test_converts_the_actor_value_to_a_string
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(@actor_class.new(22)))
+        result = @adapter.get(@feature)
+        assert_equal Set['22'], result[:actors]
+      end
+
+      def test_converts_group_value_to_a_string
+        assert_equal  true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
+        result = @adapter.get(@feature)
+        assert_equal Set['admins'], result[:groups]
+      end
+
+      def test_converts_percentage_of_time_integer_value_to_a_string
+        assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(10))
+        result = @adapter.get(@feature)
+        assert_equal '10', result[:percentage_of_time]
+      end
+
+      def test_converts_percentage_of_actors_integer_value_to_a_string
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(10))
+        result = @adapter.get(@feature)
+        assert_equal '10', result[:percentage_of_actors]
+      end
+
+      def test_can_add_remove_and_list_known_features
+        assert_equal Set.new, @adapter.features
+
+        assert_equal true, @adapter.add(@flipper[:stats])
+        assert_equal Set['stats'], @adapter.features
+
+        assert_equal true, @adapter.add(@flipper[:search])
+        assert_equal Set['stats', 'search'], @adapter.features
+
+        assert_equal true, @adapter.remove(@flipper[:stats])
+        assert_equal Set['search'], @adapter.features
+
+        assert_equal true, @adapter.remove(@flipper[:search])
+        assert_equal Set.new, @adapter.features
+      end
+
+      def test_clears_all_the_gate_values_for_the_feature_on_remove
+        actor_22 = @actor_class.new('22')
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+        assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_22))
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
+        assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(45))
+
+        assert_equal true, @adapter.remove(@feature)
+
+        assert_equal @adapter.get(@feature), {
+          :boolean => nil,
+          :groups => Set.new,
+          :actors => Set.new,
+          :percentage_of_actors => nil,
+          :percentage_of_time => nil,
+        }
+      end
+
+      def test_can_clear_all_the_gate_values_for_a_feature
+        actor_22 = @actor_class.new('22')
+        @adapter.add(@feature)
+        assert_includes @adapter.features, @feature.key
+
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+        assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_22))
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
+        assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(45))
+
+        assert_equal true, @adapter.clear(@feature)
+        assert_includes @adapter.features, @feature.key
+        assert_equal @adapter.get(@feature), {
+          :boolean => nil,
+          :groups => Set.new,
+          :actors => Set.new,
+          :percentage_of_actors => nil,
+          :percentage_of_time => nil,
+        }
+      end
+
+      def test_does_not_complain_clearing_a_feature_that_does_not_exist_in_adapter
+        assert_equal true, @adapter.clear(@flipper[:stats])
+      end
     end
-
-    Flipper.register(:early_access) { |actor|
-      actor.respond_to?(:early_access?) && actor.early_access?
-    }
-  end
-
-  def teardown
-    super
-    Flipper.unregister_groups
-  end
-
-  def test_has_name_that_is_a_symbol
-    refute_empty  @adapter.name
-    assert_kind_of Symbol, @adapter.name
-  end
-
-  def test_has_included_the_flipper_adapter_module
-    assert_includes  @adapter.class.ancestors, Flipper::Adapter
-  end
-
-  def test_returns_correct_default_values_for_gates_if_none_are_enabled
-    expected = {
-      :boolean => nil,
-      :groups => Set.new,
-      :actors => Set.new,
-      :percentage_of_actors => nil,
-      :percentage_of_time => nil,
-    }
-    assert_equal expected, @adapter.get(@feature)
-  end
-
-  def test_can_enable_disable_and_get_value_for_boolean_gate
-    assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
-    assert_equal 'true', @adapter.get(@feature)[:boolean]
-    assert_equal true, @adapter.disable(@feature, @boolean_gate, @flipper.boolean(false))
-    assert_equal nil, @adapter.get(@feature)[:boolean]
-  end
-
-  def test_fully_disables_all_enabled_things_when_boolean_gate_disabled
-    actor_22 = @actor_class.new('22')
-    assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
-    assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
-    assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_22))
-    assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
-    assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(45))
-    assert_equal true, @adapter.disable(@feature, @boolean_gate, @flipper.boolean(false))
-    expected = {
-      :boolean => nil,
-      :groups => Set.new,
-      :actors => Set.new,
-      :percentage_of_actors => nil,
-      :percentage_of_time => nil,
-    }
-    assert_equal expected, @adapter.get(@feature)
-  end
-
-  def test_can_enable_disable_get_value_for_group_gate
-    assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
-    assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:early_access))
-
-    result = @adapter.get(@feature)
-    assert_equal Set['admins', 'early_access'], result[:groups]
-
-    assert_equal true, @adapter.disable(@feature, @group_gate, @flipper.group(:early_access))
-    result = @adapter.get(@feature)
-    assert_equal Set['admins'], result[:groups]
-
-    assert_equal true, @adapter.disable(@feature, @group_gate, @flipper.group(:admins))
-    result = @adapter.get(@feature)
-    assert_equal Set.new, result[:groups]
-  end
-
-  def test_can_enable_disable_and_get_value_for_an_actor_gate
-    actor_22 = @actor_class.new('22')
-    actor_asdf = @actor_class.new('asdf')
-
-    assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_22))
-    assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_asdf))
-
-    result = @adapter.get(@feature)
-    assert_equal Set['22', 'asdf'], result[:actors]
-
-    assert true, @adapter.disable(@feature, @actor_gate, @flipper.actor(actor_22))
-    result = @adapter.get(@feature)
-    assert_equal Set['asdf'], result[:actors]
-
-    assert_equal true, @adapter.disable(@feature, @actor_gate, @flipper.actor(actor_asdf))
-    result = @adapter.get(@feature)
-    assert_equal Set.new, result[:actors]
-  end
-
-  def test_can_enable_disable_get_value_for_percentage_of_actors_gate
-    assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(15))
-    result = @adapter.get(@feature)
-    assert_equal '15', result[:percentage_of_actors]
-
-    assert_equal true, @adapter.disable(@feature, @actors_gate, @flipper.actors(0))
-    result = @adapter.get(@feature)
-    assert_equal '0', result[:percentage_of_actors]
-  end
-
-  def test_can_enable_percentage_of_actors_gate_many_times_and_consistently_return_values
-    (1..100).each do |percentage|
-      assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(percentage))
-      result = @adapter.get(@feature)
-      assert_equal percentage.to_s, result[:percentage_of_actors]
-    end
-  end
-
-  def test_can_disable_percentage_of_actors_gate_many_times_and_consistently_return_values
-    (1..100).each do |percentage|
-      assert_equal true, @adapter.disable(@feature, @actors_gate, @flipper.actors(percentage))
-      result = @adapter.get(@feature)
-      assert_equal percentage.to_s, result[:percentage_of_actors]
-    end
-  end
-
-  def test_can_enable_disable_and_get_value_for_percentage_of_time_gate
-    assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(10))
-    result = @adapter.get(@feature)
-    assert_equal '10', result[:percentage_of_time]
-
-    assert_equal true, @adapter.disable(@feature, @time_gate, @flipper.time(0))
-    result = @adapter.get(@feature)
-    assert_equal '0', result[:percentage_of_time]
-  end
-
-  def test_can_enable_percentage_of_time_gate_many_times_and_consistently_return_values
-    (1..100).each do |percentage|
-      assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(percentage))
-      result = @adapter.get(@feature)
-      assert_equal percentage.to_s, result[:percentage_of_time]
-    end
-  end
-
-  def test_can_disable_percentage_of_time_gate_many_times_and_consistently_return_values
-    (1..100).each do |percentage|
-      assert_equal true, @adapter.disable(@feature, @time_gate, @flipper.time(percentage))
-      result = @adapter.get(@feature)
-      assert_equal percentage.to_s, result[:percentage_of_time]
-    end
-  end
-
-  def test_converts_boolean_value_to_a_string
-    assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
-    result = @adapter.get(@feature)
-    assert_equal 'true', result[:boolean]
-  end
-
-  def test_converts_the_actor_value_to_a_string
-    assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(@actor_class.new(22)))
-    result = @adapter.get(@feature)
-    assert_equal Set['22'], result[:actors]
-  end
-
-  def test_converts_group_value_to_a_string
-    assert_equal  true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
-    result = @adapter.get(@feature)
-    assert_equal Set['admins'], result[:groups]
-  end
-
-  def test_converts_percentage_of_time_integer_value_to_a_string
-    assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(10))
-    result = @adapter.get(@feature)
-    assert_equal '10', result[:percentage_of_time]
-  end
-
-  def test_converts_percentage_of_actors_integer_value_to_a_string
-    assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(10))
-    result = @adapter.get(@feature)
-    assert_equal '10', result[:percentage_of_actors]
-  end
-
-  def test_can_add_remove_and_list_known_features
-    assert_equal Set.new, @adapter.features
-
-    assert_equal true, @adapter.add(@flipper[:stats])
-    assert_equal Set['stats'], @adapter.features
-
-    assert_equal true, @adapter.add(@flipper[:search])
-    assert_equal Set['stats', 'search'], @adapter.features
-
-    assert_equal true, @adapter.remove(@flipper[:stats])
-    assert_equal Set['search'], @adapter.features
-
-    assert_equal true, @adapter.remove(@flipper[:search])
-    assert_equal Set.new, @adapter.features
-  end
-
-  def test_clears_all_the_gate_values_for_the_feature_on_remove
-    actor_22 = @actor_class.new('22')
-    assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
-    assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
-    assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_22))
-    assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
-    assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(45))
-
-    assert_equal true, @adapter.remove(@feature)
-
-    assert_equal @adapter.get(@feature), {
-      :boolean => nil,
-      :groups => Set.new,
-      :actors => Set.new,
-      :percentage_of_actors => nil,
-      :percentage_of_time => nil,
-    }
-  end
-
-  def test_can_clear_all_the_gate_values_for_a_feature
-    actor_22 = @actor_class.new('22')
-    @adapter.add(@feature)
-    assert_includes @adapter.features, @feature.key
-
-    assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
-    assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
-    assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor_22))
-    assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
-    assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(45))
-
-    assert_equal true, @adapter.clear(@feature)
-    assert_includes @adapter.features, @feature.key
-    assert_equal @adapter.get(@feature), {
-      :boolean => nil,
-      :groups => Set.new,
-      :actors => Set.new,
-      :percentage_of_actors => nil,
-      :percentage_of_time => nil,
-    }
-  end
-
-  def test_does_not_complain_clearing_a_feature_that_does_not_exist_in_adapter
-    assert_equal true, @adapter.clear(@flipper[:stats])
   end
 end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.8.0"
+  VERSION = "0.9.0.beta1".freeze
 end

data/spec/flipper/adapters/instrumented_spec.rb

@@ -19,6 +19,16 @@ RSpec.describe Flipper::Adapters::Instrumented do
 
   it_should_behave_like 'a flipper adapter'
 
+  it "forwards missing methods to underlying adapter" do
+    adapter = Class.new do
+      def foo
+        :foo
+      end
+    end.new
+    instrumented = described_class.new(adapter)
+    expect(instrumented.foo).to eq(:foo)
+  end
+
   describe "#name" do
     it "is instrumented" do
       expect(subject.name).to be(:instrumented)

data/spec/flipper/adapters/memoizable_spec.rb

@@ -13,6 +13,16 @@ RSpec.describe Flipper::Adapters::Memoizable do
 
   it_should_behave_like 'a flipper adapter'
 
+  it "forwards missing methods to underlying adapter" do
+    adapter = Class.new do
+      def foo
+        :foo
+      end
+    end.new
+    memoizable = described_class.new(adapter)
+    expect(memoizable.foo).to eq(:foo)
+  end
+
   describe "#name" do
     it "is instrumented" do
       expect(subject.name).to be(:memoizable)

data/spec/flipper/adapters/operation_logger_spec.rb

@@ -12,6 +12,16 @@ RSpec.describe Flipper::Adapters::OperationLogger do
 
   it_should_behave_like 'a flipper adapter'
 
+  it "forwards missing methods to underlying adapter" do
+    adapter = Class.new do
+      def foo
+        :foo
+      end
+    end.new
+    operation_logger = described_class.new(adapter)
+    expect(operation_logger.foo).to eq(:foo)
+  end
+
   describe "#get" do
     before do
       @feature = flipper[:stats]

data/spec/flipper/dsl_spec.rb

@@ -25,13 +25,6 @@ RSpec.describe Flipper::DSL do
         dsl = described_class.new(adapter, :instrumenter => instrumenter)
         expect(dsl.instrumenter).to be(instrumenter)
       end
-
-      it "passes overridden instrumenter to instrumented adapter" do
-        dsl = described_class.new(adapter, :instrumenter => instrumenter)
-        memoized = dsl.adapter
-        instrumented = memoized.adapter
-        expect(instrumented.instrumenter).to be(instrumenter)
-      end
     end
   end
 

data/spec/flipper/instrumentation/log_subscriber_spec.rb

@@ -1,10 +1,14 @@
 require 'logger'
 require 'helper'
+require 'flipper/adapters/instrumented'
 require 'flipper/adapters/memory'
 require 'flipper/instrumentation/log_subscriber'
 
 RSpec.describe Flipper::Instrumentation::LogSubscriber do
-  let(:adapter) { Flipper::Adapters::Memory.new }
+  let(:adapter) {
+    memory = Flipper::Adapters::Memory.new
+    Flipper::Adapters::Instrumented.new(memory, :instrumenter => ActiveSupport::Notifications)
+  }
   let(:flipper) {
     Flipper.new(adapter, :instrumenter => ActiveSupport::Notifications)
   }

data/spec/flipper/instrumentation/metriks_subscriber_spec.rb

@@ -3,7 +3,10 @@ require 'flipper/adapters/memory'
 require 'flipper/instrumentation/metriks'
 
 RSpec.describe Flipper::Instrumentation::MetriksSubscriber do
-  let(:adapter) { Flipper::Adapters::Memory.new }
+  let(:adapter) {
+    memory = Flipper::Adapters::Memory.new
+    Flipper::Adapters::Instrumented.new(memory, :instrumenter => ActiveSupport::Notifications)
+  }
   let(:flipper) {
     Flipper.new(adapter, :instrumenter => ActiveSupport::Notifications)
   }

data/spec/flipper/instrumentation/statsd_subscriber_spec.rb

@@ -5,7 +5,10 @@ require 'flipper/instrumentation/statsd'
 RSpec.describe Flipper::Instrumentation::StatsdSubscriber do
   let(:statsd_client) { Statsd.new }
   let(:socket) { FakeUDPSocket.new }
-  let(:adapter) { Flipper::Adapters::Memory.new }
+  let(:adapter) {
+    memory = Flipper::Adapters::Memory.new
+    Flipper::Adapters::Instrumented.new(memory, :instrumenter => ActiveSupport::Notifications)
+  }
   let(:flipper) {
     Flipper.new(adapter, :instrumenter => ActiveSupport::Notifications)
   }

data/test/adapters/memory_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 require 'flipper/adapters/memory'
 
 class MemoryTest < MiniTest::Test
-  prepend SharedAdapterTests
+  prepend Flipper::Test::SharedAdapterTests
 
   def setup
     @adapter = Flipper::Adapters::Memory.new

data/test/adapters/pstore_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 require 'flipper/adapters/pstore'
 
 class PstoreTest < MiniTest::Test
-  prepend SharedAdapterTests
+  prepend Flipper::Test::SharedAdapterTests
 
   def setup
     dir = FlipperRoot.join("tmp").tap { |d| d.mkpath }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0.beta1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-21 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper is the act of enabling/disabling features in your application,
   ideally without re-deploying or changing anything in your code base. Flipper makes
@@ -133,9 +133,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5.1