flipper 0.7.5 → 0.8.0

data/lib/flipper/typecast.rb

@@ -5,7 +5,7 @@ module Flipper
       1       => true,
       "true"  => true,
       "1"     => true,
-    }
+    }.freeze
 
     # Internal: Convert value to a boolean.
     #

data/lib/flipper/types/group.rb

@@ -15,7 +15,7 @@ module Flipper
       end
 
       def match?(*args)
-        @block.call(*args) == true
+        @block.call(*args)
       end
     end
   end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.7.5"
+  VERSION = "0.8.0"
 end

data/spec/flipper/adapters/instrumented_spec.rb

@@ -19,6 +19,12 @@ RSpec.describe Flipper::Adapters::Instrumented do
 
   it_should_behave_like 'a flipper adapter'
 
+  describe "#name" do
+    it "is instrumented" do
+      expect(subject.name).to be(:instrumented)
+    end
+  end
+
   describe "#get" do
     it "records instrumentation" do
       result = subject.get(feature)

data/spec/flipper/adapters/memoizable_spec.rb

@@ -13,6 +13,12 @@ RSpec.describe Flipper::Adapters::Memoizable do
 
   it_should_behave_like 'a flipper adapter'
 
+  describe "#name" do
+    it "is instrumented" do
+      expect(subject.name).to be(:memoizable)
+    end
+  end
+
   describe "#memoize=" do
     it "sets value" do
       subject.memoize = true

data/spec/flipper/adapters/read_only_spec.rb

@@ -0,0 +1,94 @@
+require 'helper'
+require 'flipper/adapters/read_only'
+
+RSpec.describe Flipper::Adapters::ReadOnly do
+  let(:actor_class) { Struct.new(:flipper_id) }
+
+  let(:adapter) { Flipper::Adapters::Memory.new }
+  let(:flipper) { Flipper.new(subject) }
+  let(:feature) { flipper[:stats] }
+
+  let(:boolean_gate) { feature.gate(:boolean) }
+  let(:group_gate)   { feature.gate(:group) }
+  let(:actor_gate)   { feature.gate(:actor) }
+  let(:actors_gate)  { feature.gate(:percentage_of_actors) }
+  let(:time_gate)    { feature.gate(:percentage_of_time) }
+
+  subject { described_class.new(adapter) }
+
+  before do
+    Flipper.register(:admins) { |actor|
+      actor.respond_to?(:admin?) && actor.admin?
+    }
+
+    Flipper.register(:early_access) { |actor|
+      actor.respond_to?(:early_access?) && actor.early_access?
+    }
+  end
+
+  after do
+    Flipper.unregister_groups
+  end
+
+  it "has name that is a symbol" do
+    expect(subject.name).to_not be_nil
+    expect(subject.name).to be_instance_of(Symbol)
+  end
+
+  it "has included the flipper adapter module" do
+    expect(subject.class.ancestors).to include(Flipper::Adapter)
+  end
+
+  it "returns correct default values for the gates if none are enabled" do
+    expect(subject.get(feature)).to eq({
+      :boolean => nil,
+      :groups => Set.new,
+      :actors => Set.new,
+      :percentage_of_actors => nil,
+      :percentage_of_time => nil,
+    })
+  end
+
+  it "can get feature" do
+    actor_22 = actor_class.new('22')
+    adapter.enable(feature, boolean_gate, flipper.boolean)
+    adapter.enable(feature, group_gate, flipper.group(:admins))
+    adapter.enable(feature, actor_gate, flipper.actor(actor_22))
+    adapter.enable(feature, actors_gate, flipper.actors(25))
+    adapter.enable(feature, time_gate, flipper.time(45))
+
+    expect(subject.get(feature)).to eq({
+      :boolean => "true",
+      :groups => Set["admins"],
+      :actors => Set["22"],
+      :percentage_of_actors => "25",
+      :percentage_of_time => "45",
+    })
+  end
+
+  it "can get features" do
+    expect(subject.features).to eq(Set.new)
+    adapter.add(feature)
+    expect(subject.features).to eq(Set["stats"])
+  end
+
+  it "raises error on add" do
+    expect { subject.add(feature) }.to raise_error(Flipper::Adapters::ReadOnly::WriteAttempted)
+  end
+
+  it "raises error on remove" do
+    expect { subject.remove(feature) }.to raise_error(Flipper::Adapters::ReadOnly::WriteAttempted)
+  end
+
+  it "raises on clear" do
+    expect { subject.clear(feature) }.to raise_error(Flipper::Adapters::ReadOnly::WriteAttempted)
+  end
+
+  it "raises error on enable" do
+    expect { subject.enable(feature, boolean_gate, flipper.boolean) }.to raise_error(Flipper::Adapters::ReadOnly::WriteAttempted)
+  end
+
+  it "raises error on disable" do
+    expect { subject.disable(feature, boolean_gate, flipper.boolean) }.to raise_error(Flipper::Adapters::ReadOnly::WriteAttempted)
+  end
+end

data/spec/flipper/dsl_spec.rb

@@ -26,9 +26,11 @@ RSpec.describe Flipper::DSL do
         expect(dsl.instrumenter).to be(instrumenter)
       end
 
-      it "passes overridden instrumenter to adapter wrapping" do
+      it "passes overridden instrumenter to instrumented adapter" do
         dsl = described_class.new(adapter, :instrumenter => instrumenter)
-        expect(dsl.adapter.instrumenter).to be(instrumenter)
+        memoized = dsl.adapter
+        instrumented = memoized.adapter
+        expect(instrumented.instrumenter).to be(instrumenter)
       end
     end
   end
@@ -233,4 +235,14 @@ RSpec.describe Flipper::DSL do
       expect(subject[:stats].percentage_of_actors_value).to be(0)
     end
   end
+
+  describe '#remove' do
+    it "removes the feature" do
+      subject.enable(:stats)
+
+      expect { subject.remove(:stats) }.to change { subject.enabled?(:stats) }.to(false)
+
+      expect(subject.features).to be_empty
+    end
+  end
 end

data/spec/flipper/feature_spec.rb

@@ -197,6 +197,17 @@ RSpec.describe Flipper::Feature do
       expect(event.payload[:thing]).to eq(Flipper::Types::Actor.new(thing))
     end
 
+    it "is recorded for remove" do
+      subject.remove
+
+      event = instrumenter.events.last
+      expect(event).not_to be_nil
+      expect(event.name).to eq('feature_operation.flipper')
+      expect(event.payload[:feature_name]).to eq(:search)
+      expect(event.payload[:operation]).to eq(:remove)
+      expect(event.payload[:result]).not_to be_nil
+    end
+
     it "is recorded for enabled?" do
       thing = Flipper::Types::Actor.new(Struct.new(:flipper_id).new("1"))
       gate = subject.gate_for(thing)

data/spec/flipper/instrumentation/log_subscriber_spec.rb

@@ -42,11 +42,6 @@ RSpec.describe Flipper::Instrumentation::LogSubscriber do
       expect(adapter_line).to include('[ result={')
       expect(adapter_line).to include('} ]')
     end
-
-    it "logs gate calls" do
-      gate_line = find_line('Flipper feature(search) gate(boolean) open? false')
-      expect(gate_line).to include('[ thing=nil ]')
-    end
   end
 
   context "feature enabled checks with a thing" do
@@ -61,11 +56,6 @@ RSpec.describe Flipper::Instrumentation::LogSubscriber do
       feature_line = find_line('Flipper feature(search) enabled?')
       expect(feature_line).to include(user.inspect)
     end
-
-    it "logs thing for gate" do
-      gate_line = find_line('Flipper feature(search) gate(boolean) open')
-      expect(gate_line).to include(user.inspect)
-    end
   end
 
   context "changing feature enabled state" do

data/spec/flipper/instrumentation/metriks_subscriber_spec.rb

@@ -46,14 +46,4 @@ RSpec.describe Flipper::Instrumentation::MetriksSubscriber do
     flipper[:stats].disable(user)
     expect(Metriks.timer("flipper.adapter.memory.disable").count).to be(1)
   end
-
-  it "updates gate metrics when calls happen" do
-    flipper[:stats].enable(user)
-    flipper[:stats].enabled?(user)
-
-    expect(Metriks.timer("flipper.gate_operation.boolean.open").count).to be(1)
-    expect(Metriks.timer("flipper.feature.stats.gate_operation.boolean.open").count).to be(1)
-    expect(Metriks.meter("flipper.feature.stats.gate.actor.open").count).to be(1)
-    expect(Metriks.meter("flipper.feature.stats.gate.boolean.closed").count).to be(1)
-  end
 end

data/spec/flipper/instrumentation/statsd_subscriber_spec.rb

@@ -65,14 +65,4 @@ RSpec.describe Flipper::Instrumentation::StatsdSubscriber do
     flipper[:stats].disable(user)
     assert_timer 'flipper.adapter.memory.disable'
   end
-
-  it "updates gate metrics when calls happen" do
-    flipper[:stats].enable(user)
-    flipper[:stats].enabled?(user)
-
-    assert_timer 'flipper.gate_operation.boolean.open'
-    assert_timer 'flipper.feature.stats.gate_operation.boolean.open'
-    assert_counter 'flipper.feature.stats.gate.actor.open'
-    assert_counter 'flipper.feature.stats.gate.boolean.closed'
-  end
 end

data/spec/flipper/types/group_spec.rb

@@ -48,5 +48,19 @@ RSpec.describe Flipper::Types::Group do
     it "returns false if block does not match" do
       expect(subject.match?(non_admin_actor)).to eq(false)
     end
+
+    it "returns true for truthy block results" do
+      group = Flipper::Types::Group.new(:examples) do |actor|
+        actor.email =~ /@example\.com/
+      end
+      expect(group.match?(double('Actor', :email => "foo@example.com"))).to be_truthy
+    end
+
+    it "returns false for falsey block results" do
+      group = Flipper::Types::Group.new(:examples) do |actor|
+        nil
+      end
+      expect(group.match?(double('Actor'))).to be_falsey
+    end
   end
 end

data/spec/helper.rb

@@ -10,6 +10,7 @@ Bundler.setup(:default)
 
 require 'flipper'
 require 'flipper-ui'
+require 'flipper-api'
 
 Dir[FlipperRoot.join("spec/support/**/*.rb")].each { |f| require f }
 
@@ -17,6 +18,9 @@ RSpec.configure do |config|
   config.before(:example) do
     Flipper.unregister_groups
   end
+
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
 end
 
 RSpec.shared_examples_for 'a percentage' do

data/spec/integration_spec.rb

@@ -15,6 +15,9 @@ RSpec.describe Flipper do
   let(:admin_thing) { double 'Non Flipper Thing', :flipper_id => 1,  :admin? => true, :dev? => false }
   let(:dev_thing)   { double 'Non Flipper Thing', :flipper_id => 10, :admin? => false, :dev? => true }
 
+  let(:admin_truthy_thing) { double 'Non Flipper Thing', :flipper_id => 1,  :admin? => "true-ish", :dev? => false }
+  let(:admin_falsey_thing) { double 'Non Flipper Thing', :flipper_id => 1,  :admin? => nil, :dev? => false }
+
   let(:pitt)        { actor_class.new(1) }
   let(:clooney)     { actor_class.new(10) }
 
@@ -347,6 +350,10 @@ RSpec.describe Flipper do
         expect(feature.enabled?(flipper.actor(admin_thing))).to eq(true)
         expect(feature.enabled?(admin_thing)).to eq(true)
       end
+
+      it "returns true for truthy block values" do
+        expect(feature.enabled?(flipper.actor(admin_truthy_thing))).to eq(true)
+      end
     end
 
     context "for actor in disabled group" do
@@ -354,6 +361,10 @@ RSpec.describe Flipper do
         expect(feature.enabled?(flipper.actor(dev_thing))).to eq(false)
         expect(feature.enabled?(dev_thing)).to eq(false)
       end
+
+      it "returns false for falsey block values" do
+        expect(feature.enabled?(flipper.actor(admin_falsey_thing))).to eq(false)
+      end
     end
 
     context "for enabled actor" do

data/spec/support/spec_helpers.rb

@@ -14,6 +14,10 @@ module SpecHelpers
     }
   end
 
+  def build_api(flipper)
+    Flipper::Api.app(flipper)
+  end
+
   def build_flipper(adapter = build_memory_adapter)
     Flipper.new(adapter)
   end

data/test/adapters/memory_test.rb

@@ -0,0 +1,10 @@
+require 'test_helper'
+require 'flipper/adapters/memory'
+
+class MemoryTest < MiniTest::Test
+  prepend SharedAdapterTests
+
+  def setup
+    @adapter = Flipper::Adapters::Memory.new
+  end
+end

data/test/adapters/pstore_test.rb

@@ -0,0 +1,17 @@
+require 'test_helper'
+require 'flipper/adapters/pstore'
+
+class PstoreTest < MiniTest::Test
+  prepend SharedAdapterTests
+
+  def setup
+    dir = FlipperRoot.join("tmp").tap { |d| d.mkpath }
+    pstore_file = dir.join("flipper.pstore")
+    pstore_file.unlink if pstore_file.exist?
+    @adapter = Flipper::Adapters::PStore.new(pstore_file)
+  end
+
+  def test_defaults_path_to_flipper_pstore
+    assert_equal Flipper::Adapters::PStore.new.path, "flipper.pstore"
+  end
+end

data/test/helper.rb

@@ -1,5 +1,3 @@
-$:.unshift(File.expand_path('../../lib', __FILE__))
-
 require 'rubygems'
 require 'bundler'
 Bundler.setup(:default)

data/test/test_helper.rb

@@ -0,0 +1,6 @@
+require 'flipper'
+require 'minitest/autorun'
+require 'minitest/unit'
+Dir["./lib/flipper/test/*.rb"].each { |f| require(f) }
+
+FlipperRoot = Pathname(__FILE__).dirname.join('..').expand_path

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.8.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-25 00:00:00.000000000 Z
+date: 2016-06-21 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper is the act of enabling/disabling features in your application,
   ideally without re-deploying or changing anything in your code base. Flipper makes
@@ -43,13 +43,12 @@ files:
 - flipper.gemspec
 - lib/flipper.rb
 - lib/flipper/adapter.rb
-- lib/flipper/adapters/decorator.rb
 - lib/flipper/adapters/instrumented.rb
 - lib/flipper/adapters/memoizable.rb
 - lib/flipper/adapters/memory.rb
 - lib/flipper/adapters/operation_logger.rb
 - lib/flipper/adapters/pstore.rb
-- lib/flipper/decorator.rb
+- lib/flipper/adapters/read_only.rb
 - lib/flipper/dsl.rb
 - lib/flipper/errors.rb
 - lib/flipper/feature.rb
@@ -71,6 +70,7 @@ files:
 - lib/flipper/middleware/memoizer.rb
 - lib/flipper/registry.rb
 - lib/flipper/spec/shared_adapter_specs.rb
+- lib/flipper/test/shared_adapter_test.rb
 - lib/flipper/type.rb
 - lib/flipper/typecast.rb
 - lib/flipper/types/actor.rb
@@ -85,6 +85,7 @@ files:
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/adapters/operation_logger_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
+- spec/flipper/adapters/read_only_spec.rb
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
@@ -113,7 +114,10 @@ files:
 - spec/integration_spec.rb
 - spec/support/fake_udp_socket.rb
 - spec/support/spec_helpers.rb
+- test/adapters/memory_test.rb
+- test/adapters/pstore_test.rb
 - test/helper.rb
+- test/test_helper.rb
 homepage: https://github.com/jnunemaker/flipper
 licenses:
 - MIT
@@ -144,6 +148,7 @@ test_files:
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/adapters/operation_logger_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
+- spec/flipper/adapters/read_only_spec.rb
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
@@ -172,4 +177,7 @@ test_files:
 - spec/integration_spec.rb
 - spec/support/fake_udp_socket.rb
 - spec/support/spec_helpers.rb
+- test/adapters/memory_test.rb
+- test/adapters/pstore_test.rb
 - test/helper.rb
+- test/test_helper.rb