flipper 0.26.0 → 1.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (199) hide show
  1. checksums.yaml +4 -4
  2. data/.github/FUNDING.yml +1 -0
  3. data/.github/workflows/ci.yml +19 -13
  4. data/.github/workflows/examples.yml +32 -15
  5. data/Changelog.md +294 -154
  6. data/Gemfile +15 -10
  7. data/README.md +13 -11
  8. data/benchmark/enabled_ips.rb +10 -0
  9. data/benchmark/enabled_multiple_actors_ips.rb +20 -0
  10. data/benchmark/enabled_profile.rb +20 -0
  11. data/benchmark/instrumentation_ips.rb +21 -0
  12. data/benchmark/typecast_ips.rb +27 -0
  13. data/docs/images/flipper_cloud.png +0 -0
  14. data/examples/api/basic.ru +3 -4
  15. data/examples/api/custom_memoized.ru +3 -4
  16. data/examples/api/memoized.ru +3 -4
  17. data/examples/cloud/app.ru +12 -0
  18. data/examples/cloud/backoff_policy.rb +13 -0
  19. data/examples/cloud/basic.rb +22 -0
  20. data/examples/cloud/cloud_setup.rb +20 -0
  21. data/examples/cloud/forked.rb +36 -0
  22. data/examples/cloud/import.rb +17 -0
  23. data/examples/cloud/threaded.rb +33 -0
  24. data/examples/dsl.rb +1 -15
  25. data/examples/enabled_for_actor.rb +4 -2
  26. data/examples/expressions.rb +213 -0
  27. data/examples/mirroring.rb +59 -0
  28. data/examples/strict.rb +18 -0
  29. data/flipper-cloud.gemspec +19 -0
  30. data/flipper.gemspec +3 -5
  31. data/lib/flipper/actor.rb +6 -3
  32. data/lib/flipper/adapter.rb +33 -7
  33. data/lib/flipper/adapter_builder.rb +44 -0
  34. data/lib/flipper/adapters/dual_write.rb +1 -3
  35. data/lib/flipper/adapters/failover.rb +0 -4
  36. data/lib/flipper/adapters/failsafe.rb +0 -4
  37. data/lib/flipper/adapters/http/client.rb +26 -7
  38. data/lib/flipper/adapters/http/error.rb +1 -1
  39. data/lib/flipper/adapters/http.rb +29 -16
  40. data/lib/flipper/adapters/instrumented.rb +25 -6
  41. data/lib/flipper/adapters/memoizable.rb +33 -21
  42. data/lib/flipper/adapters/memory.rb +81 -46
  43. data/lib/flipper/adapters/operation_logger.rb +16 -7
  44. data/lib/flipper/adapters/poll/poller.rb +2 -125
  45. data/lib/flipper/adapters/poll.rb +5 -3
  46. data/lib/flipper/adapters/pstore.rb +17 -11
  47. data/lib/flipper/adapters/read_only.rb +4 -4
  48. data/lib/flipper/adapters/strict.rb +47 -0
  49. data/lib/flipper/adapters/sync/feature_synchronizer.rb +10 -1
  50. data/lib/flipper/adapters/sync.rb +0 -4
  51. data/lib/flipper/cloud/configuration.rb +258 -0
  52. data/lib/flipper/cloud/dsl.rb +27 -0
  53. data/lib/flipper/cloud/message_verifier.rb +95 -0
  54. data/lib/flipper/cloud/middleware.rb +63 -0
  55. data/lib/flipper/cloud/routes.rb +14 -0
  56. data/lib/flipper/cloud/telemetry/backoff_policy.rb +93 -0
  57. data/lib/flipper/cloud/telemetry/instrumenter.rb +26 -0
  58. data/lib/flipper/cloud/telemetry/metric.rb +39 -0
  59. data/lib/flipper/cloud/telemetry/metric_storage.rb +30 -0
  60. data/lib/flipper/cloud/telemetry/submitter.rb +98 -0
  61. data/lib/flipper/cloud/telemetry.rb +183 -0
  62. data/lib/flipper/cloud.rb +53 -0
  63. data/lib/flipper/configuration.rb +25 -4
  64. data/lib/flipper/dsl.rb +46 -45
  65. data/lib/flipper/engine.rb +88 -0
  66. data/lib/flipper/errors.rb +3 -3
  67. data/lib/flipper/export.rb +26 -0
  68. data/lib/flipper/exporter.rb +17 -0
  69. data/lib/flipper/exporters/json/export.rb +32 -0
  70. data/lib/flipper/exporters/json/v1.rb +33 -0
  71. data/lib/flipper/expression/builder.rb +73 -0
  72. data/lib/flipper/expression/constant.rb +25 -0
  73. data/lib/flipper/expression.rb +71 -0
  74. data/lib/flipper/expressions/all.rb +11 -0
  75. data/lib/flipper/expressions/any.rb +9 -0
  76. data/lib/flipper/expressions/boolean.rb +9 -0
  77. data/lib/flipper/expressions/comparable.rb +13 -0
  78. data/lib/flipper/expressions/duration.rb +28 -0
  79. data/lib/flipper/expressions/equal.rb +9 -0
  80. data/lib/flipper/expressions/greater_than.rb +9 -0
  81. data/lib/flipper/expressions/greater_than_or_equal_to.rb +9 -0
  82. data/lib/flipper/expressions/less_than.rb +9 -0
  83. data/lib/flipper/expressions/less_than_or_equal_to.rb +9 -0
  84. data/lib/flipper/expressions/not_equal.rb +9 -0
  85. data/lib/flipper/expressions/now.rb +9 -0
  86. data/lib/flipper/expressions/number.rb +9 -0
  87. data/lib/flipper/expressions/percentage.rb +9 -0
  88. data/lib/flipper/expressions/percentage_of_actors.rb +12 -0
  89. data/lib/flipper/expressions/property.rb +9 -0
  90. data/lib/flipper/expressions/random.rb +9 -0
  91. data/lib/flipper/expressions/string.rb +9 -0
  92. data/lib/flipper/expressions/time.rb +9 -0
  93. data/lib/flipper/feature.rb +87 -26
  94. data/lib/flipper/feature_check_context.rb +10 -6
  95. data/lib/flipper/gate.rb +13 -11
  96. data/lib/flipper/gate_values.rb +5 -18
  97. data/lib/flipper/gates/actor.rb +10 -17
  98. data/lib/flipper/gates/boolean.rb +1 -1
  99. data/lib/flipper/gates/expression.rb +75 -0
  100. data/lib/flipper/gates/group.rb +5 -7
  101. data/lib/flipper/gates/percentage_of_actors.rb +10 -13
  102. data/lib/flipper/gates/percentage_of_time.rb +1 -2
  103. data/lib/flipper/identifier.rb +2 -2
  104. data/lib/flipper/instrumentation/log_subscriber.rb +24 -5
  105. data/lib/flipper/instrumentation/statsd_subscriber.rb +2 -4
  106. data/lib/flipper/instrumentation/subscriber.rb +8 -1
  107. data/lib/flipper/metadata.rb +5 -1
  108. data/lib/flipper/middleware/memoizer.rb +30 -14
  109. data/lib/flipper/poller.rb +117 -0
  110. data/lib/flipper/serializers/gzip.rb +24 -0
  111. data/lib/flipper/serializers/json.rb +19 -0
  112. data/lib/flipper/spec/shared_adapter_specs.rb +95 -54
  113. data/lib/flipper/test/shared_adapter_test.rb +91 -48
  114. data/lib/flipper/typecast.rb +56 -15
  115. data/lib/flipper/types/actor.rb +13 -13
  116. data/lib/flipper/types/group.rb +4 -4
  117. data/lib/flipper/types/percentage.rb +1 -1
  118. data/lib/flipper/version.rb +1 -1
  119. data/lib/flipper.rb +47 -10
  120. data/spec/fixtures/flipper_pstore_1679087600.json +46 -0
  121. data/spec/flipper/adapter_builder_spec.rb +73 -0
  122. data/spec/flipper/adapter_spec.rb +30 -2
  123. data/spec/flipper/adapters/dual_write_spec.rb +2 -2
  124. data/spec/flipper/adapters/http_spec.rb +64 -8
  125. data/spec/flipper/adapters/instrumented_spec.rb +29 -11
  126. data/spec/flipper/adapters/memoizable_spec.rb +51 -31
  127. data/spec/flipper/adapters/memory_spec.rb +14 -3
  128. data/spec/flipper/adapters/operation_logger_spec.rb +31 -12
  129. data/spec/flipper/adapters/read_only_spec.rb +32 -17
  130. data/spec/flipper/adapters/strict_spec.rb +62 -0
  131. data/spec/flipper/adapters/sync/feature_synchronizer_spec.rb +27 -0
  132. data/spec/flipper/cloud/configuration_spec.rb +252 -0
  133. data/spec/flipper/cloud/dsl_spec.rb +82 -0
  134. data/spec/flipper/cloud/message_verifier_spec.rb +104 -0
  135. data/spec/flipper/cloud/middleware_spec.rb +289 -0
  136. data/spec/flipper/cloud/telemetry/backoff_policy_spec.rb +108 -0
  137. data/spec/flipper/cloud/telemetry/metric_spec.rb +87 -0
  138. data/spec/flipper/cloud/telemetry/metric_storage_spec.rb +58 -0
  139. data/spec/flipper/cloud/telemetry/submitter_spec.rb +145 -0
  140. data/spec/flipper/cloud/telemetry_spec.rb +156 -0
  141. data/spec/flipper/cloud_spec.rb +180 -0
  142. data/spec/flipper/configuration_spec.rb +17 -0
  143. data/spec/flipper/dsl_spec.rb +54 -73
  144. data/spec/flipper/engine_spec.rb +291 -0
  145. data/spec/flipper/export_spec.rb +13 -0
  146. data/spec/flipper/exporter_spec.rb +16 -0
  147. data/spec/flipper/exporters/json/export_spec.rb +60 -0
  148. data/spec/flipper/exporters/json/v1_spec.rb +33 -0
  149. data/spec/flipper/expression/builder_spec.rb +248 -0
  150. data/spec/flipper/expression_spec.rb +188 -0
  151. data/spec/flipper/expressions/all_spec.rb +15 -0
  152. data/spec/flipper/expressions/any_spec.rb +15 -0
  153. data/spec/flipper/expressions/boolean_spec.rb +15 -0
  154. data/spec/flipper/expressions/duration_spec.rb +43 -0
  155. data/spec/flipper/expressions/equal_spec.rb +24 -0
  156. data/spec/flipper/expressions/greater_than_or_equal_to_spec.rb +28 -0
  157. data/spec/flipper/expressions/greater_than_spec.rb +28 -0
  158. data/spec/flipper/expressions/less_than_or_equal_to_spec.rb +28 -0
  159. data/spec/flipper/expressions/less_than_spec.rb +32 -0
  160. data/spec/flipper/expressions/not_equal_spec.rb +15 -0
  161. data/spec/flipper/expressions/now_spec.rb +11 -0
  162. data/spec/flipper/expressions/number_spec.rb +21 -0
  163. data/spec/flipper/expressions/percentage_of_actors_spec.rb +20 -0
  164. data/spec/flipper/expressions/percentage_spec.rb +15 -0
  165. data/spec/flipper/expressions/property_spec.rb +13 -0
  166. data/spec/flipper/expressions/random_spec.rb +9 -0
  167. data/spec/flipper/expressions/string_spec.rb +11 -0
  168. data/spec/flipper/expressions/time_spec.rb +13 -0
  169. data/spec/flipper/feature_check_context_spec.rb +17 -17
  170. data/spec/flipper/feature_spec.rb +436 -33
  171. data/spec/flipper/gate_values_spec.rb +2 -33
  172. data/spec/flipper/gates/boolean_spec.rb +1 -1
  173. data/spec/flipper/gates/expression_spec.rb +108 -0
  174. data/spec/flipper/gates/group_spec.rb +2 -3
  175. data/spec/flipper/gates/percentage_of_actors_spec.rb +61 -5
  176. data/spec/flipper/gates/percentage_of_time_spec.rb +2 -2
  177. data/spec/flipper/identifier_spec.rb +4 -5
  178. data/spec/flipper/instrumentation/log_subscriber_spec.rb +15 -5
  179. data/spec/flipper/instrumentation/statsd_subscriber_spec.rb +25 -1
  180. data/spec/flipper/middleware/memoizer_spec.rb +67 -0
  181. data/spec/flipper/poller_spec.rb +47 -0
  182. data/spec/flipper/serializers/gzip_spec.rb +13 -0
  183. data/spec/flipper/serializers/json_spec.rb +13 -0
  184. data/spec/flipper/typecast_spec.rb +121 -6
  185. data/spec/flipper/types/actor_spec.rb +63 -46
  186. data/spec/flipper/types/group_spec.rb +2 -2
  187. data/spec/flipper_integration_spec.rb +168 -58
  188. data/spec/flipper_spec.rb +92 -28
  189. data/spec/spec_helper.rb +6 -13
  190. data/spec/support/actor_names.yml +1 -0
  191. data/spec/support/climate_control.rb +7 -0
  192. data/spec/support/fake_backoff_policy.rb +15 -0
  193. data/spec/support/skippable.rb +18 -0
  194. data/spec/support/spec_helpers.rb +11 -3
  195. metadata +166 -13
  196. data/.github/workflows/release.yml +0 -44
  197. data/.tool-versions +0 -1
  198. data/lib/flipper/railtie.rb +0 -47
  199. data/spec/flipper/railtie_spec.rb +0 -109
@@ -0,0 +1,156 @@
1
+ require 'flipper/cloud/telemetry'
2
+ require 'flipper/cloud/configuration'
3
+
4
+ RSpec.describe Flipper::Cloud::Telemetry do
5
+ it "phones home and does not update telemetry interval if missing" do
6
+ stub = stub_request(:post, "https://www.flippercloud.io/adapter/telemetry").
7
+ to_return(status: 200, body: "{}", headers: {})
8
+
9
+ cloud_configuration = Flipper::Cloud::Configuration.new(token: "test")
10
+
11
+ # Record some telemetry and stop the threads so we submit a response.
12
+ telemetry = described_class.new(cloud_configuration)
13
+ telemetry.record(Flipper::Feature::InstrumentationName, {
14
+ operation: :enabled?,
15
+ feature_name: :foo,
16
+ result: true,
17
+ })
18
+ telemetry.stop
19
+
20
+ expect(telemetry.interval).to eq(60)
21
+ expect(telemetry.timer.execution_interval).to eq(60)
22
+ expect(stub).to have_been_requested
23
+ end
24
+
25
+ it "phones home and updates telemetry interval if present" do
26
+ stub = stub_request(:post, "https://www.flippercloud.io/adapter/telemetry").
27
+ to_return(status: 200, body: "{}", headers: {"telemetry-interval" => "120"})
28
+
29
+ cloud_configuration = Flipper::Cloud::Configuration.new(token: "test")
30
+
31
+ # Record some telemetry and stop the threads so we submit a response.
32
+ telemetry = described_class.new(cloud_configuration)
33
+ telemetry.record(Flipper::Feature::InstrumentationName, {
34
+ operation: :enabled?,
35
+ feature_name: :foo,
36
+ result: true,
37
+ })
38
+ telemetry.stop
39
+
40
+ expect(telemetry.interval).to eq(120)
41
+ expect(telemetry.timer.execution_interval).to eq(120)
42
+ expect(stub).to have_been_requested
43
+ end
44
+
45
+ it "can update telemetry interval from error" do
46
+ stub = stub_request(:post, "https://www.flippercloud.io/adapter/telemetry").
47
+ to_return(status: 500, body: "{}", headers: {"telemetry-interval" => "120"})
48
+
49
+ cloud_configuration = Flipper::Cloud::Configuration.new(token: "test")
50
+ telemetry = described_class.new(cloud_configuration)
51
+
52
+ # Override the submitter to use back off policy that doesn't actually
53
+ # sleep. If we don't then the stop below kills the working thread and the
54
+ # interval is never updated.
55
+ telemetry.submitter = ->(drained) {
56
+ Flipper::Cloud::Telemetry::Submitter.new(
57
+ cloud_configuration,
58
+ backoff_policy: FakeBackoffPolicy.new
59
+ ).call(drained)
60
+ }
61
+
62
+ # Record some telemetry and stop the threads so we submit a response.
63
+ telemetry.record(Flipper::Feature::InstrumentationName, {
64
+ operation: :enabled?,
65
+ feature_name: :foo,
66
+ result: true,
67
+ })
68
+ telemetry.stop
69
+
70
+ # Check the conig interval and the timer interval.
71
+ expect(telemetry.interval).to eq(120)
72
+ expect(telemetry.timer.execution_interval).to eq(120)
73
+ expect(stub).to have_been_requested.times(10)
74
+ end
75
+
76
+ it "doesn't try to update telemetry interval from error if not response error" do
77
+ stub = stub_request(:post, "https://www.flippercloud.io/adapter/telemetry").
78
+ to_raise(Net::OpenTimeout)
79
+
80
+ cloud_configuration = Flipper::Cloud::Configuration.new(token: "test")
81
+ telemetry = described_class.new(cloud_configuration)
82
+
83
+ # Override the submitter to use back off policy that doesn't actually
84
+ # sleep. If we don't then the stop below kills the working thread and the
85
+ # interval is never updated.
86
+ telemetry.submitter = ->(drained) {
87
+ Flipper::Cloud::Telemetry::Submitter.new(
88
+ cloud_configuration,
89
+ backoff_policy: FakeBackoffPolicy.new
90
+ ).call(drained)
91
+ }
92
+
93
+ # Record some telemetry and stop the threads so we submit a response.
94
+ telemetry.record(Flipper::Feature::InstrumentationName, {
95
+ operation: :enabled?,
96
+ feature_name: :foo,
97
+ result: true,
98
+ })
99
+ telemetry.stop
100
+
101
+ expect(telemetry.interval).to eq(60)
102
+ expect(telemetry.timer.execution_interval).to eq(60)
103
+ expect(stub).to have_been_requested.times(10)
104
+ end
105
+
106
+ describe '#record' do
107
+ it "increments in metric storage" do
108
+ begin
109
+ config = Flipper::Cloud::Configuration.new(token: "test")
110
+ telemetry = described_class.new(config)
111
+ telemetry.record(Flipper::Feature::InstrumentationName, {
112
+ operation: :enabled?,
113
+ feature_name: :foo,
114
+ result: true,
115
+ })
116
+ telemetry.record(Flipper::Feature::InstrumentationName, {
117
+ operation: :enabled?,
118
+ feature_name: :foo,
119
+ result: true,
120
+ })
121
+ telemetry.record(Flipper::Feature::InstrumentationName, {
122
+ operation: :enabled?,
123
+ feature_name: :bar,
124
+ result: true,
125
+ })
126
+ telemetry.record(Flipper::Feature::InstrumentationName, {
127
+ operation: :enabled?,
128
+ feature_name: :baz,
129
+ result: true,
130
+ })
131
+ telemetry.record(Flipper::Feature::InstrumentationName, {
132
+ operation: :enabled?,
133
+ feature_name: :foo,
134
+ result: false,
135
+ })
136
+
137
+ drained = telemetry.metric_storage.drain
138
+ metrics_by_key = drained.keys.group_by(&:key)
139
+
140
+ foo_true, foo_false = metrics_by_key["foo"].partition { |metric| metric.result }
141
+ foo_true_sum = foo_true.map { |metric| drained[metric] }.sum
142
+ expect(foo_true_sum).to be(2)
143
+ foo_false_sum = foo_false.map { |metric| drained[metric] }.sum
144
+ expect(foo_false_sum).to be(1)
145
+
146
+ bar_true_sum = metrics_by_key["bar"].map { |metric| drained[metric] }.sum
147
+ expect(bar_true_sum).to be(1)
148
+
149
+ baz_true_sum = metrics_by_key["baz"].map { |metric| drained[metric] }.sum
150
+ expect(baz_true_sum).to be(1)
151
+ ensure
152
+ telemetry.stop
153
+ end
154
+ end
155
+ end
156
+ end
@@ -0,0 +1,180 @@
1
+ require 'flipper/cloud'
2
+ require 'flipper/adapters/instrumented'
3
+ require 'flipper/instrumenters/memory'
4
+
5
+ RSpec.describe Flipper::Cloud do
6
+ before do
7
+ stub_request(:get, /flippercloud\.io/).to_return(status: 200, body: "{}")
8
+ end
9
+
10
+ context "initialize with token" do
11
+ let(:token) { 'asdf' }
12
+
13
+ before do
14
+ @instance = described_class.new(token: token)
15
+ end
16
+
17
+ it 'returns Flipper::DSL instance' do
18
+ expect(@instance).to be_instance_of(Flipper::Cloud::DSL)
19
+ end
20
+
21
+ it 'can read the cloud configuration' do
22
+ expect(@instance.cloud_configuration).to be_instance_of(Flipper::Cloud::Configuration)
23
+ end
24
+
25
+ it 'configures the correct adapter' do
26
+ # pardon the nesting...
27
+ memoized_adapter = @instance.adapter
28
+ dual_write_adapter = memoized_adapter.adapter
29
+ expect(dual_write_adapter).to be_instance_of(Flipper::Adapters::DualWrite)
30
+ poll_adapter = dual_write_adapter.local
31
+ expect(poll_adapter).to be_instance_of(Flipper::Adapters::Poll)
32
+
33
+ http_adapter = dual_write_adapter.remote
34
+ client = http_adapter.client
35
+ expect(client.uri.scheme).to eq('https')
36
+ expect(client.uri.host).to eq('www.flippercloud.io')
37
+ expect(client.uri.path).to eq('/adapter')
38
+ expect(client.headers['Flipper-Cloud-Token']).to eq(token)
39
+ expect(@instance.instrumenter).to be(Flipper::Instrumenters::Noop)
40
+ end
41
+ end
42
+
43
+ context 'initialize with token and options' do
44
+ it 'sets correct url' do
45
+ instance = described_class.new(token: 'asdf', url: 'https://www.fakeflipper.com/sadpanda')
46
+ # pardon the nesting...
47
+ memoized = instance.adapter
48
+ dual_write = memoized.adapter
49
+ remote = dual_write.remote
50
+ uri = remote.client.uri
51
+ expect(uri.scheme).to eq('https')
52
+ expect(uri.host).to eq('www.fakeflipper.com')
53
+ expect(uri.path).to eq('/sadpanda')
54
+ end
55
+ end
56
+
57
+ it 'can initialize with no token explicitly provided' do
58
+ with_env 'FLIPPER_CLOUD_TOKEN' => 'asdf' do
59
+ expect(described_class.new).to be_instance_of(Flipper::Cloud::DSL)
60
+ end
61
+ end
62
+
63
+ it 'can set instrumenter' do
64
+ instrumenter = Flipper::Instrumenters::Memory.new
65
+ instance = described_class.new(token: 'asdf', instrumenter: instrumenter)
66
+ expect(instance.instrumenter).to be(instrumenter)
67
+ end
68
+
69
+ it 'allows wrapping adapter with another adapter like the instrumenter' do
70
+ instance = described_class.new(token: 'asdf') do |config|
71
+ config.adapter do |adapter|
72
+ Flipper::Adapters::Instrumented.new(adapter)
73
+ end
74
+ end
75
+ # instance.adapter is memoizable adapter instance
76
+ expect(instance.adapter.adapter).to be_instance_of(Flipper::Adapters::Instrumented)
77
+ end
78
+
79
+ it 'can set debug_output' do
80
+ expect(Flipper::Adapters::Http::Client).to receive(:new)
81
+ .with(hash_including(debug_output: STDOUT)).at_least(:once)
82
+ described_class.new(token: 'asdf', debug_output: STDOUT)
83
+ end
84
+
85
+ it 'can set read_timeout' do
86
+ expect(Flipper::Adapters::Http::Client).to receive(:new)
87
+ .with(hash_including(read_timeout: 1)).at_least(:once)
88
+ described_class.new(token: 'asdf', read_timeout: 1)
89
+ end
90
+
91
+ it 'can set open_timeout' do
92
+ expect(Flipper::Adapters::Http::Client).to receive(:new)
93
+ .with(hash_including(open_timeout: 1)).at_least(:once)
94
+ described_class.new(token: 'asdf', open_timeout: 1)
95
+ end
96
+
97
+ if RUBY_VERSION >= '2.6.0'
98
+ it 'can set write_timeout' do
99
+ expect(Flipper::Adapters::Http::Client).to receive(:new)
100
+ .with(hash_including(open_timeout: 1)).at_least(:once)
101
+ described_class.new(token: 'asdf', open_timeout: 1)
102
+ end
103
+ end
104
+
105
+ it 'can import' do
106
+ stub_request(:post, /www\.flippercloud\.io\/adapter\/features.*/).
107
+ with(headers: {'Flipper-Cloud-Token'=>'asdf'}).to_return(status: 200, body: "{}", headers: {})
108
+
109
+ flipper = Flipper.new(Flipper::Adapters::Memory.new)
110
+
111
+ flipper.enable(:test)
112
+ flipper.enable(:search)
113
+ flipper.enable_actor(:stats, Flipper::Actor.new("jnunemaker"))
114
+ flipper.enable_percentage_of_time(:logging, 5)
115
+
116
+ cloud_flipper = Flipper::Cloud.new(token: "asdf")
117
+
118
+ get_all = {
119
+ "logging" => {actors: Set.new, boolean: nil, groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: "5"},
120
+ "search" => {actors: Set.new, boolean: "true", groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
121
+ "stats" => {actors: Set["jnunemaker"], boolean: nil, groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
122
+ "test" => {actors: Set.new, boolean: "true", groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
123
+ }
124
+
125
+ expect(flipper.adapter.get_all).to eq(get_all)
126
+ cloud_flipper.import(flipper)
127
+ expect(flipper.adapter.get_all).to eq(get_all)
128
+ expect(cloud_flipper.adapter.get_all).to eq(get_all)
129
+ end
130
+
131
+ it 'raises error for failure while importing' do
132
+ stub_request(:post, /www\.flippercloud\.io\/adapter\/features.*/).
133
+ with(headers: {'Flipper-Cloud-Token'=>'asdf'}).to_return(status: 500, body: "{}")
134
+
135
+ flipper = Flipper.new(Flipper::Adapters::Memory.new)
136
+
137
+ flipper.enable(:test)
138
+ flipper.enable(:search)
139
+ flipper.enable_actor(:stats, Flipper::Actor.new("jnunemaker"))
140
+ flipper.enable_percentage_of_time(:logging, 5)
141
+
142
+ cloud_flipper = Flipper::Cloud.new(token: "asdf")
143
+
144
+ get_all = {
145
+ "logging" => {actors: Set.new, boolean: nil, groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: "5"},
146
+ "search" => {actors: Set.new, boolean: "true", groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
147
+ "stats" => {actors: Set["jnunemaker"], boolean: nil, groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
148
+ "test" => {actors: Set.new, boolean: "true", groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
149
+ }
150
+
151
+ expect(flipper.adapter.get_all).to eq(get_all)
152
+ expect { cloud_flipper.import(flipper) }.to raise_error(Flipper::Adapters::Http::Error)
153
+ expect(flipper.adapter.get_all).to eq(get_all)
154
+ end
155
+
156
+ it 'raises error for timeout while importing' do
157
+ stub_request(:post, /www\.flippercloud\.io\/adapter\/features.*/).
158
+ with(headers: {'Flipper-Cloud-Token'=>'asdf'}).to_timeout
159
+
160
+ flipper = Flipper.new(Flipper::Adapters::Memory.new)
161
+
162
+ flipper.enable(:test)
163
+ flipper.enable(:search)
164
+ flipper.enable_actor(:stats, Flipper::Actor.new("jnunemaker"))
165
+ flipper.enable_percentage_of_time(:logging, 5)
166
+
167
+ cloud_flipper = Flipper::Cloud.new(token: "asdf")
168
+
169
+ get_all = {
170
+ "logging" => {actors: Set.new, boolean: nil, groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: "5"},
171
+ "search" => {actors: Set.new, boolean: "true", groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
172
+ "stats" => {actors: Set["jnunemaker"], boolean: nil, groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
173
+ "test" => {actors: Set.new, boolean: "true", groups: Set.new, expression: nil, percentage_of_actors: nil, percentage_of_time: nil},
174
+ }
175
+
176
+ expect(flipper.adapter.get_all).to eq(get_all)
177
+ expect { cloud_flipper.import(flipper) }.to raise_error(Net::OpenTimeout)
178
+ expect(flipper.adapter.get_all).to eq(get_all)
179
+ end
180
+ end
@@ -30,4 +30,21 @@ RSpec.describe Flipper::Configuration do
30
30
  expect(subject.default).to be(instance)
31
31
  end
32
32
  end
33
+
34
+ describe '#statsd' do
35
+ let(:statsd) { double(Statsd) }
36
+
37
+ after do
38
+ Flipper::Instrumentation::StatsdSubscriber.client = nil
39
+ end
40
+
41
+ it 'returns nil by default' do
42
+ expect(subject.statsd).to be_nil
43
+ end
44
+
45
+ it 'can be set' do
46
+ subject.statsd = statsd
47
+ expect(subject.statsd).to be(statsd)
48
+ end
49
+ end
33
50
  end
@@ -123,18 +123,6 @@ RSpec.describe Flipper::DSL do
123
123
  end
124
124
  end
125
125
 
126
- describe '#boolean' do
127
- it_should_behave_like 'a DSL boolean method' do
128
- let(:method_name) { :boolean }
129
- end
130
- end
131
-
132
- describe '#bool' do
133
- it_should_behave_like 'a DSL boolean method' do
134
- let(:method_name) { :bool }
135
- end
136
- end
137
-
138
126
  describe '#group' do
139
127
  context 'for registered group' do
140
128
  before do
@@ -148,66 +136,15 @@ RSpec.describe Flipper::DSL do
148
136
  end
149
137
  end
150
138
 
151
- describe '#actor' do
152
- context 'for a thing' do
153
- it 'returns actor instance' do
154
- thing = Flipper::Actor.new(33)
155
- actor = subject.actor(thing)
156
- expect(actor).to be_instance_of(Flipper::Types::Actor)
157
- expect(actor.value).to eq('33')
158
- end
159
- end
160
-
161
- context 'for nil' do
162
- it 'raises argument error' do
163
- expect do
164
- subject.actor(nil)
165
- end.to raise_error(ArgumentError)
166
- end
167
- end
168
-
169
- context 'for something that is not actor wrappable' do
170
- it 'raises argument error' do
171
- expect do
172
- subject.actor(Object.new)
173
- end.to raise_error(ArgumentError)
174
- end
175
- end
176
- end
177
-
178
- describe '#time' do
179
- before do
180
- @result = subject.time(5)
181
- end
182
-
183
- it 'returns percentage of time' do
184
- expect(@result).to be_instance_of(Flipper::Types::PercentageOfTime)
185
- end
186
-
187
- it 'sets value' do
188
- expect(@result.value).to eq(5)
189
- end
190
-
191
- it 'is aliased to percentage_of_time' do
192
- expect(@result).to eq(subject.percentage_of_time(@result.value))
193
- end
194
- end
195
-
196
- describe '#actors' do
197
- before do
198
- @result = subject.actors(17)
199
- end
200
-
201
- it 'returns percentage of actors' do
202
- expect(@result).to be_instance_of(Flipper::Types::PercentageOfActors)
203
- end
204
-
205
- it 'sets value' do
206
- expect(@result.value).to eq(17)
139
+ describe '#expression' do
140
+ it "returns nil if feature has no expression" do
141
+ expect(subject.expression(:stats)).to be(nil)
207
142
  end
208
143
 
209
- it 'is aliased to percentage_of_actors' do
210
- expect(@result).to eq(subject.percentage_of_actors(@result.value))
144
+ it "returns expression if feature has expression" do
145
+ expression = Flipper.property(:plan).eq("basic")
146
+ subject[:stats].enable_expression expression
147
+ expect(subject.expression(:stats)).to eq(expression)
211
148
  end
212
149
  end
213
150
 
@@ -246,6 +183,33 @@ RSpec.describe Flipper::DSL do
246
183
  end
247
184
  end
248
185
 
186
+ describe '#enable_expression/disable_expression' do
187
+ it 'enables and disables the feature for the expression' do
188
+ expression = Flipper.property(:plan).eq("basic")
189
+
190
+ expect(subject[:stats].expression).to be(nil)
191
+ subject.enable_expression(:stats, expression)
192
+ expect(subject[:stats].expression).to eq(expression)
193
+
194
+ subject.disable_expression(:stats)
195
+ expect(subject[:stats].expression).to be(nil)
196
+ end
197
+ end
198
+
199
+ describe '#add_expression/remove_expression' do
200
+ it 'enables and disables the feature for the expression' do
201
+ expression = Flipper.property(:plan).eq("basic")
202
+ any_expression = Flipper.any(expression)
203
+
204
+ expect(subject[:stats].expression).to be(nil)
205
+ subject.add_expression(:stats, any_expression)
206
+ expect(subject[:stats].expression).to eq(any_expression)
207
+
208
+ subject.remove_expression(:stats, expression)
209
+ expect(subject[:stats].expression).to eq(Flipper.any)
210
+ end
211
+ end
212
+
249
213
  describe '#enable_actor/disable_actor' do
250
214
  it 'enables and disables the feature for actor' do
251
215
  actor = Flipper::Actor.new(5)
@@ -342,10 +306,27 @@ RSpec.describe Flipper::DSL do
342
306
  end
343
307
 
344
308
  describe '#import' do
309
+ context "with flipper instance" do
310
+ it 'delegates to adapter' do
311
+ destination_flipper = build_flipper
312
+ expect(subject.adapter).to receive(:import).with(destination_flipper)
313
+ subject.import(destination_flipper)
314
+ end
315
+ end
316
+
317
+ context "with flipper adapter" do
318
+ it 'delegates to adapter' do
319
+ destination_flipper = build_flipper
320
+ expect(subject.adapter).to receive(:import).with(destination_flipper.adapter)
321
+ subject.import(destination_flipper.adapter)
322
+ end
323
+ end
324
+ end
325
+
326
+ describe "#export" do
345
327
  it 'delegates to adapter' do
346
- destination_flipper = build_flipper
347
- expect(subject.adapter).to receive(:import).with(destination_flipper.adapter)
348
- subject.import(destination_flipper)
328
+ expect(subject.export).to eq(subject.adapter.export)
329
+ expect(subject.export(format: :json)).to eq(subject.adapter.export(format: :json))
349
330
  end
350
331
  end
351
332