flipper 0.26.0.rc1 → 0.26.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b6c4a5c4ef29f126e9a08cc7fc7c70be9831b179dfc55486b88b8c5da5fdf44
-  data.tar.gz: aab15578901fcab2b3717813aa37d3cc057554eea3d442f264f85707d94310f9
+  metadata.gz: 60ce7896afa06dd25ad8e6f8b4f419bbb992e16ce7147339af30ac15f338871d
+  data.tar.gz: 3a6635db6af529d29a2f1bd075fe45a82c77211bdd012d3613a89f2b98566975
 SHA512:
-  metadata.gz: 79989c8d6149b13b6c960878d4ac701f98f5e3da9b44a567092a4ace82350ec8ccffcd7e9c9ea2619a2a2508b6a392e99c05b14ab14b59b5a0b3a58b4f211150
-  data.tar.gz: 5192a0b9e1bebc39a28503861ba4eb35a05010a1841595e1282437c7d0694e3eccd02f215fbc6928b228948c6a02c8e9d26f85a5e23ae271fd0b32bc84bf6b53
+  metadata.gz: 6ce977a03bcafdfd4cb0427541eb0277b4dfbbadd723c86e12a7fcbec65d398663ed74fbdb9c46aa6b460e00e0025bd9853ed52c7a3cf3f44016e005d79e6eff
+  data.tar.gz: c422114b0e7076ebd7c0c63bef943a54aede502f253c5310a4e59f17daaadeafd435594aac7936c441adfc3a39fa3d5ba2ef17c589d828cefb5a977d750f0215

data/lib/flipper/adapters/poll/poller.rb

@@ -7,9 +7,7 @@ module Flipper
   module Adapters
     class Poll
       class Poller
-        PREFIX = "[flipper http async poll adapter]".freeze
-
-        attr_reader :thread, :pid, :mutex, :logger, :interval, :last_synced_at
+        attr_reader :thread, :pid, :mutex, :interval, :last_synced_at
 
         def self.instances
           @instances ||= Concurrent::Map.new
@@ -29,14 +27,14 @@ module Flipper
           @pid = Process.pid
           @mutex = Mutex.new
           @adapter = Memory.new
+          @instrumenter = options.fetch(:instrumenter, Instrumenters::Noop)
           @remote_adapter = options.fetch(:remote_adapter)
-          @logger = options.fetch(:logger) { Logger.new(STDOUT) }
           @interval = options.fetch(:interval, 10).to_f
           @lock = Concurrent::ReadWriteLock.new
           @last_synced_at = Concurrent::AtomicFixnum.new(0)
 
           if @interval < 1
-            warn "#{PREFIX} interval must be greater than or equal to 1 but was #{@interval}. Setting @interval to 1."
+            warn "Flipper::Cloud poll interval must be greater than or equal to 1 but was #{@interval}. Setting @interval to 1."
             @interval = 1
           end
 
@@ -57,7 +55,9 @@ module Flipper
         end
 
         def stop
-          logger.debug { "#{PREFIX} Stopping worker" }
+          @instrumenter.instrument("poller.#{InstrumentationNamespace}", {
+            operation: :stop,
+          })
           @thread&.kill
         end
 
@@ -66,15 +66,15 @@ module Flipper
             sleep jitter
             start = Concurrent.monotonic_time
             begin
-              logger.debug { "#{PREFIX} Making a checkity checkity" }
-
-              adapter = Memory.new
-              adapter.import(@remote_adapter)
+              @instrumenter.instrument("poller.#{InstrumentationNamespace}", operation: :poll) do
+                adapter = Memory.new
+                adapter.import(@remote_adapter)
 
-              @lock.with_write_lock { @adapter.import(adapter) }
-              @last_synced_at.update { |time| Concurrent.monotonic_time }
+                @lock.with_write_lock { @adapter.import(adapter) }
+                @last_synced_at.update { |time| Concurrent.monotonic_time }
+              end
             rescue => exception
-              logger.debug { "#{PREFIX} Exception: #{exception.inspect}" }
+              # you can instrument these using poller.flipper
             end
 
             sleep_interval = interval - (Concurrent.monotonic_time - start)
@@ -103,7 +103,9 @@ module Flipper
           begin
             return if thread_alive?
             @thread = Thread.new { run }
-            logger.debug { "#{PREFIX} Worker thread [#{@thread.object_id}] started" }
+            @instrumenter.instrument("poller.#{InstrumentationNamespace}", {
+              operation: :thread_start,
+            })
           ensure
             mutex.unlock
           end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.26.0.rc1'.freeze
+  VERSION = '0.26.0.rc2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.26.0.rc1
+  version: 0.26.0.rc2
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-11 00:00:00.000000000 Z
+date: 2022-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby