flipper 0.24.1 → 1.3.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.github/FUNDING.yml +1 -0
- data/.github/dependabot.yml +6 -0
- data/.github/workflows/ci.yml +45 -14
- data/.github/workflows/examples.yml +39 -16
- data/Changelog.md +2 -443
- data/Gemfile +19 -11
- data/README.md +31 -27
- data/Rakefile +6 -4
- data/benchmark/enabled_ips.rb +10 -0
- data/benchmark/enabled_multiple_actors_ips.rb +20 -0
- data/benchmark/enabled_profile.rb +20 -0
- data/benchmark/instrumentation_ips.rb +21 -0
- data/benchmark/typecast_ips.rb +27 -0
- data/docs/images/banner.jpg +0 -0
- data/docs/images/flipper_cloud.png +0 -0
- data/examples/api/basic.ru +3 -4
- data/examples/api/custom_memoized.ru +3 -4
- data/examples/api/memoized.ru +3 -4
- data/examples/cloud/app.ru +12 -0
- data/examples/cloud/backoff_policy.rb +13 -0
- data/examples/cloud/basic.rb +22 -0
- data/examples/cloud/cloud_setup.rb +20 -0
- data/examples/cloud/forked.rb +36 -0
- data/examples/cloud/import.rb +17 -0
- data/examples/cloud/threaded.rb +33 -0
- data/examples/dsl.rb +1 -15
- data/examples/enabled_for_actor.rb +4 -2
- data/examples/expressions.rb +213 -0
- data/examples/instrumentation.rb +1 -0
- data/examples/instrumentation_last_accessed_at.rb +1 -0
- data/examples/mirroring.rb +59 -0
- data/examples/strict.rb +18 -0
- data/exe/flipper +5 -0
- data/flipper-cloud.gemspec +19 -0
- data/flipper.gemspec +10 -6
- data/lib/flipper/actor.rb +6 -3
- data/lib/flipper/adapter.rb +33 -7
- data/lib/flipper/adapter_builder.rb +44 -0
- data/lib/flipper/adapters/actor_limit.rb +28 -0
- data/lib/flipper/adapters/cache_base.rb +143 -0
- data/lib/flipper/adapters/dual_write.rb +1 -3
- data/lib/flipper/adapters/failover.rb +0 -4
- data/lib/flipper/adapters/failsafe.rb +72 -0
- data/lib/flipper/adapters/http/client.rb +44 -20
- data/lib/flipper/adapters/http/error.rb +1 -1
- data/lib/flipper/adapters/http.rb +31 -16
- data/lib/flipper/adapters/instrumented.rb +25 -6
- data/lib/flipper/adapters/memoizable.rb +33 -21
- data/lib/flipper/adapters/memory.rb +81 -46
- data/lib/flipper/adapters/operation_logger.rb +17 -78
- data/lib/flipper/adapters/poll/poller.rb +2 -0
- data/lib/flipper/adapters/poll.rb +37 -0
- data/lib/flipper/adapters/pstore.rb +17 -11
- data/lib/flipper/adapters/read_only.rb +8 -41
- data/lib/flipper/adapters/strict.rb +45 -0
- data/lib/flipper/adapters/sync/feature_synchronizer.rb +10 -1
- data/lib/flipper/adapters/sync.rb +0 -4
- data/lib/flipper/adapters/wrapper.rb +54 -0
- data/lib/flipper/cli.rb +263 -0
- data/lib/flipper/cloud/configuration.rb +263 -0
- data/lib/flipper/cloud/dsl.rb +27 -0
- data/lib/flipper/cloud/message_verifier.rb +95 -0
- data/lib/flipper/cloud/middleware.rb +63 -0
- data/lib/flipper/cloud/routes.rb +14 -0
- data/lib/flipper/cloud/telemetry/backoff_policy.rb +93 -0
- data/lib/flipper/cloud/telemetry/instrumenter.rb +22 -0
- data/lib/flipper/cloud/telemetry/metric.rb +39 -0
- data/lib/flipper/cloud/telemetry/metric_storage.rb +30 -0
- data/lib/flipper/cloud/telemetry/submitter.rb +98 -0
- data/lib/flipper/cloud/telemetry.rb +191 -0
- data/lib/flipper/cloud.rb +53 -0
- data/lib/flipper/configuration.rb +25 -4
- data/lib/flipper/dsl.rb +46 -45
- data/lib/flipper/engine.rb +102 -0
- data/lib/flipper/errors.rb +3 -20
- data/lib/flipper/export.rb +26 -0
- data/lib/flipper/exporter.rb +17 -0
- data/lib/flipper/exporters/json/export.rb +32 -0
- data/lib/flipper/exporters/json/v1.rb +33 -0
- data/lib/flipper/expression/builder.rb +73 -0
- data/lib/flipper/expression/constant.rb +25 -0
- data/lib/flipper/expression.rb +71 -0
- data/lib/flipper/expressions/all.rb +11 -0
- data/lib/flipper/expressions/any.rb +9 -0
- data/lib/flipper/expressions/boolean.rb +9 -0
- data/lib/flipper/expressions/comparable.rb +13 -0
- data/lib/flipper/expressions/duration.rb +28 -0
- data/lib/flipper/expressions/equal.rb +9 -0
- data/lib/flipper/expressions/greater_than.rb +9 -0
- data/lib/flipper/expressions/greater_than_or_equal_to.rb +9 -0
- data/lib/flipper/expressions/less_than.rb +9 -0
- data/lib/flipper/expressions/less_than_or_equal_to.rb +9 -0
- data/lib/flipper/expressions/not_equal.rb +9 -0
- data/lib/flipper/expressions/now.rb +9 -0
- data/lib/flipper/expressions/number.rb +9 -0
- data/lib/flipper/expressions/percentage.rb +9 -0
- data/lib/flipper/expressions/percentage_of_actors.rb +12 -0
- data/lib/flipper/expressions/property.rb +9 -0
- data/lib/flipper/expressions/random.rb +9 -0
- data/lib/flipper/expressions/string.rb +9 -0
- data/lib/flipper/expressions/time.rb +9 -0
- data/lib/flipper/feature.rb +87 -26
- data/lib/flipper/feature_check_context.rb +10 -6
- data/lib/flipper/gate.rb +13 -11
- data/lib/flipper/gate_values.rb +5 -18
- data/lib/flipper/gates/actor.rb +10 -17
- data/lib/flipper/gates/boolean.rb +1 -1
- data/lib/flipper/gates/expression.rb +75 -0
- data/lib/flipper/gates/group.rb +5 -7
- data/lib/flipper/gates/percentage_of_actors.rb +10 -13
- data/lib/flipper/gates/percentage_of_time.rb +1 -2
- data/lib/flipper/identifier.rb +2 -2
- data/lib/flipper/instrumentation/log_subscriber.rb +34 -6
- data/lib/flipper/instrumentation/statsd_subscriber.rb +2 -4
- data/lib/flipper/instrumentation/subscriber.rb +8 -1
- data/lib/flipper/metadata.rb +7 -1
- data/lib/flipper/middleware/memoizer.rb +28 -22
- data/lib/flipper/model/active_record.rb +23 -0
- data/lib/flipper/poller.rb +118 -0
- data/lib/flipper/serializers/gzip.rb +22 -0
- data/lib/flipper/serializers/json.rb +17 -0
- data/lib/flipper/spec/shared_adapter_specs.rb +105 -63
- data/lib/flipper/test/shared_adapter_test.rb +101 -58
- data/lib/flipper/test_help.rb +43 -0
- data/lib/flipper/typecast.rb +59 -18
- data/lib/flipper/types/actor.rb +13 -13
- data/lib/flipper/types/group.rb +4 -4
- data/lib/flipper/types/percentage.rb +1 -1
- data/lib/flipper/version.rb +11 -1
- data/lib/flipper.rb +50 -11
- data/lib/generators/flipper/setup_generator.rb +63 -0
- data/lib/generators/flipper/templates/update/migrations/01_create_flipper_tables.rb.erb +22 -0
- data/lib/generators/flipper/templates/update/migrations/02_change_flipper_gates_value_to_text.rb.erb +18 -0
- data/lib/generators/flipper/update_generator.rb +35 -0
- data/package-lock.json +41 -0
- data/package.json +10 -0
- data/spec/fixtures/environment.rb +1 -0
- data/spec/fixtures/flipper_pstore_1679087600.json +46 -0
- data/spec/flipper/adapter_builder_spec.rb +72 -0
- data/spec/flipper/adapter_spec.rb +30 -2
- data/spec/flipper/adapters/actor_limit_spec.rb +20 -0
- data/spec/flipper/adapters/dual_write_spec.rb +2 -2
- data/spec/flipper/adapters/failsafe_spec.rb +58 -0
- data/spec/flipper/adapters/http/client_spec.rb +61 -0
- data/spec/flipper/adapters/http_spec.rb +137 -55
- data/spec/flipper/adapters/instrumented_spec.rb +29 -11
- data/spec/flipper/adapters/memoizable_spec.rb +51 -31
- data/spec/flipper/adapters/memory_spec.rb +14 -3
- data/spec/flipper/adapters/operation_logger_spec.rb +31 -12
- data/spec/flipper/adapters/read_only_spec.rb +32 -17
- data/spec/flipper/adapters/strict_spec.rb +64 -0
- data/spec/flipper/adapters/sync/feature_synchronizer_spec.rb +27 -0
- data/spec/flipper/cli_spec.rb +164 -0
- data/spec/flipper/cloud/configuration_spec.rb +251 -0
- data/spec/flipper/cloud/dsl_spec.rb +82 -0
- data/spec/flipper/cloud/message_verifier_spec.rb +104 -0
- data/spec/flipper/cloud/middleware_spec.rb +289 -0
- data/spec/flipper/cloud/telemetry/backoff_policy_spec.rb +107 -0
- data/spec/flipper/cloud/telemetry/metric_spec.rb +87 -0
- data/spec/flipper/cloud/telemetry/metric_storage_spec.rb +58 -0
- data/spec/flipper/cloud/telemetry/submitter_spec.rb +145 -0
- data/spec/flipper/cloud/telemetry_spec.rb +208 -0
- data/spec/flipper/cloud_spec.rb +181 -0
- data/spec/flipper/configuration_spec.rb +17 -0
- data/spec/flipper/dsl_spec.rb +54 -73
- data/spec/flipper/engine_spec.rb +373 -0
- data/spec/flipper/export_spec.rb +13 -0
- data/spec/flipper/exporter_spec.rb +16 -0
- data/spec/flipper/exporters/json/export_spec.rb +60 -0
- data/spec/flipper/exporters/json/v1_spec.rb +33 -0
- data/spec/flipper/expression/builder_spec.rb +248 -0
- data/spec/flipper/expression_spec.rb +188 -0
- data/spec/flipper/expressions/all_spec.rb +15 -0
- data/spec/flipper/expressions/any_spec.rb +15 -0
- data/spec/flipper/expressions/boolean_spec.rb +15 -0
- data/spec/flipper/expressions/duration_spec.rb +43 -0
- data/spec/flipper/expressions/equal_spec.rb +24 -0
- data/spec/flipper/expressions/greater_than_or_equal_to_spec.rb +28 -0
- data/spec/flipper/expressions/greater_than_spec.rb +28 -0
- data/spec/flipper/expressions/less_than_or_equal_to_spec.rb +28 -0
- data/spec/flipper/expressions/less_than_spec.rb +32 -0
- data/spec/flipper/expressions/not_equal_spec.rb +15 -0
- data/spec/flipper/expressions/now_spec.rb +11 -0
- data/spec/flipper/expressions/number_spec.rb +21 -0
- data/spec/flipper/expressions/percentage_of_actors_spec.rb +20 -0
- data/spec/flipper/expressions/percentage_spec.rb +15 -0
- data/spec/flipper/expressions/property_spec.rb +13 -0
- data/spec/flipper/expressions/random_spec.rb +9 -0
- data/spec/flipper/expressions/string_spec.rb +11 -0
- data/spec/flipper/expressions/time_spec.rb +13 -0
- data/spec/flipper/feature_check_context_spec.rb +17 -17
- data/spec/flipper/feature_spec.rb +436 -33
- data/spec/flipper/gate_values_spec.rb +2 -33
- data/spec/flipper/gates/boolean_spec.rb +1 -1
- data/spec/flipper/gates/expression_spec.rb +108 -0
- data/spec/flipper/gates/group_spec.rb +2 -3
- data/spec/flipper/gates/percentage_of_actors_spec.rb +61 -5
- data/spec/flipper/gates/percentage_of_time_spec.rb +2 -2
- data/spec/flipper/identifier_spec.rb +4 -5
- data/spec/flipper/instrumentation/log_subscriber_spec.rb +23 -6
- data/spec/flipper/instrumentation/statsd_subscriber_spec.rb +25 -1
- data/spec/flipper/middleware/memoizer_spec.rb +74 -24
- data/spec/flipper/model/active_record_spec.rb +61 -0
- data/spec/flipper/poller_spec.rb +47 -0
- data/spec/flipper/serializers/gzip_spec.rb +13 -0
- data/spec/flipper/serializers/json_spec.rb +13 -0
- data/spec/flipper/typecast_spec.rb +121 -6
- data/spec/flipper/types/actor_spec.rb +63 -46
- data/spec/flipper/types/group_spec.rb +2 -2
- data/spec/flipper_integration_spec.rb +168 -58
- data/spec/flipper_spec.rb +93 -29
- data/spec/spec_helper.rb +8 -14
- data/spec/support/actor_names.yml +1 -0
- data/spec/support/fail_on_output.rb +8 -0
- data/spec/support/fake_backoff_policy.rb +15 -0
- data/spec/support/skippable.rb +18 -0
- data/spec/support/spec_helpers.rb +23 -8
- data/test/adapters/actor_limit_test.rb +20 -0
- data/test_rails/generators/flipper/setup_generator_test.rb +64 -0
- data/test_rails/generators/flipper/update_generator_test.rb +96 -0
- data/test_rails/helper.rb +19 -2
- data/test_rails/system/test_help_test.rb +51 -0
- metadata +223 -19
- data/lib/flipper/railtie.rb +0 -47
- data/spec/flipper/railtie_spec.rb +0 -73
@@ -65,9 +65,9 @@ RSpec.describe Flipper::Typecast do
|
|
65
65
|
'99' => 99,
|
66
66
|
'99.9' => 99.9,
|
67
67
|
}.each do |value, expected|
|
68
|
-
context "#
|
68
|
+
context "#to_number for #{value.inspect}" do
|
69
69
|
it "returns #{expected}" do
|
70
|
-
expect(described_class.
|
70
|
+
expect(described_class.to_number(value)).to be(expected)
|
71
71
|
end
|
72
72
|
end
|
73
73
|
end
|
@@ -99,14 +99,14 @@ RSpec.describe Flipper::Typecast do
|
|
99
99
|
|
100
100
|
it 'raises argument error for bad integer percentage' do
|
101
101
|
expect do
|
102
|
-
described_class.
|
103
|
-
end.to raise_error(ArgumentError, %(["asdf"] cannot be converted to
|
102
|
+
described_class.to_number(['asdf'])
|
103
|
+
end.to raise_error(ArgumentError, %(["asdf"] cannot be converted to a number))
|
104
104
|
end
|
105
105
|
|
106
106
|
it 'raises argument error for bad float percentage' do
|
107
107
|
expect do
|
108
|
-
described_class.
|
109
|
-
end.to raise_error(ArgumentError, %(["asdf.0"] cannot be converted to a
|
108
|
+
described_class.to_number(['asdf.0'])
|
109
|
+
end.to raise_error(ArgumentError, %(["asdf.0"] cannot be converted to a number))
|
110
110
|
end
|
111
111
|
|
112
112
|
it 'raises argument error for set value that cannot be converted to a set' do
|
@@ -114,4 +114,119 @@ RSpec.describe Flipper::Typecast do
|
|
114
114
|
described_class.to_set('asdf')
|
115
115
|
end.to raise_error(ArgumentError, %("asdf" cannot be converted to a set))
|
116
116
|
end
|
117
|
+
|
118
|
+
describe "#features_hash" do
|
119
|
+
it "returns new hash" do
|
120
|
+
hash = {
|
121
|
+
"search" => {
|
122
|
+
boolean: nil,
|
123
|
+
}
|
124
|
+
}
|
125
|
+
result = described_class.features_hash(hash)
|
126
|
+
expect(result).not_to be(hash)
|
127
|
+
expect(result["search"]).not_to be(hash["search"])
|
128
|
+
end
|
129
|
+
|
130
|
+
it "converts does not convert expressions" do
|
131
|
+
hash = {
|
132
|
+
"search" => {
|
133
|
+
boolean: nil,
|
134
|
+
expression: {"Equal"=>[{"Property"=>["plan"]}, "basic"]},
|
135
|
+
groups: ['a', 'b'],
|
136
|
+
actors: ['User;1'],
|
137
|
+
percentage_of_actors: nil,
|
138
|
+
percentage_of_time: nil,
|
139
|
+
},
|
140
|
+
}
|
141
|
+
result = described_class.features_hash(hash)
|
142
|
+
expect(result).to eq({
|
143
|
+
"search" => {
|
144
|
+
boolean: nil,
|
145
|
+
expression: {"Equal"=>[{"Property"=>["plan"]}, "basic"]},
|
146
|
+
groups: Set['a', 'b'],
|
147
|
+
actors: Set['User;1'],
|
148
|
+
percentage_of_actors: nil,
|
149
|
+
percentage_of_time: nil,
|
150
|
+
},
|
151
|
+
})
|
152
|
+
end
|
153
|
+
|
154
|
+
it "converts gate value arrays to sets" do
|
155
|
+
hash = {
|
156
|
+
"search" => {
|
157
|
+
boolean: nil,
|
158
|
+
groups: ['a', 'b'],
|
159
|
+
actors: ['User;1'],
|
160
|
+
percentage_of_actors: nil,
|
161
|
+
percentage_of_time: nil,
|
162
|
+
},
|
163
|
+
}
|
164
|
+
result = described_class.features_hash(hash)
|
165
|
+
expect(result).to eq({
|
166
|
+
"search" => {
|
167
|
+
boolean: nil,
|
168
|
+
groups: Set['a', 'b'],
|
169
|
+
actors: Set['User;1'],
|
170
|
+
percentage_of_actors: nil,
|
171
|
+
percentage_of_time: nil,
|
172
|
+
},
|
173
|
+
})
|
174
|
+
end
|
175
|
+
|
176
|
+
it "converts gate value boolean and integers to strings" do
|
177
|
+
hash = {
|
178
|
+
"search" => {
|
179
|
+
boolean: true,
|
180
|
+
groups: Set.new,
|
181
|
+
actors: Set.new,
|
182
|
+
percentage_of_actors: 10,
|
183
|
+
percentage_of_time: 15,
|
184
|
+
},
|
185
|
+
}
|
186
|
+
result = described_class.features_hash(hash)
|
187
|
+
expect(result).to eq({
|
188
|
+
"search" => {
|
189
|
+
boolean: "true",
|
190
|
+
groups: Set.new,
|
191
|
+
actors: Set.new,
|
192
|
+
percentage_of_actors: "10",
|
193
|
+
percentage_of_time: "15",
|
194
|
+
},
|
195
|
+
})
|
196
|
+
end
|
197
|
+
|
198
|
+
it "converts string gate keys to symbols" do
|
199
|
+
hash = {
|
200
|
+
"search" => {
|
201
|
+
"boolean" => nil,
|
202
|
+
"groups" => Set.new,
|
203
|
+
"actors" => Set.new,
|
204
|
+
"percentage_of_actors" => nil,
|
205
|
+
"percentage_of_time" => nil,
|
206
|
+
},
|
207
|
+
}
|
208
|
+
result = described_class.features_hash(hash)
|
209
|
+
expect(result).to eq({
|
210
|
+
"search" => {
|
211
|
+
boolean: nil,
|
212
|
+
groups: Set.new,
|
213
|
+
actors: Set.new,
|
214
|
+
percentage_of_actors: nil,
|
215
|
+
percentage_of_time: nil,
|
216
|
+
},
|
217
|
+
})
|
218
|
+
end
|
219
|
+
end
|
220
|
+
|
221
|
+
it "converts to and from json" do
|
222
|
+
source = {"foo" => "bar"}
|
223
|
+
output = described_class.to_json(source)
|
224
|
+
expect(described_class.from_json(output)).to eq(source)
|
225
|
+
end
|
226
|
+
|
227
|
+
it "converts to and from gzip" do
|
228
|
+
source = "foo bar"
|
229
|
+
output = described_class.to_gzip(source)
|
230
|
+
expect(described_class.from_gzip(output)).to eq(source)
|
231
|
+
end
|
117
232
|
end
|
@@ -2,34 +2,41 @@ require 'flipper/types/actor'
|
|
2
2
|
|
3
3
|
RSpec.describe Flipper::Types::Actor do
|
4
4
|
subject do
|
5
|
-
|
6
|
-
described_class.new(
|
5
|
+
actor = actor_class.new('2')
|
6
|
+
described_class.new(actor)
|
7
7
|
end
|
8
8
|
|
9
|
-
let(:
|
9
|
+
let(:actor_class) do
|
10
10
|
Class.new do
|
11
11
|
attr_reader :flipper_id
|
12
12
|
|
13
13
|
def initialize(flipper_id)
|
14
|
-
@flipper_id = flipper_id
|
14
|
+
@flipper_id = flipper_id.to_s
|
15
15
|
end
|
16
16
|
|
17
17
|
def admin?
|
18
18
|
true
|
19
19
|
end
|
20
|
+
|
21
|
+
def flipper_properties
|
22
|
+
{
|
23
|
+
"flipper_id" => flipper_id,
|
24
|
+
"admin" => admin?,
|
25
|
+
}
|
26
|
+
end
|
20
27
|
end
|
21
28
|
end
|
22
29
|
|
23
30
|
describe '.wrappable?' do
|
24
31
|
it 'returns true if actor' do
|
25
|
-
|
26
|
-
|
27
|
-
expect(described_class.wrappable?(
|
32
|
+
actor = actor_class.new('1')
|
33
|
+
actor_type_instance = described_class.new(actor)
|
34
|
+
expect(described_class.wrappable?(actor_type_instance)).to eq(true)
|
28
35
|
end
|
29
36
|
|
30
37
|
it 'returns true if responds to flipper_id' do
|
31
|
-
|
32
|
-
expect(described_class.wrappable?(
|
38
|
+
actor = actor_class.new(10)
|
39
|
+
expect(described_class.wrappable?(actor)).to eq(true)
|
33
40
|
end
|
34
41
|
|
35
42
|
it 'returns false if nil' do
|
@@ -38,27 +45,27 @@ RSpec.describe Flipper::Types::Actor do
|
|
38
45
|
end
|
39
46
|
|
40
47
|
describe '.wrap' do
|
41
|
-
context 'for actor' do
|
42
|
-
it 'returns actor' do
|
43
|
-
|
44
|
-
expect(
|
45
|
-
expect(
|
48
|
+
context 'for actor type instance' do
|
49
|
+
it 'returns actor type instance' do
|
50
|
+
actor_type_instance = described_class.wrap(subject)
|
51
|
+
expect(actor_type_instance).to be_instance_of(described_class)
|
52
|
+
expect(actor_type_instance).to be(subject)
|
46
53
|
end
|
47
54
|
end
|
48
55
|
|
49
|
-
context 'for other
|
50
|
-
it 'returns actor' do
|
51
|
-
|
52
|
-
|
53
|
-
expect(
|
56
|
+
context 'for other object' do
|
57
|
+
it 'returns actor type instance' do
|
58
|
+
actor = actor_class.new('1')
|
59
|
+
actor_type_instance = described_class.wrap(actor)
|
60
|
+
expect(actor_type_instance).to be_instance_of(described_class)
|
54
61
|
end
|
55
62
|
end
|
56
63
|
end
|
57
64
|
|
58
|
-
it 'initializes with
|
59
|
-
|
60
|
-
|
61
|
-
expect(
|
65
|
+
it 'initializes with object that responds to flipper_id' do
|
66
|
+
actor = actor_class.new('1')
|
67
|
+
actor_type_instance = described_class.new(actor)
|
68
|
+
expect(actor_type_instance.value).to eq('1')
|
62
69
|
end
|
63
70
|
|
64
71
|
it 'raises error when initialized with nil' do
|
@@ -68,48 +75,58 @@ RSpec.describe Flipper::Types::Actor do
|
|
68
75
|
end
|
69
76
|
|
70
77
|
it 'raises error when initalized with non-wrappable object' do
|
71
|
-
|
78
|
+
unwrappable_object = Struct.new(:id).new(1)
|
72
79
|
expect do
|
73
|
-
described_class.new(
|
80
|
+
described_class.new(unwrappable_object)
|
74
81
|
end.to raise_error(ArgumentError,
|
75
|
-
"#{
|
82
|
+
"#{unwrappable_object.inspect} must respond to flipper_id, but does not")
|
76
83
|
end
|
77
84
|
|
78
85
|
it 'converts id to string' do
|
79
|
-
|
80
|
-
actor = described_class.new(
|
86
|
+
actor = actor_class.new(2)
|
87
|
+
actor = described_class.new(actor)
|
81
88
|
expect(actor.value).to eq('2')
|
82
89
|
end
|
83
90
|
|
84
|
-
it 'proxies everything to
|
85
|
-
|
86
|
-
actor = described_class.new(
|
91
|
+
it 'proxies everything to actor' do
|
92
|
+
actor = actor_class.new(10)
|
93
|
+
actor = described_class.new(actor)
|
87
94
|
expect(actor.admin?).to eq(true)
|
88
95
|
end
|
89
96
|
|
90
|
-
it '
|
91
|
-
|
92
|
-
actor = described_class.new(
|
93
|
-
expect(actor.
|
97
|
+
it 'proxies flipper_properties to actor' do
|
98
|
+
actor = actor_class.new(10)
|
99
|
+
actor = described_class.new(actor)
|
100
|
+
expect(actor.flipper_properties).to eq({
|
101
|
+
"flipper_id" => "10",
|
102
|
+
"admin" => true,
|
103
|
+
})
|
104
|
+
end
|
105
|
+
|
106
|
+
it 'exposes actor' do
|
107
|
+
actor = actor_class.new(10)
|
108
|
+
actor_type_instance = described_class.new(actor)
|
109
|
+
expect(actor_type_instance.actor).to be(actor)
|
94
110
|
end
|
95
111
|
|
96
112
|
describe '#respond_to?' do
|
97
113
|
it 'returns true if responds to method' do
|
98
|
-
|
99
|
-
|
100
|
-
expect(
|
114
|
+
actor = actor_class.new('1')
|
115
|
+
actor_type_instance = described_class.new(actor)
|
116
|
+
expect(actor_type_instance.respond_to?(:value)).to eq(true)
|
101
117
|
end
|
102
118
|
|
103
|
-
it 'returns true if
|
104
|
-
|
105
|
-
|
106
|
-
expect(
|
119
|
+
it 'returns true if actor responds to method' do
|
120
|
+
actor = actor_class.new(10)
|
121
|
+
actor_type_instance = described_class.new(actor)
|
122
|
+
expect(actor_type_instance.respond_to?(:admin?)).to eq(true)
|
123
|
+
expect(actor_type_instance.respond_to?(:flipper_properties)).to eq(true)
|
107
124
|
end
|
108
125
|
|
109
|
-
it 'returns false if does not respond to method and
|
110
|
-
|
111
|
-
|
112
|
-
expect(
|
126
|
+
it 'returns false if does not respond to method and actor does not respond to method' do
|
127
|
+
actor = actor_class.new(10)
|
128
|
+
actor_type_instance = described_class.new(actor)
|
129
|
+
expect(actor_type_instance.respond_to?(:frankenstein)).to eq(false)
|
113
130
|
end
|
114
131
|
end
|
115
132
|
end
|
@@ -90,7 +90,7 @@ RSpec.describe Flipper::Types::Group do
|
|
90
90
|
context = Flipper::FeatureCheckContext.new(
|
91
91
|
feature_name: :my_feature,
|
92
92
|
values: Flipper::GateValues.new({}),
|
93
|
-
|
93
|
+
actors: [Flipper::Types::Actor.new(Flipper::Actor.new('1'))]
|
94
94
|
)
|
95
95
|
group = Flipper.register(:group_with_context) { |actor| actor }
|
96
96
|
yielded_actor = group.match?(admin_actor, context)
|
@@ -101,7 +101,7 @@ RSpec.describe Flipper::Types::Group do
|
|
101
101
|
context = Flipper::FeatureCheckContext.new(
|
102
102
|
feature_name: :my_feature,
|
103
103
|
values: Flipper::GateValues.new({}),
|
104
|
-
|
104
|
+
actors: [Flipper::Types::Actor.new(Flipper::Actor.new('1'))]
|
105
105
|
)
|
106
106
|
group = Flipper.register(:group_with_context) { |actor, context| [actor, context] }
|
107
107
|
yielded_actor, yielded_context = group.match?(admin_actor, context)
|