flipper 0.20.2 → 0.20.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: df90e63870767caa4d32363658e4515d0822a1453cc3a5325d7dbf932c326b59
-  data.tar.gz: 125256e9cdee5bd0e2bfe065203140eb7fa015cac56043711c7eb45bd5421aa8
+  metadata.gz: 6fcb4dd7f20ac1164f7c3add8fc0bee2480926618b312dbb207375a9be171bf7
+  data.tar.gz: a81b1fb51952ab430d26ca52975dad38122643198b8ef1a874f8fe3c2cbaf0fa
 SHA512:
-  metadata.gz: 9598a0a2f62b5c160a8a7c81b50ed9d2bd06f6e70898037c8321f9060780875347552b66919c62b5deb40647f734efa6bef1382b0e9fb1caefe2c8f4b5eaec01
-  data.tar.gz: 8bb413f54398cf90e9aafc7feba144a2e15343e8a75e28ca197d52505ae4771659b3fc7bfafec899388e71c76832859396d86fa52438ba22327f6b6522ade3a5
+  metadata.gz: 2bf630be6690b4570443cefd44ac81ab801522e5b1be35f2357c45fa85c7503f1feb99abd4e01749d0fef1b1c941d53f91f0fc97ab38994a0c453533a00f7183
+  data.tar.gz: 536bad899391a69ac8380933fe151a1ede241e0ffaa43992cc42367394ad7f0adf51d8434740e9db31cd4c1fdc61debd5d0a5c7188a4f21a71aee4a27d31f5ac

data/Changelog.md

@@ -1,3 +1,9 @@
+## 0.20.3
+
+### Additions/Changes
+
+* Changed the internal structure of how the memory adapter stores things.
+
 ## 0.20.2
 
 ### Additions/Changes

data/lib/flipper/adapters/memory.rb

@@ -20,58 +20,57 @@ module Flipper
 
       # Public: The set of known features.
       def features
-        read_feature_keys
+        @source.keys.to_set
       end
 
       # Public: Adds a feature to the set of known features.
       def add(feature)
-        features.add(feature.key)
+        @source[feature.key] ||= default_config
         true
       end
 
       # Public: Removes a feature from the set of known features and clears
       # all the values for the feature.
       def remove(feature)
-        features.delete(feature.name.to_s)
-        clear(feature)
+        @source.delete(feature.key)
         true
       end
 
       # Public: Clears all the gate values for a feature.
       def clear(feature)
-        feature.gates.each do |gate|
-          delete key(feature, gate)
-        end
+        @source[feature.key] = default_config
         true
       end
 
       # Public
       def get(feature)
-        read_feature(feature)
+        @source[feature.key] || default_config
       end
 
       def get_multi(features)
-        read_many_features(features)
+        result = {}
+        features.each do |feature|
+          result[feature.key] = @source[feature.key] || default_config
+        end
+        result
       end
 
       def get_all
-        features = read_feature_keys.map do |key|
-          Flipper::Feature.new(key, self)
-        end
-
-        read_many_features(features)
+        @source
       end
 
       # Public
       def enable(feature, gate, thing)
+        @source[feature.key] ||= default_config
+
         case gate.data_type
         when :boolean
           clear(feature)
-          write key(feature, gate), thing.value.to_s
+          @source[feature.key][gate.key] = thing.value.to_s
         when :integer
-          write key(feature, gate), thing.value.to_s
+          @source[feature.key][gate.key] = thing.value.to_s
         when :set
-          set_add key(feature, gate), thing.value.to_s
+          @source[feature.key][gate.key] << thing.value.to_s
         else
           raise "#{gate} is not supported by this adapter yet"
         end
@@ -81,13 +80,15 @@ module Flipper
 
       # Public
       def disable(feature, gate, thing)
+        @source[feature.key] ||= default_config
+
         case gate.data_type
         when :boolean
           clear(feature)
         when :integer
-          write key(feature, gate), thing.value.to_s
+          @source[feature.key][gate.key] = thing.value.to_s
         when :set
-          set_delete key(feature, gate), thing.value.to_s
+          @source[feature.key][gate.key].delete thing.value.to_s
         else
           raise "#{gate} is not supported by this adapter yet"
         end
@@ -103,81 +104,6 @@ module Flipper
         ]
         "#<#{self.class.name}:#{object_id} #{attributes.join(', ')}>"
       end
-
-      private
-
-      def read_feature_keys
-        set_members(FeaturesKey)
-      end
-
-      # Private
-      def key(feature, gate)
-        "feature/#{feature.key}/#{gate.key}"
-      end
-
-      def read_many_features(features)
-        result = {}
-        features.each do |feature|
-          result[feature.key] = read_feature(feature)
-        end
-        result
-      end
-
-      def read_feature(feature)
-        result = {}
-
-        feature.gates.each do |gate|
-          result[gate.key] =
-            case gate.data_type
-            when :boolean, :integer
-              read key(feature, gate)
-            when :set
-              set_members key(feature, gate)
-            else
-              raise "#{gate} is not supported by this adapter yet"
-            end
-        end
-
-        result
-      end
-
-      # Private
-      def read(key)
-        @source[key.to_s]
-      end
-
-      # Private
-      def write(key, value)
-        @source[key.to_s] = value.to_s
-      end
-
-      # Private
-      def delete(key)
-        @source.delete(key.to_s)
-      end
-
-      # Private
-      def set_add(key, value)
-        ensure_set_initialized(key)
-        @source[key.to_s].add(value.to_s)
-      end
-
-      # Private
-      def set_delete(key, value)
-        ensure_set_initialized(key)
-        @source[key.to_s].delete(value.to_s)
-      end
-
-      # Private
-      def set_members(key)
-        ensure_set_initialized(key)
-        @source[key.to_s]
-      end
-
-      # Private
-      def ensure_set_initialized(key)
-        @source[key.to_s] ||= Set.new
-      end
     end
   end
 end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.20.2'.freeze
+  VERSION = '0.20.3'.freeze
 end

data/spec/flipper/adapters/memory_spec.rb

@@ -2,7 +2,27 @@ require 'helper'
 require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::Memory do
-  subject { described_class.new }
+  let(:source) { {} }
+  subject { described_class.new(source) }
 
   it_should_behave_like 'a flipper adapter'
+
+  it "can initialize from big hash" do
+    flipper = Flipper.new(subject)
+    flipper.enable :subscriptions
+    flipper.disable :search
+    flipper.enable_percentage_of_actors :pro_deal, 20
+    flipper.enable_percentage_of_time :logging, 30
+    flipper.enable_actor :following, Flipper::Actor.new('1')
+    flipper.enable_actor :following, Flipper::Actor.new('3')
+    flipper.enable_group :following, Flipper::Types::Group.new(:staff)
+
+    expect(source).to eq({
+      "subscriptions" => subject.default_config.merge(boolean: "true"),
+      "search" => subject.default_config,
+      "logging" => subject.default_config.merge(:percentage_of_time => "30"),
+      "pro_deal" => subject.default_config.merge(:percentage_of_actors => "20"),
+      "following" => subject.default_config.merge(actors: Set["1", "3"], groups: Set["staff"]),
+    })
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.20.2
+  version: 0.20.3
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-08 00:00:00.000000000 Z
+date: 2021-01-10 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: