flipper 0.20.1 → 0.21.0.rc2

data/spec/flipper/middleware/setup_env_spec.rb

@@ -93,20 +93,4 @@ RSpec.describe Flipper::Middleware::SetupEnv do
       expect(last_response.body).to eq(Flipper.object_id.to_s)
     end
   end
-
-  context 'when flipper instance or block are nil and default Flipper is NOT configured' do
-    let(:app) do
-      app = lambda do |env|
-        [200, { 'Content-Type' => 'text/html' }, [env['flipper'].enabled?(:search)]]
-      end
-      builder = Rack::Builder.new
-      builder.use described_class
-      builder.run app
-      builder
-    end
-
-    it 'can use env flipper' do
-      expect { get '/' }.to raise_error(Flipper::DefaultNotSet)
-    end
-  end
 end

data/spec/flipper/railtie_spec.rb

@@ -0,0 +1,69 @@
+require 'helper'
+require 'rails'
+require 'flipper/railtie'
+
+RSpec.describe Flipper::Railtie do
+  let(:application) do
+    app = Class.new(Rails::Application).new(
+      railties: [Flipper::Railtie],
+      ordered_railties: [Flipper::Railtie]
+    )
+    app.config.eager_load = false
+    app.config.logger = ActiveSupport::Logger.new($stdout)
+    app.run_load_hooks!
+  end
+
+  before do
+    Rails.application = nil
+  end
+
+  subject do
+    application.initialize!
+    application
+  end
+
+  describe 'initializers' do
+    it 'sets defaults' do
+      expect(application.config.flipper.env_key).to eq("flipper")
+      expect(application.config.flipper.memoize).to be(true)
+      expect(application.config.flipper.preload).to be(true)
+    end
+
+    it "configures instrumentor on default instance" do
+      subject
+
+      expect(Flipper.instance.instrumenter).to eq(ActiveSupport::Notifications)
+    end
+
+    it 'uses Memoizer middleware if config.memoize = true' do
+      expect(subject.middleware.last).to eq(Flipper::Middleware::Memoizer)
+    end
+
+    it 'does not use Memoizer middleware if config.memoize = false' do
+      # load but don't initialize
+      application.config.flipper.memoize = false
+
+      expect(subject.middleware.last).not_to eq(Flipper::Middleware::Memoizer)
+    end
+
+    it 'passes config to memoizer' do
+      # load but don't initialize
+      application.config.flipper.update(
+        env_key: 'my_flipper',
+        preload: [:stats, :search]
+      )
+
+      expect(Flipper::Middleware::Memoizer).to receive(:new).with(application.routes,
+        env_key: 'my_flipper', preload: [:stats, :search], if: nil
+      )
+
+      subject # initialize
+    end
+
+    it "defines #flipper_id on AR::Base" do
+      subject
+      require 'active_record'
+      expect(ActiveRecord::Base.ancestors).to include(Flipper::Identifier)
+    end
+  end
+end

data/spec/flipper_spec.rb

@@ -232,7 +232,6 @@ RSpec.describe Flipper do
       cloud_configuration = Flipper::Cloud::Configuration.new({
         token: "asdf",
         sync_secret: "tasty",
-        sync_method: :webhook,
       })
 
       described_class.configure do |config|

data/spec/support/spec_helpers.rb

@@ -61,9 +61,29 @@ module SpecHelpers
   def with_modified_env(options, &block)
     ClimateControl.modify(options, &block)
   end
+
+  def silence
+    # Store the original stderr and stdout in order to restore them later
+    original_stderr = $stderr
+    original_stdout = $stdout
+
+    # Redirect stderr and stdout
+    output = $stderr = $stdout = StringIO.new
+
+    yield
+
+    $stderr = original_stderr
+    $stdout = original_stdout
+
+    # Return output
+    output.string
+  end
 end
 
 RSpec.configure do |config|
+  config.order = :random
+  Kernel.srand config.seed
+
   config.include Rack::Test::Methods
   config.include SpecHelpers
 end

data/test/test_helper.rb

@@ -1,3 +1,4 @@
+require 'bundler/setup'
 require 'flipper'
 require 'minitest/autorun'
 require 'minitest/unit'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.20.1
+  version: 0.21.0.rc2
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-31 00:00:00.000000000 Z
+date: 2021-05-08 00:00:00.000000000 Z
 dependencies: []
 description: 
 email:
@@ -18,6 +18,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".github/workflows/ci.yml"
 - CODE_OF_CONDUCT.md
 - Changelog.md
 - Dockerfile
@@ -34,12 +35,12 @@ files:
 - docs/Optimization.md
 - docs/api/README.md
 - docs/http/README.md
+- docs/images/banner.jpg
 - docs/read-only/README.md
 - examples/basic.rb
 - examples/configuring_default.rb
 - examples/dsl.rb
 - examples/enabled_for_actor.rb
-- examples/example_setup.rb
 - examples/group.rb
 - examples/group_dynamic_lookup.rb
 - examples/group_with_members.rb
@@ -81,6 +82,7 @@ files:
 - lib/flipper/gates/group.rb
 - lib/flipper/gates/percentage_of_actors.rb
 - lib/flipper/gates/percentage_of_time.rb
+- lib/flipper/identifier.rb
 - lib/flipper/instrumentation/log_subscriber.rb
 - lib/flipper/instrumentation/statsd.rb
 - lib/flipper/instrumentation/statsd_subscriber.rb
@@ -90,6 +92,7 @@ files:
 - lib/flipper/metadata.rb
 - lib/flipper/middleware/memoizer.rb
 - lib/flipper/middleware/setup_env.rb
+- lib/flipper/railtie.rb
 - lib/flipper/registry.rb
 - lib/flipper/spec/shared_adapter_specs.rb
 - lib/flipper/test/shared_adapter_test.rb
@@ -128,12 +131,14 @@ files:
 - spec/flipper/gates/group_spec.rb
 - spec/flipper/gates/percentage_of_actors_spec.rb
 - spec/flipper/gates/percentage_of_time_spec.rb
+- spec/flipper/identifier_spec.rb
 - spec/flipper/instrumentation/log_subscriber_spec.rb
 - spec/flipper/instrumentation/statsd_subscriber_spec.rb
 - spec/flipper/instrumenters/memory_spec.rb
 - spec/flipper/instrumenters/noop_spec.rb
 - spec/flipper/middleware/memoizer_spec.rb
 - spec/flipper/middleware/setup_env_spec.rb
+- spec/flipper/railtie_spec.rb
 - spec/flipper/registry_spec.rb
 - spec/flipper/typecast_spec.rb
 - spec/flipper/types/actor_spec.rb
@@ -168,9 +173,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: 
@@ -203,12 +208,14 @@ test_files:
 - spec/flipper/gates/group_spec.rb
 - spec/flipper/gates/percentage_of_actors_spec.rb
 - spec/flipper/gates/percentage_of_time_spec.rb
+- spec/flipper/identifier_spec.rb
 - spec/flipper/instrumentation/log_subscriber_spec.rb
 - spec/flipper/instrumentation/statsd_subscriber_spec.rb
 - spec/flipper/instrumenters/memory_spec.rb
 - spec/flipper/instrumenters/noop_spec.rb
 - spec/flipper/middleware/memoizer_spec.rb
 - spec/flipper/middleware/setup_env_spec.rb
+- spec/flipper/railtie_spec.rb
 - spec/flipper/registry_spec.rb
 - spec/flipper/typecast_spec.rb
 - spec/flipper/types/actor_spec.rb

data/examples/example_setup.rb

@@ -1,8 +0,0 @@
-# Nothing to see here... move along.
-# Sets up load path for examples and requires some stuff
-require 'pp'
-require 'pathname'
-
-root_path = Pathname(__FILE__).dirname.join('..').expand_path
-lib_path  = root_path.join('lib')
-$:.unshift(lib_path)