flipper 0.20.0 → 0.21.0.rc1

data/spec/flipper/adapters/memory_spec.rb

@@ -2,7 +2,27 @@ require 'helper'
 require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::Memory do
-  subject { described_class.new }
+  let(:source) { {} }
+  subject { described_class.new(source) }
 
   it_should_behave_like 'a flipper adapter'
+
+  it "can initialize from big hash" do
+    flipper = Flipper.new(subject)
+    flipper.enable :subscriptions
+    flipper.disable :search
+    flipper.enable_percentage_of_actors :pro_deal, 20
+    flipper.enable_percentage_of_time :logging, 30
+    flipper.enable_actor :following, Flipper::Actor.new('1')
+    flipper.enable_actor :following, Flipper::Actor.new('3')
+    flipper.enable_group :following, Flipper::Types::Group.new(:staff)
+
+    expect(source).to eq({
+      "subscriptions" => subject.default_config.merge(boolean: "true"),
+      "search" => subject.default_config,
+      "logging" => subject.default_config.merge(:percentage_of_time => "30"),
+      "pro_deal" => subject.default_config.merge(:percentage_of_actors => "20"),
+      "following" => subject.default_config.merge(actors: Set["1", "3"], groups: Set["staff"]),
+    })
+  end
 end

data/spec/flipper/configuration_spec.rb

@@ -3,12 +3,15 @@ require 'flipper/configuration'
 
 RSpec.describe Flipper::Configuration do
   describe '#default' do
-    it 'raises if default not configured' do
-      expect { subject.default }.to raise_error(Flipper::DefaultNotSet)
+    it 'returns instance using Memory adapter' do
+      expect(subject.default).to be_a(Flipper::DSL)
+      # All adapter are wrapped in Memoizable
+      expect(subject.default.adapter.adapter).to be_a(Flipper::Adapters::Memory)
     end
 
     it 'can be set default' do
       instance = Flipper.new(Flipper::Adapters::Memory.new)
+      expect(subject.default).not_to be(instance)
       subject.default { instance }
       expect(subject.default).to be(instance)
     end

data/spec/flipper/identifier_spec.rb

@@ -0,0 +1,14 @@
+require 'helper'
+require 'flipper/identifier'
+
+RSpec.describe Flipper::Identifier do
+  describe '#flipper_id' do
+    class User < Struct.new(:id)
+      include Flipper::Identifier
+    end
+
+    it 'uses class name and id' do
+      expect(User.new(5).flipper_id).to eq('User;5')
+    end
+  end
+end

data/spec/flipper/middleware/memoizer_spec.rb

@@ -342,7 +342,7 @@ RSpec.describe Flipper::Middleware::Memoizer do
     it 'eagerly caches known features for duration of request' do
       memory = Flipper::Adapters::Memory.new
       logged_memory = Flipper::Adapters::OperationLogger.new(memory)
-      cache = ActiveSupport::Cache::DalliStore.new(ENV['MEMCACHED_URL'])
+      cache = ActiveSupport::Cache::MemoryStore.new
       cache.clear
       cached = Flipper::Adapters::ActiveSupportCacheStore.new(logged_memory, cache, expires_in: 10)
       logged_cached = Flipper::Adapters::OperationLogger.new(cached)

data/spec/flipper/middleware/setup_env_spec.rb

@@ -93,20 +93,4 @@ RSpec.describe Flipper::Middleware::SetupEnv do
       expect(last_response.body).to eq(Flipper.object_id.to_s)
     end
   end
-
-  context 'when flipper instance or block are nil and default Flipper is NOT configured' do
-    let(:app) do
-      app = lambda do |env|
-        [200, { 'Content-Type' => 'text/html' }, [env['flipper'].enabled?(:search)]]
-      end
-      builder = Rack::Builder.new
-      builder.use described_class
-      builder.run app
-      builder
-    end
-
-    it 'can use env flipper' do
-      expect { get '/' }.to raise_error(Flipper::DefaultNotSet)
-    end
-  end
 end

data/spec/flipper_spec.rb

@@ -232,7 +232,6 @@ RSpec.describe Flipper do
       cloud_configuration = Flipper::Cloud::Configuration.new({
         token: "asdf",
         sync_secret: "tasty",
-        sync_method: :webhook,
       })
 
       described_class.configure do |config|

data/spec/support/spec_helpers.rb

@@ -64,6 +64,9 @@ module SpecHelpers
 end
 
 RSpec.configure do |config|
+  config.order = :random
+  Kernel.srand config.seed
+
   config.include Rack::Test::Methods
   config.include SpecHelpers
 end

data/test/test_helper.rb

@@ -1,3 +1,4 @@
+require 'bundler/setup'
 require 'flipper'
 require 'minitest/autorun'
 require 'minitest/unit'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.20.0
+  version: 0.21.0.rc1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-20 00:00:00.000000000 Z
+date: 2021-05-01 00:00:00.000000000 Z
 dependencies: []
 description: 
 email:
@@ -18,6 +18,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".github/workflows/ci.yml"
 - CODE_OF_CONDUCT.md
 - Changelog.md
 - Dockerfile
@@ -34,12 +35,12 @@ files:
 - docs/Optimization.md
 - docs/api/README.md
 - docs/http/README.md
+- docs/images/banner.jpg
 - docs/read-only/README.md
 - examples/basic.rb
 - examples/configuring_default.rb
 - examples/dsl.rb
 - examples/enabled_for_actor.rb
-- examples/example_setup.rb
 - examples/group.rb
 - examples/group_dynamic_lookup.rb
 - examples/group_with_members.rb
@@ -81,6 +82,7 @@ files:
 - lib/flipper/gates/group.rb
 - lib/flipper/gates/percentage_of_actors.rb
 - lib/flipper/gates/percentage_of_time.rb
+- lib/flipper/identifier.rb
 - lib/flipper/instrumentation/log_subscriber.rb
 - lib/flipper/instrumentation/statsd.rb
 - lib/flipper/instrumentation/statsd_subscriber.rb
@@ -128,6 +130,7 @@ files:
 - spec/flipper/gates/group_spec.rb
 - spec/flipper/gates/percentage_of_actors_spec.rb
 - spec/flipper/gates/percentage_of_time_spec.rb
+- spec/flipper/identifier_spec.rb
 - spec/flipper/instrumentation/log_subscriber_spec.rb
 - spec/flipper/instrumentation/statsd_subscriber_spec.rb
 - spec/flipper/instrumenters/memory_spec.rb
@@ -168,9 +171,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: 
@@ -203,6 +206,7 @@ test_files:
 - spec/flipper/gates/group_spec.rb
 - spec/flipper/gates/percentage_of_actors_spec.rb
 - spec/flipper/gates/percentage_of_time_spec.rb
+- spec/flipper/identifier_spec.rb
 - spec/flipper/instrumentation/log_subscriber_spec.rb
 - spec/flipper/instrumentation/statsd_subscriber_spec.rb
 - spec/flipper/instrumenters/memory_spec.rb

data/examples/example_setup.rb

@@ -1,8 +0,0 @@
-# Nothing to see here... move along.
-# Sets up load path for examples and requires some stuff
-require 'pp'
-require 'pathname'
-
-root_path = Pathname(__FILE__).dirname.join('..').expand_path
-lib_path  = root_path.join('lib')
-$:.unshift(lib_path)