flipper 0.18.0 → 0.20.0.beta3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60a4f0efac1116f4a9c4f0aeb899cd9104dcccf6578691ba639e047a23b77fe0
-  data.tar.gz: 270782a3c6d8021e8efa4b926fd0dfbe49613f1b47793d4783e15667cddb58e3
+  metadata.gz: 832cad2e78b6d06a366c79f035f3c9a546c73ac158c88e51f3f10fc24ab2cfed
+  data.tar.gz: cf002bed695de325a1c90e959371f9ac7a18bca936c512f686d2a9cf3fdc6ab0
 SHA512:
-  metadata.gz: 10f4d755b8f3f9137cdf3868ddc3277177e4dea8d27e1125449c3bfc25afe3350dc4a4a6c97f71f26db8cc180357221686fcc737a1e60ce29edb6adbb60a5cc5
-  data.tar.gz: cd5b0bf940e4ff2dbede6c82c7ea2d30ab44fb9ec4917032df3b36b6c7c390c587494a6c334c36fa0498cf83162562afcecb44a12e2373ec8ebf0a3e941d525d
+  metadata.gz: 2eb3b64a40a69437979fd96e6efda94c0a322181c4f2ca554cf0fb0ac65380ad8c0244b392212dc22d5398fab6c25cf713f117f369a68f93caa460c46d998bf9
+  data.tar.gz: 60a46b36240f1d55b85ada08d68e8b5c82dc0e8bb51ef8f143362a0237b0d2cfd2585d7dabb7fd6e9aad32712be22d9507926e2a14cd4943c663ea6a56b36674

data/Changelog.md

@@ -1,6 +1,20 @@
+## 0.19.1
+
+### Additions/Changes
+
+* Bump rack-protection version to < 2.2 (https://github.com/jnunemaker/flipper/pull/487)
+* Add memoizer_options to Flipper::Api.app (https://github.com/jnunemaker/flipper/commit/174ad4bb94046a25c432d3c53fe1ff9f5a76d838)
+
+## 0.19.0
+
+### Additions/Changes
+
+* 100% of actors is now considered conditional. Feature#on?, Feature#conditional?, Feature#state would all be affected. See https://github.com/jnunemaker/flipper/issues/463 for more.
+* Several doc updates.
+
 ## 0.18.0
 
-## Additions/Changes
+### Additions/Changes
 
 * Add support for feature descriptions to flipper-ui (https://github.com/jnunemaker/flipper/pull/461).
 * Remove rubocop (https://github.com/jnunemaker/flipper/pull/469).

data/Gemfile

@@ -17,6 +17,7 @@ gem 'rails', "~> #{ENV['RAILS_VERSION'] || '6.0.0'}"
 gem 'minitest', '~> 5.8'
 gem 'minitest-documentation'
 gem 'webmock', '~> 3.0'
+gem 'climate_control'
 
 group(:guard) do
   gem 'guard', '~> 2.15'

data/examples/memoizing.rb

@@ -0,0 +1,39 @@
+require File.expand_path('../example_setup', __FILE__)
+
+require 'flipper'
+require 'flipper/adapters/operation_logger'
+require 'flipper/instrumentation/log_subscriber'
+
+Flipper.configure do |config|
+  config.default do
+    # pick an adapter, this uses memory, any will do
+    adapter = Flipper::Adapters::OperationLogger.new(Flipper::Adapters::Memory.new)
+
+    # pass adapter to handy DSL instance
+    Flipper.new(adapter)
+  end
+end
+
+Flipper.enable(:foo)
+Flipper.enable(:bar)
+Flipper.disable(:baz)
+Flipper.disable(:wick)
+# reset the operation logging adapter to empty for clarity
+Flipper.adapter.reset
+
+# Turn on memoization (the memoizing middleware does this per request).
+Flipper.memoize = true
+
+# Preload all the features.
+Flipper.preload_all
+
+# Do as many feature checks as your heart desires.
+%w[foo bar baz wick].each do |name|
+  Flipper.enabled?(name)
+end
+
+# See that only one operation exists, a get_all (which is the preload_all).
+pp Flipper.adapter.operations
+# [#<Flipper::Adapters::OperationLogger::Operation:0x00007fdcfe1100e8
+#   @args=[],
+#   @type=:get_all>]

data/lib/flipper.rb

@@ -65,7 +65,8 @@ module Flipper
                  :time, :percentage_of_time,
                  :features, :feature, :[], :preload, :preload_all,
                  :adapter, :add, :exist?, :remove, :import,
-                 :memoize=, :memoizing?
+                 :memoize=, :memoizing?,
+                 :sync, :sync_secret # For Flipper::Cloud. Will error for OSS Flipper.
 
   # Public: Use this to register a group by name.
   #

data/lib/flipper/adapters/dual_write.rb

@@ -0,0 +1,67 @@
+module Flipper
+  module Adapters
+    class DualWrite
+      include ::Flipper::Adapter
+
+      # Public: The name of the adapter.
+      attr_reader :name
+
+      # Public: Build a new sync instance.
+      #
+      # local - The local flipper adapter that should serve reads.
+      # remote - The remote flipper adapter that writes should go to first (in
+      #          addition to the local adapter).
+      def initialize(local, remote, options = {})
+        @name = :dual_write
+        @local = local
+        @remote = remote
+      end
+
+      def features
+        @local.features
+      end
+
+      def get(feature)
+        @local.get(feature)
+      end
+
+      def get_multi(features)
+        @local.get_multi(features)
+      end
+
+      def get_all
+        @local.get_all
+      end
+
+      def add(feature)
+        result = @remote.add(feature)
+        @local.add(feature)
+        result
+      end
+
+      def remove(feature)
+        result = @remote.remove(feature)
+        @local.remove(feature)
+        result
+      end
+
+      def clear(feature)
+        result = @remote.clear(feature)
+        @local.clear(feature)
+        result
+      end
+
+      def enable(feature, gate, thing)
+        result = @remote.enable(feature, gate, thing)
+        @local.enable(feature, gate, thing)
+        result
+      end
+
+      def disable(feature, gate, thing)
+        result = @remote.disable(feature, gate, thing)
+        @local.disable(feature, gate, thing)
+        result
+      end
+    end
+  end
+end

data/lib/flipper/adapters/operation_logger.rb

@@ -117,6 +117,11 @@ module Flipper
       def reset
         @operations.clear
       end
+
+      def inspect
+        inspect_id = ::Kernel::format "%x", (object_id * 2)
+        %(#<#{self.class}:0x#{inspect_id} @name=#{name.inspect}, @operations=#{@operations.inspect}, @adapter=#{@adapter.inspect}>)
+      end
     end
   end
 end

data/lib/flipper/adapters/sync.rb

@@ -17,7 +17,7 @@ module Flipper
       # Public: Build a new sync instance.
       #
       # local - The local flipper adapter that should serve reads.
-      # remote - The remote flipper adpater that should serve writes and update
+      # remote - The remote flipper adapter that should serve writes and update
       #          the local on an interval.
       # interval - The Float or Integer number of seconds between syncs from
       # remote to local. Default value is set in IntervalSynchronizer.
@@ -34,26 +34,26 @@ module Flipper
           synchronizer = Synchronizer.new(@local, @remote, sync_options)
           IntervalSynchronizer.new(synchronizer, interval: options[:interval])
         end
-        sync
+        synchronize
       end
 
       def features
-        sync
+        synchronize
         @local.features
       end
 
       def get(feature)
-        sync
+        synchronize
         @local.get(feature)
       end
 
       def get_multi(features)
-        sync
+        synchronize
         @local.get_multi(features)
       end
 
       def get_all
-        sync
+        synchronize
         @local.get_all
       end
 
@@ -89,7 +89,7 @@ module Flipper
 
       private
 
-      def sync
+      def synchronize
         @synchronizer.call
       end
     end

data/lib/flipper/adapters/sync/synchronizer.rb

@@ -15,6 +15,7 @@ module Flipper
         #          adapter should be brought in line with.
         # options - The Hash of options.
         #           :instrumenter - The instrumenter used to instrument.
+        #           :raise - Should errors be raised (default: true).
         def initialize(local, remote, options = {})
           @local = local
           @remote = remote

data/lib/flipper/dsl.rb

@@ -273,5 +273,13 @@ module Flipper
     def import(flipper)
       adapter.import(flipper.adapter)
     end
+
+    # Cloud DSL method that does nothing for open source version.
+    def sync
+    end
+
+    # Cloud DSL method that does nothing for open source version.
+    def sync_secret
+    end
   end
 end

data/lib/flipper/feature.rb

@@ -205,7 +205,7 @@ module Flipper
       boolean = gate(:boolean)
       non_boolean_gates = gates - [boolean]
 
-      if values.boolean || values.percentage_of_actors == 100 || values.percentage_of_time == 100
+      if values.boolean || values.percentage_of_time == 100
         :on
       elsif non_boolean_gates.detect { |gate| gate.enabled?(values[gate.key]) }
         :conditional

data/lib/flipper/middleware/setup_env.rb

@@ -7,7 +7,8 @@ module Flipper
       #
       # app - The app this middleware is included in.
       # flipper_or_block - The Flipper::DSL instance or a block that yields a
-      #                    Flipper::DSL instance to use for all operations.
+      #                    Flipper::DSL instance to use for all operations
+      #                    (optional, default: Flipper).
       #
       # Examples
       #
@@ -19,18 +20,27 @@ module Flipper
       #   # using with a block that yields a flipper instance
       #   use Flipper::Middleware::SetupEnv, lambda { Flipper.new(...) }
       #
-      def initialize(app, flipper_or_block, options = {})
+      #   # using default configured Flipper instance
+      #   Flipper.configure do |config|
+      #     config.default { Flipper.new(...) }
+      #   end
+      #   use Flipper::Middleware::SetupEnv
+      def initialize(app, flipper_or_block = nil, options = {})
         @app = app
         @env_key = options.fetch(:env_key, 'flipper')
 
         if flipper_or_block.respond_to?(:call)
           @flipper_block = flipper_or_block
         else
-          @flipper = flipper_or_block
+          @flipper = flipper_or_block || Flipper
         end
       end
 
       def call(env)
+        dup.call!(env)
+      end
+
+      def call!(env)
         env[@env_key] ||= flipper
         @app.call(env)
       end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.18.0'.freeze
+  VERSION = '0.20.0.beta3'.freeze
 end

data/spec/flipper/adapters/dual_write_spec.rb

@@ -0,0 +1,71 @@
+require 'helper'
+require 'flipper/adapters/dual_write'
+require 'flipper/adapters/operation_logger'
+require 'flipper/spec/shared_adapter_specs'
+require 'active_support/notifications'
+
+RSpec.describe Flipper::Adapters::DualWrite do
+  let(:local_adapter) do
+    Flipper::Adapters::OperationLogger.new Flipper::Adapters::Memory.new
+  end
+  let(:remote_adapter) do
+    Flipper::Adapters::OperationLogger.new Flipper::Adapters::Memory.new
+  end
+  let(:local) { Flipper.new(local_adapter) }
+  let(:remote) { Flipper.new(remote_adapter) }
+  let(:sync) { Flipper.new(subject) }
+
+  subject do
+    described_class.new(local_adapter, remote_adapter)
+  end
+
+  it_should_behave_like 'a flipper adapter'
+
+  it 'only uses local for #features' do
+    subject.features
+  end
+
+  it 'only uses local for #get' do
+    subject.get sync[:search]
+  end
+
+  it 'only uses local for #get_multi' do
+    subject.get_multi [sync[:search]]
+  end
+
+  it 'only uses local for #get_all' do
+    subject.get_all
+  end
+
+  it 'updates remote and local for #add' do
+    subject.add sync[:search]
+    expect(remote_adapter.count(:add)).to be(1)
+    expect(local_adapter.count(:add)).to be(1)
+  end
+
+  it 'updates remote and local for #remove' do
+    subject.remove sync[:search]
+    expect(remote_adapter.count(:remove)).to be(1)
+    expect(local_adapter.count(:remove)).to be(1)
+  end
+
+  it 'updates remote and local for #clear' do
+    subject.clear sync[:search]
+    expect(remote_adapter.count(:clear)).to be(1)
+    expect(local_adapter.count(:clear)).to be(1)
+  end
+
+  it 'updates remote and local for #enable' do
+    feature = sync[:search]
+    subject.enable feature, feature.gate(:boolean), local.boolean
+    expect(remote_adapter.count(:enable)).to be(1)
+    expect(local_adapter.count(:enable)).to be(1)
+  end
+
+  it 'updates remote and local for #disable' do
+    feature = sync[:search]
+    subject.disable feature, feature.gate(:boolean), local.boolean(false)
+    expect(remote_adapter.count(:disable)).to be(1)
+    expect(local_adapter.count(:disable)).to be(1)
+  end
+end

data/spec/flipper/adapters/operation_logger_spec.rb

@@ -11,6 +11,15 @@ RSpec.describe Flipper::Adapters::OperationLogger do
 
   it_should_behave_like 'a flipper adapter'
 
+  it 'shows itself when inspect' do
+    subject.features
+    output = subject.inspect
+    expect(output).to match(/OperationLogger/)
+    expect(output).to match(/operation_logger/)
+    expect(output).to match(/@type=:features/)
+    expect(output).to match(/@adapter=#<Flipper::Adapters::Memory/)
+  end
+
   it 'forwards missing methods to underlying adapter' do
     adapter = Class.new do
       def foo

data/spec/flipper/adapters/sync_spec.rb

@@ -175,22 +175,22 @@ RSpec.describe Flipper::Adapters::Sync do
   end
 
   it 'synchronizes for #features' do
-    expect(subject).to receive(:sync)
+    expect(subject).to receive(:synchronize)
     subject.features
   end
 
   it 'synchronizes for #get' do
-    expect(subject).to receive(:sync)
+    expect(subject).to receive(:synchronize)
     subject.get sync[:search]
   end
 
   it 'synchronizes for #get_multi' do
-    expect(subject).to receive(:sync)
+    expect(subject).to receive(:synchronize)
     subject.get_multi [sync[:search]]
   end
 
   it 'synchronizes for #get_all' do
-    expect(subject).to receive(:sync)
+    expect(subject).to receive(:synchronize)
     subject.get_all
   end
 

data/spec/flipper/feature_spec.rb

@@ -359,19 +359,19 @@ RSpec.describe Flipper::Feature do
       end
 
       it 'returns :on' do
-        expect(subject.state).to be(:on)
+        expect(subject.state).to be(:conditional)
       end
 
-      it 'returns true for on?' do
-        expect(subject.on?).to be(true)
+      it 'returns false for on?' do
+        expect(subject.on?).to be(false)
       end
 
       it 'returns false for off?' do
         expect(subject.off?).to be(false)
       end
 
-      it 'returns false for conditional?' do
-        expect(subject.conditional?).to be(false)
+      it 'returns true for conditional?' do
+        expect(subject.conditional?).to be(true)
       end
     end
 

data/spec/flipper/middleware/memoizer_spec.rb

@@ -342,7 +342,7 @@ RSpec.describe Flipper::Middleware::Memoizer do
     it 'eagerly caches known features for duration of request' do
       memory = Flipper::Adapters::Memory.new
       logged_memory = Flipper::Adapters::OperationLogger.new(memory)
-      cache = ActiveSupport::Cache::DalliStore.new
+      cache = ActiveSupport::Cache::DalliStore.new(ENV['MEMCACHED_URL'])
       cache.clear
       cached = Flipper::Adapters::ActiveSupportCacheStore.new(logged_memory, cache, expires_in: 10)
       logged_cached = Flipper::Adapters::OperationLogger.new(cached)

data/spec/flipper/middleware/setup_env_spec.rb

@@ -56,21 +56,57 @@ RSpec.describe Flipper::Middleware::SetupEnv do
     end
   end
 
-  context 'when flipper instance is nil' do
+  context 'when flipper instance or block are nil but env flipper is configured' do
     let(:app) do
       app = lambda do |env|
         [200, { 'Content-Type' => 'text/html' }, [env['flipper'].object_id.to_s]]
       end
       builder = Rack::Builder.new
-      builder.use described_class, nil
+      builder.use described_class
       builder.run app
       builder
     end
 
-    it 'leaves env flipper alone' do
+    it 'can use env flipper' do
       env_flipper = build_flipper
       get '/', {}, 'flipper' => env_flipper
       expect(last_response.body).to eq(env_flipper.object_id.to_s)
     end
   end
+
+  context 'when flipper instance or block are nil and default Flipper is configured' do
+    let(:app) do
+      Flipper.configure do |config|
+        config.default { flipper }
+      end
+      app = lambda do |env|
+        [200, { 'Content-Type' => 'text/html' }, [env['flipper'].object_id.to_s]]
+      end
+      builder = Rack::Builder.new
+      builder.use described_class
+      builder.run app
+      builder
+    end
+
+    it 'can use env flipper' do
+      get '/', {}, {}
+      expect(last_response.body).to eq(Flipper.object_id.to_s)
+    end
+  end
+
+  context 'when flipper instance or block are nil and default Flipper is NOT configured' do
+    let(:app) do
+      app = lambda do |env|
+        [200, { 'Content-Type' => 'text/html' }, [env['flipper'].enabled?(:search)]]
+      end
+      builder = Rack::Builder.new
+      builder.use described_class
+      builder.run app
+      builder
+    end
+
+    it 'can use env flipper' do
+      expect { get '/' }.to raise_error(Flipper::DefaultNotSet)
+    end
+  end
 end

data/spec/flipper_spec.rb

@@ -1,4 +1,5 @@
 require 'helper'
+require 'flipper/cloud'
 
 RSpec.describe Flipper do
   describe '.new' do
@@ -215,6 +216,32 @@ RSpec.describe Flipper do
     it 'delegates memoizing? to instance' do
       expect(described_class.memoizing?).to eq(described_class.adapter.memoizing?)
     end
+
+    it 'delegates sync stuff to instance and does nothing' do
+      expect(described_class.sync).to be(nil)
+      expect(described_class.sync_secret).to be(nil)
+    end
+
+    it 'delegates sync stuff to instance for Flipper::Cloud' do
+      stub = stub_request(:get, "https://www.flippercloud.io/adapter/features").
+        with({
+          headers: {
+            'Flipper-Cloud-Token'=>'asdf',
+          },
+        }).to_return(status: 200, body: '{"features": {}}', headers: {})
+      cloud_configuration = Flipper::Cloud::Configuration.new({
+        token: "asdf",
+        sync_secret: "tasty",
+        sync_method: :webhook,
+      })
+
+      described_class.configure do |config|
+        config.default { Flipper::Cloud::DSL.new(cloud_configuration) }
+      end
+      described_class.sync
+      expect(described_class.sync_secret).to eq("tasty")
+      expect(stub).to have_been_requested
+    end
   end
 
   describe '.register' do

data/spec/support/spec_helpers.rb

@@ -1,3 +1,4 @@
+require 'climate_control'
 require 'json'
 require 'rack/test'
 
@@ -56,6 +57,10 @@ module SpecHelpers
       'more_info' => api_error_code_reference_url,
     }
   end
+
+  def with_modified_env(options, &block)
+    ClimateControl.modify(options, &block)
+  end
 end
 
 RSpec.configure do |config|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.20.0.beta3
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-25 00:00:00.000000000 Z
+date: 2020-12-17 00:00:00.000000000 Z
 dependencies: []
 description: 
 email:
@@ -46,6 +46,7 @@ files:
 - examples/importing.rb
 - examples/individual_actor.rb
 - examples/instrumentation.rb
+- examples/memoizing.rb
 - examples/percentage_of_actors.rb
 - examples/percentage_of_actors_enabled_check.rb
 - examples/percentage_of_actors_group.rb
@@ -54,6 +55,7 @@ files:
 - lib/flipper.rb
 - lib/flipper/actor.rb
 - lib/flipper/adapter.rb
+- lib/flipper/adapters/dual_write.rb
 - lib/flipper/adapters/http.rb
 - lib/flipper/adapters/http/client.rb
 - lib/flipper/adapters/http/error.rb
@@ -103,6 +105,7 @@ files:
 - spec/fixtures/feature.json
 - spec/flipper/actor_spec.rb
 - spec/flipper/adapter_spec.rb
+- spec/flipper/adapters/dual_write_spec.rb
 - spec/flipper/adapters/http_spec.rb
 - spec/flipper/adapters/instrumented_spec.rb
 - spec/flipper/adapters/memoizable_spec.rb
@@ -165,9 +168,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: 
@@ -177,6 +180,7 @@ test_files:
 - spec/fixtures/feature.json
 - spec/flipper/actor_spec.rb
 - spec/flipper/adapter_spec.rb
+- spec/flipper/adapters/dual_write_spec.rb
 - spec/flipper/adapters/http_spec.rb
 - spec/flipper/adapters/instrumented_spec.rb
 - spec/flipper/adapters/memoizable_spec.rb