flipper 0.16.1 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0d3f43b874f8dfd5484317d635fd96662f8c4aab
-  data.tar.gz: 83b68438215b14a9f1fd6ba0782ceaa87f08e592
+SHA256:
+  metadata.gz: 988b31a807cedba4ca7b26ce056207198bddd3ce4a3c8e2ad177bc22c1977f4b
+  data.tar.gz: 89b7ae96bf65c9975edb06cdab1fc4a0d2453ee9cc876ffa7cb84a7ba44f4b91
 SHA512:
-  metadata.gz: 8d05d3d79dbe8150d0e7cda538f9cb891d7e05ad04faf9fb55ef10cf693406bdc8d84783cb70bdfccecbfdbeb6b5569df54b3742bb13108a35fa04a201872776
-  data.tar.gz: 11beea578344f06abd0e203e92b8eda7277ee8ac556adab9f756af0745e926059510a0063ff13f121edde890af7ea9b8b38e367ddc31c73c8646d28d36b72b19
+  metadata.gz: b2cfb8bdebeb0de99f5f79258ae04eb547bbe06fc8242ee0c2d9c0557968942ffad9eecd4ecd80420cdbda85f75043daddaee80a7fab2bb4f7fcfa18de55d2af
+  data.tar.gz: 39813690991745a27bdb3e03207ebd89e61b12b2d516fc470a74ea8770c4ebc2445d60a7f17b0870e6d7582d070b221d866a90244864f9a5dfe58d6f97b4c7f0

data/Changelog.md

@@ -1,3 +1,62 @@
+## 0.19.0
+
+## Additions/Changes
+
+* 100% of actors is now considered conditional. Feature#on?, Feature#conditional?, Feature#state would all be affected. See https://github.com/jnunemaker/flipper/issues/463 for more.
+* Several doc updates.
+
+## 0.18.0
+
+## Additions/Changes
+
+* Add support for feature descriptions to flipper-ui (https://github.com/jnunemaker/flipper/pull/461).
+* Remove rubocop (https://github.com/jnunemaker/flipper/pull/469).
+* flipper-ui redesign (https://github.com/jnunemaker/flipper/pull/470).
+* Removed support for ruby 2.4.
+* Added support for ruby 2.7.
+* Removed support for Rails 4.x.x.
+* Removed support for customizing actors, groups, % of actors and % of time text in flipper-ui in favor of automatic and more descriptive text.
+
+## 0.17.2
+
+### Additions/Changes
+
+* Avoid errors on import when there are no features and shared specs/tests for get all with no features (https://github.com/jnunemaker/flipper/pull/441 and https://github.com/jnunemaker/flipper/pull/442)
+* ::ActiveRecord::RecordNotUnique > ActiveRecord::RecordNotUnique (https://github.com/jnunemaker/flipper/pull/444)
+* Clear gate values on enable (https://github.com/jnunemaker/flipper/pull/454)
+* Remove use of multi from redis adapter (https://github.com/jnunemaker/flipper/pull/451)
+
+## 0.17.1
+
+* Fix require in flipper-active_record (https://github.com/jnunemaker/flipper/pull/437)
+
+## 0.17.0
+
+### Additions/Changes
+
+* Allow shorthand block notation on group types (https://github.com/jnunemaker/flipper/pull/406)
+* Relax active record/support constraints to support Rails 6 (https://github.com/jnunemaker/flipper/pull/409)
+* Allow disabling fun (https://github.com/jnunemaker/flipper/pull/413)
+* Include thing_value in payload of Instrumented#enable and #disable (https://github.com/jnunemaker/flipper/pull/417)
+* Replace Erubis with Erubi (https://github.com/jnunemaker/flipper/pull/407)
+* Allow customizing Rack::Protection middleware list (https://github.com/jnunemaker/flipper/pull/385)
+* Allow setting write_timeout for ruby 2.6+ (https://github.com/jnunemaker/flipper/pull/433)
+* Drop support for Ruby 2.1, 2.2, and 2.3 (https://github.com/jnunemaker/flipper/commit/cf58982e70de5e6963b018ceced4f36a275f5b5d)
+* Add support for Ruby 2.6 (https://github.com/jnunemaker/flipper/commit/57888311449ec81184d3d47ba9ae5cb1ad4a2f45)
+* Remove support for Rails 3.2 (https://github.com/jnunemaker/flipper/commit/177c48c4edf51d4e411e7c673e30e06d1c66fb40)
+* Add write_timeout for flipper http adapter for ruby 2.6+ (https://github.com/jnunemaker/flipper/pull/433)
+* Relax moneta version to allow for < 1.2 (https://github.com/jnunemaker/flipper/pull/434).
+* Improve active record idempotency (https://github.com/jnunemaker/flipper/pull/436).
+* Allow customizing add actor placeholder text (https://github.com/jnunemaker/flipper/commit/5faa1e9cf66b68f8227d2f8408fb448a14676c45)
+
+## 0.16.2
+
+### Additions/Changes
+
+* Bump rollout redis dependency to < 5 (https://github.com/jnunemaker/flipper/pull/403)
+* Bump redis dependency to < 5 (https://github.com/jnunemaker/flipper/pull/401)
+* Bump sequel dependency to < 6 (https://github.com/jnunemaker/flipper/pull/399 and https://github.com/jnunemaker/flipper/commit/edc767e69b4ce8daead9801f38e0e8bf6b238765)
+
 ## 0.16.1
 
 ### Additions/Changes
@@ -50,7 +109,7 @@
 
 ### Additions/Changes
 
-* Added rollout adapter documentation (https://github.com/jnunemaker/flipper/pull/328).  
+* Added rollout adapter documentation (https://github.com/jnunemaker/flipper/pull/328).
 
 ### Bug Fixes
 
@@ -184,8 +243,8 @@
 
 * Added Flipper.groups and Flipper.group_names
 * Changed percentage_of_random to percentage_of_time
-* Added enable/disable convenience methods for all gates (ie: enable_group, enable_actor, enable_percentage_of_actors, enable_percentage_of_time)
-* Added value convenience methods (ie: boolean_value, groups_value, actors_value, etc.)
+* Added enable/disable convenience methods for all gates (enable_group, enable_actor, enable_percentage_of_actors, enable_percentage_of_time)
+* Added value convenience methods (boolean_value, groups_value, actors_value, etc.)
 * Added Feature#gate_values for getting typecast adapter gate values
 * Added Feature#enabled_gates and #disabled_gates for getting the gates that are enabled/disabled for the feature
 * Remove Feature#description

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM ruby:2.2.5
+FROM ruby:2.5
 
 RUN apt-get update && apt-get install -y \
   # build-essential \

data/Gemfile

@@ -7,27 +7,20 @@ Dir['flipper-*.gemspec'].each do |gemspec|
 end
 
 gem 'pry'
-gem 'rake', '~> 10.4.2'
+gem 'rake', '~> 12.3.3'
 gem 'shotgun', '~> 0.9'
 gem 'statsd-ruby', '~> 1.2.1'
 gem 'rspec', '~> 3.0'
 gem 'rack-test', '~> 0.6.3'
-gem 'sqlite3', '~> 1.3.11'
-gem 'rails', "~> #{ENV['RAILS_VERSION'] || '5.1.4'}"
-gem 'minitest', '~> 5.8.0'
-gem 'rubocop', '~> 0.45.0'
-gem 'rubocop-rspec', '= 1.5.1'
-gem 'webmock', '~> 2.0'
-
-# for active support tests in test/ and only needed for ruby 2.2.x
-gem 'test-unit', '~> 3.0'
+gem 'sqlite3', "~> #{ENV['SQLITE3_VERSION'] || '1.4.1'}"
+gem 'rails', "~> #{ENV['RAILS_VERSION'] || '6.0.0'}"
+gem 'minitest', '~> 5.8'
+gem 'minitest-documentation'
+gem 'webmock', '~> 3.0'
 
 group(:guard) do
-  gem 'guard', '~> 2.12.5'
-  gem 'guard-rubocop', '~> 1.3.0'
-  gem 'guard-rspec', '~> 4.5.0'
-  gem 'guard-bundler', '~> 2.1.0'
-  gem 'guard-coffeescript', '~> 2.0.1'
-  gem 'guard-sass', '~> 1.6.0'
-  gem 'rb-fsevent', '~> 0.9.4'
+  gem 'guard', '~> 2.15'
+  gem 'guard-rspec', '~> 4.5'
+  gem 'guard-bundler', '~> 2.2'
+  gem 'rb-fsevent', '~> 0.9'
 end

data/README.md

@@ -85,7 +85,7 @@ Of course there are more [examples for you to peruse](examples/). You could also
 
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Check your changes with Rubocop tests (`script/rubocop`)
+3. Run the tests (`bundle exec rake`)
 4. Commit your changes (`git commit -am 'Added some feature'`)
 5. Push to the branch (`git push origin my-new-feature`)
 6. Create new Pull Request

data/Rakefile

@@ -25,7 +25,7 @@ end
 
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec) do |t|
-  t.rspec_opts = %w(--color)
+  t.rspec_opts = %w(--color --format documentation)
 end
 
 namespace :spec do
@@ -39,6 +39,14 @@ end
 Rake::TestTask.new do |t|
   t.libs = %w(lib test)
   t.pattern = 'test/**/*_test.rb'
+  t.options = '--documentation'
+  t.warning = false
 end
 
-task default: [:spec, :test]
+Rake::TestTask.new(:test_rails) do |t|
+  t.libs = %w(lib test_rails)
+  t.pattern = 'test_rails/**/*_test.rb'
+  t.warning = false
+end
+
+task default: [:spec, :test, :test_rails]

data/docs/Adapters.md

@@ -4,7 +4,7 @@ I plan on supporting the adapters in the flipper repo. Other adapters are welcom
 
 ## Officially Supported
 
-* [ActiveRecord adapter](https://github.com/jnunemaker/flipper/blob/master/docs/active_record) - Rails 3, 4, and 5.
+* [ActiveRecord adapter](https://github.com/jnunemaker/flipper/blob/master/docs/active_record) - Rails 3, 4, 5, and 6.
 * [ActiveSupportCacheStore adapter](https://github.com/jnunemaker/flipper/blob/master/docs/active_support_cache_store) - ActiveSupport::Cache::Store
 * [Cassanity adapter](https://github.com/jnunemaker/flipper-cassanity)
 * [Http adapter](https://github.com/jnunemaker/flipper/blob/master/docs/http)

data/docs/Caveats.md

@@ -1,4 +1,4 @@
 # Caveats
 
-1. The [individual actor gate](https://github.com/jnunemaker/flipper/blob/master/docs/Gates.md#3-individual-actor) is typically not designed for hundreds or thousands of actors to be enabled. This is an explicit choice to make it easier to batch load data from the adapters instead of performing individual checks for actors over and over. If you need to enable something for more than 20 individual people, I would recommend using a [group](https://github.com/jnunemaker/flipper/blob/master/docs/Gates.md#2-group).
+1. The [individual actor gate](https://github.com/jnunemaker/flipper/blob/master/docs/Gates.md#2-individual-actor) is typically not designed for hundreds or thousands of actors to be enabled. This is an explicit choice to make it easier to batch load data from the adapters instead of performing individual checks for actors over and over. If you need to enable something for more than 20 individual people, I would recommend using a [group](https://github.com/jnunemaker/flipper/blob/master/docs/Gates.md#5-group).
 2. The disable method exists only to clear something that is enabled. If the thing you are disabling is not enabled, the disable is pointless. This means that if you enable one group an actor is in and disable another group, the feature will be enabled for the actor. ([related issue](https://github.com/jnunemaker/flipper/issues/71))

data/docs/DockerCompose.md

@@ -11,7 +11,6 @@ new contributor could start working on code with a minumum efforts.
 1. Install gems `docker-compose run --rm app bundle install`
 1. Run specs `docker-compose run --rm app bundle exec rspec`
 1. Run tests `docker-compose run --rm app bundle exec rake test`
-1. Clear and check files with Rubocop `docker-compose run --rm  app bundle exec rubocop -D`
 1. Optional: log in to container an using a `bash` shell for running specs
 ```sh
 docker-compose run --rm app bash

data/docs/Gates.md

@@ -96,7 +96,7 @@ flipper[:logging].enable percentage
 flipper[:logging].enabled? # this will return true 5% of the time.
 
 # you can also use shortcut methods
-flipper.enable_percentage_of_time :search, 5 # registers a feature called "enable_percentage_of_time" and enables it 5% of the time
+flipper.enable_percentage_of_time :search, 5 # registers a feature called "search" and enables it 5% of the time
 flipper.disable_percentage_of_time :search # sets to 0
 flipper[:search].enable_percentage_of_time 5
 flipper[:search].disable_percentage_of_time # sets to 0
@@ -139,7 +139,7 @@ Flipper.register(:admins) do |actor|
   actor.respond_to?(:admin?) && actor.admin?
 end
 ```
-- The above first registers a group called `admins` which essentially saves a [Proc](http://www.eriktrautman.com/posts/ruby-explained-blocks-procs-and-lambdas-aka-closures) to be called later.
+- The above first registers a group called `admins` which essentially saves a [Proc](http://www.eriktrautman.com/posts/ruby-explained-blocks-procs-and-lambdas-aka-closures) to be called later. The `actor` is an instance of the `Flipper::Types::Actor` that wraps the thing being checked against and `actor.thing` is the original object being checked. 
 
 ```
 flipper[:stats].enable flipper.group(:admins)

data/docs/api/README.md

@@ -527,7 +527,7 @@ Successful enabling of the actor will return a 200 HTTP status and the feature o
     {
       "key": "actors",
       "name": "actor",
-      "value": ["User:1"]
+      "value": ["User;1"]
     },
     {
       "key": "percentage_of_actors",
@@ -828,7 +828,7 @@ Successful disabling of a percentage of time will set the percentage to 0 and re
 **Request**
 
 ```
-curl -X GET http://example.com/flipper/api/actors/user:1?keys=my_feature_1,my_feature_2
+curl -X GET http://example.com/flipper/api/actors/User;1?keys=my_feature_1,my_feature_2
 ```
 
 **Response**
@@ -838,7 +838,7 @@ If no keys are specified all features are returned.
 
 ```json
 {
-  "flipper_id": "user:1",
+  "flipper_id": "User;1",
     "features": {
       "my_feature_1": {
         "enabled": true,

data/flipper.gemspec

@@ -25,7 +25,6 @@ Gem::Specification.new do |gem|
   gem.authors       = ['John Nunemaker']
   gem.email         = ['nunemaker@gmail.com']
   gem.summary       = 'Feature flipper for ANYTHING'
-  gem.description   = 'Feature flipper is the act of enabling/disabling features in your application, ideally without re-deploying or changing anything in your code base. Flipper makes this extremely easy to do with any backend you would like to use.'
   gem.homepage      = 'https://github.com/jnunemaker/flipper'
   gem.license       = 'MIT'
 

data/lib/flipper.rb

@@ -1,7 +1,7 @@
 require "forwardable"
 
 module Flipper
-  extend self # rubocop:disable Style/ModuleFunction
+  extend self
   extend Forwardable
 
   # Private: The namespace for all instrumented events.

data/lib/flipper/adapters/http/client.rb

@@ -21,6 +21,7 @@ module Flipper
           @basic_auth_password = options[:basic_auth_password]
           @read_timeout = options[:read_timeout]
           @open_timeout = options[:open_timeout]
+          @write_timeout = options[:write_timeout]
           @debug_output = options[:debug_output]
         end
 
@@ -57,6 +58,7 @@ module Flipper
           http = Net::HTTP.new(uri.host, uri.port)
           http.read_timeout = @read_timeout if @read_timeout
           http.open_timeout = @open_timeout if @open_timeout
+          apply_write_timeout(http)
           http.set_debug_output(@debug_output) if @debug_output
 
           if uri.scheme == HTTPS_SCHEME
@@ -79,6 +81,16 @@ module Flipper
 
           request
         end
+
+        def apply_write_timeout(http)
+          if @write_timeout
+            if RUBY_VERSION >= '2.6.0'
+              http.write_timeout = @write_timeout
+            else
+              Kernel.warn("Warning: option :write_timeout requires Ruby version 2.6.0 or later")
+            end
+          end
+        end
       end
     end
   end

data/lib/flipper/adapters/instrumented.rb

@@ -32,115 +32,117 @@ module Flipper
 
       # Public
       def features
-        payload = {
+        default_payload = {
           operation: :features,
           adapter_name: @adapter.name,
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.features
         end
       end
 
       # Public
       def add(feature)
-        payload = {
+        default_payload = {
           operation: :add,
           adapter_name: @adapter.name,
           feature_name: feature.name,
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.add(feature)
         end
       end
 
       # Public
       def remove(feature)
-        payload = {
+        default_payload = {
           operation: :remove,
           adapter_name: @adapter.name,
           feature_name: feature.name,
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.remove(feature)
         end
       end
 
       # Public
       def clear(feature)
-        payload = {
+        default_payload = {
           operation: :clear,
           adapter_name: @adapter.name,
           feature_name: feature.name,
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.clear(feature)
         end
       end
 
       # Public
       def get(feature)
-        payload = {
+        default_payload = {
           operation: :get,
           adapter_name: @adapter.name,
           feature_name: feature.name,
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.get(feature)
         end
       end
 
       def get_multi(features)
-        payload = {
+        default_payload = {
           operation: :get_multi,
           adapter_name: @adapter.name,
           feature_names: features.map(&:name),
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.get_multi(features)
         end
       end
 
       def get_all
-        payload = {
+        default_payload = {
           operation: :get_all,
           adapter_name: @adapter.name,
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.get_all
         end
       end
 
       # Public
       def enable(feature, gate, thing)
-        payload = {
+        default_payload = {
           operation: :enable,
           adapter_name: @adapter.name,
           feature_name: feature.name,
           gate_name: gate.name,
+          thing_value: thing.value,
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.enable(feature, gate, thing)
         end
       end
 
       # Public
       def disable(feature, gate, thing)
-        payload = {
+        default_payload = {
           operation: :disable,
           adapter_name: @adapter.name,
           feature_name: feature.name,
           gate_name: gate.name,
+          thing_value: thing.value,
         }
 
-        @instrumenter.instrument(InstrumentationName, payload) do |payload|
+        @instrumenter.instrument(InstrumentationName, default_payload) do |payload|
           payload[:result] = @adapter.disable(feature, gate, thing)
         end
       end

data/lib/flipper/adapters/memory.rb

@@ -2,7 +2,7 @@ require 'set'
 
 module Flipper
   module Adapters
-    # Public: Adapter for storing everything in memory (ie: Hash).
+    # Public: Adapter for storing everything in memory.
     # Useful for tests/specs.
     class Memory
       include ::Flipper::Adapter
@@ -65,7 +65,10 @@ module Flipper
       # Public
       def enable(feature, gate, thing)
         case gate.data_type
-        when :boolean, :integer
+        when :boolean
+          clear(feature)
+          write key(feature, gate), thing.value.to_s
+        when :integer
           write key(feature, gate), thing.value.to_s
         when :set
           set_add key(feature, gate), thing.value.to_s

data/lib/flipper/adapters/pstore.rb

@@ -84,7 +84,10 @@ module Flipper
       def enable(feature, gate, thing)
         @store.transaction do
           case gate.data_type
-          when :boolean, :integer
+          when :boolean
+            clear_gates(feature)
+            write key(feature, gate), thing.value.to_s
+          when :integer
             write key(feature, gate), thing.value.to_s
           when :set
             set_add key(feature, gate), thing.value.to_s

data/lib/flipper/feature.rb

@@ -5,7 +5,6 @@ require 'flipper/feature_check_context'
 require 'flipper/gate_values'
 
 module Flipper
-  # rubocop:disable Metrics/ClassLength
   class Feature
     # Private: The name of feature instrumentation events.
     InstrumentationName = "feature_operation.#{InstrumentationNamespace}".freeze
@@ -206,7 +205,7 @@ module Flipper
       boolean = gate(:boolean)
       non_boolean_gates = gates - [boolean]
 
-      if values.boolean || values.percentage_of_actors == 100 || values.percentage_of_time == 100
+      if values.boolean || values.percentage_of_time == 100
         :on
       elsif non_boolean_gates.detect { |gate| gate.enabled?(values[gate.key]) }
         :conditional

data/lib/flipper/middleware/memoizer.rb

@@ -23,7 +23,7 @@ module Flipper
       #
       def initialize(app, opts = {})
         if opts.is_a?(Flipper::DSL) || opts.is_a?(Proc)
-          raise 'Flipper::Middleware::Memoizer no longer initializes with a flipper instance or block. Read more at: https://git.io/vSo31.' # rubocop:disable LineLength
+          raise 'Flipper::Middleware::Memoizer no longer initializes with a flipper instance or block. Read more at: https://git.io/vSo31.'
         end
 
         @app = app

data/lib/flipper/spec/shared_adapter_specs.rb

@@ -1,6 +1,5 @@
 # Requires the following methods:
 # * subject - The instance of the adapter
-# rubocop:disable Metrics/BlockLength
 RSpec.shared_examples_for 'a flipper adapter' do
   let(:flipper) { Flipper.new(subject) }
   let(:feature) { flipper[:stats] }
@@ -280,4 +279,29 @@ RSpec.shared_examples_for 'a flipper adapter' do
     expect(subject.enable(feature, group_gate, flipper.group(:admins))).to eq(true)
     expect(subject.get(feature).fetch(:groups)).to eq(Set['admins'])
   end
+
+  it 'can double enable percentage without error' do
+    expect(subject.enable(feature, actors_gate, flipper.actors(25))).to eq(true)
+    expect(subject.enable(feature, actors_gate, flipper.actors(25))).to eq(true)
+  end
+
+  it 'can double enable without error' do
+    expect(subject.enable(feature, boolean_gate, flipper.boolean)).to eq(true)
+    expect(subject.enable(feature, boolean_gate, flipper.boolean)).to eq(true)
+  end
+
+  it 'can get_all features when there are none' do
+    expect(subject.features).to eq(Set.new)
+    expect(subject.get_all).to eq({})
+  end
+
+  it 'clears other gate values on enable' do
+    actor = Flipper::Actor.new('Flipper::Actor;22')
+    subject.enable(feature, actors_gate, flipper.actors(25))
+    subject.enable(feature, time_gate, flipper.time(25))
+    subject.enable(feature, group_gate, flipper.group(:admins))
+    subject.enable(feature, actor_gate, flipper.actor(actor))
+    subject.enable(feature, boolean_gate, flipper.boolean(true))
+    expect(subject.get(feature)).to eq(subject.default_config.merge(boolean: "true"))
+  end
 end

data/lib/flipper/test/shared_adapter_test.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Metrics/ModuleLength
 module Flipper
   module Test
     module SharedAdapterTests
@@ -43,7 +42,7 @@ module Flipper
         assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
         assert_equal 'true', @adapter.get(@feature)[:boolean]
         assert_equal true, @adapter.disable(@feature, @boolean_gate, @flipper.boolean(false))
-        assert_equal nil, @adapter.get(@feature)[:boolean]
+        assert_nil @adapter.get(@feature)[:boolean]
       end
 
       def test_fully_disables_all_enabled_things_when_boolean_gate_disabled
@@ -275,6 +274,32 @@ module Flipper
         assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
         assert_equal Set['admins'], @adapter.get(@feature).fetch(:groups)
       end
+
+      def test_can_double_enable_percentage_without_error
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
+      end
+
+      def test_can_double_enable_without_error
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+      end
+
+      def test_can_get_all_features_when_there_are_none
+        expected = {}
+        assert_equal Set.new, @adapter.features
+        assert_equal expected, @adapter.get_all
+      end
+
+      def test_clears_other_gate_values_on_enable
+        actor = Flipper::Actor.new('Flipper::Actor;22')
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
+        assert_equal true, @adapter.enable(@feature, @time_gate, @flipper.time(25))
+        assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor))
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean(true))
+        assert_equal @adapter.default_config.merge(boolean: "true"), @adapter.get(@feature)
+      end
     end
   end
 end

data/lib/flipper/types/group.rb

@@ -14,7 +14,7 @@ module Flipper
 
         if block_given?
           @block = block
-          @single_argument = @block.arity == 1
+          @single_argument = @block.arity.abs == 1
         else
           @block = ->(_thing, _context) { false }
           @single_argument = false

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.16.1'.freeze
+  VERSION = '0.19.0'.freeze
 end

data/spec/flipper/adapter_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe Flipper::Adapter do
   describe '.default_config' do
     it 'returns default config' do
       adapter_class = Class.new do
-        include Flipper::Adapter # rubocop:disable RSpec/DescribedClass
+        include Flipper::Adapter
       end
       expect(adapter_class.default_config).to eq(default_config)
     end
@@ -25,7 +25,7 @@ RSpec.describe Flipper::Adapter do
   describe '#default_config' do
     it 'returns default config' do
       adapter_class = Class.new do
-        include Flipper::Adapter # rubocop:disable RSpec/DescribedClass
+        include Flipper::Adapter
       end
       expect(adapter_class.new.default_config).to eq(default_config)
     end

data/spec/flipper/adapters/http_spec.rb

@@ -128,6 +128,7 @@ RSpec.describe Flipper::Adapters::Http do
         basic_auth_password: 'password',
         read_timeout: 100,
         open_timeout: 40,
+        write_timeout: 40,
         debug_output: debug_output,
       }
     end

data/spec/flipper/adapters/instrumented_spec.rb

@@ -73,6 +73,7 @@ RSpec.describe Flipper::Adapters::Instrumented do
       expect(event.payload[:adapter_name]).to eq(:memory)
       expect(event.payload[:feature_name]).to eq(:stats)
       expect(event.payload[:gate_name]).to eq(:percentage_of_actors)
+      expect(event.payload[:thing_value]).to eq(22)
       expect(event.payload[:result]).to be(result)
     end
   end
@@ -88,6 +89,7 @@ RSpec.describe Flipper::Adapters::Instrumented do
       expect(event.payload[:adapter_name]).to eq(:memory)
       expect(event.payload[:feature_name]).to eq(:stats)
       expect(event.payload[:gate_name]).to eq(:percentage_of_actors)
+      expect(event.payload[:thing_value]).to eq(22)
       expect(event.payload[:result]).to be(result)
     end
   end

data/spec/flipper/feature_check_context_spec.rb

@@ -41,8 +41,8 @@ RSpec.describe Flipper::FeatureCheckContext do
   end
 
   it 'knows actors_value' do
-    args = options.merge(values: Flipper::GateValues.new(actors: Set['User:1']))
-    expect(described_class.new(args).actors_value).to eq(Set['User:1'])
+    args = options.merge(values: Flipper::GateValues.new(actors: Set['User;1']))
+    expect(described_class.new(args).actors_value).to eq(Set['User;1'])
   end
 
   it 'knows groups_value' do

data/spec/flipper/feature_spec.rb

@@ -359,19 +359,19 @@ RSpec.describe Flipper::Feature do
       end
 
       it 'returns :on' do
-        expect(subject.state).to be(:on)
+        expect(subject.state).to be(:conditional)
       end
 
-      it 'returns true for on?' do
-        expect(subject.on?).to be(true)
+      it 'returns false for on?' do
+        expect(subject.on?).to be(false)
       end
 
       it 'returns false for off?' do
         expect(subject.off?).to be(false)
       end
 
-      it 'returns false for conditional?' do
-        expect(subject.conditional?).to be(false)
+      it 'returns true for conditional?' do
+        expect(subject.conditional?).to be(true)
       end
     end
 
@@ -530,12 +530,12 @@ RSpec.describe Flipper::Feature do
 
     context 'when one or more actors are enabled' do
       before do
-        subject.enable Flipper::Types::Actor.new(Flipper::Actor.new('User:5'))
-        subject.enable Flipper::Types::Actor.new(Flipper::Actor.new('User:22'))
+        subject.enable Flipper::Types::Actor.new(Flipper::Actor.new('User;5'))
+        subject.enable Flipper::Types::Actor.new(Flipper::Actor.new('User;22'))
       end
 
       it 'returns set of actor ids' do
-        expect(subject.actors_value).to eq(Set.new(['User:5', 'User:22']))
+        expect(subject.actors_value).to eq(Set.new(['User;5', 'User;22']))
       end
     end
   end

data/spec/flipper/middleware/memoizer_spec.rb

@@ -342,7 +342,7 @@ RSpec.describe Flipper::Middleware::Memoizer do
     it 'eagerly caches known features for duration of request' do
       memory = Flipper::Adapters::Memory.new
       logged_memory = Flipper::Adapters::OperationLogger.new(memory)
-      cache = ActiveSupport::Cache::DalliStore.new
+      cache = ActiveSupport::Cache::DalliStore.new(ENV['MEMCACHED_URL'])
       cache.clear
       cached = Flipper::Adapters::ActiveSupportCacheStore.new(logged_memory, cache, expires_in: 10)
       logged_cached = Flipper::Adapters::OperationLogger.new(cached)

data/spec/flipper/types/group_spec.rb

@@ -65,6 +65,28 @@ RSpec.describe Flipper::Types::Group do
       expect(group.match?(double('Actor'), fake_context)).to be_falsey
     end
 
+    it 'returns true for truthy shortand block results' do
+      actor = Class.new do
+        def admin?
+          true
+        end
+      end.new
+
+      group = described_class.new(:admin, &:admin?)
+      expect(group.match?(actor, fake_context)).to be_truthy
+    end
+
+    it 'returns false for falsy shortand block results' do
+      actor = Class.new do
+        def admin?
+          false
+        end
+      end.new
+
+      group = described_class.new(:admin, &:admin?)
+      expect(group.match?(actor, fake_context)).to be_falsey
+    end
+
     it 'can yield without context as block argument' do
       context = Flipper::FeatureCheckContext.new(
         feature_name: :my_feature,

data/spec/helper.rb

@@ -17,7 +17,7 @@ require 'flipper'
 require 'flipper-ui'
 require 'flipper-api'
 
-Dir[FlipperRoot.join('spec/support/**/*.rb')].each { |f| require f }
+Dir[FlipperRoot.join('spec/support/**/*.rb')].sort.each { |f| require f }
 
 RSpec.configure do |config|
   config.before(:example) do

data/spec/support/descriptions.yml

@@ -0,0 +1 @@
+some_awesome_feature: 'Awesome feature description'

data/test/test_helper.rb

@@ -1,6 +1,6 @@
 require 'flipper'
 require 'minitest/autorun'
 require 'minitest/unit'
-Dir['./lib/flipper/test/*.rb'].each { |f| require(f) }
+Dir['./lib/flipper/test/*.rb'].sort.each { |f| require(f) }
 
 FlipperRoot = Pathname(__FILE__).dirname.join('..').expand_path

data/{test → test_rails}/helper.rb

@@ -6,6 +6,6 @@ require 'rails/test_help'
 
 begin
   ActiveSupport::TestCase.test_order = :random
-rescue NoMethodError => boom
+rescue NoMethodError
   # no biggie, means we are on older version of AS that doesn't have this option
 end

metadata

@@ -1,18 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.16.1
+  version: 0.19.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-05 00:00:00.000000000 Z
+date: 2020-09-25 00:00:00.000000000 Z
 dependencies: []
-description: Feature flipper is the act of enabling/disabling features in your application,
-  ideally without re-deploying or changing anything in your code base. Flipper makes
-  this extremely easy to do with any backend you would like to use.
+description: 
 email:
 - nunemaker@gmail.com
 executables: []
@@ -20,8 +18,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
 - CODE_OF_CONDUCT.md
 - Changelog.md
 - Dockerfile
@@ -143,15 +139,16 @@ files:
 - spec/flipper/types/percentage_of_actors_spec.rb
 - spec/flipper/types/percentage_of_time_spec.rb
 - spec/flipper/types/percentage_spec.rb
+- spec/flipper_integration_spec.rb
 - spec/flipper_spec.rb
 - spec/helper.rb
-- spec/integration_spec.rb
+- spec/support/descriptions.yml
 - spec/support/fake_udp_socket.rb
 - spec/support/spec_helpers.rb
 - test/adapters/memory_test.rb
 - test/adapters/pstore_test.rb
-- test/helper.rb
 - test/test_helper.rb
+- test_rails/helper.rb
 homepage: https://github.com/jnunemaker/flipper
 licenses:
 - MIT
@@ -172,8 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.4
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Feature flipper for ANYTHING
@@ -217,12 +213,12 @@ test_files:
 - spec/flipper/types/percentage_of_actors_spec.rb
 - spec/flipper/types/percentage_of_time_spec.rb
 - spec/flipper/types/percentage_spec.rb
+- spec/flipper_integration_spec.rb
 - spec/flipper_spec.rb
 - spec/helper.rb
-- spec/integration_spec.rb
+- spec/support/descriptions.yml
 - spec/support/fake_udp_socket.rb
 - spec/support/spec_helpers.rb
 - test/adapters/memory_test.rb
 - test/adapters/pstore_test.rb
-- test/helper.rb
 - test/test_helper.rb

data/.rubocop.yml

@@ -1,54 +0,0 @@
-# This is the configuration used to check the rubocop source code.
-
-require: rubocop-rspec
-inherit_from:
-  - .rubocop_todo.yml
-
-AllCops:
-  Exclude:
-    - 'docker-compose/**/*'
-    - 'examples/**/*'
-    - 'tmp/**/*'
-    - 'bin/**/*'
-  TargetRubyVersion: 2.0
-  # DefaultFormatter: fuubar
-Style/Alias:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
-
-Style/Encoding:
-  Enabled: false
-
-Style/NumericLiterals:
-  Enabled: false
-
-Style/StringLiterals:
-  Enabled: false
-
-Style/GuardClause:
-  Enabled: false
-
-Style/IfUnlessModifier:
-  Enabled: false
-
-Metrics/LineLength:
-  Max: 100
-  Exclude:
-    - '*.gemspec'
-
-Style/RegexpLiteral:
-  EnforcedStyle: mixed
-
-Style/TrailingCommaInLiteral:
-  EnforcedStyleForMultiline: consistent_comma
-
-RSpec/InstanceVariable:
-  Enabled: false
-
-Style/AccessorMethodName:
-  Enabled: false
-
-Lint/HandleExceptions:
-  Enabled: false

data/.rubocop_todo.yml

@@ -1,199 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2016-11-20 15:49:33 +0000 using RuboCop version 0.45.0.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-require: rubocop-rspec
-
-# Offense count: 2
-Lint/AmbiguousRegexpLiteral:
-  Exclude:
-    - 'lib/flipper/instrumentation/metriks.rb'
-    - 'lib/flipper/instrumentation/statsd.rb'
-
-# Offense count: 6
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Exclude:
-    - 'lib/flipper/adapters/active_record.rb'
-    - 'lib/flipper/adapters/sequel.rb'
-    - 'lib/flipper/feature.rb'
-    - 'lib/flipper/gate_values.rb'
-
-# Offense count: 1
-Lint/Eval:
-  Exclude:
-    - 'flipper.gemspec'
-
-# Offense count: 3
-Lint/HandleExceptions:
-  Exclude:
-    - 'spec/flipper/adapters/mongo_spec.rb'
-    - 'test/adapters/mongo_test.rb'
-    - 'test/helper.rb'
-
-# Offense count: 24
-Lint/ShadowingOuterLocalVariable:
-  Exclude:
-    - 'lib/flipper/adapters/active_record.rb'
-    - 'lib/flipper/adapters/instrumented.rb'
-    - 'lib/flipper/adapters/sequel.rb'
-    - 'spec/flipper/api/v1/actions/actors_gate_spec.rb'
-    - 'spec/flipper/api/v1/actions/percentage_of_actors_gate_spec.rb'
-    - 'spec/flipper/api/v1/actions/percentage_of_time_gate_spec.rb'
-    - 'spec/flipper/dsl_spec.rb'
-    - 'spec/flipper/feature_spec.rb'
-    - 'spec/flipper/types/group_spec.rb'
-
-# Offense count: 26
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/flipper/instrumentation/log_subscriber.rb'
-    - 'lib/flipper/instrumentation/subscriber.rb'
-    - 'lib/flipper/ui/actions/groups_gate.rb'
-    - 'spec/flipper/api/action_spec.rb'
-    - 'spec/flipper/dsl_spec.rb'
-    - 'spec/flipper/feature_spec.rb'
-    - 'spec/flipper/gates/group_spec.rb'
-    - 'spec/flipper/instrumentation/metriks_subscriber_spec.rb'
-    - 'spec/flipper/instrumentation/statsd_subscriber_spec.rb'
-    - 'spec/flipper_spec.rb'
-    - 'spec/flipper/middleware/memoizer_spec.rb'
-    - 'test/helper.rb'
-
-# Offense count: 27
-Metrics/AbcSize:
-  Max: 30
-
-# Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/BlockLength:
-  Max: 195
-
-# Offense count: 4
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 178
-
-# Offense count: 39
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 23
-
-# Offense count: 65
-# Configuration parameters: Max.
-RSpec/ExampleLength:
-  Enabled: false
-
-# Offense count: 2
-# Configuration parameters: CustomTransform.
-RSpec/FilePath:
-  Exclude:
-    - 'spec/flipper/adapters/pstore_spec.rb'
-    - 'spec/integration_spec.rb'
-
-# Offense count: 91
-RSpec/InstanceVariable:
-  Exclude:
-    - 'spec/flipper/adapters/operation_logger_spec.rb'
-    - 'spec/flipper/dsl_spec.rb'
-    - 'spec/flipper/feature_spec.rb'
-    - 'spec/flipper/instrumentation/log_subscriber_spec.rb'
-    - 'spec/flipper/ui/actions/add_feature_spec.rb'
-    - 'spec/flipper/ui/actions/features_spec.rb'
-    - 'spec/flipper/ui/decorators/feature_spec.rb'
-    - 'spec/flipper/ui/decorators/gate_spec.rb'
-    - 'spec/flipper/ui_spec.rb'
-    - 'spec/flipper_spec.rb'
-    - 'spec/integration_spec.rb'
-
-# Offense count: 15
-# Configuration parameters: IgnoreSymbolicNames.
-RSpec/VerifiedDoubles:
-  Exclude:
-    - 'spec/flipper/api/v1/actions/features_spec.rb'
-    - 'spec/flipper/dsl_spec.rb'
-    - 'spec/flipper/feature_spec.rb'
-    - 'spec/flipper/types/group_spec.rb'
-    - 'spec/flipper_spec.rb'
-    - 'spec/integration_spec.rb'
-
-# Offense count: 2
-Style/AccessorMethodName:
-  Exclude:
-    - 'lib/flipper/adapters/memory.rb'
-    - 'lib/flipper/adapters/pstore.rb'
-
-# Offense count: 7
-Style/ConstantName:
-  Exclude:
-    - 'lib/flipper.rb'
-    - 'lib/flipper/adapters/dalli.rb'
-    - 'lib/flipper/adapters/memoizable.rb'
-    - 'lib/flipper/adapters/memory.rb'
-    - 'lib/flipper/adapters/mongo.rb'
-    - 'lib/flipper/adapters/pstore.rb'
-    - 'lib/flipper/adapters/redis.rb'
-
-# Offense count: 3
-Style/DoubleNegation:
-  Exclude:
-    - 'lib/flipper/adapters/memoizable.rb'
-    - 'lib/flipper/gates/boolean.rb'
-    - 'lib/flipper/typecast.rb'
-
-# Offense count: 7
-# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
-Style/FileName:
-  Exclude:
-    - 'lib/flipper-active_record.rb'
-    - 'lib/flipper-api.rb'
-    - 'lib/flipper-active_support_cache_store.rb'
-    - 'lib/flipper-cloud.rb'
-    - 'lib/flipper-dalli.rb'
-    - 'lib/flipper-mongo.rb'
-    - 'lib/flipper-redis.rb'
-    - 'lib/flipper-sequel.rb'
-    - 'lib/flipper-ui.rb'
-
-# Offense count: 2
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: format, sprintf, percent
-Style/FormatString:
-  Exclude:
-    - 'lib/flipper/instrumentation/log_subscriber.rb'
-
-# Offense count: 10
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Exclude:
-    - 'lib/flipper/api/v1/actions/percentage_of_actors_gate.rb'
-    - 'lib/flipper/api/v1/actions/percentage_of_time_gate.rb'
-    - 'lib/flipper/gate_values.rb'
-    - 'lib/flipper/instrumentation/statsd_subscriber.rb'
-    - 'lib/flipper/instrumentation/subscriber.rb'
-    - 'lib/flipper/registry.rb'
-    - 'lib/flipper/typecast.rb'
-
-# Offense count: 1
-Style/IfInsideElse:
-  Exclude:
-    - 'lib/flipper/gates/actor.rb'
-
-# Offense count: 1
-Style/MethodMissing:
-  Exclude:
-    - 'lib/flipper/types/actor.rb'
-
-Style/AccessorMethodName:
-  Exclude:
-    - 'lib/flipper/adapter.rb'
-    - 'lib/flipper/adapters/http.rb'
-    - 'lib/flipper/adapters/instrumented.rb'
-    - 'lib/flipper/adapters/memoizable.rb'
-    - 'lib/flipper/adapters/operation_logger.rb'
-    - 'lib/flipper/adapters/memory.rb'
-    - 'lib/flipper/adapters/pstore.rb'