flipper 0.16.0 → 1.4.0

data/spec/flipper/expressions/percentage_of_actors_spec.rb

@@ -0,0 +1,20 @@
+RSpec.describe Flipper::Expressions::PercentageOfActors do
+  describe "#call" do
+    it "returns true when string in percentage enabled" do
+      expect(described_class.call("User;1", 42)).to be(true)
+    end
+
+    it "returns true when string in fractional percentage enabled" do
+      expect(described_class.call("User;1", 41.687)).to be(true)
+    end
+
+    it "returns false when string in percentage enabled" do
+      expect(described_class.call("User;1", 0)).to be(false)
+    end
+
+    it "changes value based on feature_name so not all actors get all features first" do
+      expect(described_class.call("User;1", 70, context: {feature_name: "a"})).to be(true)
+      expect(described_class.call("User;1", 70, context: {feature_name: "b"})).to be(false)
+    end
+  end
+end

data/spec/flipper/expressions/percentage_spec.rb

@@ -0,0 +1,15 @@
+RSpec.describe Flipper::Expressions::Percentage do
+  describe "#call" do
+    it "returns numeric" do
+      expect(described_class.call(10)).to be(10.0)
+    end
+
+    it "returns 0 if less than 0" do
+      expect(described_class.call(-1)).to be(0)
+    end
+
+    it "returns 100 if greater than 100" do
+      expect(described_class.call(101)).to be(100)
+    end
+  end
+end

data/spec/flipper/expressions/property_spec.rb

@@ -0,0 +1,13 @@
+RSpec.describe Flipper::Expressions::Property do
+  describe "#call" do
+    it "returns value for property key" do
+      context = { properties: { "flipper_id" => "User;1" } }
+      expect(described_class.call("flipper_id", context: context)).to eq("User;1")
+    end
+
+    it "returns nil if key not found in properties" do
+      context = { properties: { } }
+      expect(described_class.call("flipper_id", context: context)).to be(nil)
+    end
+  end
+end

data/spec/flipper/expressions/random_spec.rb

@@ -0,0 +1,9 @@
+RSpec.describe Flipper::Expressions::Random do
+  describe "#call" do
+    it "returns random number based on max" do
+      100.times do
+        expect(described_class.call(10)).to be_between(0, 10)
+      end
+    end
+  end
+end

data/spec/flipper/expressions/string_spec.rb

@@ -0,0 +1,11 @@
+RSpec.describe Flipper::Expressions::String do
+  describe "#call" do
+    it "returns String for Numeric" do
+      expect(described_class.call(10)).to eq("10")
+    end
+
+    it "returns String" do
+      expect(described_class.call("test")).to eq("test")
+    end
+  end
+end

data/spec/flipper/expressions/time_spec.rb

@@ -0,0 +1,29 @@
+RSpec.describe Flipper::Expressions::Time do
+  let(:time) { Time.now.round }
+
+  describe "#call" do
+    it "returns time for #to_s format" do
+      expect(described_class.call(time.to_s)).to eq(time)
+    end
+
+    it "returns time for #iso8601 format" do
+      expect(described_class.call(time.iso8601)).to eq(time)
+    end
+
+    it "returns time for epoch integer" do
+      expect(described_class.call(time.to_i)).to eq(Time.at(time.to_i).utc)
+    end
+
+    it "returns time for epoch float" do
+      expect(described_class.call(time.to_f)).to be_within(0.001).of(time)
+    end
+
+    it "returns utc for string input" do
+      expect(described_class.call(time.to_s).utc?).to be(true)
+    end
+
+    it "returns utc for numeric input" do
+      expect(described_class.call(time.to_i).utc?).to be(true)
+    end
+  end
+end

data/spec/flipper/feature_check_context_spec.rb

@@ -1,67 +1,65 @@
-require 'helper'
-
 RSpec.describe Flipper::FeatureCheckContext do
   let(:feature_name) { :new_profiles }
   let(:values) { Flipper::GateValues.new({}) }
-  let(:thing) { Flipper::Actor.new('5') }
+  let(:actor) { Flipper::Actor.new('5') }
   let(:options) do
     {
       feature_name: feature_name,
       values: values,
-      thing: thing,
+      actors: [actor],
     }
   end
 
   it 'initializes just fine' do
-    instance = described_class.new(options)
+    instance = described_class.new(**options)
     expect(instance.feature_name).to eq(feature_name)
     expect(instance.values).to eq(values)
-    expect(instance.thing).to eq(thing)
+    expect(instance.actors).to eq([actor])
   end
 
   it 'requires feature_name' do
     options.delete(:feature_name)
     expect do
-      described_class.new(options)
-    end.to raise_error(KeyError)
+      described_class.new(**options)
+    end.to raise_error(ArgumentError)
   end
 
   it 'requires values' do
     options.delete(:values)
     expect do
-      described_class.new(options)
-    end.to raise_error(KeyError)
+      described_class.new(**options)
+    end.to raise_error(ArgumentError)
   end
 
-  it 'requires thing' do
-    options.delete(:thing)
+  it 'requires actors' do
+    options.delete(:actors)
     expect do
-      described_class.new(options)
-    end.to raise_error(KeyError)
+      described_class.new(**options)
+    end.to raise_error(ArgumentError)
   end
 
   it 'knows actors_value' do
-    args = options.merge(values: Flipper::GateValues.new(actors: Set['User:1']))
-    expect(described_class.new(args).actors_value).to eq(Set['User:1'])
+    args = options.merge(values: Flipper::GateValues.new(actors: Set['User;1']))
+    expect(described_class.new(**args).actors_value).to eq(Set['User;1'])
   end
 
   it 'knows groups_value' do
     args = options.merge(values: Flipper::GateValues.new(groups: Set['admins']))
-    expect(described_class.new(args).groups_value).to eq(Set['admins'])
+    expect(described_class.new(**args).groups_value).to eq(Set['admins'])
   end
 
   it 'knows boolean_value' do
-    instance = described_class.new(options.merge(values: Flipper::GateValues.new(boolean: true)))
+    instance = described_class.new(**options.merge(values: Flipper::GateValues.new(boolean: true)))
     expect(instance.boolean_value).to eq(true)
   end
 
   it 'knows percentage_of_actors_value' do
     args = options.merge(values: Flipper::GateValues.new(percentage_of_actors: 14))
-    expect(described_class.new(args).percentage_of_actors_value).to eq(14)
+    expect(described_class.new(**args).percentage_of_actors_value).to eq(14)
   end
 
   it 'knows percentage_of_time_value' do
     args = options.merge(values: Flipper::GateValues.new(percentage_of_time: 41))
-    expect(described_class.new(args).percentage_of_time_value).to eq(41)
+    expect(described_class.new(**args).percentage_of_time_value).to eq(41)
   end
 end