flipper 0.11.0.beta6 → 0.11.0.beta7

data/spec/helper.rb

@@ -22,6 +22,7 @@ Dir[FlipperRoot.join('spec/support/**/*.rb')].each { |f| require f }
 RSpec.configure do |config|
   config.before(:example) do
     Flipper.unregister_groups
+    Flipper.configuration = nil
   end
 
   config.disable_monkey_patching!

data/spec/integration_spec.rb

@@ -132,6 +132,29 @@ RSpec.describe Flipper do
       end
     end
 
+    context 'with a float percentage of actors' do
+      before do
+        @result = feature.enable_percentage_of_actors 5.1
+      end
+
+      it 'returns true' do
+        expect(@result).to eq(true)
+      end
+
+      it 'enables feature for actor within percentage' do
+        enabled = (1..100).select do |i|
+          thing = Flipper::Actor.new(i)
+          feature.enabled?(thing)
+        end.size
+
+        expect(enabled).to be_within(2).of(5)
+      end
+
+      it 'adds feature to set of features' do
+        expect(flipper.features.map(&:name)).to include(:search)
+      end
+    end
+
     context 'with a percentage of time' do
       before do
         @gate = feature.gate(:percentage_of_time)
@@ -411,10 +434,27 @@ RSpec.describe Flipper do
       end
     end
 
-    context 'for not enabled percentage of time' do
+    context 'for enabled float percentage of time' do
       before do
-        # ensure percentage of time returns percentage that makes five percent
-        # of time false
+        # ensure percentage of time returns percentage that makes 4.1 percent
+        # of time true
+        @gate = feature.gate(:percentage_of_time)
+        allow(@gate).to receive_messages(rand: 0.04)
+
+        feature.enable_percentage_of_time 4.1
+      end
+
+      it 'returns true' do
+        expect(feature.enabled?).to eq(true)
+        expect(feature.enabled?(nil)).to eq(true)
+        expect(feature.enabled?(pitt)).to eq(true)
+        expect(feature.enabled?(admin_thing)).to eq(true)
+      end
+    end
+
+    context 'for NOT enabled integer percentage of time' do
+      before do
+        # ensure percentage of time returns percentage that makes enabled? false
         @gate = feature.gate(:percentage_of_time)
         allow(@gate).to receive_messages(rand: 0.10)
 
@@ -437,6 +477,31 @@ RSpec.describe Flipper do
       end
     end
 
+    context 'for NOT enabled float percentage of time' do
+      before do
+        # ensure percentage of time returns percentage that makes enabled? false
+        @gate = feature.gate(:percentage_of_time)
+        allow(@gate).to receive_messages(rand: 0.10)
+
+        feature.enable_percentage_of_time 9.9
+      end
+
+      it 'returns false' do
+        expect(feature.enabled?).to eq(false)
+        expect(feature.enabled?(nil)).to eq(false)
+        expect(feature.enabled?(pitt)).to eq(false)
+        expect(feature.enabled?(admin_thing)).to eq(false)
+      end
+
+      it 'returns true if boolean enabled' do
+        feature.enable
+        expect(feature.enabled?).to eq(true)
+        expect(feature.enabled?(nil)).to eq(true)
+        expect(feature.enabled?(pitt)).to eq(true)
+        expect(feature.enabled?(admin_thing)).to eq(true)
+      end
+    end
+
     context 'for a non flipper thing' do
       before do
         feature.enable admin_group

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.11.0.beta6
+  version: 0.11.0.beta7
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-11 00:00:00.000000000 Z
+date: 2017-07-26 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper is the act of enabling/disabling features in your application,
   ideally without re-deploying or changing anything in your code base. Flipper makes
@@ -38,6 +38,7 @@ files:
 - docs/http/README.md
 - docs/read-only/README.md
 - examples/basic.rb
+- examples/configuring_default.rb
 - examples/dsl.rb
 - examples/enabled_for_actor.rb
 - examples/example_setup.rb
@@ -51,11 +52,11 @@ files:
 - examples/percentage_of_actors_enabled_check.rb
 - examples/percentage_of_actors_group.rb
 - examples/percentage_of_time.rb
+- flipper-cache-store.gemspec
 - flipper.gemspec
 - lib/flipper.rb
 - lib/flipper/actor.rb
 - lib/flipper/adapter.rb
-- lib/flipper/adapters/cache_store.rb
 - lib/flipper/adapters/http.rb
 - lib/flipper/adapters/http/client.rb
 - lib/flipper/adapters/http/error.rb
@@ -65,6 +66,7 @@ files:
 - lib/flipper/adapters/operation_logger.rb
 - lib/flipper/adapters/pstore.rb
 - lib/flipper/adapters/read_only.rb
+- lib/flipper/configuration.rb
 - lib/flipper/dsl.rb
 - lib/flipper/errors.rb
 - lib/flipper/feature.rb
@@ -101,7 +103,6 @@ files:
 - spec/fixtures/feature.json
 - spec/flipper/actor_spec.rb
 - spec/flipper/adapter_spec.rb
-- spec/flipper/adapters/cache_store_spec.rb
 - spec/flipper/adapters/http_spec.rb
 - spec/flipper/adapters/instrumented_spec.rb
 - spec/flipper/adapters/memoizable_spec.rb
@@ -109,6 +110,7 @@ files:
 - spec/flipper/adapters/operation_logger_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
+- spec/flipper/configuration_spec.rb
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_check_context_spec.rb
 - spec/flipper/feature_spec.rb
@@ -171,7 +173,6 @@ test_files:
 - spec/fixtures/feature.json
 - spec/flipper/actor_spec.rb
 - spec/flipper/adapter_spec.rb
-- spec/flipper/adapters/cache_store_spec.rb
 - spec/flipper/adapters/http_spec.rb
 - spec/flipper/adapters/instrumented_spec.rb
 - spec/flipper/adapters/memoizable_spec.rb
@@ -179,6 +180,7 @@ test_files:
 - spec/flipper/adapters/operation_logger_spec.rb
 - spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/adapters/read_only_spec.rb
+- spec/flipper/configuration_spec.rb
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_check_context_spec.rb
 - spec/flipper/feature_spec.rb

data/lib/flipper/adapters/cache_store.rb

@@ -1,104 +0,0 @@
-module Flipper
-  module Adapters
-    # Public: Adapter that wraps another adapter with the ability to cache
-    # adapter calls in ActiveSupport::CacheStore caches.
-    #
-    class CacheStore
-      include ::Flipper::Adapter
-
-      Version = 'v1'.freeze
-      Namespace = "flipper/#{Version}".freeze
-      FeaturesKey = "#{Namespace}/features".freeze
-
-      # Private
-      def self.key_for(key)
-        "#{Namespace}/feature/#{key}"
-      end
-
-      # Internal
-      attr_reader :cache
-
-      # Public: The name of the adapter.
-      attr_reader :name
-
-      # Public
-      def initialize(adapter, cache, expires_in: nil)
-        @adapter = adapter
-        @name = :cache_store
-        @cache = cache
-        @write_options = {}
-        @write_options.merge!(expires_in: expires_in) if expires_in
-      end
-
-      # Public
-      def features
-        @cache.fetch(FeaturesKey, @write_options) do
-          @adapter.features
-        end
-      end
-
-      # Public
-      def add(feature)
-        result = @adapter.add(feature)
-        @cache.delete(FeaturesKey)
-        result
-      end
-
-      ## Public
-      def remove(feature)
-        result = @adapter.remove(feature)
-        @cache.delete(FeaturesKey)
-        @cache.delete(key_for(feature.key))
-        result
-      end
-
-      ## Public
-      def clear(feature)
-        result = @adapter.clear(feature)
-        @cache.delete(key_for(feature.key))
-        result
-      end
-
-      ## Public
-      def get(feature)
-        @cache.fetch(key_for(feature.key), @write_options) do
-          @adapter.get(feature)
-        end
-      end
-
-      def get_multi(features)
-        keys = features.map { |feature| key_for(feature.key) }
-        result = @cache.read_multi(keys)
-        uncached_features = features.reject { |feature| result[feature.key] }
-        if uncached_features.any?
-          response = @adapter.get_multi(uncached_features)
-          response.each do |key, value|
-            @cache.write(key_for(key), value, @write_options)
-            result[key] = value
-          end
-        end
-        result
-      end
-
-      ## Public
-      def enable(feature, gate, thing)
-        result = @adapter.enable(feature, gate, thing)
-        @cache.delete(key_for(feature.key))
-        result
-      end
-
-      ## Public
-      def disable(feature, gate, thing)
-        result = @adapter.disable(feature, gate, thing)
-        @cache.delete(key_for(feature.key))
-        result
-      end
-
-      private
-
-      def key_for(key)
-        self.class.key_for(key)
-      end
-    end
-  end
-end

data/spec/flipper/adapters/cache_store_spec.rb

@@ -1,50 +0,0 @@
-require 'helper'
-require 'active_support/cache'
-require 'flipper/adapters/memory'
-require 'flipper/adapters/cache_store'
-require 'flipper/spec/shared_adapter_specs'
-
-RSpec.describe Flipper::Adapters::CacheStore do
-  let(:memory_adapter) { Flipper::Adapters::Memory.new }
-  let(:cache) { ActiveSupport::Cache::MemoryStore.new }
-  let(:adapter) { described_class.new(memory_adapter, cache) }
-  let(:flipper) { Flipper.new(adapter) }
-
-  subject { adapter }
-
-  it_should_behave_like 'a flipper adapter'
-
-  describe '#remove' do
-    it 'expires feature' do
-      feature = flipper[:stats]
-      adapter.get(feature)
-      adapter.remove(feature)
-      expect(cache.read(described_class.key_for(feature))).to be(nil)
-    end
-  end
-
-  describe '#get_multi' do
-    it 'warms uncached features' do
-      stats = flipper[:stats]
-      search = flipper[:search]
-      other = flipper[:other]
-      stats.enable
-      search.enable
-
-      adapter.get(stats)
-      expect(cache.read(described_class.key_for(search))).to be(nil)
-      expect(cache.read(described_class.key_for(other))).to be(nil)
-
-      adapter.get_multi([stats, search, other])
-
-      expect(cache.read(described_class.key_for(search))[:boolean]).to eq('true')
-      expect(cache.read(described_class.key_for(other))[:boolean]).to be(nil)
-    end
-  end
-
-  describe '#name' do
-    it 'is cache_store' do
-      expect(subject.name).to be(:cache_store)
-    end
-  end
-end