flipper-ui 0.26.0.rc2 → 0.26.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c2e1ad8439dbc0b215ffdf8c55491eccb01c129348e44e2e2f52d3347c3a8ff5
-  data.tar.gz: c30b64c7b661d6a7163c6042bef817254ce85829f01602d08a11a3ec72382e70
+  metadata.gz: fb876470ebb6b05094e57f03964f9c32eac27f52dd449ea6bba74a40d5aaa4bd
+  data.tar.gz: 2511d18885a5b94104ba2e8ad5845079be6425ea18425f5cfd01ac080cc7d0ad
 SHA512:
-  metadata.gz: ab411eb73a497b554c133eb3b448a86d0b736b1d82b19b280682082a0834bd5f688cb6406e42c86cda5bbe01244a208ba7d6ef630dbff310b7b24023fa2fe739
-  data.tar.gz: e7e739c84acaca3b0012953c6dfc32a6d3cb8b1bf33d3d258d03016b9183b702b2d33c972b0d8f48a055b2b7b8ea432c82fd95d6ad45f64357cc95296ba4b780
+  metadata.gz: d92a393344d56c17ef6e2c745d210879b5c2a457926f9663461fd68c4368294328bf81c3710b197f9744739e7d3ffc52a30ea8af6adce49a63bca5e58da23ee3
+  data.tar.gz: e4f03b7e76dc5238a4e7e02ba9a77beaa2c92e21b1b92c931f932bd2d588e789eec4e826e1d0ea833fb9f9918610d71a317a42d0ed49dc1595a7da592886df0f

data/lib/flipper/ui/public/js/application.js

@@ -5,7 +5,7 @@ $(function () {
   });
 
   $("#enable_feature__button").on("click", function (e) {
-    const featureName = $("#feature_name").val();
+    const featureName = $(e.target).data("confirmation-text");
     const promptMessage = prompt(
       `Are you sure you want to fully enable this feature for everyone? Please enter the name of the feature to confirm it: ${featureName}`
     );
@@ -16,7 +16,7 @@ $(function () {
   });
   
   $("#delete_feature__button").on("click", function (e) {
-    const featureName = $("#feature_name").val();
+    const featureName = $(e.target).data("confirmation-text");
     const promptMessage = prompt(
       `Are you sure you want to remove this feature from the list of features and disable it for everyone? Please enter the name of the feature to confirm it: ${featureName}`
     );

data/lib/flipper/ui/views/feature.erb

@@ -243,6 +243,9 @@
               <div class="col">
                 <button type="submit" name="action" value="Enable" <% if Flipper::UI.configuration.confirm_fully_enable %>id="enable_feature__button"<% end %> class="btn btn-outline-success btn-block" <% if Flipper::UI.configuration.read_only %>disabled<% end %>>
                   <span class="d-block" data-toggle="tooltip"
+                    <% if Flipper::UI.configuration.confirm_fully_enable %>
+                      data-confirmation-text="<%= feature_name %>"
+                    <% end %>
                     <% if Flipper::UI.configuration.read_only %>
                       title="Fully enable is not allowed in read only mode."
                     <% else %>
@@ -289,7 +292,7 @@
             <%== csrf_input_tag %>
             <input type="hidden" id="feature_name" name="_feature" value="<%= feature_name %>">
             <input type="hidden" name="_method" value="DELETE">
-            <button type="submit" name="action" value="Delete" id="delete_feature__button" class="btn btn-outline-danger" data-toggle="tooltip" title="Remove feature from list of features and disable it." data-placement="right">Delete</button>
+            <button type="submit" name="action" value="Delete" id="delete_feature__button" data-confirmation-text="<%= feature_name %>" class="btn btn-outline-danger" data-toggle="tooltip" title="Remove feature from list of features and disable it." data-placement="right">Delete</button>
           </form>
         </div>
       </div>

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.26.0.rc2'.freeze
+  VERSION = '0.26.0'.freeze
 end

data/spec/flipper/ui/configuration_spec.rb

@@ -110,6 +110,17 @@ RSpec.describe Flipper::UI::Configuration do
     end
   end
 
+  describe "#confirm_fully_enable" do
+    it "has default value" do
+      expect(configuration.confirm_fully_enable).to eq(false)
+    end
+
+    it "can be updated" do
+      configuration.confirm_fully_enable = true
+      expect(configuration.confirm_fully_enable).to eq(true)
+    end
+  end
+
   describe "#show_feature_description_in_list" do
     it "has default value" do
       expect(configuration.show_feature_description_in_list).to eq(false)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-ui
 version: !ruby/object:Gem::Version
-  version: 0.26.0.rc2
+  version: 0.26.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-16 00:00:00.000000000 Z
+date: 2022-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -56,14 +56,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.26.0.rc2
+        version: 0.26.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.26.0.rc2
+        version: 0.26.0
 - !ruby/object:Gem::Dependency
   name: erubi
   requirement: !ruby/object:Gem::Requirement
@@ -123,7 +123,6 @@ files:
 - lib/flipper/ui/actions/home.rb
 - lib/flipper/ui/actions/percentage_of_actors_gate.rb
 - lib/flipper/ui/actions/percentage_of_time_gate.rb
-- lib/flipper/ui/assets/javascripts/application.coffee
 - lib/flipper/ui/configuration.rb
 - lib/flipper/ui/configuration/option.rb
 - lib/flipper/ui/decorators/feature.rb
@@ -164,7 +163,7 @@ homepage: https://github.com/jnunemaker/flipper
 licenses:
 - MIT
 metadata:
-  changelog_uri: https://github.com/jnunemaker/flipper/blob/master/Changelog.md
+  changelog_uri: https://github.com/jnunemaker/flipper/blob/main/Changelog.md
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -176,9 +175,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.3.7
 signing_key:

data/lib/flipper/ui/assets/javascripts/application.coffee

@@ -1,5 +0,0 @@
-$ ->
-  $(document).on('click', '.js-toggle-trigger', ->
-    $container = $(this).closest('.js-toggle-container')
-    $container.toggleClass('toggle-on')
-  )