flipper-ui 0.23.1 → 0.25.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee562b76b55741bc4dfcff342caf7fa8d3d2c67c20a08064ffad7bff2c8aee9f
-  data.tar.gz: 71a8325d427b2effb9ff0064a555eb830cbebdef68d04520970674da45b3e729
+  metadata.gz: fb0126f841f3ae62c7adad641aeff2349a49498f06e62eec515daf8c65166e93
+  data.tar.gz: 2f85713709a6701e340013499954d303bd6b15efc077d7d71ff2f73cca91b7b8
 SHA512:
-  metadata.gz: 209a9595db0b375927c553d8e09e5a656a0bf39948baa4ac3e075a26fb8b49736013eb64df1db2c2337f340e03f5293d8a4547b6d5ef90c65c2edba85582bae0
-  data.tar.gz: bbe95b17da844227f16bb22d2c1a9bb75510ba6cd8ed36ca261b3ce692475aa6a44f9d692b43a4353f502132915100183496c5039e0002c638e3f1a002920776
+  metadata.gz: deffd4af36ecf9a8aeeb28eb8384d4abdd8781d32075f2db719f82817d79480e0317a7ba134ffdc061de90c51b9247ffe57a47d4b5f57ac20fb8a7918b2d58e5
+  data.tar.gz: 1f58c684a211bef6d01fe2d0ae5fb4d20d8432c186befc53adb59fca25e889b35f57339a56d7dd9e3816a7b50c1723623be42ff51738850e484da7762f96090d

data/flipper-ui.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |gem|
   gem.metadata      = Flipper::METADATA
 
   gem.add_dependency 'rack', '>= 1.4', '< 3'
-  gem.add_dependency 'rack-protection', '>= 1.5.3', '< 2.2.0'
+  gem.add_dependency 'rack-protection', '>= 1.5.3', '<= 2.2.0'
   gem.add_dependency 'flipper', "~> #{Flipper::VERSION}"
   gem.add_dependency 'erubi', '>= 1.0.0', '< 2.0.0'
   gem.add_dependency 'sanitize', '< 7'

data/lib/flipper/ui/public/js/application.js

@@ -1,6 +1,17 @@
-$(function() {
-  $(document).on('click', '.js-toggle-trigger', function() {
-    var $container = $(this).closest('.js-toggle-container');
-    return $container.toggleClass('toggle-on');
+$(function () {
+  $(document).on("click", ".js-toggle-trigger", function () {
+    var $container = $(this).closest(".js-toggle-container");
+    return $container.toggleClass("toggle-on");
+  });
+
+  $("#delete_feature__button").on("click", function (e) {
+    const featureName = $("#feature_name").val();
+    const promptMessage = prompt(
+      `Are you sure you want to remove this feature from the list of features and disable it for everyone? Please enter the name of the feature to confirm it: ${featureName}`
+    );
+    
+    if (promptMessage !== featureName) {
+      e.preventDefault();
+    }
   });
 });

data/lib/flipper/ui/views/feature.erb

@@ -258,11 +258,11 @@
           <p>
             <%= Flipper::UI.configuration.delete.description %>
           </p>
-
-          <form action="<%= script_name %>/features/<%= @feature.key %>" method="post" onsubmit="return confirm('Are you sure you want to remove this feature from the list of features and disable it for everyone?')">
+          <form action="<%= script_name %>/features/<%= @feature.key %>" method="post">
             <%== csrf_input_tag %>
+            <input type="hidden" id="feature_name" name="_feature" value="<%= feature_name %>">
             <input type="hidden" name="_method" value="DELETE">
-            <button type="submit" name="action" value="Delete" class="btn btn-outline-danger" data-toggle="tooltip" title="Remove feature from list of features and disable it." data-placement="right">Delete</button>
+            <button type="submit" name="action" value="Delete" id="delete_feature__button" class="btn btn-outline-danger" data-toggle="tooltip" title="Remove feature from list of features and disable it." data-placement="right">Delete</button>
           </form>
         </div>
       </div>

data/lib/flipper/ui/views/features.erb

@@ -8,9 +8,6 @@
           <a class="btn btn-primary btn-sm" href="<%= script_name %>/features/new">Add Feature</a>
         </p>
       <%- end -%>
-      <div class="embed-responsive embed-responsive-16by9">
-        <iframe class="embed-responsive-item" width="560" height="315" src="https://www.youtube.com/embed/e-ORhEE9VVg" frameborder="0" allowfullscreen></iframe>
-      </div>
     <% else %>
       <h4>Getting Started</h4>
       <p class="mb-1">You have not added any features to configure yet.</p>

data/lib/flipper/ui.rb

@@ -14,24 +14,6 @@ require 'flipper/ui/configuration'
 
 module Flipper
   module UI
-    class << self
-      # These three configuration options have been moved to Flipper::UI::Configuration
-      deprecated_configuration_options = %w(application_breadcrumb_href
-                                            feature_creation_enabled
-                                            feature_removal_enabled)
-      deprecated_configuration_options.each do |attribute_name|
-        send(:define_method, "#{attribute_name}=".to_sym) do
-          raise ConfigurationDeprecated, "The UI configuration for #{attribute_name} has " \
-            "deprecated. This configuration option has moved to Flipper::UI::Configuration"
-        end
-
-        send(:define_method, attribute_name.to_sym) do
-          raise ConfigurationDeprecated, "The UI configuration for #{attribute_name} has " \
-            "deprecated. This configuration option has moved to Flipper::UI::Configuration"
-        end
-      end
-    end
-
     def self.root
       @root ||= Pathname(__FILE__).dirname.expand_path.join('ui')
     end
@@ -49,8 +31,9 @@ module Flipper
       builder.use Flipper::UI::Middleware, flipper: flipper, env_key: env_key
       builder.run app
       klass = self
-      builder.define_singleton_method(:inspect) { klass.inspect } # pretty rake routes output
-      builder
+      app = builder.to_app
+      app.define_singleton_method(:inspect) { klass.inspect } # pretty rake routes output
+      app
     end
 
     # Public: yields configuration instance for customizing UI text

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.23.1'.freeze
+  VERSION = '0.25.0'.freeze
 end

data/spec/flipper/ui_spec.rb

@@ -32,7 +32,7 @@ RSpec.describe Flipper::UI do
 
   describe 'Inspecting the built Rack app' do
     it 'returns a String' do
-      expect(build_app(flipper).inspect).to be_a(String)
+      expect(build_app(flipper).inspect).to eq("Flipper::UI")
     end
   end
 
@@ -45,27 +45,6 @@ RSpec.describe Flipper::UI do
     expect(last_response.headers['Location']).to eq('/features/refactor-images')
   end
 
-  describe "application_breadcrumb_href" do
-    it "raises an exception since it is deprecated" do
-      expect { described_class.application_breadcrumb_href }
-        .to raise_error(Flipper::ConfigurationDeprecated)
-    end
-  end
-
-  describe "feature_creation_enabled" do
-    it "raises an exception since it is deprecated" do
-      expect { described_class.feature_creation_enabled }
-        .to raise_error(Flipper::ConfigurationDeprecated)
-    end
-  end
-
-  describe "feature_removal_enabled" do
-    it "raises an exception since it is deprecated" do
-      expect { described_class.feature_removal_enabled }
-        .to raise_error(Flipper::ConfigurationDeprecated)
-    end
-  end
-
   describe 'configure' do
     it 'yields configuration instance' do
       described_class.configure do |config|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-ui
 version: !ruby/object:Gem::Version
-  version: 0.23.1
+  version: 0.25.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-19 00:00:00.000000000 Z
+date: 2022-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -37,7 +37,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.3
-    - - "<"
+    - - "<="
       - !ruby/object:Gem::Version
         version: 2.2.0
   type: :runtime
@@ -47,7 +47,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.3
-    - - "<"
+    - - "<="
       - !ruby/object:Gem::Version
         version: 2.2.0
 - !ruby/object:Gem::Dependency
@@ -56,14 +56,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.23.1
+        version: 0.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.23.1
+        version: 0.25.0
 - !ruby/object:Gem::Dependency
   name: erubi
   requirement: !ruby/object:Gem::Requirement