flipper-ui 0.21.0 → 0.23.0

data/spec/flipper/ui/actions/actors_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::ActorsGate do
   let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
@@ -45,6 +43,7 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
   describe 'POST /features/:feature/actors' do
     context 'enabling an actor' do
       let(:value) { 'User;6' }
+      let(:multi_value) { 'User;5, User;7, User;9, User;12' }
 
       before do
         post 'features/search/actors',
@@ -53,7 +52,18 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
       end
 
       it 'adds item to members' do
-        expect(flipper[:search].actors_value).to include('User;6')
+        expect(flipper[:search].actors_value).to include(value)
+      end
+
+      it 'adds item to multiple members' do
+        post 'features/search/actors',
+             { 'value' => multi_value, 'operation' => 'enable', 'authenticity_token' => token },
+             'rack.session' => session
+
+        expect(flipper[:search].actors_value).to include('User;5')
+        expect(flipper[:search].actors_value).to include('User;7')
+        expect(flipper[:search].actors_value).to include('User;9')
+        expect(flipper[:search].actors_value).to include('User;12')
       end
 
       it 'redirects back to feature' do
@@ -61,12 +71,41 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
         expect(last_response.headers['Location']).to eq('/features/search')
       end
 
+      context "when feature name contains space" do
+        before do
+          post 'features/sp%20ace/actors',
+               { 'value' => value, 'operation' => 'enable', 'authenticity_token' => token },
+               'rack.session' => session
+        end
+
+        it 'adds item to members' do
+          expect(flipper["sp ace"].actors_value).to include('User;6')
+        end
+
+        it "redirects back to feature" do
+          expect(last_response.status).to be(302)
+          expect(last_response.headers['Location']).to eq('/features/sp%20ace')
+        end
+      end
+
       context 'value contains whitespace' do
         let(:value) { '  User;6  ' }
+        let(:multi_value) { '  User;5  ,  User;7   ,  User;9 ,  User;12 ' }
 
         it 'adds item without whitespace' do
           expect(flipper[:search].actors_value).to include('User;6')
         end
+
+        it 'adds item to multi members without whitespace' do
+          post 'features/search/actors',
+             { 'value' => multi_value, 'operation' => 'enable', 'authenticity_token' => token },
+             'rack.session' => session
+
+          expect(flipper[:search].actors_value).to include('User;5')
+          expect(flipper[:search].actors_value).to include('User;7')
+          expect(flipper[:search].actors_value).to include('User;9')
+          expect(flipper[:search].actors_value).to include('User;12')
+        end
       end
 
       context 'for an invalid actor value' do
@@ -75,7 +114,7 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
 
           it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers['Location']).to eq('/features/search/actors?error=%22%22+is+not+a+valid+actor+value.')
+            expect(last_response.headers['Location']).to eq('/features/search/actors?error=%22%22%20is%20not%20a%20valid%20actor%20value.')
           end
         end
 
@@ -84,7 +123,7 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
 
           it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers['Location']).to eq('/features/search/actors?error=%22%22+is+not+a+valid+actor+value.')
+            expect(last_response.headers['Location']).to eq('/features/search/actors?error=%22%22%20is%20not%20a%20valid%20actor%20value.')
           end
         end
       end
@@ -92,16 +131,29 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
 
     context 'disabling an actor' do
       let(:value) { 'User;6' }
+      let(:multi_value) { 'User;5, User;7, User;9, User;12' }
 
       before do
-        flipper[:search].enable_actor Flipper::Actor.new('User;6')
+        flipper[:search].enable_actor Flipper::Actor.new(value)
         post 'features/search/actors',
              { 'value' => value, 'operation' => 'disable', 'authenticity_token' => token },
              'rack.session' => session
       end
 
       it 'removes item from members' do
-        expect(flipper[:search].actors_value).not_to include('User;6')
+        expect(flipper[:search].actors_value).not_to include(value)
+      end
+
+      it 'removes item from multi members' do
+        multi_value.split(',').map(&:strip).each do |value|
+          flipper[:search].enable_actor Flipper::Actor.new(value)
+        end
+
+        post 'features/search/actors',
+             { 'value' => multi_value, 'operation' => 'disable', 'authenticity_token' => token },
+             'rack.session' => session
+
+        expect(flipper[:search].actors_value).not_to eq(Set.new(multi_value.split(',').map(&:strip)))
       end
 
       it 'redirects back to feature' do
@@ -111,10 +163,21 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
 
       context 'value contains whitespace' do
         let(:value) { '  User;6  ' }
+        let(:multi_value) { '  User;5  ,  User;7   ,  User;9 ,  User;12 ' }
 
         it 'removes item without whitespace' do
           expect(flipper[:search].actors_value).not_to include('User;6')
         end
+
+        it 'removes item without whitespace' do
+          multi_value.split(',').map(&:strip).each do |value|
+            flipper[:search].enable_actor Flipper::Actor.new(value)
+          end
+          post 'features/search/actors',
+              { 'value' => multi_value, 'operation' => 'disable', 'authenticity_token' => token },
+              'rack.session' => session
+          expect(flipper[:search].actors_value).not_to eq(Set.new(multi_value.split(',').map(&:strip)))
+        end
       end
     end
   end

data/spec/flipper/ui/actions/add_feature_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::AddFeature do
   describe 'GET /features/new with feature_creation_enabled set to true' do
     before do

data/spec/flipper/ui/actions/boolean_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::BooleanGate do
   let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
@@ -31,6 +29,24 @@ RSpec.describe Flipper::UI::Actions::BooleanGate do
       end
     end
 
+    context "with space in feature name" do
+      before do
+        flipper.disable :search
+        post 'features/sp%20ace/boolean',
+             { 'action' => 'Enable', 'authenticity_token' => token },
+             'rack.session' => session
+      end
+
+      it 'updates feature' do
+        expect(flipper.enabled?("sp ace")).to be(true)
+      end
+
+      it 'redirects back to feature' do
+        expect(last_response.status).to be(302)
+        expect(last_response.headers['Location']).to eq('/features/sp%20ace')
+      end
+    end
+
     context 'with disable' do
       before do
         flipper.enable :search

data/spec/flipper/ui/actions/feature_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::Feature do
   let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
@@ -29,6 +27,24 @@ RSpec.describe Flipper::UI::Actions::Feature do
       expect(last_response.headers['Location']).to eq('/features')
     end
 
+    context "with space in feature name" do
+      before do
+        flipper.enable "sp ace"
+        delete '/features/sp%20ace',
+               { 'authenticity_token' => token },
+               'rack.session' => session
+      end
+
+      it 'removes feature' do
+        expect(flipper.features.map(&:key)).not_to include('sp ace')
+      end
+
+      it 'redirects to features' do
+        expect(last_response.status).to be(302)
+        expect(last_response.headers['Location']).to eq('/features')
+      end
+    end
+
     context 'when feature_removal_enabled is set to false' do
       around do |example|
         begin

data/spec/flipper/ui/actions/features_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::Features do
   let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
@@ -95,7 +93,7 @@ RSpec.describe Flipper::UI::Actions::Features do
         expect(last_response.headers['Location']).to eq('/features/notifications_next')
       end
 
-      context 'feature name contains whitespace' do
+      context 'feature name has whitespace at beginning and end' do
         let(:feature_name) { '  notifications_next   ' }
 
         it 'adds feature without whitespace' do
@@ -103,6 +101,19 @@ RSpec.describe Flipper::UI::Actions::Features do
         end
       end
 
+      context 'feature name contains space' do
+        let(:feature_name) { 'notifications next' }
+
+        it 'adds feature with space' do
+          expect(flipper.features.map(&:key)).to include('notifications next')
+        end
+
+        it 'redirects to feature' do
+          expect(last_response.status).to be(302)
+          expect(last_response.headers['Location']).to eq('/features/notifications%20next')
+        end
+      end
+
       context 'for an invalid feature name' do
         context 'empty feature name' do
           let(:feature_name) { '' }
@@ -113,7 +124,7 @@ RSpec.describe Flipper::UI::Actions::Features do
 
           it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers['Location']).to eq('/features/new?error=%22%22+is+not+a+valid+feature+name.')
+            expect(last_response.headers['Location']).to eq('/features/new?error=%22%22%20is%20not%20a%20valid%20feature%20name.')
           end
         end
 
@@ -126,7 +137,7 @@ RSpec.describe Flipper::UI::Actions::Features do
 
           it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers['Location']).to eq('/features/new?error=%22%22+is+not+a+valid+feature+name.')
+            expect(last_response.headers['Location']).to eq('/features/new?error=%22%22%20is%20not%20a%20valid%20feature%20name.')
           end
         end
       end

data/spec/flipper/ui/actions/file_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::File do
   describe 'GET /images/logo.png' do
     before do
@@ -20,14 +18,4 @@ RSpec.describe Flipper::UI::Actions::File do
       expect(last_response.status).to be(200)
     end
   end
-
-  describe 'GET /octicons/octicons.eot' do
-    before do
-      get '/octicons/octicons.eot'
-    end
-
-    it 'responds with 200' do
-      expect(last_response.status).to be(200)
-    end
-  end
 end

data/spec/flipper/ui/actions/groups_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::GroupsGate do
   let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
@@ -60,6 +58,23 @@ RSpec.describe Flipper::UI::Actions::GroupsGate do
         expect(last_response.headers['Location']).to eq('/features/search')
       end
 
+      context 'feature name contains space' do
+        before do
+          post 'features/sp%20ace/groups',
+               { 'value' => group_name, 'operation' => 'enable', 'authenticity_token' => token },
+               'rack.session' => session
+        end
+
+        it 'adds item to members' do
+          expect(flipper["sp ace"].groups_value).to include('admins')
+        end
+
+        it 'redirects back to feature' do
+          expect(last_response.status).to be(302)
+          expect(last_response.headers['Location']).to eq('/features/sp%20ace')
+        end
+      end
+
       context 'group name contains whitespace' do
         let(:group_name) { '  admins  ' }
 
@@ -74,7 +89,7 @@ RSpec.describe Flipper::UI::Actions::GroupsGate do
 
           it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The+group+named+%22not_here%22+has+not+been+registered.')
+            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The%20group%20named%20%22not_here%22%20has%20not%20been%20registered.')
           end
         end
 
@@ -83,7 +98,7 @@ RSpec.describe Flipper::UI::Actions::GroupsGate do
 
           it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The+group+named+%22%22+has+not+been+registered.')
+            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The%20group%20named%20%22%22%20has%20not%20been%20registered.')
           end
         end
 
@@ -92,7 +107,7 @@ RSpec.describe Flipper::UI::Actions::GroupsGate do
 
           it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The+group+named+%22%22+has+not+been+registered.')
+            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The%20group%20named%20%22%22%20has%20not%20been%20registered.')
           end
         end
       end

data/spec/flipper/ui/actions/home_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::Home do
   describe 'GET /' do
     before do

data/spec/flipper/ui/actions/percentage_of_actors_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::PercentageOfActorsGate do
   let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
@@ -30,6 +28,23 @@ RSpec.describe Flipper::UI::Actions::PercentageOfActorsGate do
       end
     end
 
+    context 'with space in feature name' do
+      before do
+        post 'features/sp%20ace/percentage_of_actors',
+             { 'value' => '24', 'authenticity_token' => token },
+             'rack.session' => session
+      end
+
+      it 'enables the feature' do
+        expect(flipper["sp ace"].percentage_of_actors_value).to be(24)
+      end
+
+      it 'redirects back to feature' do
+        expect(last_response.status).to be(302)
+        expect(last_response.headers['Location']).to eq('/features/sp%20ace')
+      end
+    end
+
     context 'with invalid value' do
       before do
         post 'features/search/percentage_of_actors',
@@ -43,7 +58,7 @@ RSpec.describe Flipper::UI::Actions::PercentageOfActorsGate do
 
       it 'redirects back to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers['Location']).to eq('/features/search?error=Invalid+percentage+of+actors+value%3A+value+must+be+a+positive+number+less+than+or+equal+to+100%2C+but+was+555')
+        expect(last_response.headers['Location']).to eq('/features/search?error=Invalid%20percentage%20of%20actors%20value:%20value%20must%20be%20a%20positive%20number%20less%20than%20or%20equal%20to%20100,%20but%20was%20555')
       end
     end
   end

data/spec/flipper/ui/actions/percentage_of_time_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Actions::PercentageOfTimeGate do
   let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
@@ -30,6 +28,23 @@ RSpec.describe Flipper::UI::Actions::PercentageOfTimeGate do
       end
     end
 
+    context 'with space in feature name' do
+      before do
+        post 'features/sp%20ace/percentage_of_time',
+             { 'value' => '24', 'authenticity_token' => token },
+             'rack.session' => session
+      end
+
+      it 'enables the feature' do
+        expect(flipper["sp ace"].percentage_of_time_value).to be(24)
+      end
+
+      it 'redirects back to feature' do
+        expect(last_response.status).to be(302)
+        expect(last_response.headers['Location']).to eq('/features/sp%20ace')
+      end
+    end
+
     context 'with invalid value' do
       before do
         post 'features/search/percentage_of_time',
@@ -43,7 +58,7 @@ RSpec.describe Flipper::UI::Actions::PercentageOfTimeGate do
 
       it 'redirects back to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers['Location']).to eq('/features/search?error=Invalid+percentage+of+time+value%3A+value+must+be+a+positive+number+less+than+or+equal+to+100%2C+but+was+555')
+        expect(last_response.headers['Location']).to eq('/features/search?error=Invalid%20percentage%20of%20time%20value:%20value%20must%20be%20a%20positive%20number%20less%20than%20or%20equal%20to%20100,%20but%20was%20555')
       end
     end
   end

data/spec/flipper/ui/configuration_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Configuration do
   let(:configuration) { described_class.new }
 

data/spec/flipper/ui/decorators/feature_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI::Decorators::Feature do
   let(:source)  { {} }
   let(:adapter) { Flipper::Adapters::Memory.new(source) }

data/spec/flipper/ui/decorators/gate_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/ui/decorators/gate'
 
 RSpec.describe Flipper::UI::Decorators::Gate do

data/spec/flipper/ui/util_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/ui/util'
 
 RSpec.describe Flipper::UI::Util do

data/spec/flipper/ui_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::UI do
   let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
@@ -24,19 +22,6 @@ RSpec.describe Flipper::UI do
     end
   end
 
-  describe 'Initializing middleware lazily with a block' do
-    let(:app) do
-      build_app(-> { flipper })
-    end
-
-    it 'works' do
-      flipper.enable :some_great_feature
-      get '/features'
-      expect(last_response.status).to be(200)
-      expect(last_response.body).to include('some_great_feature')
-    end
-  end
-
   describe 'Request method unsupported by action' do
     it 'raises error' do
       expect do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-ui
 version: !ruby/object:Gem::Version
-  version: 0.21.0
+  version: 0.23.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-09 00:00:00.000000000 Z
+date: 2021-12-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -56,14 +56,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 0.23.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 0.23.0
 - !ruby/object:Gem::Dependency
   name: erubi
   requirement: !ruby/object:Gem::Requirement
@@ -84,6 +84,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
+- !ruby/object:Gem::Dependency
+  name: sanitize
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7'
 description: 
 email:
 - nunemaker@gmail.com
@@ -91,11 +105,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- docs/ui/README.md
-- docs/ui/images/banner.png
-- docs/ui/images/description.png
-- docs/ui/images/feature.png
-- docs/ui/images/features.png
 - examples/ui/authorization.ru
 - examples/ui/basic.ru
 - flipper-ui.gemspec
@@ -123,14 +132,6 @@ files:
 - lib/flipper/ui/public/css/application.css
 - lib/flipper/ui/public/images/logo.png
 - lib/flipper/ui/public/js/application.js
-- lib/flipper/ui/public/octicons/LICENSE.txt
-- lib/flipper/ui/public/octicons/README.md
-- lib/flipper/ui/public/octicons/octicons-local.ttf
-- lib/flipper/ui/public/octicons/octicons.css
-- lib/flipper/ui/public/octicons/octicons.eot
-- lib/flipper/ui/public/octicons/octicons.svg
-- lib/flipper/ui/public/octicons/octicons.ttf
-- lib/flipper/ui/public/octicons/octicons.woff
 - lib/flipper/ui/util.rb
 - lib/flipper/ui/views/add_actor.erb
 - lib/flipper/ui/views/add_feature.erb
@@ -177,7 +178,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: UI for the Flipper gem