flipper-ui 0.2.0.beta2 → 0.2.0.beta3

data/script/release

@@ -0,0 +1,15 @@
+#!/bin/sh
+#/ Usage: release
+#/
+#/ Package and release the gem to rubyforge.
+#/
+
+set -e
+cd $(dirname "$0")/..
+
+[ "$1" = "--help" -o "$1" = "-h" -o "$1" = "help" ] && {
+    grep '^#/' <"$0"| cut -c4-
+    exit 0
+}
+
+script/bootstrap && bundle exec rake release

data/spec/flipper/ui/actions/actors_gate_spec.rb

@@ -0,0 +1,68 @@
+require 'helper'
+require 'flipper/ui/actor'
+
+describe Flipper::UI::Actions::ActorsGate do
+  describe "GET /features/:feature/actors" do
+    before do
+      get "features/search/actors"
+    end
+
+    it "responds with success" do
+      last_response.status.should be(200)
+    end
+
+    it "renders add new actor form" do
+      last_response.body.should include('<form action="/features/search/actors" method="post">')
+    end
+  end
+
+  describe "POST /features/:feature/actors" do
+    context "enabling an actor" do
+      before do
+        post "features/search/actors",
+          {"value" => "User:6", "operation" => "enable", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "adds item to members" do
+        flipper[:search].actors_value.should include("User:6")
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search")
+      end
+    end
+
+    context "disabling an actor" do
+      before do
+        flipper[:search].enable_actor Flipper::UI::Actor.new("User:6")
+        post "features/search/actors",
+          {"value" => "User:6", "operation" => "disable", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "removes item from members" do
+        flipper[:search].actors_value.should_not include("User:6")
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search")
+      end
+    end
+
+    context "for an invalid actor value" do
+      before do
+        post "features/search/actors",
+          {"value" => "", "operation" => "enable", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search/actors?error=%22%22+is+not+a+valid+actor+value.")
+      end
+    end
+  end
+end

data/spec/flipper/ui/actions/add_feature_spec.rb

@@ -0,0 +1,17 @@
+require 'helper'
+
+describe Flipper::UI::Actions::AddFeature do
+  describe "GET /features/new" do
+    before do
+      get "/features/new"
+    end
+
+    it "responds with success" do
+      last_response.status.should be(200)
+    end
+
+    it "renders template" do
+      last_response.body.should include('<form action="/features" method="post">')
+    end
+  end
+end

data/spec/flipper/ui/actions/boolean_gate_spec.rb

@@ -0,0 +1,41 @@
+require 'helper'
+
+describe Flipper::UI::Actions::BooleanGate do
+  describe "POST /features/:feature/boolean" do
+    context "with enable" do
+      before do
+        flipper.disable :search
+        post "features/search/boolean",
+          {"action" => "Enable", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "enables the feature" do
+        flipper.enabled?(:search).should be(true)
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search")
+      end
+    end
+
+    context "with disable" do
+      before do
+        flipper.enable :search
+        post "features/search/boolean",
+          {"action" => "Disable", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "disables the feature" do
+        flipper.enabled?(:search).should be(false)
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search")
+      end
+    end
+  end
+end

data/spec/flipper/ui/actions/feature_spec.rb

@@ -0,0 +1,59 @@
+require 'helper'
+
+describe Flipper::UI::Actions::Feature do
+  describe "DELETE /features/:feature" do
+    before do
+      flipper.enable :search
+      delete "/features/search",
+        {"authenticity_token" => "a"},
+        "rack.session" => {:csrf => "a"}
+    end
+
+    it "removes feature" do
+      flipper.features.map(&:key).should_not include("search")
+    end
+
+    it "redirects to features" do
+      last_response.status.should be(302)
+      last_response.headers["Location"].should eq("/features")
+    end
+  end
+
+  describe "POST /features/:feature with _method=DELETE" do
+    before do
+      flipper.enable :search
+      post "/features/search",
+        {"_method" => "DELETE", "authenticity_token" => "a"},
+        "rack.session" => {:csrf => "a"}
+    end
+
+    it "removes feature" do
+      flipper.features.map(&:key).should_not include("search")
+    end
+
+    it "redirects to features" do
+      last_response.status.should be(302)
+      last_response.headers["Location"].should eq("/features")
+    end
+  end
+
+  describe "GET /features/:feature" do
+    before do
+      get "/features/search"
+    end
+
+    it "responds with success" do
+      last_response.status.should be(200)
+    end
+
+    it "renders template" do
+      last_response.body.should include("search")
+      last_response.body.should include("Enable")
+      last_response.body.should include("Disable")
+      last_response.body.should include("Actors")
+      last_response.body.should include("Groups")
+      last_response.body.should include("Percentage of Time")
+      last_response.body.should include("Percentage of Actors")
+    end
+  end
+end

data/spec/flipper/ui/actions/features_spec.rb

@@ -0,0 +1,37 @@
+require 'helper'
+
+describe Flipper::UI::Actions::Features do
+  describe "GET /features" do
+    before do
+      flipper[:stats].enable
+      flipper[:search].enable
+      get "/features"
+    end
+
+    it "responds with success" do
+      last_response.status.should be(200)
+    end
+
+    it "renders template" do
+      last_response.body.should include("stats")
+      last_response.body.should include("search")
+    end
+  end
+
+  describe "POST /features" do
+    before do
+      post "/features",
+        {"value" => "notifications_next", "authenticity_token" => "a"},
+        "rack.session" => {:csrf => "a"}
+    end
+
+    it "adds feature" do
+      flipper.features.map(&:key).should include("notifications_next")
+    end
+
+    it "redirects to features" do
+      last_response.status.should be(302)
+      last_response.headers["Location"].should eq("/features")
+    end
+  end
+end

data/spec/flipper/ui/actions/file_spec.rb

@@ -0,0 +1,43 @@
+require 'helper'
+
+describe Flipper::UI::Actions::File do
+  describe "GET /images/logo.png" do
+    before do
+      get '/images/logo.png'
+    end
+
+    it "responds with 200" do
+      last_response.status.should be(200)
+    end
+  end
+
+  describe "GET /css/application.css" do
+    before do
+      get '/css/application.css'
+    end
+
+    it "responds with 200" do
+      last_response.status.should be(200)
+    end
+  end
+
+  describe "GET /fonts/bootstrap/glyphicons-halflings-regular.eot" do
+    before do
+      get '/fonts/bootstrap/glyphicons-halflings-regular.eot'
+    end
+
+    it "responds with 200" do
+      last_response.status.should be(200)
+    end
+  end
+
+  describe "GET /octicons/octicons.eot" do
+    before do
+      get '/octicons/octicons.eot'
+    end
+
+    it "responds with 200" do
+      last_response.status.should be(200)
+    end
+  end
+end

data/spec/flipper/ui/actions/gate_spec.rb

@@ -0,0 +1,24 @@
+require 'helper'
+
+describe Flipper::UI::Actions::Gate do
+  describe "POST /features/:feature/non-existent-gate" do
+    before do
+      post "/features/search/non-existent-gate",
+        {"authenticity_token" => "a"},
+        "rack.session" => {:csrf => "a"}
+    end
+
+    it "responds with redirect" do
+      last_response.status.should be(302)
+    end
+
+    it "escapes error message" do
+      last_response.headers["Location"].should eq("/features/search?error=%22non-existent-gate%22+gate+does+not+exist+therefore+it+cannot+be+updated.")
+    end
+
+    it "renders error in template" do
+      follow_redirect!
+      last_response.body.should match(/non-existent-gate.*gate does not exist/)
+    end
+  end
+end

data/spec/flipper/ui/actions/groups_gate_spec.rb

@@ -0,0 +1,80 @@
+require 'helper'
+
+describe Flipper::UI::Actions::GroupsGate do
+  describe "GET /features/:feature/groups" do
+    before do
+      Flipper.register(:admins) { |user| user.admin? }
+      get "features/search/groups"
+    end
+
+    after do
+      Flipper.unregister_groups
+    end
+
+    it "responds with success" do
+      last_response.status.should be(200)
+    end
+
+    it "renders add new group form" do
+      last_response.body.should include('<form action="/features/search/groups" method="post">')
+    end
+  end
+
+  describe "POST /features/:feature/groups" do
+    before do
+      Flipper.register(:admins) { |user| user.admin? }
+    end
+
+    after do
+      Flipper.unregister_groups
+    end
+
+    context "enabling a group" do
+      before do
+        post "features/search/groups",
+          {"value" => "admins", "operation" => "enable", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "adds item to members" do
+        flipper[:search].groups_value.should include("admins")
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search")
+      end
+    end
+
+    context "disabling a group" do
+      before do
+        flipper[:search].enable_group :admins
+        post "features/search/groups",
+          {"value" => "admins", "operation" => "disable", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "removes item from members" do
+        flipper[:search].groups_value.should_not include("admins")
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search")
+      end
+    end
+
+    context "for an unregistered group" do
+      before do
+        post "features/search/groups",
+          {"value" => "not_here", "operation" => "enable", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search/groups?error=The+group+named+%22not_here%22+has+not+been+registered.")
+      end
+    end
+  end
+end

data/spec/flipper/ui/actions/home_spec.rb

@@ -0,0 +1,16 @@
+require 'helper'
+
+describe Flipper::UI::Actions::Home do
+  describe "GET /" do
+    before do
+      flipper[:stats].enable
+      flipper[:search].enable
+      get "/"
+    end
+
+    it "responds with redirect" do
+      last_response.status.should be(302)
+      last_response.headers["Location"].should eq("/features")
+    end
+  end
+end

data/spec/flipper/ui/actions/percentage_of_actors_gate_spec.rb

@@ -0,0 +1,40 @@
+require 'helper'
+require 'flipper/ui/actor'
+
+describe Flipper::UI::Actions::PercentageOfActorsGate do
+  describe "POST /features/:feature/percentage_of_actors" do
+    context "with valid value" do
+      before do
+        post "features/search/percentage_of_actors",
+          {"value" => "24", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "enables the feature" do
+        flipper[:search].percentage_of_actors_value.should be(24)
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search")
+      end
+    end
+
+    context "with invalid value" do
+      before do
+        post "features/search/percentage_of_actors",
+          {"value" => "555", "authenticity_token" => "a"},
+          "rack.session" => {:csrf => "a"}
+      end
+
+      it "does not change value" do
+        flipper[:search].percentage_of_actors_value.should be(0)
+      end
+
+      it "redirects back to feature" do
+        last_response.status.should be(302)
+        last_response.headers["Location"].should eq("/features/search?error=Invalid+percentage+of+actors+value%3A+value+must+be+a+positive+number+less+than+or+equal+to+100%2C+but+was+555")
+      end
+    end
+  end
+end