flipper-ui 0.16.2 → 0.22.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 71eccacf760968860d08a08de30d86c435314c3a
-  data.tar.gz: 9e6a0d87e9158c108dbf7c80fbf663576899fcf3
+SHA256:
+  metadata.gz: b17af1c2cd05d9026a457941c46e7c497460e4289bd8446b90d2f0342e53f34c
+  data.tar.gz: 4adae31beca41aebaae69c9c3a0efe51bb024d0acc54eadf3982ddfff4a16748
 SHA512:
-  metadata.gz: 5790f438fba84b3a34301fc004fab83f6609c249026438639395781b474848e2c57f38aa612a5864e6365b5e2e853b00a7c72c96c69e6b9074e37fd5e55da44b
-  data.tar.gz: ed1011c894f34b0ebd3ff87a06ed5687428c7ba8d76466d8e18a49ccfc595716eae65afdb6f2b54786ebde372f8ad367b6bea079773da00977d155d06d9b2d64
+  metadata.gz: a8e0d113cb89d77c9e8cd0ec83d8deb7a26f3f6e00452aa81ab6a308843dfe45e069b0e1303374ece24e4a5bd79718958e160249db9195ea22249bab2df66a5d
+  data.tar.gz: cc5f6567f690c2bd48b762083046b19e868f4885384885667f20d808cd09f0533df5d3df5239e4a21cc649babbe231e494af984b5c1261b4ef9358b68581784a

data/docs/ui/README.md

@@ -5,9 +5,11 @@ UI for the [Flipper](https://github.com/jnunemaker/flipper) gem.
 ## Screenshots
 
 Viewing list of features:
+
 ![features](images/features.png)
 
 Viewing an individual feature:
+
 ![feature](images/feature.png)
 
 ## Installation
@@ -37,14 +39,15 @@ YourRailsApp::Application.routes.draw do
 end
 ```
 
-If you'd like to lazy load flipper, you can pass a block instead:
+If you'd like to lazy load flipper, you can instead pass a block to initialize it:
 
 ```ruby
 # config/routes.rb
 YourRailsApp::Application.routes.draw do
   flipper_block = lambda {
     # some flipper initialization here, for example:
-    # YourRailsApp.flipper
+    adapter = Flipper::Adapters::Memory.new
+    Flipper.new(adapter)
   }
   mount Flipper::UI.app(flipper_block) => '/flipper'
 end
@@ -95,7 +98,7 @@ end
 # config/routes.rb
 
 constraints CanAccessFlipperUI do
-  mount Flipper::UI.app(flipper) => '/flipper'
+  mount Flipper::UI.app(Flipper) => '/flipper'
 end
 ```
 
@@ -106,7 +109,7 @@ Minimal example for Rack:
 ```ruby
 # config.ru
 
-require 'flipper-ui'
+require 'flipper/ui'
 
 adapter = Flipper::Adapters::Memory.new
 flipper = Flipper.new(adapter)
@@ -126,32 +129,30 @@ See [examples/ui/basic.ru](https://github.com/jnunemaker/flipper/blob/master/exa
 
 ### Configuration
 
-Flipper UI can be customized via `configure`, which yields a configuration instance for setting the text on the five main sections of the UI feature view.
+Flipper UI can be customized via `configure`, which yields a configuration instance.
 
-* `config.actors`
-* `config.groups`
-* `config.percentage_of_actors`
-* `config.percentage_of_time`
-* `config.delete`
+#### Description
 
-Each of these methods returns a [Flipper::UI::Option](https://github.com/jnunemaker/flipper/blob/master/lib/flipper/ui/configuration/option.rb) that responds to `title=`, `description=` as seen below.
+We can associate a `description` for each `feature` by providing a descriptions source:
 
-*e.g. customzing the percentage_of_actors and delete sections' titles and descriptions*
 ```ruby
 Flipper::UI.configure do |config|
-  config.percentage_of_actors.title = "My Custom Title"
-  config.percentage_of_actors.description = "My custom description"
+  config.descriptions_source = ->(keys) do
+    # descriptions loaded from YAML file or database (postgres, mysql, etc)
+    # return has to be hash of {String key => String description}
+  end
 
-  config.delete.title = "BE VERY CAREFUL!"
-  config.delete.description = "YOU'VE BEEN WARNED!"
+  # Defaults to false. Set to true to show feature descriptions on the list
+  # page as well as the view page.
+  # config.show_feature_description_in_list = true
 end
 ```
 
-results in:
+Descriptions show up in the UI like so:
 
-![configure](images/configured-ui.png)
+![description](images/description.png)
 
-### Banner
+#### Banner
 
 Flipper UI can display a banner across the top of the page. The `banner_text` and `banner_class` can be configured by using the `Flipper::UI.configure` block as seen below.
 
@@ -166,15 +167,24 @@ By default the `environment` is set to an empty string so no banner will show. I
 
 The above configuration results in:
 
-![configure](images/environment-banner.png)
+![banner](images/banner.png)
+
+#### Fun mode
+
+By default, Flipper UI displays a videoclip when there are no flags. The `fun` mode can be configured by using the `Flipper::UI.configure` block as seen below.
+
+```ruby
+Flipper::UI.configure do |config|
+  config.fun = false
+end
+```
 
 ## Contributing
 
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. **Fire up the app** (`script/server`)
-4. **Start up guard** (`bundle exec guard` for automatic coffeescript/sass compilation and such).
-5. Run the tests `bundle exec rake`
-6. Commit your changes (`git commit -am 'Added some feature'`)
-7. Push to the branch (`git push origin my-new-feature`)
-8. Create new Pull Request
+4. Run the tests `bundle exec rake`
+5. Commit your changes (`git commit -am 'Added some feature'`)
+6. Push to the branch (`git push origin my-new-feature`)
+7. Create new Pull Request

data/examples/ui/authorization.ru

@@ -0,0 +1,46 @@
+#
+# Usage:
+#   bundle exec rackup examples/ui/authorization.ru -p 9999
+#   bundle exec shotgun examples/ui/authorization.ru -p 9999
+#   http://localhost:9999/
+#
+require 'bundler/setup'
+require "flipper/ui"
+require "flipper/adapters/pstore"
+
+Flipper.register(:admins) { |actor|
+  actor.respond_to?(:admin?) && actor.admin?
+}
+
+# Example middleware to allow reading the Flipper UI but nothing else.
+class FlipperReadOnlyMiddleware
+  def initialize(app)
+    @app = app
+  end
+
+  def call(env)
+    request = Rack::Request.new(env)
+
+    if request.get?
+      @app.call(env)
+    else
+      [401, {}, ["You can only look"]]
+    end
+  end
+end
+
+# You can uncomment these to get some default data:
+# Flipper.enable(:search_performance_another_long_thing)
+# Flipper.disable(:gauges_tracking)
+# Flipper.disable(:unused)
+# Flipper.enable_actor(:suits, Flipper::Actor.new('1'))
+# Flipper.enable_actor(:suits, Flipper::Actor.new('6'))
+# Flipper.enable_group(:secrets, :admins)
+# Flipper.enable_percentage_of_time(:logging, 5)
+# Flipper.enable_percentage_of_actors(:new_cache, 15)
+# Flipper.add("a/b")
+
+run Flipper::UI.app { |builder|
+  builder.use Rack::Session::Cookie, secret: "_super_secret"
+  builder.use FlipperReadOnlyMiddleware
+}

data/examples/ui/basic.ru

@@ -1,20 +1,16 @@
 #
 # Usage:
-#   bundle exec rackup examples/ui/basic.ru -p 9999
-#   bundle exec shotgun examples/ui/basic.ru -p 9999
+#   # if you want it to not reload and be really fast
+#   bin/rackup examples/ui/basic.ru -p 9999
+#
+#   # if you want reloading
+#   bin/shotgun examples/ui/basic.ru -p 9999
+#
 #   http://localhost:9999/
 #
-require "pp"
-require "logger"
-require "pathname"
-
-root_path = Pathname(__FILE__).dirname.join("..").expand_path
-lib_path  = root_path.join("lib")
-$:.unshift(lib_path)
-
-require "flipper-ui"
+require 'bundler/setup'
+require "flipper/ui"
 require "flipper/adapters/pstore"
-require "active_support/notifications"
 
 Flipper.register(:admins) { |actor|
   actor.respond_to?(:admin?) && actor.admin?
@@ -24,28 +20,39 @@ Flipper.register(:early_access) { |actor|
   actor.respond_to?(:early?) && actor.early?
 }
 
-# Setup logging of flipper calls.
-if ENV["LOG"] == "1"
-  $logger = Logger.new(STDOUT)
-  require "flipper/instrumentation/log_subscriber"
-  Flipper::Instrumentation::LogSubscriber.logger = $logger
+Flipper::UI.configure do |config|
+  # config.banner_text = 'Production Environment'
+  # config.banner_class = 'danger'
+  config.feature_creation_enabled = true
+  config.feature_removal_enabled = true
+  config.cloud_recommendation = true
+  # config.show_feature_description_in_list = true
+  config.descriptions_source = lambda do |_keys|
+    {
+      "search_performance_another_long_thing" => "Just to test feature name length.",
+      "gauges_tracking" => "Should we track page views with gaug.es.",
+      "unused" => "Not used.",
+      "suits" => "Are suits necessary in business?",
+      "secrets" => "Secrets are lies.",
+      "logging" => "Log all the things.",
+      "new_cache" => "Like the old cache but newer.",
+      "a/b" => "Why would someone use a slash? I don't know but someone did. Let's make this really long so they regret using slashes. Please don't use slashes.",
+    }
+  end
 end
 
-adapter = Flipper::Adapters::PStore.new
-flipper = Flipper.new(adapter, instrumenter: ActiveSupport::Notifications)
-
 # You can uncomment these to get some default data:
-# flipper[:search_performance_another_long_thing].enable
-# flipper[:gauges_tracking].enable
-# flipper[:unused].disable
-# flipper[:suits].enable_actor Flipper::Actor.new('1')
-# flipper[:suits].enable_actor Flipper::Actor.new('6')
-# flipper[:secrets].enable_group :admins
-# flipper[:secrets].enable_group :early_access
-# flipper[:logging].enable_percentage_of_time 5
-# flipper[:new_cache].enable_percentage_of_actors 15
-# flipper["a/b"].add
-
-run Flipper::UI.app(flipper) { |builder|
+# Flipper.enable(:search_performance_another_long_thing)
+# Flipper.disable(:gauges_tracking)
+# Flipper.disable(:unused)
+# Flipper.enable_actor(:suits, Flipper::Actor.new('1'))
+# Flipper.enable_actor(:suits, Flipper::Actor.new('6'))
+# Flipper.enable_group(:secrets, :admins)
+# Flipper.enable_group(:secrets, :early_access)
+# Flipper.enable_percentage_of_time(:logging, 5)
+# Flipper.enable_percentage_of_actors(:new_cache, 15)
+# Flipper.add("a/b")
+
+run Flipper::UI.app { |builder|
   builder.use Rack::Session::Cookie, secret: "_super_secret"
 }

data/flipper-ui.gemspec

@@ -10,7 +10,6 @@ Gem::Specification.new do |gem|
   gem.authors       = ['John Nunemaker']
   gem.email         = ['nunemaker@gmail.com']
   gem.summary       = 'UI for the Flipper gem'
-  gem.description   = 'Rack middleware that provides a fully featured web interface for the flipper gem.'
   gem.license       = 'MIT'
   gem.homepage      = 'https://github.com/jnunemaker/flipper'
 
@@ -22,7 +21,7 @@ Gem::Specification.new do |gem|
   gem.metadata      = Flipper::METADATA
 
   gem.add_dependency 'rack', '>= 1.4', '< 3'
-  gem.add_dependency 'rack-protection', '>= 1.5.3', '< 2.1.0'
+  gem.add_dependency 'rack-protection', '>= 1.5.3', '< 2.2.0'
   gem.add_dependency 'flipper', "~> #{Flipper::VERSION}"
-  gem.add_dependency 'erubis', '~> 2.7.0'
+  gem.add_dependency 'erubi', '>= 1.0.0', '< 2.0.0'
 end

data/lib/flipper/ui/action.rb

@@ -1,6 +1,7 @@
 require 'forwardable'
+require 'flipper/ui/configuration'
 require 'flipper/ui/error'
-require 'flipper/ui/eruby'
+require 'erubi'
 require 'json'
 
 module Flipper
@@ -25,6 +26,36 @@ module Flipper
                                              'delete'.freeze,
                                            ]).freeze
 
+      SOURCES = {
+        bootstrap_css: {
+          src: "https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css".freeze,
+          hash: "sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm".freeze
+        }.freeze,
+        jquery_js: {
+          src: "https://code.jquery.com/jquery-3.2.1.slim.min.js".freeze,
+          hash: "sha384-KJ3o2DKtIkvYIK3UENzmM7KCkRr/rE9/Qpg6aAZGJwFDMVNA/GpGFF93hXpG5KkN".freeze
+        }.freeze,
+        popper_js: {
+          src: "https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.12.9/umd/popper.min.js".freeze,
+          hash: "sha384-ApNbgh9B+Y1QKtv3Rn7W3mgPxhU9K/ScQsAP7hUibX39j7fakFPskvXusvfa0b4Q".freeze
+        }.freeze,
+        bootstrap_js: {
+          src: "https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/js/bootstrap.min.js".freeze,
+          hash: "sha384-JZR6Spejh4U02d8jOt6vLEHfe/JQGiRRSQQxSfFWpi1MquVdAyjUar5+76PVCmYl".freeze
+        }.freeze
+      }.freeze
+      SCRIPT_SRCS = SOURCES.values_at(:jquery_js, :popper_js, :bootstrap_js).map { |s| s[:src] }
+      STYLE_SRCS = SOURCES.values_at(:bootstrap_css).map { |s| s[:src] }
+      CONTENT_SECURITY_POLICY = <<-CSP.delete("\n")
+        default-src 'none';
+        img-src 'self';
+        font-src 'self';
+        script-src 'report-sample' 'self' #{SCRIPT_SRCS.join(' ')};
+        style-src 'self' 'unsafe-inline' #{STYLE_SRCS.join(' ')};
+        style-src-attr 'unsafe-inline' ;
+        style-src-elem 'self' #{STYLE_SRCS.join(' ')};
+      CSP
+
       # Public: Call this in subclasses so the action knows its route.
       #
       # regex - The Regexp that this action should run for.
@@ -129,6 +160,7 @@ module Flipper
       # Returns a response.
       def view_response(name)
         header 'Content-Type', 'text/html'
+        header 'Content-Security-Policy', CONTENT_SECURITY_POLICY
         body = view_with_layout { view_without_layout name }
         halt [@code, @headers, [body]]
       end
@@ -150,7 +182,7 @@ module Flipper
       # location - The String location to set the Location header to.
       def redirect_to(location)
         status 302
-        header 'Location', "#{script_name}#{location}"
+        header 'Location', "#{script_name}#{Rack::Utils.escape_path(location)}"
         halt [@code, @headers, ['']]
       end
 
@@ -205,12 +237,8 @@ module Flipper
       # Private
       def view(name)
         path = views_path.join("#{name}.erb")
-
         raise "Template does not exist: #{path}" unless path.exist?
-
-        contents = path.read
-        compiled = Eruby.new(contents)
-        compiled.result proc {}.binding
+        eval(Erubi::Engine.new(path.read, escape: true).src)
       end
 
       # Internal: The path the app is mounted at.
@@ -240,6 +268,22 @@ module Flipper
       def valid_request_method?
         VALID_REQUEST_METHOD_NAMES.include?(request_method_name)
       end
+
+      def bootstrap_css
+        SOURCES[:bootstrap_css]
+      end
+
+      def bootstrap_js
+        SOURCES[:bootstrap_js]
+      end
+
+      def popper_js
+        SOURCES[:popper_js]
+      end
+
+      def jquery_js
+        SOURCES[:jquery_js]
+      end
     end
   end
 end

data/lib/flipper/ui/actions/actors_gate.rb

@@ -25,19 +25,22 @@ module Flipper
         def post
           feature = flipper[feature_name]
           value = params['value'].to_s.strip
+          values = value.split(UI.configuration.actors_separator).map(&:strip).uniq
 
-          if Util.blank?(value)
-            error = Rack::Utils.escape("#{value.inspect} is not a valid actor value.")
+          if values.empty?
+            error = "#{value.inspect} is not a valid actor value."
             redirect_to("/features/#{feature.key}/actors?error=#{error}")
           end
 
-          actor = Flipper::Actor.new(value)
+          values.each do |value|
+            actor = Flipper::Actor.new(value)
 
-          case params['operation']
-          when 'enable'
-            feature.enable_actor actor
-          when 'disable'
-            feature.disable_actor actor
+            case params['operation']
+            when 'enable'
+              feature.enable_actor actor
+            when 'disable'
+              feature.disable_actor actor
+            end
           end
 
           redirect_to("/features/#{feature.key}")

data/lib/flipper/ui/actions/feature.rb

@@ -10,9 +10,12 @@ module Flipper
         route %r{\A/features/(?<feature_name>.*)\Z}
 
         def get
-          @feature = Decorators::Feature.new(flipper[feature_name])
+          flipper_feature = flipper[feature_name]
+          @feature = Decorators::Feature.new(flipper_feature)
+          descriptions = Flipper::UI.configuration.descriptions_source.call([flipper_feature.key])
+          @feature.description = descriptions[@feature.key]
           @page_title = "#{@feature.key} // Features"
-          @percentages = [0, 1, 5, 10, 15, 25, 50, 75, 100]
+          @percentages = [0, 1, 5, 10, 25, 50, 100]
 
           breadcrumb 'Home', '/'
           breadcrumb 'Features', '/features'

data/lib/flipper/ui/actions/features.rb

@@ -10,8 +10,21 @@ module Flipper
 
         def get
           @page_title = 'Features'
+          keys = flipper.features.map(&:key)
+          descriptions = if Flipper::UI.configuration.show_feature_description_in_list?
+            Flipper::UI.configuration.descriptions_source.call(keys)
+          else
+            {}
+          end
+
           @features = flipper.features.map do |feature|
-            Decorators::Feature.new(feature)
+            decorated_feature = Decorators::Feature.new(feature)
+
+            if Flipper::UI.configuration.show_feature_description_in_list?
+              decorated_feature.description = descriptions[feature.key]
+            end
+
+            decorated_feature
           end.sort
 
           @show_blank_slate = @features.empty?
@@ -36,14 +49,14 @@ module Flipper
           value = params['value'].to_s.strip
 
           if Util.blank?(value)
-            error = Rack::Utils.escape("#{value.inspect} is not a valid feature name.")
+            error = "#{value.inspect} is not a valid feature name."
             redirect_to("/features/new?error=#{error}")
           end
 
           feature = flipper[value]
           feature.add
 
-          redirect_to "/features/#{Rack::Utils.escape_path(value)}"
+          redirect_to "/features/#{value}"
         end
       end
     end

data/lib/flipper/ui/actions/file.rb

@@ -5,7 +5,7 @@ module Flipper
   module UI
     module Actions
       class File < UI::Action
-        route %r{(images|css|js|octicons|fonts)/.*\Z}
+        route %r{(images|css|js)/.*\Z}
 
         def get
           Rack::File.new(public_path).call(request.env)

data/lib/flipper/ui/actions/groups_gate.rb

@@ -35,7 +35,7 @@ module Flipper
 
             redirect_to("/features/#{feature.key}")
           else
-            error = Rack::Utils.escape("The group named #{value.inspect} has not been registered.")
+            error = "The group named #{value.inspect} has not been registered."
             redirect_to("/features/#{feature.key}/groups?error=#{error}")
           end
         end

data/lib/flipper/ui/actions/percentage_of_actors_gate.rb

@@ -16,7 +16,7 @@ module Flipper
           begin
             feature.enable_percentage_of_actors params['value']
           rescue ArgumentError => exception
-            error = Rack::Utils.escape("Invalid percentage of actors value: #{exception.message}")
+            error = "Invalid percentage of actors value: #{exception.message}"
             redirect_to("/features/#{@feature.key}?error=#{error}")
           end
 

data/lib/flipper/ui/actions/percentage_of_time_gate.rb

@@ -16,7 +16,7 @@ module Flipper
           begin
             feature.enable_percentage_of_time params['value']
           rescue ArgumentError => exception
-            error = Rack::Utils.escape("Invalid percentage of time value: #{exception.message}")
+            error = "Invalid percentage of time value: #{exception.message}"
             redirect_to("/features/#{@feature.key}?error=#{error}")
           end
 

data/lib/flipper/ui/assets/javascripts/application.coffee

@@ -1,3 +1,5 @@
-$(() ->
-  $('[data-toggle="tooltip"]').tooltip();
-);
+$ ->
+  $(document).on('click', '.js-toggle-trigger', ->
+    $container = $(this).closest('.js-toggle-container')
+    $container.toggleClass('toggle-on')
+  )

data/lib/flipper/ui/configuration.rb

@@ -3,11 +3,7 @@ require 'flipper/ui/configuration/option'
 module Flipper
   module UI
     class Configuration
-      attr_reader :actors,
-                  :delete,
-                  :groups,
-                  :percentage_of_actors,
-                  :percentage_of_time
+      attr_reader :delete
 
       attr_accessor :banner_text,
                     :banner_class
@@ -26,6 +22,33 @@ module Flipper
       # set to false, users won't be able to delete features from the UI.
       attr_accessor :feature_removal_enabled
 
+      # Public: Are you feeling lucky? Defaults to true. If set to false, users
+      # won't see a videoclip of Taylor Swift when there aren't any features
+      attr_accessor :fun
+
+      # Public: Tired of seeing the awesome message about Cloud? Set this to
+      # false and it will go away. Defaults to true.
+      attr_accessor :cloud_recommendation
+
+      # Public: What should show up in the form to add actors. This can be
+      # different per application since flipper_id's can be whatever an
+      # application needs. Defaults to "a flipper id".
+      attr_accessor :add_actor_placeholder
+
+      # Public: If you set this, Flipper::UI will fetch descriptions
+      # from your external source. Descriptions for `features` will be shown on `feature`
+      # page, and optionally the `features` pages. Defaults to empty block.
+      attr_accessor :descriptions_source
+
+      # Public: Should feature descriptions be show on the `features` list page.
+      # Default false. Only works when using descriptions.
+      attr_accessor :show_feature_description_in_list
+
+      # Public: What should be used to denote you are trying to add multiple
+      # actors at once (instead of just a single actor).
+      # Default is comma ",".
+      attr_accessor :actors_separator
+
       VALID_BANNER_CLASS_VALUES = %w(
         danger
         dark
@@ -37,16 +60,28 @@ module Flipper
         warning
       ).freeze
 
+      DEFAULT_DESCRIPTIONS_SOURCE = ->(_keys) { {} }
+
       def initialize
-        @actors = Option.new("Actors", "Enable actors using the form above.")
-        @groups = Option.new("Groups", "Enable groups using the form above.")
-        @percentage_of_actors = Option.new("Percentage of Actors", "Percentage of actors functions independently of percentage of time. If you enable 50% of Actors and 25% of Time then the feature will always be enabled for 50% of users and occasionally enabled 25% of the time for everyone.") # rubocop:disable Metrics/LineLength
-        @percentage_of_time = Option.new("Percentage of Time", "Percentage of actors functions independently of percentage of time. If you enable 50% of Actors and 25% of Time then the feature will always be enabled for 50% of users and occasionally enabled 25% of the time for everyone.") # rubocop:disable Metrics/LineLength
-        @delete = Option.new("Danger Zone", "Deleting a feature removes it from the list of features and disables it for everyone.") # rubocop:disable Metrics/LineLength
+        @delete = Option.new("Danger Zone", "Deleting a feature removes it from the list of features and disables it for everyone.")
         @banner_text = nil
         @banner_class = 'danger'
         @feature_creation_enabled = true
         @feature_removal_enabled = true
+        @fun = true
+        @cloud_recommendation = true
+        @add_actor_placeholder = "a flipper id"
+        @descriptions_source = DEFAULT_DESCRIPTIONS_SOURCE
+        @show_feature_description_in_list = false
+        @actors_separator = ','
+      end
+
+      def using_descriptions?
+        @descriptions_source != DEFAULT_DESCRIPTIONS_SOURCE
+      end
+
+      def show_feature_description_in_list?
+        using_descriptions? && @show_feature_description_in_list
       end
 
       def banner_class=(value)