flipper-ui 0.10.1 → 0.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb1bfdee4a96ba233417ff628d798b3c143df5a6
-  data.tar.gz: c26c0f69ae33c2667826ff9eea83303e54f64d11
+  metadata.gz: aecff7000b2350bc4238cd50dcfc9cad07c8bb27
+  data.tar.gz: 86be7431a5eca0a785984083c645dbf6fa7e510e
 SHA512:
-  metadata.gz: db86038c00be28d278b1b878f32f9bf075e620f5f152eeea6ee13be502aa94c593b79ad24cca45c99ece880849bd22f87385df770197f605f874b4ca69a2a3ff
-  data.tar.gz: 6c461a47ea74dacf2e3901f5fee62609ef0de89ff554065c8efd0c24abda3e743fa9ee2d94966499ea2aac3d2c5b37eefc26782d5d1e78d165158dbffeab9d8c
+  metadata.gz: 7945d54ccb03a0d2b3b309175a601d797b68f1c96fa80d66354d1028aafe12abc7fc2b1eb83b40577180a8dec3450044ad86b8ae58bf4d7653c0d3d3890e6185
+  data.tar.gz: d5d68823b6d56dfe8069792b5e18c52530400967ca8ff078cf0590dc9768d0c61c2a8ea44780a0cf2b290ac9181673e795c84ec7690af53c300e12db4e788e98

data/lib/flipper/ui/actions/actors_gate.rb

@@ -24,7 +24,7 @@ module Flipper
         def post
           feature_name = Rack::Utils.unescape(request.path.split('/')[-2])
           feature = flipper[feature_name.to_sym]
-          value = params["value"]
+          value = params["value"].to_s.strip
 
           if Util.blank?(value)
             error = Rack::Utils.escape("#{value.inspect} is not a valid actor value.")

data/lib/flipper/ui/actions/features.rb

@@ -34,7 +34,7 @@ module Flipper
             halt view_response(:feature_creation_disabled)
           end
 
-          value = params["value"]
+          value = params["value"].to_s.strip
 
           if Util.blank?(value)
             error = Rack::Utils.escape("#{value.inspect} is not a valid feature name.")

data/lib/flipper/ui/actions/groups_gate.rb

@@ -23,7 +23,7 @@ module Flipper
         def post
           feature_name = Rack::Utils.unescape(request.path.split('/')[-2])
           feature = flipper[feature_name.to_sym]
-          value = params["value"]
+          value = params["value"].to_s.strip
 
           case params["operation"]
           when "enable"

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.10.1".freeze
+  VERSION = "0.10.2".freeze
 end

data/spec/flipper/ui/actions/actors_gate_spec.rb

@@ -32,9 +32,11 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
 
   describe "POST /features/:feature/actors" do
     context "enabling an actor" do
+      let(:value) { "User:6" }
+
       before do
         post "features/search/actors",
-          {"value" => "User:6", "operation" => "enable", "authenticity_token" => token},
+          {"value" => value, "operation" => "enable", "authenticity_token" => token},
           "rack.session" => session
       end
 
@@ -46,13 +48,43 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
         expect(last_response.status).to be(302)
         expect(last_response.headers["Location"]).to eq("/features/search")
       end
+
+      context 'value contains whitespace' do
+        let(:value) { "  User:6  " }
+
+        it "adds item without whitespace" do
+          expect(flipper[:search].actors_value).to include("User:6")
+        end
+      end
+
+      context "for an invalid actor value" do
+        context "empty value" do
+          let(:value) { "" }
+
+          it "redirects back to feature" do
+            expect(last_response.status).to be(302)
+            expect(last_response.headers["Location"]).to eq("/features/search/actors?error=%22%22+is+not+a+valid+actor+value.")
+          end
+        end
+
+        context "nil value" do
+          let(:value) { nil }
+
+          it "redirects back to feature" do
+            expect(last_response.status).to be(302)
+            expect(last_response.headers["Location"]).to eq("/features/search/actors?error=%22%22+is+not+a+valid+actor+value.")
+          end
+        end
+      end
     end
 
     context "disabling an actor" do
+      let(:value) { "User:6" }
+
       before do
         flipper[:search].enable_actor Flipper::UI::Actor.new("User:6")
         post "features/search/actors",
-          {"value" => "User:6", "operation" => "disable", "authenticity_token" => token},
+          {"value" => value, "operation" => "disable", "authenticity_token" => token},
           "rack.session" => session
       end
 
@@ -64,18 +96,13 @@ RSpec.describe Flipper::UI::Actions::ActorsGate do
         expect(last_response.status).to be(302)
         expect(last_response.headers["Location"]).to eq("/features/search")
       end
-    end
 
-    context "for an invalid actor value" do
-      before do
-        post "features/search/actors",
-          {"value" => "", "operation" => "enable", "authenticity_token" => token},
-          "rack.session" => session
-      end
+      context 'value contains whitespace' do
+        let(:value) { "  User:6  " }
 
-      it "redirects back to feature" do
-        expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/search/actors?error=%22%22+is+not+a+valid+actor+value.")
+        it "removes item whitout whitespace" do
+          expect(flipper[:search].actors_value).not_to include("User:6")
+        end
       end
     end
   end

data/spec/flipper/ui/actions/features_spec.rb

@@ -33,12 +33,14 @@ RSpec.describe Flipper::UI::Actions::Features do
     end
   end
 
-  describe "POST /features with feature_creation_enabled set to true" do
+  describe "POST /features" do
+    let(:feature_name) { "notifications_next" }
+
     before do
       @original_feature_creation_enabled = Flipper::UI.feature_creation_enabled
-      Flipper::UI.feature_creation_enabled = true
+      Flipper::UI.feature_creation_enabled = feature_creation_enabled
       post "/features",
-        {"value" => "notifications_next", "authenticity_token" => token},
+        {"value" => feature_name, "authenticity_token" => token},
         "rack.session" => session
     end
 
@@ -46,39 +48,69 @@ RSpec.describe Flipper::UI::Actions::Features do
       Flipper::UI.feature_creation_enabled = @original_feature_creation_enabled
     end
 
-    it "adds feature" do
-      expect(flipper.features.map(&:key)).to include("notifications_next")
-    end
+    context 'feature_creation_enabled set to true' do
+      let(:feature_creation_enabled) { true }
 
-    it "redirects to feature" do
-      expect(last_response.status).to be(302)
-      expect(last_response.headers["Location"]).to eq("/features/notifications_next")
-    end
-  end
+      it "adds feature" do
+        expect(flipper.features.map(&:key)).to include("notifications_next")
+      end
 
-  describe "POST /features with feature_creation_enabled set to false" do
-    before do
-      @original_feature_creation_enabled = Flipper::UI.feature_creation_enabled
-      Flipper::UI.feature_creation_enabled = false
-      post "/features",
-        {"value" => "notifications_next", "authenticity_token" => token},
-        "rack.session" => session
-    end
+      it "redirects to feature" do
+        expect(last_response.status).to be(302)
+        expect(last_response.headers["Location"]).to eq("/features/notifications_next")
+      end
 
-    after do
-      Flipper::UI.feature_creation_enabled = @original_feature_creation_enabled
-    end
+      context 'feature name contains whitespace' do
+        let(:feature_name) { "  notifications_next   " }
 
-    it "does not add feature" do
-      expect(flipper.features.map(&:key)).to_not include("notifications_next")
-    end
+        it "adds feature without whitespace" do
+          expect(flipper.features.map(&:key)).to include("notifications_next")
+        end
+      end
+
+      context "for an invalid feature name" do
+        context "empty feature name" do
+          let(:feature_name) { "" }
+
+          it "does not add feature" do
+            expect(flipper.features.map(&:key)).to eq([])
+          end
+
+          it "redirects back to feature" do
+            expect(last_response.status).to be(302)
+            expect(last_response.headers["Location"]).to eq("/features/new?error=%22%22+is+not+a+valid+feature+name.")
+          end
+        end
 
-    it "returns 403" do
-      expect(last_response.status).to be(403)
+        context "nil feature name" do
+          let(:feature_name) { nil }
+
+          it "does not add feature" do
+            expect(flipper.features.map(&:key)).to eq([])
+          end
+
+          it "redirects back to feature" do
+            expect(last_response.status).to be(302)
+            expect(last_response.headers["Location"]).to eq("/features/new?error=%22%22+is+not+a+valid+feature+name.")
+          end
+        end
+      end
     end
 
-    it "renders feature creation disabled template" do
-      expect(last_response.body).to include("Feature creation is disabled.")
+    context 'feature_creation_enabled set to false' do
+      let(:feature_creation_enabled) { false }
+
+      it "does not add feature" do
+        expect(flipper.features.map(&:key)).to_not include("notifications_next")
+      end
+
+      it "returns 403" do
+        expect(last_response.status).to be(403)
+      end
+
+      it "renders feature creation disabled template" do
+        expect(last_response.body).to include("Feature creation is disabled.")
+      end
     end
   end
 end

data/spec/flipper/ui/actions/groups_gate_spec.rb

@@ -36,6 +36,8 @@ RSpec.describe Flipper::UI::Actions::GroupsGate do
   end
 
   describe "POST /features/:feature/groups" do
+    let(:group_name) { "admins" }
+
     before do
       Flipper.register(:admins) { |user| user.admin? }
     end
@@ -47,7 +49,7 @@ RSpec.describe Flipper::UI::Actions::GroupsGate do
     context "enabling a group" do
       before do
         post "features/search/groups",
-          {"value" => "admins", "operation" => "enable", "authenticity_token" => token},
+          {"value" => group_name, "operation" => "enable", "authenticity_token" => token},
           "rack.session" => session
       end
 
@@ -59,13 +61,52 @@ RSpec.describe Flipper::UI::Actions::GroupsGate do
         expect(last_response.status).to be(302)
         expect(last_response.headers["Location"]).to eq("/features/search")
       end
+
+      context 'group name contains whitespace' do
+        let(:group_name) { "  admins  " }
+
+        it "adds item without whitespace" do
+          expect(flipper[:search].groups_value).to include("admins")
+        end
+      end
+
+      context "for an unregistered group" do
+        context "unknown group name" do
+          let(:group_name) { "not_here" }
+
+          it "redirects back to feature" do
+            expect(last_response.status).to be(302)
+            expect(last_response.headers["Location"]).to eq("/features/search/groups?error=The+group+named+%22not_here%22+has+not+been+registered.")
+          end
+        end
+
+        context "empty group name" do
+          let(:group_name) { "" }
+
+          it "redirects back to feature" do
+            expect(last_response.status).to be(302)
+            expect(last_response.headers["Location"]).to eq("/features/search/groups?error=The+group+named+%22%22+has+not+been+registered.")
+          end
+        end
+
+        context "nil group name" do
+          let(:group_name) { nil }
+
+          it "redirects back to feature" do
+            expect(last_response.status).to be(302)
+            expect(last_response.headers["Location"]).to eq("/features/search/groups?error=The+group+named+%22%22+has+not+been+registered.")
+          end
+        end
+      end
     end
 
     context "disabling a group" do
+      let(:group_name) { "admins" }
+
       before do
         flipper[:search].enable_group :admins
         post "features/search/groups",
-          {"value" => "admins", "operation" => "disable", "authenticity_token" => token},
+          {"value" => group_name, "operation" => "disable", "authenticity_token" => token},
           "rack.session" => session
       end
 
@@ -77,18 +118,13 @@ RSpec.describe Flipper::UI::Actions::GroupsGate do
         expect(last_response.status).to be(302)
         expect(last_response.headers["Location"]).to eq("/features/search")
       end
-    end
 
-    context "for an unregistered group" do
-      before do
-        post "features/search/groups",
-          {"value" => "not_here", "operation" => "enable", "authenticity_token" => token},
-          "rack.session" => session
-      end
+      context 'group name contains whitespace' do
+        let(:group_name) { "  admins  " }
 
-      it "redirects back to feature" do
-        expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/search/groups?error=The+group+named+%22not_here%22+has+not+been+registered.")
+        it "removes item without whitespace" do
+          expect(flipper[:search].groups_value).not_to include("admins")
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-ui
 version: !ruby/object:Gem::Version
-  version: 0.10.1
+  version: 0.10.2
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-19 00:00:00.000000000 Z
+date: 2016-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -56,14 +56,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.10.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.10.2
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement