flipper-redis 1.2.1 → 1.3.0.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81d4a4b62fd5f48b74aae7137e3ca383c510aa89e9d11d2674708c120d985229
-  data.tar.gz: e35e14ff8636b75300a0f962017d9b212d17120c60b27aeba048956189a0a003
+  metadata.gz: 59430891951625789c71f32a02e5980d2cc652325b440c67567d18ef558f1ef4
+  data.tar.gz: c8b13da6dab4000d45de813dd552ff1ec3e8781fed5e4271b846f0237efd60e3
 SHA512:
-  metadata.gz: 77984006356dc5ecaabef2eff62bca84f8ba904af725f3e16e62172aeb756ec7c7d7011e224ea37334218dc7d08e110044dfbbabc08cc6eca1e03bc282626f42
-  data.tar.gz: cb0cec1aebfc88241cf0f350c2becca24b049b69a3b49781c300ec7eb4aaf5c2af87bbbdf4d879d22addb370d9fe71acf514cd2094d03f31595b80e6b8090d8c
+  metadata.gz: 79249f1638b67670fb93f725659e58bb0231e02199300024350f3ede831e7861ba7596f4eb257c7689a87724f259a07d08c6f89dadfb643202f00944b474b65d
+  data.tar.gz: 7bbc58f6f5ab4caa2e1f7cd8b111bad1187beaad54d55b5c76e75b5add26df75ed5ccb6853e698df4affa6e159eb24484e6daf68d8599b10a125c39c9b56906d

data/lib/flipper/adapters/redis_cache.rb

@@ -1,147 +1,45 @@
 require 'redis'
 require 'flipper'
+require 'flipper/adapters/cache_base'
 
 module Flipper
   module Adapters
     # Public: Adapter that wraps another adapter with the ability to cache
-    # adapter calls in Redis
-    class RedisCache
-      include ::Flipper::Adapter
-
-      # Internal
-      attr_reader :cache
-
-      # Public
-      def initialize(adapter, cache, ttl = 3600)
-        @adapter = adapter
-        @cache = cache
-        @ttl = ttl
-
-        @version = 'v1'.freeze
-        @namespace = "flipper/#{@version}".freeze
-        @features_key = "#{@namespace}/features".freeze
-        @get_all_key = "#{@namespace}/get_all".freeze
-      end
-
-      # Public
-      def features
-        read_feature_keys
-      end
-
-      # Public
-      def add(feature)
-        result = @adapter.add(feature)
-        @cache.del(@features_key)
-        result
-      end
-
-      # Public
-      def remove(feature)
-        result = @adapter.remove(feature)
-        @cache.del(@features_key)
-        @cache.del(key_for(feature.key))
-        result
-      end
-
-      # Public
-      def clear(feature)
-        result = @adapter.clear(feature)
-        @cache.del(key_for(feature.key))
-        result
-      end
-
-      # Public
-      def get(feature)
-        fetch(key_for(feature.key)) do
-          @adapter.get(feature)
-        end
-      end
-
-      def get_multi(features)
-        read_many_features(features)
-      end
-
-      def get_all
-        if @cache.setnx(@get_all_key, Time.now.to_i)
-          @cache.expire(@get_all_key, @ttl)
-          response = @adapter.get_all
-          response.each do |key, value|
-            set_with_ttl key_for(key), value
-          end
-          set_with_ttl @features_key, response.keys.to_set
-          response
-        else
-          features = read_feature_keys.map { |key| Flipper::Feature.new(key, self) }
-          read_many_features(features)
-        end
-      end
-
-      # Public
-      def enable(feature, gate, thing)
-        result = @adapter.enable(feature, gate, thing)
-        @cache.del(key_for(feature.key))
-        result
-      end
-
-      # Public
-      def disable(feature, gate, thing)
-        result = @adapter.disable(feature, gate, thing)
-        @cache.del(key_for(feature.key))
-        result
+    # adapter calls in Redis.
+    class RedisCache < CacheBase
+      def initialize(adapter, cache, ttl = 3600, prefix: nil)
+        super
       end
 
       private
 
-      def key_for(key)
-        "#{@namespace}/feature/#{key}"
-      end
-
-      def read_feature_keys
-        fetch(@features_key) { @adapter.features }
-      end
-
-      def read_many_features(features)
-        keys = features.map(&:key)
-        cache_result = Hash[keys.zip(multi_cache_get(keys))]
-        uncached_features = features.reject { |feature| cache_result[feature.key] }
-
-        if uncached_features.any?
-          response = @adapter.get_multi(uncached_features)
-          response.each do |key, value|
-            set_with_ttl(key_for(key), value)
-            cache_result[key] = value
-          end
-        end
-
-        result = {}
-        features.each do |feature|
-          result[feature.key] = cache_result[feature.key]
-        end
-        result
-      end
-
-      def fetch(cache_key)
-        cached = @cache.get(cache_key)
+      def cache_fetch(key, &block)
+        cached = @cache.get(key)
         if cached
           Marshal.load(cached)
         else
           to_cache = yield
-          set_with_ttl(cache_key, to_cache)
+          cache_write key, to_cache
           to_cache
         end
       end
 
-      def set_with_ttl(key, value)
-        @cache.setex(key, @ttl, Marshal.dump(value))
-      end
+      def cache_read_multi(keys)
+        return {} if keys.empty?
 
-      def multi_cache_get(keys)
-        return [] if keys.empty?
-
-        cache_keys = keys.map { |key| key_for(key) }
-        @cache.mget(*cache_keys).map do |value|
+        values = @cache.mget(*keys).map do |value|
           value ? Marshal.load(value) : nil
         end
+
+        Hash[keys.zip(values)]
+      end
+
+      def cache_write(key, value)
+        @cache.setex(key, @ttl, Marshal.dump(value))
+      end
+
+      def cache_delete(key)
+        @cache.del(key)
       end
     end
   end

data/lib/flipper/version.rb

@@ -1,5 +1,5 @@
 module Flipper
-  VERSION = '1.2.1'.freeze
+  VERSION = '1.3.0.pre'.freeze
 
   REQUIRED_RUBY_VERSION = '2.6'.freeze
   NEXT_REQUIRED_RUBY_VERSION = '3.0'.freeze

data/spec/flipper/adapters/redis_cache_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe Flipper::Adapters::RedisCache do
   let(:memory_adapter) do
     Flipper::Adapters::OperationLogger.new(Flipper::Adapters::Memory.new)
   end
-  let(:adapter) { described_class.new(memory_adapter, client) }
+  let(:adapter) { described_class.new(memory_adapter, client, 10) }
   let(:flipper) { Flipper.new(adapter) }
 
   subject { adapter }
@@ -24,6 +24,73 @@ RSpec.describe Flipper::Adapters::RedisCache do
 
   it_should_behave_like 'a flipper adapter'
 
+  it "knows ttl" do
+    expect(adapter.ttl).to eq(10)
+  end
+
+  it "knows features_cache_key" do
+    expect(adapter.features_cache_key).to eq("flipper/v1/features")
+  end
+
+  it "can expire features cache" do
+    # cache the features
+    adapter.features
+    expect(client.get("flipper/v1/features")).not_to be(nil)
+
+    # expire cache
+    adapter.expire_features_cache
+    expect(client.get("flipper/v1/features")).to be(nil)
+  end
+
+  it "can expire feature cache" do
+    # cache the features
+    adapter.get(flipper[:stats])
+    expect(client.get("flipper/v1/feature/stats")).not_to be(nil)
+
+    # expire cache
+    adapter.expire_feature_cache("stats")
+    expect(client.get("flipper/v1/feature/stats")).to be(nil)
+  end
+
+  it "can generate feature cache key" do
+    expect(adapter.feature_cache_key("stats")).to eq("flipper/v1/feature/stats")
+  end
+
+  context "when using a prefix" do
+    let(:adapter) { described_class.new(memory_adapter, client, 3600, prefix: "foo/") }
+    it_should_behave_like 'a flipper adapter'
+
+    it "knows features_cache_key" do
+      expect(adapter.features_cache_key).to eq("foo/flipper/v1/features")
+    end
+
+    it "can generate feature cache key" do
+      expect(adapter.feature_cache_key("stats")).to eq("foo/flipper/v1/feature/stats")
+    end
+
+    it "uses the prefix for all keys" do
+      # check individual feature get cached with prefix
+      adapter.get(flipper[:stats])
+      expect(Marshal.load(client.get("foo/flipper/v1/feature/stats"))).not_to be(nil)
+
+      # check individual feature expired with prefix
+      adapter.remove(flipper[:stats])
+      expect(client.get("foo/flipper/v1/feature/stats")).to be(nil)
+
+      # enable some stuff
+      flipper.enable_percentage_of_actors(:search, 10)
+      flipper.enable(:stats)
+
+      # populate the cache
+      adapter.get_all
+
+      # verify cached with prefix
+      expect(Marshal.load(client.get("foo/flipper/v1/features"))).to eq(Set["stats", "search"])
+      expect(Marshal.load(client.get("foo/flipper/v1/feature/search"))[:percentage_of_actors]).to eq("10")
+      expect(Marshal.load(client.get("foo/flipper/v1/feature/stats"))[:boolean]).to eq("true")
+    end
+  end
+
   describe '#remove' do
     it 'expires feature' do
       feature = flipper[:stats]
@@ -82,17 +149,19 @@ RSpec.describe Flipper::Adapters::RedisCache do
       adapter.get_all
       expect(Marshal.load(client.get("flipper/v1/feature/#{stats.key}"))[:boolean]).to eq('true')
       expect(Marshal.load(client.get("flipper/v1/feature/#{search.key}"))[:boolean]).to be(nil)
-      expect(client.get("flipper/v1/get_all").to_i).to be_within(2).of(Time.now.to_i)
+      expect(Marshal.load(client.get("flipper/v1/features"))).to eq(Set["stats", "search"])
     end
 
     it 'returns same result when already cached' do
       expect(adapter.get_all).to eq(adapter.get_all)
     end
 
-    it 'only invokes one call to wrapped adapter' do
+    it 'only invokes two calls to wrapped adapter (for features set and gate data for each feature in set)' do
       memory_adapter.reset
       5.times { adapter.get_all }
-      expect(memory_adapter.count(:get_all)).to eq(1)
+      expect(memory_adapter.count(:features)).to eq(1)
+      expect(memory_adapter.count(:get_multi)).to eq(1)
+      expect(memory_adapter.count).to eq(2)
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-redis
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0.pre
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-15 00:00:00.000000000 Z
+date: 2024-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.3.0.pre
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.3.0.pre
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
@@ -70,7 +70,7 @@ metadata:
   homepage_uri: https://www.flippercloud.io
   source_code_uri: https://github.com/flippercloud/flipper
   bug_tracker_uri: https://github.com/flippercloud/flipper/issues
-  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.2.1
+  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.3.0.pre
 post_install_message:
 rdoc_options: []
 require_paths: