flipper-redis 0.24.1 → 0.25.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d03229764fb9f1ca1443a0e32779bc8a0d23913b57debf63513e6b55251004fa
-  data.tar.gz: 3ed534fc6218a2df061008e8057beaa08bd6645318ae33d2ca1cb491d1ebb683
+  metadata.gz: 13389e639f482e51952030304e02d945aab43ca406ec67daf3f591117160c726
+  data.tar.gz: 575f21419f14fab17ebe8d88ae919f2ba127ff580cb21892025abed8e6c0c19e
 SHA512:
-  metadata.gz: d487eb67f3e4d9f3b4f5e590eb1a56c5cadd4ac24cfd95fe26f68315e595cfbb3103a9138035f511a282ad07cd7b356ed76fef669538ec6a15d5556996263b72
-  data.tar.gz: be0cce07afcc3dbb907928698c6c88667c5a3d652f8791936c55842c37451d4e364375e444528c6d64567003455c466fe56633c94385e49b8de18f726d0e78d8
+  metadata.gz: 1e2e6fc9c924156f2092c40459543413ec061e9b78fcdd60490cef98bc8cab9096d7e72c6c2568ec66c59f7d06da4839658fc9c01d725eb17f58edbedabc5b55
+  data.tar.gz: 0365d12dbfb9dfcff20cd92c1458b97f7b8ba20422ca04fd28b50dcd77f513471b0862251e870c28002eeed873e9906031505aae5e776b4f3fc5a8f97bb990c8

data/lib/flipper/adapters/redis.rb

@@ -28,13 +28,21 @@ module Flipper
 
       # Public: Adds a feature to the set of known features.
       def add(feature)
-        @client.sadd FeaturesKey, feature.key
+        if redis_sadd_returns_boolean?
+          @client.sadd? FeaturesKey, feature.key
+        else
+          @client.sadd FeaturesKey, feature.key
+        end
         true
       end
 
       # Public: Removes a feature from the set of known features.
       def remove(feature)
-        @client.srem FeaturesKey, feature.key
+        if redis_sadd_returns_boolean?
+          @client.srem? FeaturesKey, feature.key
+        else
+          @client.srem FeaturesKey, feature.key
+        end
         @client.del feature.key
         true
       end
@@ -109,6 +117,10 @@ module Flipper
 
       private
 
+      def redis_sadd_returns_boolean?
+        ::Redis.respond_to?(:sadd_returns_boolean) && ::Redis.sadd_returns_boolean
+      end
+
       def read_many_features(features)
         docs = docs_for(features)
         result = {}

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.24.1'.freeze
+  VERSION = '0.25.2'.freeze
 end

data/spec/flipper/adapters/redis_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Flipper::Adapters::Redis do
 
     options[:url] = ENV['REDIS_URL'] if ENV['REDIS_URL']
 
+    Redis.raise_deprecations = true
     Redis.new(options)
   end
 
@@ -25,7 +26,7 @@ RSpec.describe Flipper::Adapters::Redis do
     Flipper.configuration = nil
     Flipper.instance = nil
 
-    load 'flipper/adapters/redis.rb'
+    silence { load 'flipper/adapters/redis.rb' }
 
     expect(Flipper.adapter.adapter).to be_a(Flipper::Adapters::Redis)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-redis
 version: !ruby/object:Gem::Version
-  version: 0.24.1
+  version: 0.25.2
 platform: ruby
 authors:
 - John Nunemaker
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-13 00:00:00.000000000 Z
+date: 2022-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.24.1
+        version: 0.25.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.24.1
+        version: 0.25.2
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
@@ -44,7 +44,7 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '5'
-description: 
+description:
 email:
 - nunemaker@gmail.com
 executables: []
@@ -68,7 +68,7 @@ licenses:
 - MIT
 metadata:
   changelog_uri: https://github.com/jnunemaker/flipper/blob/master/Changelog.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -83,8 +83,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Redis adapter for Flipper
 test_files: