flipper-redis 0.20.4 → 0.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 38ed937a4141ea4dd894c5b12894a117d5117309106993ae73f541bbabf4ca52
-  data.tar.gz: 79c9e9e33ff30120149967724ab170417cba12431cbae1dc46d243e4f2a4043c
+  metadata.gz: cb99d58e35c7f9ef6e7009d590b10567f892e12219d7e9932efd1fbf8738ca93
+  data.tar.gz: 29e58a9005b46a3c5369b627c4e202900c6f26fa3a21a037ce4bad5402027281
 SHA512:
-  metadata.gz: 12e3459fc127df7292e9288dd4a63cf7a8c6332dcefc2f0bdfd80e145b1966dd1cdbb95913616f998a602b26e7e8b1c71f59052fdccccdca68ab66ce00a683c5
-  data.tar.gz: c7215cefbff7c825dca2a15d2e10b49c021aad72ff4b4d51ac8131b32173b42aad70f4f2a10da724431121bf19ce71dd10b6e912e6525c0c09a27aca7dc99901
+  metadata.gz: 993919ce04acf986020d41383393f15312366f903eefc8db7331dfbe3b3223d6c15fab41b3755ac7e480bee71bf4dc257ab1425984d5203098a03b621e18c22e
+  data.tar.gz: eca5fc0aa2ffccd136dd5972c4e6bae7d43a28e27d5696a419e0fb3e94b6b5ac0227a1491b85f7c30e9600144033b5c4272da80c1d50330a6d35a26fce39643f

data/docs/redis/README.md

@@ -18,12 +18,18 @@ Or install it yourself with:
 
 ## Usage
 
+In most cases, all you need to do is require the adapter. It will connect to the Redis instance specified in the `REDIS_URL` or `FLIPPER_REDIS_URL` environment vairable, or localhost by default.
+
 ```ruby
 require 'flipper/adapters/redis'
-client = Redis.new
-adapter = Flipper::Adapters::Redis.new(client)
-flipper = Flipper.new(adapter)
-# profit...
+```
+
+**If you need to customize the adapter**, you can add this to an initializer:
+
+```ruby
+Flipper.configure do |config|
+  config.adapter { Flipper::Adapters::Redis.new(Redis.new) }
+end
 ```
 
 ## Internals

data/examples/redis/basic.rb

@@ -1,30 +1,19 @@
-require 'pathname'
+require 'bundler/setup'
 require 'logger'
 
-root_path = Pathname(__FILE__).dirname.join('..').expand_path
-lib_path  = root_path.join('lib')
-$:.unshift(lib_path)
-
 require 'flipper/adapters/redis'
-options = {}
-if ENV['REDIS_URL']
-  options[:url] = ENV['REDIS_URL']
-end
-client = Redis.new(options)
-adapter = Flipper::Adapters::Redis.new(client)
-flipper = Flipper.new(adapter)
 
-flipper[:stats].enable
+Flipper[:stats].enable
 
-if flipper[:stats].enabled?
+if Flipper[:stats].enabled?
   puts "Enabled!"
 else
   puts "Disabled!"
 end
 
-flipper[:stats].disable
+Flipper[:stats].disable
 
-if flipper[:stats].enabled?
+if Flipper[:stats].enabled?
   puts "Enabled!"
 else
   puts "Disabled!"

data/examples/redis/internals.rb

@@ -1,20 +1,9 @@
+require 'bundler/setup'
 require 'pp'
-require 'pathname'
 require 'logger'
-
-root_path = Pathname(__FILE__).dirname.join('..').expand_path
-lib_path  = root_path.join('lib')
-$:.unshift(lib_path)
-
 require 'flipper/adapters/redis'
 
-options = {}
-if ENV['REDIS_URL']
-  options[:url] = ENV['REDIS_URL']
-end
-client = Redis.new(options)
-adapter = Flipper::Adapters::Redis.new(client)
-flipper = Flipper.new(adapter)
+client = Redis.new
 
 # Register a few groups.
 Flipper.register(:admins) { |thing| thing.admin? }
@@ -23,16 +12,16 @@ Flipper.register(:early_access) { |thing| thing.early_access? }
 # Create a user class that has flipper_id instance method.
 User = Struct.new(:flipper_id)
 
-flipper[:stats].enable
-flipper[:stats].enable_group :admins
-flipper[:stats].enable_group :early_access
-flipper[:stats].enable_actor User.new('25')
-flipper[:stats].enable_actor User.new('90')
-flipper[:stats].enable_actor User.new('180')
-flipper[:stats].enable_percentage_of_time 15
-flipper[:stats].enable_percentage_of_actors 45
+Flipper[:stats].enable
+Flipper[:stats].enable_group :admins
+Flipper[:stats].enable_group :early_access
+Flipper[:stats].enable_actor User.new('25')
+Flipper[:stats].enable_actor User.new('90')
+Flipper[:stats].enable_actor User.new('180')
+Flipper[:stats].enable_percentage_of_time 15
+Flipper[:stats].enable_percentage_of_actors 45
 
-flipper[:search].enable
+Flipper[:search].enable
 
 print 'all keys: '
 pp client.keys
@@ -64,7 +53,7 @@ pp client.hgetall('search')
 puts
 
 puts 'flipper get of feature'
-pp adapter.get(flipper[:stats])
+pp Flipper.adapter.get(Flipper[:stats])
 # flipper get of feature
 # {:boolean=>"true",
 #  :groups=>#<Set: {"admins", "early_access"}>,

data/examples/redis/namespaced.rb

@@ -1,18 +1,7 @@
-require 'pp'
-require 'pathname'
-require 'logger'
-begin
-  require 'redis-namespace'
-rescue LoadError
-  puts 'you must have redis-namespace gem installed'
-  exit 1
-end
-
-root_path = Pathname(__FILE__).dirname.join('..').expand_path
-lib_path  = root_path.join('lib')
-$:.unshift(lib_path)
-
+require 'bundler/setup'
+require 'redis-namespace'
 require 'flipper/adapters/redis'
+
 options = {url: 'redis://127.0.0.1:6379'}
 if ENV['REDIS_URL']
   options[:url] = ENV['REDIS_URL']

data/lib/flipper/adapters/redis.rb

@@ -178,3 +178,10 @@ module Flipper
     end
   end
 end
+
+Flipper.configure do |config|
+  config.adapter do
+    client = Redis.new(url: ENV["FLIPPER_REDIS_URL"] || ENV["REDIS_URL"])
+    Flipper::Adapters::Redis.new(client)
+  end
+end

data/lib/flipper/adapters/redis_cache.rb

@@ -148,7 +148,7 @@ module Flipper
         return [] if keys.empty?
 
         cache_keys = keys.map { |key| key_for(key) }
-        @cache.mget(cache_keys).map do |value|
+        @cache.mget(*cache_keys).map do |value|
           value ? Marshal.load(value) : nil
         end
       end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.20.4'.freeze
+  VERSION = '0.21.0'.freeze
 end

data/spec/flipper/adapters/redis_cache_spec.rb

@@ -19,7 +19,11 @@ RSpec.describe Flipper::Adapters::RedisCache do
   subject { adapter }
 
   before do
-    client.flushdb
+    begin
+      client.flushdb
+    rescue Redis::CannotConnectError
+      ENV['CI'] ? raise : skip('Redis not available')
+    end
   end
 
   it_should_behave_like 'a flipper adapter'

data/spec/flipper/adapters/redis_spec.rb

@@ -14,8 +14,21 @@ RSpec.describe Flipper::Adapters::Redis do
   subject { described_class.new(client) }
 
   before do
-    client.flushdb
+    begin
+      client.flushdb
+    rescue Redis::CannotConnectError
+      ENV['CI'] ? raise : skip('Redis not available')
+    end
   end
 
   it_should_behave_like 'a flipper adapter'
+
+  it 'configures itself on load' do
+    Flipper.configuration = nil
+    Flipper.instance = nil
+
+    load 'flipper/adapters/redis.rb'
+
+    expect(Flipper.adapter.adapter).to be_a(Flipper::Adapters::Redis)
+  end
 end

data/test/adapters/redis_cache_test.rb

@@ -9,6 +9,8 @@ class RedisCacheTest < MiniTest::Test
     @cache = Redis.new(url: url).tap(&:flushdb)
     memory_adapter = Flipper::Adapters::Memory.new
     @adapter = Flipper::Adapters::RedisCache.new(memory_adapter, @cache)
+  rescue Redis::CannotConnectError
+    ENV['CI'] ? raise : skip('Reids not available')
   end
 
   def teardown

data/test/adapters/redis_test.rb

@@ -8,5 +8,7 @@ class RedisTest < MiniTest::Test
     url = ENV.fetch('REDIS_URL', 'redis://localhost:6379')
     client = Redis.new(url: url).tap(&:flushdb)
     @adapter = Flipper::Adapters::Redis.new(client)
+  rescue Redis::CannotConnectError
+    ENV['CI'] ? raise : skip('Redis not available')
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-redis
 version: !ruby/object:Gem::Version
-  version: 0.20.4
+  version: 0.21.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-06 00:00:00.000000000 Z
+date: 2021-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.20.4
+        version: 0.21.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.20.4
+        version: 0.21.0
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement